ric-plt/lib/rmr.git
10 days agoCI: Add silent cmake SonarCloud scan 33/12733/2 master
Jessica Wagantall [Fri, 12 Apr 2024 21:22:06 +0000 (14:22 -0700)]
CI: Add silent cmake SonarCloud scan

Change-Id: Ic116d226b02284b35183986bc4aeacb0324829b5
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
4 months agorelease 4.9.4 step 2 of 2 51/12251/1 i-release
czichy [Wed, 13 Dec 2023 08:28:30 +0000 (10:28 +0200)]
release 4.9.4 step 2 of 2

Change-Id: I19a71953e9f941a8be8213c0ba281b56a8f8ad3d
Signed-off-by: czichy <thoralf.czichy@nokia.com>
4 months agorelease 4.9.4 step 1 of 2 48/12248/1 4.9.4
czichy [Wed, 13 Dec 2023 05:55:43 +0000 (07:55 +0200)]
release 4.9.4 step 1 of 2

Change-Id: I2039570dca5599a962e352c1d2501187e29e0dfc
Signed-off-by: czichy <thoralf.czichy@nokia.com>
4 months agoRelease RMR version 4.9.3 39/12239/1
czichy [Tue, 12 Dec 2023 16:18:58 +0000 (18:18 +0200)]
Release RMR version 4.9.3

Change-Id: Ib6b5acacb43fcb2b9a781e40e14953ed9fd507c4
Signed-off-by: czichy <thoralf.czichy@nokia.com>
4 months agoFixing handling of invalid header size 38/12238/3
czichy [Tue, 12 Dec 2023 12:35:38 +0000 (14:35 +0200)]
Fixing handling of invalid header size

Issue-ID: RIC-991

Change-Id: Ifebdff6728966989a66854bf4eeef89090060616
Signed-off-by: czichy <thoralf.czichy@nokia.com>
4 months agoCorrect whitespaces in sample message 37/12237/1
czichy [Tue, 12 Dec 2023 12:01:46 +0000 (14:01 +0200)]
Correct whitespaces in sample message

Issue-ID: RIC-989

Change-Id: I8caa8d9521183f5cd93ac813d29fb4f4a51e0508
Signed-off-by: czichy <thoralf.czichy@nokia.com>
4 months agofixing RMR messages with negative size 30/12230/2
czichy [Mon, 11 Dec 2023 15:24:44 +0000 (17:24 +0200)]
fixing RMR messages with negative size

This fixes an issue in RMR when receiving messages that in their
header have a negative length. We now mark the connection
as to be reset, i.e, it becomes unusable once there was a
message sent with a wrong header length.

Issue-ID: RIC-989

Change-Id: I1e6e958d1f3977b2caf15477d8381aeda3c77822
Signed-off-by: czichy <thoralf.czichy@nokia.com>
6 months agoRelease RMR version 4.9.2 85/11885/3
Juha Hyttinen [Fri, 6 Oct 2023 04:56:31 +0000 (07:56 +0300)]
Release RMR version 4.9.2

Issue-ID: RIC-1020

Signed-off-by: Juha Hyttinen <juha.hyttinen@nokia.com>
Change-Id: Icc267e6d2be6c109f1adb84cc86d8bc82e61d0a1

6 months agoFixes some stability issues seen during route table update. 44/11744/1 4.9.2
Juha Hyttinen [Wed, 4 Oct 2023 18:46:01 +0000 (21:46 +0300)]
Fixes some stability issues seen during route table update.

Dont allow clean old_rtable until it's reference count is really 0.
Added more faster recognition for connect failure, so route table
update will not stuck in preparing new rtable while waiting, that
old_rtable reference count reaches 0.
"rtgate" lock is not needed to init and destroy continouosly.

Issue-ID: RIC-1020

Signed-off-by: Juha Hyttinen <juha.hyttinen@nokia.com>
Change-Id: Ia5a228679ef9e71634217405334a4b9dc2da01b7

10 months agoRelease RMR version 4.9.1 71/11271/1 h-release
Alexandre Huff [Tue, 6 Jun 2023 13:53:05 +0000 (10:53 -0300)]
Release RMR version 4.9.1

Issue-ID: RIC-985

Signed-off-by: Alexandre Huff <alexandrehuff@utfpr.edu.br>
Change-Id: Ib76a1befcf140bebfd0c520caec164cfd6c59927

10 months agoFix binding to IPv6 interfaces 34/11234/5 4.9.1
Alexandre Huff [Sun, 28 May 2023 23:42:52 +0000 (20:42 -0300)]
Fix binding to IPv6 interfaces

RMR is unable to bind to IPv6 interfaces causing it to never become
ready when using IPv6-only deployments.

This change fixes this issue and implements application-level test cases
to test support for IPv6 deployments.

Issue-ID: RIC-985

Signed-off-by: Alexandre Huff <alexandrehuff@utfpr.edu.br>
Change-Id: I86b596851cb3561cda34fe20334e285e4151304f

11 months agoFix: tox config error 41/11241/1
Anil Belur [Tue, 30 May 2023 07:21:44 +0000 (17:21 +1000)]
Fix: tox config error

This requires pining urllib3<2.0.0 in tox.ini

Change-Id: I7e46ff3ad376f42ee075391ce5b7322896e0b946
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
14 months agoRelease RMR version 4.9.0 68/10468/1
czichy [Tue, 14 Feb 2023 11:15:38 +0000 (13:15 +0200)]
Release RMR version 4.9.0

Signed-off-by: czichy <thoralf.czichy@nokia.com>
Change-Id: I35a131607973032e70f472e9327d148977d1f421

14 months agoPreparation for release 4.9.0 67/10467/1 4.9.0
czichy [Tue, 14 Feb 2023 10:45:29 +0000 (12:45 +0200)]
Preparation for release 4.9.0

Signed-off-by: czichy <thoralf.czichy@nokia.com>
Change-Id: I1b74aa7cc5093b2d77723f6a51ddc1ceeb5d1dc4

15 months agoRIC-851: Updated rmr to define messagetype 85/10285/2
gunjarastogi [Wed, 18 Jan 2023 11:52:56 +0000 (17:22 +0530)]
RIC-851: Updated rmr to define messagetype
for IS_SUBS_DEL_REQD procedure

Signed-off-by: gunjarastogi <gunja.rastogi@capgemini.com>
Change-Id: I5a68dc9c047e12af126b485f7e992d8561fb4039

16 months agoRelease RMR version 4.8.5 99/9999/1 g-release
czichy [Wed, 7 Dec 2022 15:03:21 +0000 (17:03 +0200)]
Release RMR version 4.8.5

Signed-off-by: czichy <thoralf.czichy@nokia.com>
Change-Id: I43694927d5f8e1e28fead5721fdb2d1bec334361

16 months agoPreparation for releasing 4.8.5 98/9998/1 4.8.5
czichy [Wed, 7 Dec 2022 14:44:12 +0000 (16:44 +0200)]
Preparation for releasing 4.8.5

Signed-off-by: czichy <thoralf.czichy@nokia.com>
Change-Id: I1b9109538efe35af6975df9d57a74f6915a0e529

16 months agoPreparation for releasing 4.8.4 97/9997/1
czichy [Wed, 7 Dec 2022 14:18:33 +0000 (16:18 +0200)]
Preparation for releasing 4.8.4

Signed-off-by: czichy <thoralf.czichy@nokia.com>
Change-Id: I5306fad54c34c00ab8820165a6beff70c1c3f4e5

17 months agoRIC-939 : Fixes for static error checks 77/9577/1
Abdulwahid W [Thu, 10 Nov 2022 13:04:51 +0000 (16:04 +0300)]
RIC-939 : Fixes for static error checks

Signed-off-by: Abdulwahid W <abdulwahid.w@nokia.com>
Change-Id: If9f0a0e899d6bd4ea4566cd2b26d194fcf32b3ad

23 months agoMerge "Release RMR version 4.8.3" f-release
Thoralf Czichy [Wed, 11 May 2022 08:45:27 +0000 (08:45 +0000)]
Merge "Release RMR version 4.8.3"

23 months agoRelease RMR version 4.8.3 58/8258/3
czichy [Wed, 11 May 2022 06:03:51 +0000 (09:03 +0300)]
Release RMR version 4.8.3

Issue-ID: RIC-638

Signed-off-by: czichy <thoralf.czichy@nokia.com>
Change-Id: I12c0c330f474e62db3cdcee21b0ccb916d935464

23 months agoPreparation for releasing 4.8.3 60/8260/1 4.8.3
czichy [Wed, 11 May 2022 07:18:43 +0000 (10:18 +0300)]
Preparation for releasing 4.8.3

Issue-ID: RIC-638

Signed-off-by: czichy <thoralf.czichy@nokia.com>
Change-Id: I69ca8ddedbe38046ed4ee754e2cc2fab8e07b70e

23 months agoConstants for E2nodeConfigUpdate Messages 55/8255/1
subhash kumar singh [Tue, 10 May 2022 20:40:48 +0000 (20:40 +0000)]
Constants for E2nodeConfigUpdate Messages

Added constants for E2nodeConfigUpdate procedure defined
in E2APv2.0 specification.

Signed-off-by: subhash kumar singh <subh.singh@samsung.com>
Change-Id: Id3ac86f88d8f116e26052ffb3f65b9126fcc14b7

2 years agoRelease RMR version 4.8.2 25/7725/1
Alexandre Huff [Fri, 11 Feb 2022 10:09:38 +0000 (07:09 -0300)]
Release RMR version 4.8.2

Issue-ID: RIC-872

Signed-off-by: Alexandre Huff <alexandrehuff@utfpr.edu.br>
Change-Id: Icd8d11c3ad159bfb0ff73f007b53b524506cfccb

2 years agoFix RMR routing statistic data printout crash 66/7566/2 4.8.2
Alexandre Huff [Mon, 17 Jan 2022 22:59:22 +0000 (19:59 -0300)]
Fix RMR routing statistic data printout crash

If a routing table update happens while traversing entries to print
routing statistics, then it will cause RMR to crash. This
crash is generated due to an unsafe reference used to print
the rt statistics. This change fixes this routing statistic
printout crash.

This change also fixes a related problem of read-access to ref count
in routing table that is not protected by a mutex.

Issue-ID: RIC-872

Signed-off-by: Alexandre Huff <alexandrehuff@utfpr.edu.br>
Change-Id: I03b0cb79a62e7fbdb1eb08c2006894fab4ebf5cd
Signed-off-by: Alexandre Huff <alexandrehuff@utfpr.edu.br>
2 years agoRelease RMR version 4.8.1 19/7519/1
Alexandre Huff [Mon, 10 Jan 2022 13:50:47 +0000 (10:50 -0300)]
Release RMR version 4.8.1

Issue-ID: RIC-861

Signed-off-by: Alexandre Huff <alexandrehuff@utfpr.edu.br>
Change-Id: Ic025e5faf96adb14640c41ed074134a09626429a

2 years agoRe-enable RMR libary's module tests 15/7515/2 4.8.1
Alexandre Huff [Fri, 7 Jan 2022 17:20:28 +0000 (14:20 -0300)]
Re-enable RMR libary's module tests

This change fixes and re-enables the SI95's module tests
disabled in RIC-838.
This change also creates a new unit test for the debugging
rmr rx queue API.
Fixes some bugs and possible memory likeage in SI95 code.

Issue-ID: RIC-861

Signed-off-by: Alexandre Huff <alexandrehuff@utfpr.edu.br>
Change-Id: I19e3bccb61605a8506b03afd755e627d0259c394

2 years agoRelease RMR version 4.8.0 04/7204/1 e-release
Timo Tietavainen [Thu, 2 Dec 2021 19:57:31 +0000 (21:57 +0200)]
Release RMR version 4.8.0

Issue-ID: RIC-858

Signed-off-by: Timo Tietavainen <timo.tietavainen@nokia.com>
Change-Id: I100c76f7f41b06948afaa518605d8289f3ed619c

2 years agoUpdate RMR version to 4.8.0 82/7182/1 4.8.0
Timo Tietavainen [Thu, 2 Dec 2021 17:40:55 +0000 (19:40 +0200)]
Update RMR version to 4.8.0

Update new RMR version to be 4.8.0 and update release documents.
Version 4.8.0 contains below changes:
* Fixing memory leak in python support function (RIC-858).
* New API added for debugging rmr rx queue (RIC-838).

Issue-ID: RIC-858

Signed-off-by: Timo Tietavainen <timo.tietavainen@nokia.com>
Change-Id: I3feecf10efad3ab28bffef912492fa6ab039aca8

2 years agoFixing memory leak in python support function 76/7176/1
czichy [Thu, 2 Dec 2021 12:15:49 +0000 (14:15 +0200)]
Fixing memory leak in python support function

Issue-ID: RIC-858
Signed-off-by: czichy <thoralf.czichy@nokia.com>
Change-Id: I67eabcf7249baa1b0b191f2ee47be94c1857a58a

2 years agoNew API added for debugging rmr rx queue 34/6934/3
sw94.chung [Tue, 26 Oct 2021 04:13:59 +0000 (13:13 +0900)]
New API added for debugging rmr rx queue

1. Two new API for debugging rmr rx queue added
for accumulated rmr queue status count
- rmr_reset_rx_debug_count
  - api to reset accumulated counter for
    rx enqueue, rx queue drop count
- rmr_get_rx_debug_info
  - api to get accumulated counter info of
    rx queue status for debugging usage
2. Two new variable added to uta_ctx structure
- uint64_t acc_dcount
  - accumulated counter for rx queue drop
- uint64_t acc_ecount
  - accumulated counter for rx queue enqueue
3. New structure for rmr debug info added
- rmr_rx_debug_t
4. Build fail of ci due to si95_test.c changed
name to si95_test_fixme.c future bugfix is needed

Issue-ID: RIC-838

Signed-off-by: sw94.chung <sw94.chung@samsung.com>
Change-Id: I021df3df22d4bd349982c260accfa739313b7bfc

3 years agoRelease current package from staging (4.7.4) 37/5937/3 dawn
E. Scott Daniels [Mon, 26 Apr 2021 12:41:56 +0000 (08:41 -0400)]
Release current package from staging (4.7.4)

This change triggers the CI job to release the current package in staging
into the "prod" area of package cloud

Issue-ID: RIC-777

Signed-off-by: E. Scott Daniels <daniels@att.com>
Change-Id: I7bb6a20c4f7e906dfba207c0e4598530783d99e0
Signed-off-by: E. Scott Daniels <daniels@att.com>
3 years agoBeef up unit tests for SI95 code 25/5925/2 4.7.4
E. Scott Daniels [Thu, 22 Apr 2021 20:34:08 +0000 (16:34 -0400)]
Beef up unit tests for SI95 code

This changes adds some unit tests for SI95 modules which had none
prior, and extends some of the existing tests to improve coverage.

Issue-ID: RIC-777

Change-Id: I5d704776fd9094e8b17e35263cc4680bf822b38c
Signed-off-by: E. Scott Daniels <daniels@att.com>
3 years agoCorrect bug identified in static analysis 09/5909/2 4.7.3
E. Scott Daniels [Mon, 19 Apr 2021 19:13:51 +0000 (15:13 -0400)]
Correct bug identified in static analysis

This change corrects a flag test bug identified during static analysis
of the code. Several tests were added and/or enhanced to beef up
the coverage.

Issue-ID: RIC-777

Signed-off-by: E. Scott Daniels <daniels@att.com>
Change-Id: Icd56f9a669e9583446ac80a5120bc42193eb7adb
Signed-off-by: E. Scott Daniels <daniels@att.com>
3 years agoEnsure RT incremental update not applied early 69/5869/1
E. Scott Daniels [Fri, 9 Apr 2021 12:40:20 +0000 (08:40 -0400)]
Ensure RT incremental update not applied early

This change ensures that a full table has been provided by the
route generator (route manager) prior to RMR accepting any
incremental updates.

The change also captures the initial value of the RMR_SEED
environment variable such that it cannot be changed once it has
been used.

Issue-ID: RIC-329

Signed-off-by: E. Scott Daniels <daniels@att.com>
Change-Id: I168cb42905e41641590130de724965e8dbca67e6

3 years agoFixed some static code errors 59/5859/1
wahidw [Mon, 5 Apr 2021 14:51:31 +0000 (14:51 +0000)]
Fixed some static code errors

Signed-off-by: wahidw <abdulwahid.w@nokia.com>
Change-Id: Icd3a57c4478759de92472159692fab330eee79dd

3 years agoPush package out of staging for 4.7.0 49/5849/3
E. Scott Daniels [Fri, 2 Apr 2021 11:32:25 +0000 (07:32 -0400)]
Push package out of staging for 4.7.0

Issue-ID: RIC-744

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I65bc6e973c2666e41d72a2cdb0a29b880d0b5cb3
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
3 years agoAdd ability to save route table updates to disk 48/5848/1 4.7.0
E. Scott Daniels [Thu, 1 Apr 2021 14:05:33 +0000 (10:05 -0400)]
Add ability to save route table updates to disk

Updates from the route table generator are now saved into a disk
file using the new RMR_STASH_RT environment variable, or adding a .stash
extension to the vaue of RMR_SEED_RT if the stash variable is
not present. If neither variable is present, then no information
is saved.  This is intended to make debugging easier; for non-RMR
developers reading the dump output is not straight forward.

Issue-ID: RIC-774

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I79d3adf8c3c291f82f54849a3be94648fb86aab1

3 years agoAdd better support for manual app testing 48/5748/3 4.6.1
E. Scott Daniels [Wed, 10 Mar 2021 17:22:44 +0000 (12:22 -0500)]
Add better support for manual app testing

This change adds some support to the app test scripts to provide
for manual testing of the application tests without the need
to intall RMR.

The change also provides the means to set the optimisation level
when building RMR libraries for better profiling and debugging.

Issue-ID: RIC-753

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I7ff5f9a1b1bdcdb83ed83c217dae1bce03b0fda4

3 years agoCommit to release the package from staging 91/5691/1
E. Scott Daniels [Wed, 24 Feb 2021 18:32:26 +0000 (13:32 -0500)]
Commit to release the package from staging

This commit triggers the CI to move the package to the
release directory.

Issue-ID: RIC-204

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I3bce7fb4f2823cef8c753ca5e9d647ee5ba366fe

3 years agoAdd alarm generation when application is slow 81/5681/3 4.6.0
E. Scott Daniels [Mon, 22 Feb 2021 19:42:21 +0000 (14:42 -0500)]
Add alarm generation when application is slow

This change enhances RMR such that it will send alarms to the alarm
manager when the application is not removing messages quickly enough
and causing RMR to drop inbound messages.

Issue-ID: RIC-204

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I23abb439ff4dcde021b517f8edd758767c30d319
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
3 years agoAdd millisecond resolution to log timestamps 72/5672/1
E. Scott Daniels [Wed, 17 Feb 2021 20:01:58 +0000 (15:01 -0500)]
Add millisecond resolution to log timestamps

This change adds millisecond resolution to the timestamp written
on RMR stderr messages.

The change also allows the verbose control file specified by the
environment variable RMR_VCTL_FILE to be created and populated
after the application starts. In addition, if no variable is
supplied, RMR will now use a default control file (/tmp/rmr.v)
to allow debugging to be enabled without requireing an application
restart.

Issue-ID: RIC-627

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I207150679370add11fcdeef381ff453b28e701db

3 years agoPush 4.5.2 to package cloud release 10/5510/1
E. Scott Daniels [Tue, 26 Jan 2021 15:08:58 +0000 (10:08 -0500)]
Push 4.5.2 to package cloud release

This change only triggers the CI job which moves the 4.5.2
package from staging to release in package cloud.

Issue-ID: RIC-735

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I3586a58e3d64213e4b9ab8f822b73d6e03f1ac42

3 years agoCorrect excessive TCP connection bug 89/5489/1 4.5.2
E. Scott Daniels [Thu, 21 Jan 2021 16:17:33 +0000 (11:17 -0500)]
Correct excessive TCP connection bug

This change corrects a bug in the handling of sends on a blocked
TCP session that was causing a session reconnect to the endpoint,
and resulted in an excessive number of open file descriptors leading
to a segmentation fault.

The change also includes a better warning message when a receiving
process is failing to keep up; the warning is issued every 60
seconds, with a count, when messages are being dropped.

Issue-ID: RIC-735

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Id43b1c8c4766e5a89158fb31b05df547603c3e13

3 years agoPush 4.5.1 to the release area on package cloud 79/5479/1
E. Scott Daniels [Tue, 19 Jan 2021 21:47:40 +0000 (16:47 -0500)]
Push 4.5.1 to the release area on package cloud

Issue-ID: RIC-732

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I5693acf3a30061a27ea5e5f2116528a7f66da812

3 years agoBump version to deal with CI bug 73/5473/1 4.5.1
E. Scott Daniels [Tue, 19 Jan 2021 19:53:30 +0000 (14:53 -0500)]
Bump version to deal with CI bug

The CI jobs failed to move all packages on the first go and
is now unable to move the remainter packages. This change
is solely to bump the version number to get the CI jobs to
work and push packages to release.  The version is now 4.5.1
and has NO code changes.

Issue-ID: RIC-732

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I4ed87731ad038aabb63509f9a079cf761705024d

3 years agoRelease latest package from staging 70/5470/1 4.5.0
E. Scott Daniels [Tue, 19 Jan 2021 15:45:52 +0000 (10:45 -0500)]
Release latest package from staging

Issue-ID: RIC-732

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Idc9029c2799437d7e6554e76875b73378067f321

3 years agoCorrect potenital locking issue in msg allocation 99/5399/1
E. Scott Daniels [Fri, 8 Jan 2021 18:57:01 +0000 (13:57 -0500)]
Correct potenital locking issue in msg allocation

The message allocation when pulling a buffer from the free pool could
potentially fail to own the lock. This was causing core dumps for
multi-threaded processes (e.g. those using the Go wrapper).

Version bump to 4.5.0 to move away from the previous release of
4.4.*.

Issue-ID: RIC-732

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I9abc7f64391d0292c5ba1323713040faedb569a1

3 years agoUpdate release notes to include cherry header 18/5318/1
E. Scott Daniels [Fri, 11 Dec 2020 12:56:13 +0000 (07:56 -0500)]
Update release notes to include cherry header

Issue-ID: RIC-730

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I17f929920949eb1723da7fffec870ed18ba3d0fd

3 years agoPush version 4.4.6 out from packagecloud staging 55/5255/1
E. Scott Daniels [Sat, 5 Dec 2020 00:19:50 +0000 (19:19 -0500)]
Push version 4.4.6 out from packagecloud staging

Issue-ID: RIC-721

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Ie9bfc882b158643ebfbd61848ba0c2b7de4e3ed7

3 years agoFix route table clone core dump 39/5239/2 4.4.6
E. Scott Daniels [Fri, 4 Dec 2020 18:04:29 +0000 (13:04 -0500)]
Fix route table clone core dump

This change addresses the bug that was causing a cored dump in
the route table clone functions.

Issue-ID: RIC-720

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I58a8f75fcc7f9fc08495eabafb4644e365b18c90
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
3 years agoFixing minor exception checks 15/5115/2
swc [Thu, 19 Nov 2020 04:10:34 +0000 (13:10 +0900)]
Fixing minor exception checks

- uta_ring_free() updated to free resources
- Exception Handling to avoid reference null_ptr
- free_ctx() updated to free resources
- err: added to safely handle resource free

Issue-ID: RIC-673

Signed-off-by: swc <sw94.chung@samsung.com>
Change-Id: I2645d6eddb230ca9cf2822c778c1b533e5da1f9b

3 years agoBump package version in CMake to 4.4.5 02/5102/1 4.4.5
E. Scott Daniels [Tue, 17 Nov 2020 20:26:26 +0000 (15:26 -0500)]
Bump package version in CMake to 4.4.5

Issue-ID: RIC-695

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Ibd3549d54dfa3d4c624642ccdcabaf453e27c7b1

3 years agoFixed bug on building RTE groups with no endpoint 01/5101/2
Alexandre Huff [Tue, 17 Nov 2020 14:11:21 +0000 (11:11 -0300)]
Fixed bug on building RTE groups with no endpoint

When building a route table entry (rte) with several groups, a given
group can be added contiguously to the rte even if it has no endpoint.
Endpoints that reference to any of "our" local "address:port" are not
added to the rte. Thus, in some cases, groups that only reference to
local endpoints (nil) are added contiguously to the rte, causing the
round-robin group selection mechanism to stop sending messages to the
next groups after finding a nil-one.

This might happen, for instance, when a multicast routing rule is required
in which only one endpoint is added to each group, and one of these groups
references to one of the local "address:port" being used. In this case, only
the endpoints in the groups prior the nil-one will receive a copy of the
multicast message.

This change fixes this issue by adding contiguously only groups that have at
least one endpoint that does not refer to a local "address:port".
Some extra bytes are wasted in the rte by referencing to a group that does not
have an endpoint, but this is minor compared to spending time on recreating a
new rte and adding only the groups that do have endpoints. Those nil groups
don't cause any harm since the function that does the round-robin selection
assumes that the groups are contiguous and stops selecting endpoints when a
nil group is found.

Issue-ID: RIC-695

Signed-off-by: Alexandre Huff <alexandrehuff@gmail.com>
Change-Id: I13c7576ce0de82b7814c81c1a0da24172371a897

3 years agoCorrect memory leak in the RTE cleanup 90/5090/2 4.4.4
E. Scott Daniels [Fri, 13 Nov 2020 20:13:46 +0000 (15:13 -0500)]
Correct memory leak in the RTE cleanup

When cleaning up a route table entry the round robin group
block (rrg) was not being correctly freed. The leak was small,
but would be noticed in a situation described by the indicated
issue (many table updates).

Issue-ID: RIC-674

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Ica7d0219574abd33392c7127f918ac71b2891702
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
3 years agoCorrect table clear bug in route table ready 57/5057/3 4.4.3
E. Scott Daniels [Thu, 12 Nov 2020 21:44:34 +0000 (16:44 -0500)]
Correct table clear bug in route table ready

This change fixes a bug introduced in the 4.4.0 fix. During
symtable roll prep the table was cleared, but the reference
counts in the RTEs was not being decremented.

Issue-ID: RIC-674

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I3b1fb0a74207960b2adeb9c53016358d01658b1b
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
3 years agoMore changes for scan corrections and unit test coverage 46/5046/1 4.4.2
E. Scott Daniels [Wed, 11 Nov 2020 20:57:22 +0000 (15:57 -0500)]
More changes for scan corrections and unit test coverage

Issue-ID: RIC-673

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I337e8caebda4d4585fbce2ab455caaa4f68be8f1

3 years agoAddress complaints by code scanner 25/5025/1 4.4.1
E. Scott Daniels [Tue, 10 Nov 2020 13:38:52 +0000 (08:38 -0500)]
Address complaints by code scanner

This change addresses complaints generated by a recent code scan

Issue-ID: RIC-673

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I230449eced30477e13ec3eb867a5e16f67d4fae8

3 years agoFix potential race in route table load 94/4994/4 4.4.0
E. Scott Daniels [Thu, 5 Nov 2020 14:11:04 +0000 (09:11 -0500)]
Fix potential race in route table load

If route tables are received in quick succession there is a potential
race condition that can cause the xAPPs thread to use a stale pointer
likely resulting in a segfault.

Issue-ID: RIC-674

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I5536d3f30646dca0ed375468719fa3cf0920c103
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
3 years agoAddress code analysis issues 50/4950/1 4.3.1
E. Scott Daniels [Fri, 30 Oct 2020 19:04:16 +0000 (15:04 -0400)]
Address code analysis issues

This change addresses code analysis issues which were found to be
potential bugs in the code.  The details are captured in the Jira
ticket.

Issue-ID: RIC-673

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Ic05b716780f5fae76e98a3c5fa8be98fcd8452d8

3 years agoAdd message types for traffic steering anomaly messages 02/4802/2
E. Scott Daniels [Fri, 2 Oct 2020 11:36:41 +0000 (07:36 -0400)]
Add message types for traffic steering anomaly messages

This change addes the following message types:

TS_ANOMALY_UPDATE
TS_ANOMALY_ACK

The RTD message type page will also be updated.

Issue-ID: RIC-651

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I4a8efd6d9c2aced40b6ff1eb6e42ee3d034f0745

3 years agoMerge "Removig committer Chris"
Thoralf Czichy [Tue, 22 Sep 2020 10:46:22 +0000 (10:46 +0000)]
Merge "Removig committer Chris"

3 years agoAdd manual page for set low latency funciton 51/4751/2
E. Scott Daniels [Mon, 21 Sep 2020 15:59:35 +0000 (11:59 -0400)]
Add manual page for set low latency funciton

This change adds the manual page for the rmr_set_low_latency()
function.

Issue-ID: RIC-631

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I3c5bd0a27ef36c351b2003c34d70f4f09aff8974

3 years agoRemovig committer Chris 47/4747/1
czichy [Mon, 21 Sep 2020 10:17:19 +0000 (13:17 +0300)]
Removig committer Chris

Signed-off-by: czichy <thoralf.czichy@nokia.com>
Change-Id: I446de1d2187d6fc2294d365b95220c8c9cfe88a1

3 years agoAdd summary data to unit test output 18/4718/5 4.2.3
E. Scott Daniels [Thu, 17 Sep 2020 20:39:31 +0000 (16:39 -0400)]
Add summary data to unit test output

This change causes summary data to be added to the unit test
data that is generated. Summary data lists counts for the total
tests, test passed and test failed in addition th to the information
which was previously generated.

Issue-ID: RIC-646

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Ibeda3418291c490d49f9e8a29b89c93aa55567fb

3 years agoFix rmr_rpobe command line bug; add test coverage 05/4705/1
E. Scott Daniels [Tue, 15 Sep 2020 14:27:34 +0000 (10:27 -0400)]
Fix rmr_rpobe command line bug; add test coverage

This change corrects a deficency in the command line parsing of
the rmr_probe support utility. It also adds unit test code to
cover a significant portion of the SI95 code which was previously
not covered.  Commented out code in SI95 was also removed to
reduce the sonar grumblings.

Issue-ID: RIC-645

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I5943bacf8d7434a7991781dba70b01bf5c16c67d

3 years agoPush package to release in package cloud (4.2.2) 94/4694/1
E. Scott Daniels [Fri, 11 Sep 2020 16:43:36 +0000 (12:43 -0400)]
Push package to release in package cloud (4.2.2)

Issue-ID: RIC-644

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I5a6c826a9d8cfc7369ac4095b04f1770ec197ffd

3 years agoFix core dump in rmr_probe when -r option given 93/4693/1 4.2.2
E. Scott Daniels [Fri, 11 Sep 2020 13:51:52 +0000 (09:51 -0400)]
Fix core dump in rmr_probe when -r option given

When the '-r' option was given on the rmr_probe command line the
process would core dump. This change corrects the argument parsing
code that was the source of the problem.

Issue-ID: RIC-644

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I02b5b0ba211de1ec0458e8c83d2f2ccf97523825

3 years agoPush package ver 4.2.1 out of pkg-cloud staging 89/4589/1
E. Scott Daniels [Thu, 20 Aug 2020 15:55:19 +0000 (11:55 -0400)]
Push package ver 4.2.1 out of pkg-cloud staging

This commit changes the release version information which will
cause the package to be moved from the staging repo to the release
repo in package cloud.

Issue-ID: RIC-630

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Ibc7c2cc49a6fbcd91a1795057af94fc82108d515

3 years agoAdd additional env variable dump during init 21/4521/2 4.2.1
E. Scott Daniels [Tue, 4 Aug 2020 17:48:47 +0000 (13:48 -0400)]
Add additional env variable dump during init

If the RMR_LOG_VLEVEL environment is set to 4 or greater
the settingf for the environment variables that are
significant to RMR are written to stderr.

Issue-ID: RIC-630

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I6709f2c6d6c592494b0a7edbf23b6bd234715262

3 years agoAdd ability to control route table req frequency 03/4503/2 4.2.0
E. Scott Daniels [Mon, 3 Aug 2020 13:22:20 +0000 (09:22 -0400)]
Add ability to control route table req frequency

This change introduces the RMR_RTREQ_FREQ environment variable
which allows the frequency that RMR will send requests to the
route manager to be externally controlled. Valid values are between
1 and 300 seconds inclusive.

This change also closes a test initialisation issue causing unit
test failures in the CI environment.

Issue-ID: RIC-630

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I399cca797c6b13a1b7fab0c9c17d54c419cf169f

3 years agoFix potential pointer use err in SI95 25/4425/2 4.1.4
E. Scott Daniels [Tue, 21 Jul 2020 17:39:18 +0000 (13:39 -0400)]
Fix potential pointer use err in SI95

In SIconnect it was possible for a freed struct to be used
if the session didn't connect.

This change also picks up whitespace changes to the docs.

Issue-ID: RIC-626

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Ie23f4925c6a29b301f0143e938c11f57f0ed5631

3 years agoAllow RTS calls prior to initial route table load 54/4354/1 4.1.3
E. Scott Daniels [Wed, 8 Jul 2020 15:28:05 +0000 (11:28 -0400)]
Allow RTS calls prior to initial route table load

To better support heartbeat responses it is necessary to
allow RTS messages to be sent prior to the loading of
the initial route table. This change implements this and
has the side effect of also allowing wormhold sends prior
to a route table arrival (which is ok since no routing
is needed for wormhole traffic).

Issue-ID: RIC-589

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I302bdd0f274a7c5bc95f3f382e3374b21662ab8c

3 years agoRelase 4.1.2 from package cloude staging 28/4228/1
E. Scott Daniels [Wed, 24 Jun 2020 17:49:32 +0000 (13:49 -0400)]
Relase 4.1.2 from package cloude staging

This commit will cause the packages in PC staging to move
to the release repo.

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Ie88563ba97353a614794859aeb79b21c68b2f54b

3 years agoFix bug in message type header file 20/4220/4 4.1.2
E. Scott Daniels [Mon, 22 Jun 2020 20:25:31 +0000 (16:25 -0400)]
Fix bug in message type header file

There was a dangling 'i' on one of the new constants.

The script to scrape the message type header file and the
resulting RTD document are also included in this change.
The comments which provide supplemental documentation have
been added to the header file.

Issue-ID: RIC-514

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I8ba2eaa4242f0870e05030896050f7fe8e2dd106

3 years agoAdd RIC message types to header 16/4216/2 4.1.1
E. Scott Daniels [Mon, 22 Jun 2020 12:07:28 +0000 (08:07 -0400)]
Add RIC message types to header

Message types added to the RIC message type header for:
RIC_ALARM           (110)
RIC_ALARM_QUERY     (111)
RIC_METRICS         (120)
RAN_E2_RESET_REQ    (12008)
RAN_E2_RESET_RESP   (12009)

Issue-ID: RIC-514

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I544cec60e4e9402139261b6fe0291d7c1253475e

3 years agoAllow C++ applications to include symtab header 77/4177/1
E. Scott Daniels [Thu, 18 Jun 2020 12:22:58 +0000 (08:22 -0400)]
Allow C++ applications to include symtab header

The RMR symbol table functions are exposed to xAPPs, however the
header file lacked the magic C++ goo that allowed it to be included.
This change adds the goo, and changes a parameter name in the
prototypes to avoide a collision with C++ reserved words.

Issue-ID: RIC-522

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Idadaa109d191b0de0629737f27d2444a4e581e64

3 years agoCorrect man page formatting in RST output 85/4085/3 bronze
E. Scott Daniels [Fri, 12 Jun 2020 14:40:19 +0000 (10:40 -0400)]
Correct man page formatting in RST output

Some man pages were assuming that the "&item" macro
was defined.  This change adds that macro and pushes
the affected RST man pages for RTD.

The change also adds a release header for the major
project releases to the relase notes file.

Issue-ID: RIC-510

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I89b784c4a18ba0ac85aaed2bdde8bda18e3d0946

3 years agoAdd installation guide with link to PackageCloud 74/4074/1
Lott, Christopher (cl778h) [Thu, 11 Jun 2020 17:51:04 +0000 (13:51 -0400)]
Add installation guide with link to PackageCloud

Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>
Change-Id: I4efabf46db130cefc9b972f199eb938b551d7ba1

3 years agoRemoving and adding committers 65/4065/2
czichy [Thu, 11 Jun 2020 11:28:46 +0000 (14:28 +0300)]
Removing and adding committers

Signed-off-by: czichy <thoralf.czichy@nokia.com>
Change-Id: Ifc8389ca04b19d71148e4ba36f61d95c16c83d45

3 years agoPublish man page changes to RTD 22/4022/1
E. Scott Daniels [Mon, 8 Jun 2020 13:20:32 +0000 (09:20 -0400)]
Publish man page changes to RTD

Man page changes commited earlier were not published. This change
publishes these changes.

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I056d7f03e05b3fcc633ac6c12962b7ffc4a49aab

3 years agoRepair minor flaws in wormhole function docs 83/3983/2
Lott, Christopher (cl778h) [Wed, 3 Jun 2020 19:42:06 +0000 (15:42 -0400)]
Repair minor flaws in wormhole function docs

Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>
Change-Id: Ia8c0707c074c424f3380c972f57478473689496e

3 years agoAdd link to RTD index 88/3688/1
E. Scott Daniels [Wed, 13 May 2020 13:50:40 +0000 (09:50 -0400)]
Add link to RTD index

This change adds the link to the main RMR manual page
in place of a formal overveiw document.

A few other small tweaks were made to the route table
document and glossary; the glossary code is shared so the
update triggers an update to the user guide .rst as well.

The overview source is deleted in this change.

Issue-ID: RIC-378

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I4972683faaab204dd0167b67a7510cb97e01d01a

3 years agoAdd route table guide and formatting tweaks 52/3652/11
E. Scott Daniels [Wed, 6 May 2020 13:07:08 +0000 (09:07 -0400)]
Add route table guide and formatting tweaks

The route table guide has been added to the repo so that it
can be published on the RTD site.  This change also includes
pulling full examples into the user guide from the repo
example directory (rather than maintaining snipits in the
doc), and generates RST definition lists in a more traditional
format that just look better in the rendered HTML.

Issue-ID: RIC-378

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I2661dbb28daf3575640426a847f17fe45ea0ba43

3 years agoRelease RMR packages at version 4.0.5 15/3615/1
Lott, Christopher (cl778h) [Thu, 7 May 2020 11:46:00 +0000 (07:46 -0400)]
Release RMR packages at version 4.0.5

Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>
Change-Id: Ic749b5bb9ed28b74c95dcda061a96c6a1ab23cef

3 years agoMerge "Fix semaphore count bug in SI95 non-blocking rcv"
Matti Hiltunen [Thu, 7 May 2020 03:17:22 +0000 (03:17 +0000)]
Merge "Fix semaphore count bug in SI95 non-blocking rcv"

3 years agoFix semaphore count bug in SI95 non-blocking rcv 01/3601/3 4.0.5
E. Scott Daniels [Wed, 6 May 2020 19:45:49 +0000 (15:45 -0400)]
Fix semaphore count bug in SI95 non-blocking rcv

When a non-blocking receive is invoked it is possible that
the semaphore count was not being decremented as the message
is popped off the ring.  This corrects that.

Issue-ID: RIC-355

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: If502f6f85c7ea5960f38e61fc8e3e29427b4c30f

3 years agoChange doc config key to ric-plt-lib-rmr 98/3598/1
Lott, Christopher (cl778h) [Wed, 6 May 2020 14:45:25 +0000 (10:45 -0400)]
Change doc config key to ric-plt-lib-rmr

Adjust the token shown in the top-left corner of RTD pages.

Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>
Change-Id: I15aa222cfb71cd766ce76353927a3b4fbd7dc6fe

4 years agoCorrect traffic steering message type constants 34/3534/1 4.04
E. Scott Daniels [Wed, 29 Apr 2020 17:16:11 +0000 (13:16 -0400)]
Correct traffic steering message type constants

The original correction got the "fix" backwards.
This changes QUE to QOE as it was supposed to be.

Issue-ID: RIC-342

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I72a4869c5bd2e6db29e8243a460b9c2503c7fc1e

4 years agoFix sonar flagged bugs 21/3521/3 4.0.3
E. Scott Daniels [Tue, 28 Apr 2020 20:20:53 +0000 (16:20 -0400)]
Fix sonar flagged bugs

1 bug and 9 security (buffer overrun potentials) were
corrected.

Issue-ID: RIC-78

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I95fb1180efb304ab9fed98eea83af29d5ed23fe7

4 years agoDocument both valid route table entry types 17/3517/1
Lott, Christopher (cl778h) [Tue, 28 Apr 2020 16:41:50 +0000 (12:41 -0400)]
Document both valid route table entry types

This includes "rte" (old) and "mse" (new) using text gleaned
from the wiki page.

Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>
Change-Id: Ib57405f93a41b74ad651c89de283211572d503b6

4 years agoAdd missing pipe delimiter to route table syntax 92/3492/1
Lott, Christopher (cl778h) [Mon, 27 Apr 2020 21:07:20 +0000 (17:07 -0400)]
Add missing pipe delimiter to route table syntax

Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>
Change-Id: I169d3144524f8ae9f03e008cc4a20a13540d062b

4 years agoRelease commit: move 4.0.2 to release repo 83/3483/1
E. Scott Daniels [Mon, 27 Apr 2020 13:04:48 +0000 (09:04 -0400)]
Release commit: move 4.0.2 to release repo

This change causes the 4.0.2 package in the staging repo to be
moved to the released repo.

Issue-ID: RIC-341

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I7f77eab8c09a179d7cbfb61d696873ed0ad61410

4 years agoFix SI95 transport header length bug 56/3456/1 4.0.2
E. Scott Daniels [Fri, 24 Apr 2020 17:26:21 +0000 (13:26 -0400)]
Fix SI95 transport header length bug

A bug in the buffer length extraction from the SI95 transport
header was causing failures when communicating with an application
using a backlevel version of RMR.  Symptoms were dropped return
to sender messages, and a flood of messages with type 0.  This
fix corrects this problem.

Issue-ID: RIC-341

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I0223608c26917a5f94378fd83e1bb71be93999fe

4 years agoFix message type constant name for TS_QUE_PREDICTION 43/3443/1
E. Scott Daniels [Fri, 24 Apr 2020 01:20:54 +0000 (21:20 -0400)]
Fix message type constant name for TS_QUE_PREDICTION

The constant for message type 30002 was not correct.

Issue-ID: RIC-342

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I4286f96f650ad77811c76cccef0eeca52592ad34

4 years agoMerge "Release RMR packages at version 3.8.2"
Scott Daniels [Wed, 22 Apr 2020 18:16:10 +0000 (18:16 +0000)]
Merge "Release RMR packages at version 3.8.2"

4 years agoDrop release files for RMR python bindings 02/3402/1
Lott, Christopher (cl778h) [Wed, 22 Apr 2020 18:01:20 +0000 (14:01 -0400)]
Drop release files for RMR python bindings

The binding code left this repo so the control files are useless.

Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>
Change-Id: Ie030e54b6647d448cfa1110c03d0f49f107d2cd5

4 years agoRelease RMR packages at version 3.8.2 99/3399/2 4.0.0
Lott, Christopher (cl778h) [Wed, 22 Apr 2020 17:27:13 +0000 (13:27 -0400)]
Release RMR packages at version 3.8.2

Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>
Change-Id: I4c49a99c7b01e9a38f491dfd07458271da73b1e8

4 years agoRemove NNG libraries from packages 68/3368/8
E. Scott Daniels [Tue, 21 Apr 2020 16:51:05 +0000 (12:51 -0400)]
Remove NNG libraries from packages

The default build process will no longer include the NNG
libraries (librmr_nng.*) by default.  It is still possible
to enable them with a CMake build flag (-DBUILD_NNG=1).

The NNG specific unit tests have been disabled.

Some SI95 specific unit tests have been enhanced in an effort
to work toward full coverage of the SI95 code.

This change is in a major version bump as the package contents
change. However, there is NOT an API change; all existing
applications will be able to use the new version without any
modification (other than possibly removing references to the
NNG based libraries).

Issue-ID: RIC-337

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Ic9854b1ffc1e82c765692a11724d8086d24cceed

4 years agoFix block of dynamic route table load 36/3336/1 3.8.2
E. Scott Daniels [Mon, 20 Apr 2020 17:17:04 +0000 (13:17 -0400)]
Fix block of dynamic route table load

A bug in the initialisation of RMR beginning with 3.7.2
was causing the dynamic update of routes to be blocked.
This change corrects that bug.

Issue-ID: RIC-336

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I517b0ba65808bb4853983f92bc57e93a22792014