Address potential error state after good send 41/841/2 1.5.0
authorE. Scott Daniels <daniels@research.att.com>
Tue, 27 Aug 2019 14:17:21 +0000 (10:17 -0400)
committerE. Scott Daniels <daniels@research.att.com>
Thu, 29 Aug 2019 17:27:37 +0000 (13:27 -0400)
commit6511ac74cdc367a94bffeb3743624775acd52c5b
treeb8eefd946ca80d744ddea43635811c7c328961c2
parent36262115f77dc315e156c574dfb3b8e9090e6970
Address potential error state after good send

This change addresses the potential to "hide" the good
status of a send in the case where there are multiple
round-robin groups for a message type. The send algorithm
was modified to eliminate the potential edge case and
to report a successful result if the message was accepted
for delivery to at least one group.

Two issues identified by valgrind (use of a potentially
uninitialised variable in a jump) were also corrected.

Intermediate commits:
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Add error tag to msg

Missing ERR on failure message.

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Prevent NPE in symtab

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Adjust unit tests, fix valgrind inddicated issues

Unit tests were added to verify the new get rte function.
Valgrind indicated several places where a conditional was
using a potentially uninitialised variable; these were fixed.

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I7c0a49713ab3d6fbb8f66e3d286049762433dc58
16 files changed:
CMakeLists.txt
src/rmr/common/include/rmr_agnostic.h
src/rmr/common/src/rt_generic_static.c
src/rmr/common/src/symtab.c
src/rmr/nng/include/rmr_nng_private.h
src/rmr/nng/src/rmr_nng.c
src/rmr/nng/src/rtable_nng_static.c
src/rmr/nng/src/sr_nng_static.c
test/mbuf_api_static_test.c
test/rmr_nng_test.c
test/rt_nano_static_test.c
test/rt_static_test.c
test/sr_nng_static_test.c
test/test_nng_em.c
test/tools_static_test.c
test/unit_test.ksh