Validate request bodies in controller methods

[portal/ric-dashboard.git] / dashboard / webapp-backend / src / test / java / org / oransc / ric / portal / dashboard / portalapi / PortalAuthManagerTest.java

diff --git a/dashboard/webapp-backend/src/test/java/org/oransc/ric/portal/dashboard/portalapi/PortalAuthManagerTest.java b/dashboard/webapp-backend/src/test/java/org/oransc/ric/portal/dashboard/portalapi/PortalAuthManagerTest.java
index a2747e8..028921b 100644 (file)
--- a/dashboard/webapp-backend/src/test/java/org/oransc/ric/portal/dashboard/portalapi/PortalAuthManagerTest.java
+++ b/dashboard/webapp-backend/src/test/java/org/oransc/ric/portal/dashboard/portalapi/PortalAuthManagerTest.java
@@ -27,6 +27,7 @@ import javax.servlet.ServletException;
 import javax.servlet.http.Cookie;
 
 import org.junit.Assert;
+import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.onap.portalsdk.core.onboarding.util.PortalApiConstants;
@@ -71,22 +72,16 @@ public class PortalAuthManagerTest {
                Assert.assertNull(s);
 
                DashboardUserManager dum = new DashboardUserManager(true);
-               PortalAuthenticationFilter filter = new PortalAuthenticationFilter(false, m, dum);
+               final PortalAuthenticationFilter filter = new PortalAuthenticationFilter(false, m, dum);
                filter.init(null);
                filter.destroy();
                MockHttpServletResponse response = new MockHttpServletResponse();
-               try {
+               Assertions.assertThrows(NullPointerException.class, () -> {
                        filter.doFilter(request, response, null);
-               } catch (NullPointerException ex) {
-                       logger.debug("chain is null");
-               }
+               });
 
-               filter = new PortalAuthenticationFilter(true, m, dum);
-               try {
-                       filter.doFilter(request, response, null);
-               } catch (NullPointerException ex) {
-                       logger.debug("chain is null");
-               }
+               PortalAuthenticationFilter filter2 = new PortalAuthenticationFilter(true, m, dum);
+               filter2.doFilter(request, response, null);
        }
 
 }
\ No newline at end of file