From 900eefd2158c5165baa4ea4fa1ae3093cab99c67 Mon Sep 17 00:00:00 2001
From: kkangmin <kangminh925@gmail.com>
Date: Sat, 4 Oct 2025 13:30:25 +0000
Subject: [PATCH] Add missing unit test for pipeline_controller.py

Add unit tests for missing endpoints:
- get_versions_for_pipeline
- get_pipelines
- upload_pipeline
- get_all_experiment_names

Improved coverage to ~89%

Issue-Id: AIMLFW-280
Change-Id: I7c4b2b31bc852cab58eb57c998fd058a1df0cbfc
Signed-off-by: kkangmin <kangminh925@gmail.com>
---
 tests/test_pipeline_controller.py | 86 ++++++++++++++++++++++++++++++++++++++-
 1 file changed, 85 insertions(+), 1 deletion(-)

diff --git a/tests/test_pipeline_controller.py b/tests/test_pipeline_controller.py
index 6fa2c0e..dae7a0a 100644
--- a/tests/test_pipeline_controller.py
+++ b/tests/test_pipeline_controller.py
@@ -27,7 +27,8 @@ from threading import Lock
 import os
 import sys
 import datetime
-from flask_api import status
+# from flask_api import status
+from http import HTTPStatus as status
 from dotenv import load_dotenv
 load_dotenv('tests/test.env')
 from trainingmgr.constants.states import States
@@ -97,3 +98,86 @@ class TestGetPipelineInfoByName:
 
         assert response.status_code == 500
         assert response.get_json() == {"error": "An unexpected error occurred"}
+
+# ---------------------------
+# Test: get_versions_for_pipeline
+# ---------------------------
+class TestGetVersionsForPipeline:
+    @patch("trainingmgr.controller.pipeline_controller.get_all_pipeline_versions")
+    def test_success(self, mock_versions, client):
+        mock_versions.return_value = ["v1", "v2"]
+        resp = client.get("/pipelines/test/versions")
+        assert resp.status_code == 200
+        assert resp.get_json() == ["v1", "v2"]
+
+    @patch("trainingmgr.controller.pipeline_controller.get_all_pipeline_versions", return_value=None)
+    def test_not_found(self, mock_versions, client):
+        resp = client.get("/pipelines/unknown/versions")
+        assert resp.status_code == 404
+
+
+# ---------------------------
+# Test: get_pipelines
+# ---------------------------
+class TestGetPipelines:
+    @patch("trainingmgr.controller.pipeline_controller.get_all_pipelines")
+    def test_success(self, mock_pipelines, client):
+        mock_pipelines.return_value = ["pipeline1", "pipeline2"]
+        resp = client.get("/pipelines")
+        assert resp.status_code == 200
+        assert resp.get_json() == ["pipeline1", "pipeline2"]
+
+
+# ---------------------------
+# Test: upload_pipeline
+# ---------------------------
+class TestUploadPipeline:
+    @patch("trainingmgr.controller.pipeline_controller.upload_pipeline_service")
+    def test_success(self, mock_upload, client):
+        data = {"file": (BytesIO(b"fake content"), "test.py")}
+        resp = client.post("/pipelines/test/upload", data=data, content_type="multipart/form-data")
+        assert resp.status_code == 200
+        assert "Pipeline uploaded test Sucessfully!" in resp.get_json()["result"]
+
+    def test_invalid_name(self, client):
+        resp = client.post("/pipelines/invalid!name/upload", data={})
+        assert resp.status_code == 500
+        assert "not correct" in resp.get_json()["result"]
+
+    def test_no_file(self, client):
+        resp = client.post("/pipelines/test/upload", data={}, content_type="multipart/form-data")
+        assert resp.status_code == 500
+        assert "File not found" in resp.get_json()["result"]
+
+    def test_empty_filename(self, client):
+        data = {"file": (BytesIO(b""), "")}
+        resp = client.post("/pipelines/test/upload", data=data, content_type="multipart/form-data")
+        assert resp.status_code == 500
+        assert "Filename is not found" in resp.get_json()["result"]
+
+    @patch("trainingmgr.controller.pipeline_controller.upload_pipeline_service")
+    def test_tm_exception(self, mock_upload, client):
+        mock_upload.side_effect = TMException("Upload failed")
+        data = {"file": (BytesIO(b"fake content"), "test.py")}
+        resp = client.post("/pipelines/test/upload", data=data, content_type="multipart/form-data")
+        assert resp.status_code == 500
+        assert "Upload failed" in resp.get_json()["result"]
+
+
+# ---------------------------
+# Test: get_all_experiment_names
+# ---------------------------
+class TestGetAllExperimentNames:
+    @patch("trainingmgr.controller.pipeline_controller.list_experiments_service")
+    def test_success(self, mock_experiments, client):
+        mock_experiments.return_value = ["exp1", "exp2"]
+        resp = client.get("/pipelines/experiments")
+        assert resp.status_code == 200
+        assert resp.get_json() == ["exp1", "exp2"]
+
+    @patch("trainingmgr.controller.pipeline_controller.list_experiments_service")
+    def test_exception(self, mock_experiments, client):
+        mock_experiments.side_effect = Exception("DB error")
+        resp = client.get("/pipelines/experiments")
+        assert resp.status_code == 500
+        assert "DB error" in resp.get_json()["Exception"]
\ No newline at end of file
-- 
2.16.6