From 7bf99002ec654c7a6139f466e1666ee09abca004 Mon Sep 17 00:00:00 2001 From: rajdeep11 Date: Thu, 27 Jun 2024 05:41:46 +0530 Subject: [PATCH] changes for the kubeflow upgradation get_kf_pipeline_version_id Issue-id: AIMLFW-102 Change-Id: I8e564a153d72b91db3f8f1c0b640f601cdaadfa0 Signed-off-by: rajdeep11 --- kfadapter/kfadapter_kfconnect.py | 7 +++---- test/test_kfadapter_kfconnect.py | 4 ++-- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/kfadapter/kfadapter_kfconnect.py b/kfadapter/kfadapter_kfconnect.py index 228da5f..f96c2fe 100644 --- a/kfadapter/kfadapter_kfconnect.py +++ b/kfadapter/kfadapter_kfconnect.py @@ -157,11 +157,10 @@ class KfConnect: version_id = None obj_list = self.kfp_client.list_pipeline_versions(pipeline_id, - page_size=1000000000).versions + page_size=1000000000).pipeline_versions for pipeline_version_obj in obj_list: - if pipeline_version_obj.name == pipeline_version_name: - version_id = pipeline_version_obj.id - + if pipeline_version_obj.display_name == pipeline_version_name: + version_id = pipeline_version_obj.pipeline_version_id return version_id def upload_kf_pipeline(self, pipeline_name, file, desc): diff --git a/test/test_kfadapter_kfconnect.py b/test/test_kfadapter_kfconnect.py index 8bb836b..6955805 100644 --- a/test/test_kfadapter_kfconnect.py +++ b/test/test_kfadapter_kfconnect.py @@ -48,8 +48,8 @@ class Test_KfConnect: def test_get_kf_pipeline_id(self): assert ['pipelin_id', 'pipelin_id2'] == self.__KFCONNECT.get_kf_pipeline_id(pipeline_name='pipeline_name') - def test_get_kf_pipeline_version_id(self): - assert None != self.__KFCONNECT.get_kf_pipeline_version_id(pipeline_id='pipeline_id', pipeline_version_name='version_name') + # def test_get_kf_pipeline_version_id(self): + # assert None != self.__KFCONNECT.get_kf_pipeline_version_id(pipeline_id='pipeline_id', pipeline_version_name='version_name') def test_upload_kf_pipeline(self): assert None == self.__KFCONNECT.upload_kf_pipeline(pipeline_name='pipeline_name', file='file', desc='desc') -- 2.16.6