From 52bf6cf53a585197f998187399ebfd88681d4490 Mon Sep 17 00:00:00 2001 From: vlad shkapenyuk Date: Fri, 25 Sep 2020 13:33:35 -0400 Subject: [PATCH] Disable printing out-of-order messages, increase max_flushes to 25 in running groupby Signed-off-by: vlad shkapenyuk Change-Id: Ied085c332a416f1bd5d7a2cb0f7b24e15ee5c224 --- include/hfta/groupby_operator.h | 4 ++-- include/hfta/groupby_slowflush_operator.h | 4 ++-- include/hfta/join_eq_hash_operator.h | 2 +- include/hfta/running_gb_operator.h | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/include/hfta/groupby_operator.h b/include/hfta/groupby_operator.h index 6085907..2d2dc84 100644 --- a/include/hfta/groupby_operator.h +++ b/include/hfta/groupby_operator.h @@ -47,7 +47,7 @@ public: group grp; if (!func.create_group(tup, (gs_sp_t)&grp)) { if(func.disordered()){ - fprintf(stderr,"Out of order record in %s\n",op_name); + // fprintf(stderr,"Out of order record in %s\n",op_name); return 0; } if (func.flush_needed()){ @@ -64,7 +64,7 @@ public: return 0; } if(func.disordered()){ - fprintf(stderr,"Out of order record in %s\n",op_name); + // fprintf(stderr,"Out of order record in %s\n",op_name); return 0; } diff --git a/include/hfta/groupby_slowflush_operator.h b/include/hfta/groupby_slowflush_operator.h index cc5ab36..f9de2a0 100644 --- a/include/hfta/groupby_slowflush_operator.h +++ b/include/hfta/groupby_slowflush_operator.h @@ -55,7 +55,7 @@ public: group grp; if (!func.create_group(tup, (gs_sp_t)&grp)) { if(func.disordered()){ - fprintf(stderr,"Out of order record in %s\n",op_name); + // fprintf(stderr,"Out of order record in %s\n",op_name); return 0; } if (func.flush_needed()){ @@ -72,7 +72,7 @@ public: return 0; } if(func.disordered()){ - fprintf(stderr,"Out of order record in %s\n",op_name); + // fprintf(stderr,"Out of order record in %s\n",op_name); return 0; } diff --git a/include/hfta/join_eq_hash_operator.h b/include/hfta/join_eq_hash_operator.h index fd8bf00..880cc53 100644 --- a/include/hfta/join_eq_hash_operator.h +++ b/include/hfta/join_eq_hash_operator.h @@ -292,7 +292,7 @@ n_calls=0; n_iters=0; n_eqk=0; //printf("accept_tuple channel=%d: ",tup.channel); int tup_order=func.compare_ts_with_ts(&tup_ts,max_input_ts[tup.channel]); if (tup_order < 0){ - printf("%s: out of order ts, channel=%d.\n", op_name, tup.channel); + // printf("%s: out of order ts, channel=%d.\n", op_name, tup.channel); tup.free_tuple(); // even for out of order temporal tuples we need to post new temporal tuple diff --git a/include/hfta/running_gb_operator.h b/include/hfta/running_gb_operator.h index 3dbe946..ca2e7fc 100644 --- a/include/hfta/running_gb_operator.h +++ b/include/hfta/running_gb_operator.h @@ -48,7 +48,7 @@ public: ret = func.create_group(tup, (gs_sp_t)&grp); nflushes = func.flush_needed(); if(func.disordered()){ - fprintf(stderr,"Out of order record in %s\n",op_name); + // fprintf(stderr,"Out of order record in %s\n",op_name); return 0; } @@ -89,7 +89,7 @@ public: typename hash_table::iterator iter; // Limit the number of successive flushes - avoid explosive behavior - const gs_int32_t max_flushes = 10; + const gs_int32_t max_flushes = 25; if(nflushes>max_flushes){ fprintf(stderr,"Warning in operator %s, temporal advance of %d windows needed, max number of windows that can be reported at once is %d\n",op_name, nflushes, max_flushes); nflushes = max_flushes; -- 2.16.6