From 50ff83df553a67ac0db399af6b7d51e058dde4a2 Mon Sep 17 00:00:00 2001 From: subhash kumar singh Date: Fri, 23 Feb 2024 09:05:04 +0000 Subject: [PATCH] Introduce interface for DB Introcuced the interface for DB to remove direct dependency on S3Mganager. Also removed unused structure. Change-Id: I88be5b595c0d41c490c723c65981c1902a7029ac Signed-off-by: subhash kumar singh --- core/s3_manager.go | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/core/s3_manager.go b/core/s3_manager.go index 8313fcf..b54e06b 100644 --- a/core/s3_manager.go +++ b/core/s3_manager.go @@ -43,6 +43,16 @@ type S3Manager struct { S3Client *s3.S3 } +type DBMgr interface { + CreateBucket(bucketName string) (err error) + GetBucketObject(objectName string, bucketName string) []byte + DeleteBucket(client *s3.S3, objectName string, bucketName string) + DeleteBucketObject(client *s3.S3, objectName string, bucketName string) bool + UploadFile(dataBytes []byte, file_name string, bucketName string) + ListBucket() + GetBucketItems(bucketName string) +} + // Singleton for S3Manager func GetS3ManagerInstance() *S3Manager { Lock.Lock() @@ -58,11 +68,6 @@ func GetS3ManagerInstance() *S3Manager { return s3MgrInstance } -type S3Error struct { - msg string - code int -} - /* This function return an pointer to instance of S3_manager struct the struct instance hold pointer to s3.S3 connection, which is @@ -173,9 +178,9 @@ func (s3manager *S3Manager) UploadFile(dataBytes []byte, file_name string, bucke logging.INFO("File uploaded to bucket ", bucketName) } -func (s3manager *S3Manager) ListBucket(client *s3.S3) { +func (s3manager *S3Manager) ListBucket() { input := &s3.ListBucketsInput{} - result, err := client.ListBuckets(input) + result, err := s3manager.S3Client.ListBuckets(input) if err != nil { logging.ERROR(err.Error()) } @@ -184,5 +189,4 @@ func (s3manager *S3Manager) ListBucket(client *s3.S3) { // Return list of objects in the buckets func GetBucketItems(bucketName string) { - } -- 2.16.6