From 1e56c12edad3d438e3337437bf3f876c34d2a136 Mon Sep 17 00:00:00 2001 From: daniel Date: Fri, 8 Aug 2025 01:33:33 +0900 Subject: [PATCH] Refactor redundant JSON parsing in trainingjob_controller.py - Consolidated duplicate request.get_json() calls into a single call. Issue-ID: AIMLFW-219 Signed-off-by: daniel9456 Change-Id: I9545bcb2dd2b21af0a6a25a531222273f8de02d1 --- trainingmgr/controller/trainingjob_controller.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/trainingmgr/controller/trainingjob_controller.py b/trainingmgr/controller/trainingjob_controller.py index 17af296..78557f8 100644 --- a/trainingmgr/controller/trainingjob_controller.py +++ b/trainingmgr/controller/trainingjob_controller.py @@ -59,8 +59,9 @@ def delete_trainingjob(training_job_id): @training_job_controller.route('/training-jobs', methods=['POST']) def create_trainingjob(): try: - LOGGER.debug(f"Request for training job with JSON: {request.get_json()}") request_json = request.get_json() + LOGGER.debug(f"Request for training job with JSON: {request_json}") + if not check_key_in_dictionary(["training_config"], request_json): return ProblemDetails(400, "Bad Request", "The 'training_config' field is missing.").to_json() request_json['training_config'] = json.dumps(request_json["training_config"]) @@ -157,4 +158,4 @@ def get_model_metrics(trainingjob_id): return jsonify(model_metrics), 200 except Exception as err: LOGGER.error(f"Error Getting model_metrics of trainingJob-ID {trainingjob_id}: {str(err)}") - return ProblemDetails(500, "Internal Server Error", str(err)).to_json() \ No newline at end of file + return ProblemDetails(500, "Internal Server Error", str(err)).to_json() -- 2.16.6