From 07e256fcb16b77d572daf450d07277ba6d07f8b9 Mon Sep 17 00:00:00 2001
From: "aa7133@att.com" <aa7133@att.com>
Date: Mon, 20 Apr 2020 15:59:51 +0300
Subject: [PATCH] version 4.0.8 Optimization level 3 error (Didn't initialize
 parameter) wrong value in pointer now set to nullptr

Change-Id: Ia7bbb437b959510a87e4d0de1769fe8024cce234
Signed-off-by: aa7133@att.com <aa7133@att.com>
---
 .../TEST/testAsn/setUpMessages/SetUpMessages.cpp    | 21 ++++++++++++++++++++-
 RIC-E2-TERMINATION/sctpThread.cpp                   |  5 +++--
 2 files changed, 23 insertions(+), 3 deletions(-)

diff --git a/RIC-E2-TERMINATION/TEST/testAsn/setUpMessages/SetUpMessages.cpp b/RIC-E2-TERMINATION/TEST/testAsn/setUpMessages/SetUpMessages.cpp
index ca18a12..69ae82d 100644
--- a/RIC-E2-TERMINATION/TEST/testAsn/setUpMessages/SetUpMessages.cpp
+++ b/RIC-E2-TERMINATION/TEST/testAsn/setUpMessages/SetUpMessages.cpp
@@ -164,6 +164,24 @@ std::string setupFailure = "<E2AP-PDU>"
 
 
 
+std::string otherSucc = "  <E2AP-PDU>"
+                        "<successfulOutcome>"
+                        "<procedureCode>1</procedureCode>"
+                        "<criticality><reject/></criticality>"
+                        "<value>"
+                        "<E2setupResponse>"
+                        "<protocolIEs>"
+                        "<E2setupResponseIEs>"
+                        "<id>4</id>"
+                        "<criticality><reject/></criticality>"
+                        "<value>"
+                        "<GlobalRIC-ID>"
+                        "<pLMN-Identity>131014</pLMN-Identity>"
+                        "<ric-ID>10101010110011001110</ric-ID>"
+                        "</GlobalRIC-ID>"
+                        "</value>"
+                        "</E2setupResponseIEs><E2setupResponseIEs><id>9</id><criticality><reject/></criticality><value><RANfunctionsID-List><ProtocolIE-SingleContainer><id>6</id><criticality><ignore/></criticality><value><RANfunctionID-Item><ranFunctionID>1</ranFunctionID><ranFunctionRevision>1</ranFunctionRevision></RANfunctionID-Item></value></ProtocolIE-SingleContainer><ProtocolIE-SingleContainer><id>6</id><criticality><ignore/></criticality><value><RANfunctionID-Item><ranFunctionID>2</ranFunctionID><ranFunctionRevision>1</ranFunctionRevision></RANfunctionID-Item></value></ProtocolIE-SingleContainer><ProtocolIE-SingleContainer><id>6</id><criticality><ignore/></criticality><value><RANfunctionID-Item><ranFunctionID>3</ranFunctionID><ranFunctionRevision>1</ranFunctionRevision></RANfunctionID-Item></value></ProtocolIE-SingleContainer></RANfunctionsID-List></value></E2setupResponseIEs></protocolIEs></E2setupResponse></value></successfulOutcome></E2AP-PDU>";
+
 auto main(const int argc, char **argv) -> int {
     E2AP_PDU_t pdu;
     char *printBuffer;
@@ -173,8 +191,9 @@ auto main(const int argc, char **argv) -> int {
     unsigned char buffer[8192] = {};
 
     E2AP_PDU_t *XERpdu  = nullptr;
+    cout << "message size = " <<  otherSucc.length() << endl;
     auto rval = asn_decode(nullptr, ATS_BASIC_XER, &asn_DEF_E2AP_PDU, (void **) &XERpdu,
-                           setupFailure.c_str(), setupFailure.length());
+                           otherSucc.c_str(), otherSucc.length());
     if (rval.code != RC_OK) {
         cout <<  "Error " << rval.code << " (unpack) setup response " << endl;
         //return -1;
diff --git a/RIC-E2-TERMINATION/sctpThread.cpp b/RIC-E2-TERMINATION/sctpThread.cpp
index f622d53..7fa142e 100644
--- a/RIC-E2-TERMINATION/sctpThread.cpp
+++ b/RIC-E2-TERMINATION/sctpThread.cpp
@@ -1943,10 +1943,11 @@ void getRmrContext(sctp_params_t &pSctpParams) {
 }
 
 int PER_FromXML(ReportingMessages_t &message, RmrMessagesBuffer_t &rmrMessageBuffer) {
-    E2AP_PDU_t *pdu;
+    E2AP_PDU_t *pdu = nullptr;
 
     if (mdclog_level_get() >= MDCLOG_DEBUG) {
-        mdclog_write(MDCLOG_DEBUG, "got xml setup response \n %s\n", rmrMessageBuffer.rcvMessage->payload);
+        mdclog_write(MDCLOG_DEBUG, "got xml setup response of size %d is:%s",
+                rmrMessageBuffer.rcvMessage->len, rmrMessageBuffer.rcvMessage->payload);
     }
     auto rval = asn_decode(nullptr, ATS_BASIC_XER, &asn_DEF_E2AP_PDU, (void **) &pdu,
                            rmrMessageBuffer.rcvMessage->payload, rmrMessageBuffer.rcvMessage->len);
-- 
2.16.6