From 957cd9f34329bc33951dcd5ece6f99b1fd1227b7 Mon Sep 17 00:00:00 2001 From: elinuxhenrik Date: Tue, 17 Mar 2020 14:50:12 +0100 Subject: [PATCH] Fix wrong Sonar suppressions Change-Id: I91c4c23e8ac9f64c4e1619ac3525ca5ae3ba5f35 Issue-ID: NONRTRIC-142 Signed-off-by: elinuxhenrik --- policy-agent/src/main/java/org/oransc/policyagent/SwaggerConfig.java | 1 + .../main/java/org/oransc/policyagent/tasks/RicSynchronizationTask.java | 2 +- .../src/test/java/org/oransc/policyagent/repository/LockTest.java | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/policy-agent/src/main/java/org/oransc/policyagent/SwaggerConfig.java b/policy-agent/src/main/java/org/oransc/policyagent/SwaggerConfig.java index 01065f9c..a56892ab 100644 --- a/policy-agent/src/main/java/org/oransc/policyagent/SwaggerConfig.java +++ b/policy-agent/src/main/java/org/oransc/policyagent/SwaggerConfig.java @@ -48,6 +48,7 @@ public class SwaggerConfig extends WebMvcConfigurationSupport { static final String API_TITLE = "A1 Policy management service"; static final String DESCRIPTION = "This page lists all the rest apis for the service."; static final String VERSION = "1.0"; + @SuppressWarnings("squid:S1075") // Refactor your code to get this URI from a customizable parameter. static final String RESOURCES_PATH = "classpath:/META-INF/resources/"; static final String WEBJARS_PATH = RESOURCES_PATH + "webjars/"; static final String SWAGGER_UI = "swagger-ui.html"; diff --git a/policy-agent/src/main/java/org/oransc/policyagent/tasks/RicSynchronizationTask.java b/policy-agent/src/main/java/org/oransc/policyagent/tasks/RicSynchronizationTask.java index 79b92e49..05812d43 100644 --- a/policy-agent/src/main/java/org/oransc/policyagent/tasks/RicSynchronizationTask.java +++ b/policy-agent/src/main/java/org/oransc/policyagent/tasks/RicSynchronizationTask.java @@ -55,6 +55,7 @@ import reactor.core.publisher.Mono; *

* Notify subscribing services */ +@SuppressWarnings("squid:S2629") // Invoke method(s) only conditionally. public class RicSynchronizationTask { private static final Logger logger = LoggerFactory.getLogger(RicSynchronizationTask.class); @@ -64,7 +65,6 @@ public class RicSynchronizationTask { private final Policies policies; private final Services services; - @SuppressWarnings("squid:S2629") // Invoke method(s) only conditionally. public RicSynchronizationTask(A1ClientFactory a1ClientFactory, PolicyTypes policyTypes, Policies policies, Services services) { this.a1ClientFactory = a1ClientFactory; diff --git a/policy-agent/src/test/java/org/oransc/policyagent/repository/LockTest.java b/policy-agent/src/test/java/org/oransc/policyagent/repository/LockTest.java index 814056b3..ee7e04fd 100644 --- a/policy-agent/src/test/java/org/oransc/policyagent/repository/LockTest.java +++ b/policy-agent/src/test/java/org/oransc/policyagent/repository/LockTest.java @@ -36,7 +36,7 @@ import reactor.test.StepVerifier; @ExtendWith(MockitoExtension.class) public class LockTest { - @SuppressWarnings("squid:S2276") // Remove this use of "Thread.sleep()". + @SuppressWarnings("squid:S2925") // "Thread.sleep" should not be used in tests. private void sleep() { try { Thread.sleep(100); -- 2.16.6