From 42f2115c202cdb68191c9715e0036db6f3db24c5 Mon Sep 17 00:00:00 2001 From: Timo Tietavainen Date: Fri, 30 Sep 2022 13:22:46 +0300 Subject: [PATCH] Handle CloseDB() error in statistics query Add handling of Redis connection close function CloseDB() return value after sentinel statistics were queried. Issue-Id: RIC-942 Signed-off-by: Timo Tietavainen Change-Id: I632b112a085c95bf0dbe80035308ffcc799bfa10 --- internal/sdlgoredis/sdlgoredis.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/internal/sdlgoredis/sdlgoredis.go b/internal/sdlgoredis/sdlgoredis.go index 8cdae46..7f66f0c 100644 --- a/internal/sdlgoredis/sdlgoredis.go +++ b/internal/sdlgoredis/sdlgoredis.go @@ -886,7 +886,9 @@ func sentinelStatistics(db *DB) (*DbStatistics, error) { for _, r := range dbState.ReplicasDbState.States { replicaDb := createReplicaDbClient(r.GetAddress()) dbStatisticsInfo, err = getStatisticsInfo(replicaDb, r.GetAddress()) - replicaDb.CloseDB() + if closeErr := replicaDb.CloseDB(); closeErr != nil { + return nil, closeErr + } if err != nil { return nil, err } -- 2.16.6