E. Scott Daniels [Tue, 10 Nov 2020 13:38:52 +0000 (08:38 -0500)]
Address complaints by code scanner
This change addresses complaints generated by a recent code scan
Issue-ID: RIC-673
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I230449eced30477e13ec3eb867a5e16f67d4fae8
E. Scott Daniels [Thu, 5 Nov 2020 14:11:04 +0000 (09:11 -0500)]
Fix potential race in route table load
If route tables are received in quick succession there is a potential
race condition that can cause the xAPPs thread to use a stale pointer
likely resulting in a segfault.
Issue-ID: RIC-674
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I5536d3f30646dca0ed375468719fa3cf0920c103
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
E. Scott Daniels [Fri, 30 Oct 2020 19:04:16 +0000 (15:04 -0400)]
Address code analysis issues
This change addresses code analysis issues which were found to be
potential bugs in the code. The details are captured in the Jira
ticket.
Issue-ID: RIC-673
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Ic05b716780f5fae76e98a3c5fa8be98fcd8452d8
E. Scott Daniels [Fri, 2 Oct 2020 11:36:41 +0000 (07:36 -0400)]
Add message types for traffic steering anomaly messages
This change addes the following message types:
TS_ANOMALY_UPDATE
TS_ANOMALY_ACK
The RTD message type page will also be updated.
Issue-ID: RIC-651
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I4a8efd6d9c2aced40b6ff1eb6e42ee3d034f0745
Thoralf Czichy [Tue, 22 Sep 2020 10:46:22 +0000 (10:46 +0000)]
Merge "Removig committer Chris"
E. Scott Daniels [Mon, 21 Sep 2020 15:59:35 +0000 (11:59 -0400)]
Add manual page for set low latency funciton
This change adds the manual page for the rmr_set_low_latency()
function.
Issue-ID: RIC-631
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I3c5bd0a27ef36c351b2003c34d70f4f09aff8974
czichy [Mon, 21 Sep 2020 10:17:19 +0000 (13:17 +0300)]
Removig committer Chris
Signed-off-by: czichy <thoralf.czichy@nokia.com>
Change-Id: I446de1d2187d6fc2294d365b95220c8c9cfe88a1
E. Scott Daniels [Thu, 17 Sep 2020 20:39:31 +0000 (16:39 -0400)]
Add summary data to unit test output
This change causes summary data to be added to the unit test
data that is generated. Summary data lists counts for the total
tests, test passed and test failed in addition th to the information
which was previously generated.
Issue-ID: RIC-646
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Ibeda3418291c490d49f9e8a29b89c93aa55567fb
E. Scott Daniels [Tue, 15 Sep 2020 14:27:34 +0000 (10:27 -0400)]
Fix rmr_rpobe command line bug; add test coverage
This change corrects a deficency in the command line parsing of
the rmr_probe support utility. It also adds unit test code to
cover a significant portion of the SI95 code which was previously
not covered. Commented out code in SI95 was also removed to
reduce the sonar grumblings.
Issue-ID: RIC-645
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I5943bacf8d7434a7991781dba70b01bf5c16c67d
E. Scott Daniels [Fri, 11 Sep 2020 16:43:36 +0000 (12:43 -0400)]
Push package to release in package cloud (4.2.2)
Issue-ID: RIC-644
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I5a6c826a9d8cfc7369ac4095b04f1770ec197ffd
E. Scott Daniels [Fri, 11 Sep 2020 13:51:52 +0000 (09:51 -0400)]
Fix core dump in rmr_probe when -r option given
When the '-r' option was given on the rmr_probe command line the
process would core dump. This change corrects the argument parsing
code that was the source of the problem.
Issue-ID: RIC-644
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I02b5b0ba211de1ec0458e8c83d2f2ccf97523825
E. Scott Daniels [Thu, 20 Aug 2020 15:55:19 +0000 (11:55 -0400)]
Push package ver 4.2.1 out of pkg-cloud staging
This commit changes the release version information which will
cause the package to be moved from the staging repo to the release
repo in package cloud.
Issue-ID: RIC-630
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Ibc7c2cc49a6fbcd91a1795057af94fc82108d515
E. Scott Daniels [Tue, 4 Aug 2020 17:48:47 +0000 (13:48 -0400)]
Add additional env variable dump during init
If the RMR_LOG_VLEVEL environment is set to 4 or greater
the settingf for the environment variables that are
significant to RMR are written to stderr.
Issue-ID: RIC-630
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I6709f2c6d6c592494b0a7edbf23b6bd234715262
E. Scott Daniels [Mon, 3 Aug 2020 13:22:20 +0000 (09:22 -0400)]
Add ability to control route table req frequency
This change introduces the RMR_RTREQ_FREQ environment variable
which allows the frequency that RMR will send requests to the
route manager to be externally controlled. Valid values are between
1 and 300 seconds inclusive.
This change also closes a test initialisation issue causing unit
test failures in the CI environment.
Issue-ID: RIC-630
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I399cca797c6b13a1b7fab0c9c17d54c419cf169f
E. Scott Daniels [Tue, 21 Jul 2020 17:39:18 +0000 (13:39 -0400)]
Fix potential pointer use err in SI95
In SIconnect it was possible for a freed struct to be used
if the session didn't connect.
This change also picks up whitespace changes to the docs.
Issue-ID: RIC-626
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Ie23f4925c6a29b301f0143e938c11f57f0ed5631
E. Scott Daniels [Wed, 8 Jul 2020 15:28:05 +0000 (11:28 -0400)]
Allow RTS calls prior to initial route table load
To better support heartbeat responses it is necessary to
allow RTS messages to be sent prior to the loading of
the initial route table. This change implements this and
has the side effect of also allowing wormhold sends prior
to a route table arrival (which is ok since no routing
is needed for wormhole traffic).
Issue-ID: RIC-589
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I302bdd0f274a7c5bc95f3f382e3374b21662ab8c
E. Scott Daniels [Wed, 24 Jun 2020 17:49:32 +0000 (13:49 -0400)]
Relase 4.1.2 from package cloude staging
This commit will cause the packages in PC staging to move
to the release repo.
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Ie88563ba97353a614794859aeb79b21c68b2f54b
E. Scott Daniels [Mon, 22 Jun 2020 20:25:31 +0000 (16:25 -0400)]
Fix bug in message type header file
There was a dangling 'i' on one of the new constants.
The script to scrape the message type header file and the
resulting RTD document are also included in this change.
The comments which provide supplemental documentation have
been added to the header file.
Issue-ID: RIC-514
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I8ba2eaa4242f0870e05030896050f7fe8e2dd106
E. Scott Daniels [Mon, 22 Jun 2020 12:07:28 +0000 (08:07 -0400)]
Add RIC message types to header
Message types added to the RIC message type header for:
RIC_ALARM (110)
RIC_ALARM_QUERY (111)
RIC_METRICS (120)
RAN_E2_RESET_REQ (12008)
RAN_E2_RESET_RESP (12009)
Issue-ID: RIC-514
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I544cec60e4e9402139261b6fe0291d7c1253475e
E. Scott Daniels [Thu, 18 Jun 2020 12:22:58 +0000 (08:22 -0400)]
Allow C++ applications to include symtab header
The RMR symbol table functions are exposed to xAPPs, however the
header file lacked the magic C++ goo that allowed it to be included.
This change adds the goo, and changes a parameter name in the
prototypes to avoide a collision with C++ reserved words.
Issue-ID: RIC-522
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Idadaa109d191b0de0629737f27d2444a4e581e64
E. Scott Daniels [Fri, 12 Jun 2020 14:40:19 +0000 (10:40 -0400)]
Correct man page formatting in RST output
Some man pages were assuming that the "&item" macro
was defined. This change adds that macro and pushes
the affected RST man pages for RTD.
The change also adds a release header for the major
project releases to the relase notes file.
Issue-ID: RIC-510
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I89b784c4a18ba0ac85aaed2bdde8bda18e3d0946
Lott, Christopher (cl778h) [Thu, 11 Jun 2020 17:51:04 +0000 (13:51 -0400)]
Add installation guide with link to PackageCloud
Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>
Change-Id: I4efabf46db130cefc9b972f199eb938b551d7ba1
czichy [Thu, 11 Jun 2020 11:28:46 +0000 (14:28 +0300)]
Removing and adding committers
Signed-off-by: czichy <thoralf.czichy@nokia.com>
Change-Id: Ifc8389ca04b19d71148e4ba36f61d95c16c83d45
E. Scott Daniels [Mon, 8 Jun 2020 13:20:32 +0000 (09:20 -0400)]
Publish man page changes to RTD
Man page changes commited earlier were not published. This change
publishes these changes.
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I056d7f03e05b3fcc633ac6c12962b7ffc4a49aab
Lott, Christopher (cl778h) [Wed, 3 Jun 2020 19:42:06 +0000 (15:42 -0400)]
Repair minor flaws in wormhole function docs
Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>
Change-Id: Ia8c0707c074c424f3380c972f57478473689496e
E. Scott Daniels [Wed, 13 May 2020 13:50:40 +0000 (09:50 -0400)]
Add link to RTD index
This change adds the link to the main RMR manual page
in place of a formal overveiw document.
A few other small tweaks were made to the route table
document and glossary; the glossary code is shared so the
update triggers an update to the user guide .rst as well.
The overview source is deleted in this change.
Issue-ID: RIC-378
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I4972683faaab204dd0167b67a7510cb97e01d01a
E. Scott Daniels [Wed, 6 May 2020 13:07:08 +0000 (09:07 -0400)]
Add route table guide and formatting tweaks
The route table guide has been added to the repo so that it
can be published on the RTD site. This change also includes
pulling full examples into the user guide from the repo
example directory (rather than maintaining snipits in the
doc), and generates RST definition lists in a more traditional
format that just look better in the rendered HTML.
Issue-ID: RIC-378
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I2661dbb28daf3575640426a847f17fe45ea0ba43
Lott, Christopher (cl778h) [Thu, 7 May 2020 11:46:00 +0000 (07:46 -0400)]
Release RMR packages at version 4.0.5
Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>
Change-Id: Ic749b5bb9ed28b74c95dcda061a96c6a1ab23cef
Matti Hiltunen [Thu, 7 May 2020 03:17:22 +0000 (03:17 +0000)]
Merge "Fix semaphore count bug in SI95 non-blocking rcv"
E. Scott Daniels [Wed, 6 May 2020 19:45:49 +0000 (15:45 -0400)]
Fix semaphore count bug in SI95 non-blocking rcv
When a non-blocking receive is invoked it is possible that
the semaphore count was not being decremented as the message
is popped off the ring. This corrects that.
Issue-ID: RIC-355
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: If502f6f85c7ea5960f38e61fc8e3e29427b4c30f
Lott, Christopher (cl778h) [Wed, 6 May 2020 14:45:25 +0000 (10:45 -0400)]
Change doc config key to ric-plt-lib-rmr
Adjust the token shown in the top-left corner of RTD pages.
Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>
Change-Id: I15aa222cfb71cd766ce76353927a3b4fbd7dc6fe
E. Scott Daniels [Wed, 29 Apr 2020 17:16:11 +0000 (13:16 -0400)]
Correct traffic steering message type constants
The original correction got the "fix" backwards.
This changes QUE to QOE as it was supposed to be.
Issue-ID: RIC-342
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I72a4869c5bd2e6db29e8243a460b9c2503c7fc1e
E. Scott Daniels [Tue, 28 Apr 2020 20:20:53 +0000 (16:20 -0400)]
Fix sonar flagged bugs
1 bug and 9 security (buffer overrun potentials) were
corrected.
Issue-ID: RIC-78
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I95fb1180efb304ab9fed98eea83af29d5ed23fe7
Lott, Christopher (cl778h) [Tue, 28 Apr 2020 16:41:50 +0000 (12:41 -0400)]
Document both valid route table entry types
This includes "rte" (old) and "mse" (new) using text gleaned
from the wiki page.
Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>
Change-Id: Ib57405f93a41b74ad651c89de283211572d503b6
Lott, Christopher (cl778h) [Mon, 27 Apr 2020 21:07:20 +0000 (17:07 -0400)]
Add missing pipe delimiter to route table syntax
Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>
Change-Id: I169d3144524f8ae9f03e008cc4a20a13540d062b
E. Scott Daniels [Mon, 27 Apr 2020 13:04:48 +0000 (09:04 -0400)]
Release commit: move 4.0.2 to release repo
This change causes the 4.0.2 package in the staging repo to be
moved to the released repo.
Issue-ID: RIC-341
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I7f77eab8c09a179d7cbfb61d696873ed0ad61410
E. Scott Daniels [Fri, 24 Apr 2020 17:26:21 +0000 (13:26 -0400)]
Fix SI95 transport header length bug
A bug in the buffer length extraction from the SI95 transport
header was causing failures when communicating with an application
using a backlevel version of RMR. Symptoms were dropped return
to sender messages, and a flood of messages with type 0. This
fix corrects this problem.
Issue-ID: RIC-341
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I0223608c26917a5f94378fd83e1bb71be93999fe
E. Scott Daniels [Fri, 24 Apr 2020 01:20:54 +0000 (21:20 -0400)]
Fix message type constant name for TS_QUE_PREDICTION
The constant for message type 30002 was not correct.
Issue-ID: RIC-342
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I4286f96f650ad77811c76cccef0eeca52592ad34
Scott Daniels [Wed, 22 Apr 2020 18:16:10 +0000 (18:16 +0000)]
Merge "Release RMR packages at version 3.8.2"
Lott, Christopher (cl778h) [Wed, 22 Apr 2020 18:01:20 +0000 (14:01 -0400)]
Drop release files for RMR python bindings
The binding code left this repo so the control files are useless.
Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>
Change-Id: Ie030e54b6647d448cfa1110c03d0f49f107d2cd5
Lott, Christopher (cl778h) [Wed, 22 Apr 2020 17:27:13 +0000 (13:27 -0400)]
Release RMR packages at version 3.8.2
Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>
Change-Id: I4c49a99c7b01e9a38f491dfd07458271da73b1e8
E. Scott Daniels [Tue, 21 Apr 2020 16:51:05 +0000 (12:51 -0400)]
Remove NNG libraries from packages
The default build process will no longer include the NNG
libraries (librmr_nng.*) by default. It is still possible
to enable them with a CMake build flag (-DBUILD_NNG=1).
The NNG specific unit tests have been disabled.
Some SI95 specific unit tests have been enhanced in an effort
to work toward full coverage of the SI95 code.
This change is in a major version bump as the package contents
change. However, there is NOT an API change; all existing
applications will be able to use the new version without any
modification (other than possibly removing references to the
NNG based libraries).
Issue-ID: RIC-337
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Ic9854b1ffc1e82c765692a11724d8086d24cceed
E. Scott Daniels [Mon, 20 Apr 2020 17:17:04 +0000 (13:17 -0400)]
Fix block of dynamic route table load
A bug in the initialisation of RMR beginning with 3.7.2
was causing the dynamic update of routes to be blocked.
This change corrects that bug.
Issue-ID: RIC-336
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I517b0ba65808bb4853983f92bc57e93a22792014
E. Scott Daniels [Fri, 17 Apr 2020 21:07:06 +0000 (17:07 -0400)]
Documentation fixes and revamp user guide
The user guide is now a real document and no longer a collection
of the RMR manual pages (which now exist on their own).
This change also corrects some minor typos in the manual pages.
Issue-ID: RIC-328
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I4eb915ca029ab20d3ceb9d56247f30fde4e04766
E. Scott Daniels [Fri, 17 Apr 2020 17:00:28 +0000 (13:00 -0400)]
Add safe connect, fix possible seg fault in RTC
This change adds "safe connect" to the SI95 code which avoids
the connect to even port bug in Linux which could potentially
result in a successful connection when the remote process is
not running or listening on the attempted port.
Issue-ID: RIC-332
This change also includes a change to the level 2 debugging
in the route table collector (RTC) code which could have
resulted in a segment fault.
Issue-ID: RIC-335
Several of the man pages are updated with typo corrections.
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Ib6045f36850bd2a4b07a19bf11839ce3e9824b6a
E. Scott Daniels [Wed, 15 Apr 2020 15:28:11 +0000 (11:28 -0400)]
Add missing mc report message type to header
The type 30010 was not defined in the header file; it now is.
Issue-ID: RIC-334
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I9cbf576ac04d134f2d8e40c634fe0bc332125735
Matti Hiltunen [Tue, 14 Apr 2020 20:55:32 +0000 (20:55 +0000)]
Merge "Fix rmr_call() parameter checking bug"
E. Scott Daniels [Tue, 14 Apr 2020 19:55:13 +0000 (15:55 -0400)]
Fix rmr_call() parameter checking bug
When RMR was extended to add wormhole support for
a rmr_wh_call() function, the main call code was broken
into an inward facing funciton. A parameter check which
applies only to the outward facing rmr_call() API function
was accidentally moved to the internal funciton. This change
moves the check back into the rmr_call() funciton.
Issue-ID: RIC-333
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Iab0c8cc33e8a9970c53b9248021a1273559f82f8
E. Scott Daniels [Fri, 10 Apr 2020 21:17:02 +0000 (17:17 -0400)]
Add manual pages to RTD as individual files
This change introduces the code to generate man pages
as individual .rst files and the first set of those
into the scrapable docs directory.
Issue-ID: RIC-328
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I8d0b7b84b0b4fcadf9767d0ba69db64078a38d69
E. Scott Daniels [Fri, 10 Apr 2020 16:11:30 +0000 (12:11 -0400)]
Fix failure when in static only route table mode
When the RMR_RTG_SVC environment variable is set to -1, RMR
should enter static route table only mode and not attempt to
listen for dynamic updates from the route manager. There was
a misinterpretation of the environment variable name when
checking for this value which was causing the initialisation
to fail.
Man pages were also updated to remove references to the
deprecated RMR_MAX_RCV_BYTES constant. The constant was
marked as being deprecated.
Issue-ID: RIC-331
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I7b0b82397f3ad4f223682727213504d3fbdae518
E. Scott Daniels [Wed, 8 Apr 2020 19:44:40 +0000 (15:44 -0400)]
Eliminate the SI receive buffer length requirement
This change eliminates the need to enforce a receive
buffer maximum length as specified by the user application.
The length supplied will be assumed to be the "normal"
maximum and used as the default receive buffer size,
but when messages larger than this are received RMR will
now allocate a larger buffer to use.
Issue-ID: RIC-309
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I9dacadea40b982fde604b78789568b8118a89b35
Scott Daniels [Thu, 9 Apr 2020 16:23:40 +0000 (16:23 +0000)]
Merge "Add missing man pages to doc build list"
Lott, Christopher (cl778h) [Thu, 9 Apr 2020 15:56:06 +0000 (11:56 -0400)]
Add missing man pages to doc build list
Add rmr_close and rmr_set_fack; sort the list
Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>
Change-Id: Id27559cca0da7921478be4df9281ec26917560a8
Tommy Carpenter [Wed, 8 Apr 2020 16:40:22 +0000 (12:40 -0400)]
RMR Python has been moved to xapp frame.
Issue-ID: RIC-228
Change-Id: I527179f3cd9c717789d4d1289728a15597af98aa
Signed-off-by: Tommy Carpenter <tc677g@att.com>
E. Scott Daniels [Fri, 3 Apr 2020 14:14:44 +0000 (10:14 -0400)]
Rename health_ck support binary to rmr_probe
The health_ck name was determed to be too generic
and has been replaced with rmr_probe. The application
performs the same health check function, and may at some
point in the futre be extended to provide other RMR
delivered probes.
This change also adds a useage message which was missing
Issue-ID: RIC-308
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I98f9dd7f9598b6a5682e4fb0d62c4146e8577e97
Lott, Christopher (cl778h) [Tue, 7 Apr 2020 00:31:32 +0000 (20:31 -0400)]
Fix minor typos in RMR man pages
Remove some spaces within invocations of &bold() and other
formatting macros to placate the RST/Sphinx formatter.
Remove tab characters entirely, which cleans up code examples.
Change text "NULL pointer" to "nil pointer".
Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>
Change-Id: Ic9ab6304831c0b1db21f62159da4f02f0442bb98
Matti Hiltunen [Tue, 7 Apr 2020 14:45:24 +0000 (14:45 +0000)]
Merge "Fix SI address and initialistion bugs"
E. Scott Daniels [Mon, 6 Apr 2020 20:42:32 +0000 (16:42 -0400)]
Fix SI address and initialistion bugs
The SI95 address translation between an address struct and
human readable string had a function call with reversed
parameter constants.
The SI initialisation could excite an NPE if the v6 "listen
all" string (::) was given instead of 0.0.0.0.
Issue-ID: RIC-327
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Ifa673aca7ceaa7e47fbd9158340f0f825ac0fae8
Lott, Christopher (cl778h) [Mon, 6 Apr 2020 19:05:22 +0000 (15:05 -0400)]
Add SI95 transport library to doc
Also clean up a few minor typos
Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>
Change-Id: I275dc89012b7f5b6f460a3267ddcc9193a9d2ef2
E. Scott Daniels [Wed, 1 Apr 2020 18:01:02 +0000 (14:01 -0400)]
Fix possible nil pointer deref in interface check
This change address a potential nil pointer dereference when
building a list of interface names that might be used for
connection listening.
Issue-ID: RIC-307
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I3b63bebe31afc61073bd4d4093f1fb42d018963e
Matti Hiltunen [Thu, 2 Apr 2020 15:05:28 +0000 (15:05 +0000)]
Merge "Fix potential nil ptr seg fault and CI test issue"
E. Scott Daniels [Wed, 1 Apr 2020 16:39:47 +0000 (12:39 -0400)]
Fix potential nil ptr seg fault and CI test issue
This change corrects two problems that the "dockerless"
CI build process was encountering:
- Include and link paths set in the CMake config
were not always honoured by the application test
scripts
- Building packges to install in the test environment
as a non-root user was causing non-standard install
prefixes to be added to the packages.
This change also corrects a typo in the NNG module which
potentially could have allowed a nil pointer to be
dereferenced. This bug was discovered while makeing the
changes for the CI jobs.
Issue-ID: RIC-303
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I30150950dd186e72f8c822ec3fbe5b07369cb4ce
E. Scott Daniels [Mon, 30 Mar 2020 16:23:13 +0000 (12:23 -0400)]
Release commit to push 3.6.3 in package cloud
This change will cause the push job to promote the 3.6.3
fix to the release area of package cloud. There are
no changes in this commit.
Issue-ID: RIC-301
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I85eece74fa4b8fcbe94a47fd0f97c25df9b23b51
E. Scott Daniels [Mon, 30 Mar 2020 15:05:45 +0000 (11:05 -0400)]
Correct the max receive message constant
The max receive size constant (a user programme only
constant) still reflected the original limit of 4k.
While internally this was not used and/or enforced, the
incorrect setting could cause some wrapper implementations
to incorrectly limit the max receive size.
This change sets this constant to the acknowledged max
receive size for all transports (64K).
Issue-ID: RIC-301
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I214b9d9dd67a00232e57bab8327dcb76f891b517
E. Scott Daniels [Wed, 25 Mar 2020 14:02:53 +0000 (10:02 -0400)]
Set release file for RMR core package
This change sets the release file for RMR's core package
such that 3.6.2 should be promoted in the package cloud
environment.
Issue-ID: RIC-295
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I36623d829fb2816d75ff47773c98b6451ba31e22
E. Scott Daniels [Mon, 23 Mar 2020 18:37:16 +0000 (14:37 -0400)]
Fix msg init bug when pulling msg from the poo2
When reusing a message from the message pool the flags were
not being properly reset before the message was returned
Issue-ID: RIC-295
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I5924e162ca9e1835807785e2401a871f1fcd36b2
Tommy Carpenter [Thu, 19 Mar 2020 12:58:30 +0000 (08:58 -0400)]
Release 400
Issue-ID: RIC-256
Change-Id: I3dbf31ebc86b039ded8ae6e689459647e16f1839
Signed-off-by: Tommy Carpenter <tc677g@att.com>
Tommy Carpenter [Thu, 19 Mar 2020 12:30:39 +0000 (08:30 -0400)]
Switch to SI95.
Issue-ID: RIC-156
Change-Id: I31868eac8abfde19be820dcabe630c0f75aecdfd
Signed-off-by: Tommy Carpenter <tc677g@att.com>
E. Scott Daniels [Thu, 19 Mar 2020 03:50:57 +0000 (23:50 -0400)]
Fix problem with RPM install
The additon of the health check supplemental application was
causing the RPM install to fail because of a misconception that
a library in the package wasn't already installed. This change
attempts to address this by hard linking the RMR library (.a)
into the supplemental applicaiton such that RPM won't assume
a depenendency.
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: If9b70bed14a7994c517dc514c7963488301c8206
E. Scott Daniels [Wed, 18 Mar 2020 12:41:07 +0000 (08:41 -0400)]
Additional message types added for TS and E2
Message types added in RIC message types header
for E2_RESET and TS (traffic steering).
This change also includes additional constants in
rmr.h to help framework code improve readability.
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I3e0f358b4f34f461ea09dfe7d823c6251d4e398b
E. Scott Daniels [Mon, 16 Mar 2020 17:12:59 +0000 (13:12 -0400)]
Correct meid table parse bug
The MEID table parser was not ack/nacking to route manager
when the end of the table was recognised.
Issue-ID: RIC-273
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I2272005301bb376942cb4be262406846f98270ef
E. Scott Daniels [Fri, 13 Mar 2020 15:10:34 +0000 (11:10 -0400)]
Break changes for easier doc generation
Because the repo houses both the core RMR and python
wrappers the changes file was messy. This change breaks
the changes file into one for wrappers and one for the
core RMR code. The RTD release notes is generated by
combining these changes files with meaningful section
headers.
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I5cac1f601c9e5c71e6ab14c34751100410882688
E. Scott Daniels [Tue, 10 Mar 2020 12:28:37 +0000 (08:28 -0400)]
Add health check mesage types
This change adds the health check message types to the main
RIC message type list.
Issue-ID: RICAPP-25
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I9010ae719c27ff5a6271fa8fe05e2499eb83759f
E. Scott Daniels [Mon, 9 Mar 2020 17:57:39 +0000 (13:57 -0400)]
Add the wormhole call function
This change adds the rmr_wh_call() function to provide a
wormhole send which blocks until a response is received.
Issue-ID: RICAPP-80
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Ic97001db8a9fb177c70045fc3d0326805b9fb17b
E. Scott Daniels [Fri, 6 Mar 2020 18:40:33 +0000 (13:40 -0500)]
Correct CMake document reference typo
The man page build CMake file had a typo which was
preventing it from building in the merge environment.
Issue-ID: RICAPP-79
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I91676b688ddbac1833e552008ce40f68904ce792
E. Scott Daniels [Fri, 6 Mar 2020 17:29:28 +0000 (12:29 -0500)]
Add wormhole state check function
This change adds a new function allowing the state of a wormhole
to be checked by the user programme.
Issue-ID: RICAPP-79
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Id685dcb163f7266aa40f04317bee2b23fade4f43
E. Scott Daniels [Fri, 6 Mar 2020 14:13:06 +0000 (09:13 -0500)]
Add missing changes and CMake from last change
The CHANGES and CMakefile needed to bump the version on
the last change were omitted. This adds those files.
Issue-ID: RICAPP-78
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Id37dc89fb2f33d6cce0bf4b7661bdf6c70bcddbe
Matti Hiltunen [Fri, 6 Mar 2020 13:57:50 +0000 (13:57 +0000)]
Merge "Address code analysis issues"
E. Scott Daniels [Thu, 5 Mar 2020 21:16:09 +0000 (16:16 -0500)]
Address code analysis issues
This change addresses the bugs which Sonar identified on
5 March 2020. These were identified as Reliability bugs
two of which were found to be true issues; all were
addressed in hopes of keeping sonar quiet.
Issue-ID: RICAPP-78
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Id575817686395bbad9683b1df476e3e1e7fbd2b2
Lott, Christopher (cl778h) [Thu, 5 Mar 2020 15:19:50 +0000 (10:19 -0500)]
Add option for xml coverage to pytest
Also add invocation of coverage tool
Signed-off-by: Lott, Christopher (cl778h) <cl778h@att.com>
Change-Id: I61d188c72cec0b36f059825246fa99732da715a5
E. Scott Daniels [Fri, 21 Feb 2020 18:24:29 +0000 (13:24 -0500)]
Add first set of SI95 unit tests and health check
This change adds the first series of unit tests for
the RMR SI95 code. It also bundles the running of
the unit tests and the application level tests into
the CMake description such that "make test" will
run them all.
The health check application (health_ck) is now built
from the "support" source and added to the RMR run-time
package in /usr/local/bin.
Issue-ID: RIC-151
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I72804452afa5a972aa4ca0ded7b68131e16f5955
Tommy Carpenter [Tue, 3 Mar 2020 22:04:55 +0000 (22:04 +0000)]
Release 221
Issue-ID: RICAPP-74
Change-Id: I156f1e0d584e62b3f5670cc3b09d9c9c31075034
Signed-off-by: Tommy Carpenter <tc677g@att.com>
E. Scott Daniels [Tue, 3 Mar 2020 20:30:59 +0000 (15:30 -0500)]
Fix MEID unit test, catch init failure
The RMR change to support routing based on the MEID (
190665fe)
broke the related unit tests. This change fixes the unit test.
This change also adds a check to the init wrapper function to
ensure that an error is generated if RMR is unable to initialise
the underlying transport.
Issue-ID: RICAPP-74
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I1f3ca3f8e821cd1356fb5247404b8cafd22a6119
E. Scott Daniels [Fri, 28 Feb 2020 15:21:09 +0000 (10:21 -0500)]
Fix bug preventing table ID from being sent on ack
When RMR acks the receipt of a route table to Rt. Mgr. it
was failing to send the table ID. This change fixes this
problem.
Issue-ID: RIC-232
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I363df4d2b1ecc8432ed7767edfabbf78c575838d
E. Scott Daniels [Wed, 26 Feb 2020 19:28:54 +0000 (14:28 -0500)]
Fix message marker for src reset on send/rts
The SI95 receive function was not properly causing a
message buffer to be marked as "receive generated" and
if the msg buffer was subsequently used to send a message
(e.g. return to sender) the correct source address was
not placed into the message before sending. This change
ensures that the message buffer received via SI95 are
marked so that a send will set the source address when
needed.
Issue-ID: RIC-227
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Ic9c49834e5f066420463fa4568cfdf6f722f81cb
E. Scott Daniels [Wed, 26 Feb 2020 14:20:45 +0000 (09:20 -0500)]
Changes to fd2ep for locking and disconnect locking
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I4c3d9d4191d0c994246c076861b52973413404a6
E. Scott Daniels [Tue, 25 Feb 2020 15:40:20 +0000 (10:40 -0500)]
Address multi-threading issues in SI95
There are potential issues when a uer application is multi-threaded
and disconnections are noticed. This change addresses these issues.
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Ie586cfe6294429b299e0044b2f6bf315d78104ce
E. Scott Daniels [Mon, 24 Feb 2020 15:14:56 +0000 (10:14 -0500)]
Fix meid related core dump
This change fixes a bug in rtable_nng_static and rtable_si_static
modules. The caller's reference to the discovered endpoint was
not always being set correctly.
The change also corrects the unit test which missed the problem.
Issue-ID: RIC-220
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I11a5e89638845b1f31953c16bb584108c0f88850
E. Scott Daniels [Fri, 21 Feb 2020 18:58:19 +0000 (13:58 -0500)]
Revert RTS to use unidirectional connection
Because of potential performance impacts it was decided to
revert return to sender messages to NOT use the same
connection that the message was received on. This applies
only to the SI95; RTS has always been on uni-directional
connections with NNG.
This change also enables the MEID routing in the SI95 code.
Issue-ID: RIC-153
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I6415effb3283f5961aa0098f1ff0d1380d7aa197
E. Scott Daniels [Thu, 20 Feb 2020 19:43:35 +0000 (14:43 -0500)]
Fix crash under SI95 with multiple receive threads
When the user application was using multiple threads to receive
messages it was alsmost certain to crash with a segfault.
This change corrects a bug in the ring handler which was
allowing a premature release of the ring lock.
A verification cookie has been added to the msg buffer to
facilitate validation of a message buffer when examining
crash output.
Issue-ID: RIC-218
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Iaa6519e415dcf7f8c52312e8e02d8cf4dca5866f
E. Scott Daniels [Wed, 19 Feb 2020 14:47:06 +0000 (09:47 -0500)]
Add message types for E2 setup
Issue-ID: RIC-214
Message types added to the RIC header in rmr.
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I38612fd7915090a515da07986df830f3a72bf8e9
E. Scott Daniels [Fri, 14 Feb 2020 14:23:59 +0000 (09:23 -0500)]
Add ability for RMR to request route table
The route table collector has been extended to allow RMR to send
a request to have the route manager deliver a new table. This
change also provides for an ack/nack to be sent back to route
manager to indicate the state of a route table update.
There is also a small wormhole bug fix:
Wormhole send was not clearing the call ID and some message
were being treated as call response on the other side.
Issue-ID: RIC-92
Issue-ID: RIC-91
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I8ffa7919b42412e4604130885b968f32b5448294
E. Scott Daniels [Fri, 14 Feb 2020 14:31:48 +0000 (09:31 -0500)]
Fix SI bug causing core dump sending to closed fd
The SIsendt function was not properly checking the file descriptor
and could core dump when an attempt was made to send on a connection
that was closed.
Issue-ID: RIC-207
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I09b33bf1185aef609bfff058b272e1895eb1a29d
Matti Hiltunen [Thu, 6 Feb 2020 19:16:34 +0000 (19:16 +0000)]
Merge "Cmake, change files missing from previous commit"
E. Scott Daniels [Thu, 6 Feb 2020 18:46:34 +0000 (13:46 -0500)]
Cmake, change files missing from previous commit
The cmake and changes files were accidentally omitted from the
previous commit.
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Ib6cbe254816305d83acf65207a1682ac6668afab
E. Scott Daniels [Thu, 6 Feb 2020 18:05:25 +0000 (13:05 -0500)]
Fix session discconnect bug in interface to SI95
The disconnect of a session wasn't being properly recorded
and thus was preventing a reconnection attempt on the next
send attempt by the user application.
The warning about dropping messsages when the application cannot
keep up was also changed to be an error so that it is visible
at the default logging level.
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Ib07e4d0f9bf0d2b6436bb0b49be4ea37455509d3
E. Scott Daniels [Fri, 31 Jan 2020 21:10:34 +0000 (16:10 -0500)]
Ensure route table thread logging can be disabled
The messages written by the route table collector thread are
not affected by the verbose level that the user application
can set. This change allows the complete squelching of the
messages from this thread when all messages are turned off.
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Iddea13591f28a96f0cfc4630924a9fc11fadd809
E. Scott Daniels [Tue, 28 Jan 2020 21:50:27 +0000 (16:50 -0500)]
Allow user programme to set RMR verbosity level
This change centralises the writing of messages to the standard
error device which allows the user programme to have control over
the verbosity level. Introduces the new rmr_set_vlevel() function.
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I0c4b4b3af94d34b480622ec1f65a9da65cabf2b5
E. Scott Daniels [Fri, 24 Jan 2020 21:00:11 +0000 (16:00 -0500)]
Fix large message bug in SI95 data callback
The receive buffer was not being allocated correctly and in some
cases would cause a segment fault when a large buffer was received.
The fix also includes dropping a message which is larger than the
allocated message. The rmr_init() manual page has been updated to
better define the meaning of the max message length pararmeter which
is passed.
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I20eb0d7ed8ba914b380807d9b3142d51d4f9f0b6
E. Scott Daniels [Thu, 23 Jan 2020 21:20:12 +0000 (16:20 -0500)]
Correct bug in SIwait causing excessive CPU use
The select timer in SIwait was not being reset correctly
and after a few loops the timer was set such that the
thread was using 100% of a CPU.
Also eliminated the build poll list from cache as this
turned out to be slower than the original method.
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Ic606f19aaf522ff7c7146a6fc62c76ec9f8de3a9