From: idanshal <idan.shalom@intl.att.com>
Date: Sun, 19 Jul 2020 16:37:00 +0000 (+0000)
Subject: [RIC-431] Add rnibWriter UTs
X-Git-Tag: R5_RC~32
X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F14%2F4414%2F1;p=ric-plt%2Fe2mgr.git

[RIC-431] Add rnibWriter UTs

Change-Id: I8c76c6f05711ff2c47913a80883b3dff9b33ff4f
Signed-off-by: idanshal <idan.shalom@intl.att.com>
---

diff --git a/E2Manager/rNibWriter/rNibWriter_test.go b/E2Manager/rNibWriter/rNibWriter_test.go
index 75240fa..f99f69e 100644
--- a/E2Manager/rNibWriter/rNibWriter_test.go
+++ b/E2Manager/rNibWriter/rNibWriter_test.go
@@ -37,6 +37,8 @@ var namespace = "namespace"
 
 const (
 	RanName = "test"
+	PlmnId = "02f829"
+	NbId = "4a952a0a"
 )
 
 func initSdlInstanceMock(namespace string) (w RNibWriter, sdlInstanceMock *mocks.MockSdlInstance) {
@@ -144,6 +146,34 @@ func TestUpdateGnbCellsInvalidNodebInfoFailure(t *testing.T) {
 	assert.IsType(t, &common.ValidationError{}, rNibErr)
 }
 
+func TestAddNbIdentitySuccess(t *testing.T) {
+	w, sdlInstanceMock := initSdlInstanceMock(namespace)
+
+	nbIdentity :=  &entities.NbIdentity{InventoryName: RanName, GlobalNbId: &entities.GlobalNbId{PlmnId: PlmnId, NbId: NbId}}
+	nbIdData, err := proto.Marshal(nbIdentity)
+	if err != nil {
+		t.Fatalf("#rNibWriter_test.TestAddNbIdentitySuccess - Failed to marshal NodeB Identity entity. Error: %v", err)
+	}
+
+	sdlInstanceMock.On("AddMember", "ENB", []interface{}{nbIdData}).Return(nil)
+	rNibErr := w.AddNbIdentity(entities.Node_ENB,nbIdentity)
+	assert.Nil(t, rNibErr)
+}
+
+func TestAddNbIdentitySdlFailure(t *testing.T) {
+	w, sdlInstanceMock := initSdlInstanceMock(namespace)
+
+	nbIdentity :=  &entities.NbIdentity{InventoryName: RanName, GlobalNbId: &entities.GlobalNbId{PlmnId: PlmnId, NbId: NbId}}
+	nbIdData, err := proto.Marshal(nbIdentity)
+	if err != nil {
+		t.Fatalf("#rNibWriter_test.TestAddNbIdentitySdlFailure - Failed to marshal NodeB Identity entity. Error: %v", err)
+	}
+
+	sdlInstanceMock.On("AddMember", "ENB", []interface{}{nbIdData}).Return(errors.New("expected error"))
+	rNibErr := w.AddNbIdentity(entities.Node_ENB,nbIdentity)
+	assert.IsType(t, &common.InternalError{}, rNibErr)
+}
+
 func TestUpdateGnbCellsInvalidCellFailure(t *testing.T) {
 	inventoryName := "name"
 	plmnId := "02f829"