From: rajdeep11 <rajdeep.sin@samsung.com>
Date: Tue, 31 Jan 2023 08:11:45 +0000 (+0530)
Subject: minor fixes for issues reported in sonar
X-Git-Tag: 1.1.0~28
X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=commitdiff_plain;h=e5b8248620bc76d08a0e4b36269d6530d031f530;p=aiml-fw%2Fawmf%2Ftm.git

minor fixes for issues reported in sonar

Issue-Id: AIMLFW-22

Signed-off-by: rajdeep11 <rajdeep.sin@samsung.com>
Change-Id: I9476014ffba0039af1b030b7949113cafb48a9ba
---

diff --git a/tox.ini b/tox.ini
index 46a6589..cf847e0 100644
--- a/tox.ini
+++ b/tox.ini
@@ -43,7 +43,7 @@ deps=
 
 setenv = cd  = {toxinidir}/tests
 commands =
-  pip3 install {toxinidir}
+  pip3 install -e {toxinidir}
 
   git clone "https://gerrit.o-ran-sc.org/r/aiml-fw/athp/sdk/feature-store" /tmp/fssdk/
   git clone "https://gerrit.o-ran-sc.org/r/aiml-fw/athp/sdk/model-storage" /tmp/modelsdk/
diff --git a/trainingmgr/trainingmgr_main.py b/trainingmgr/trainingmgr_main.py
index 96a1925..4c2e082 100644
--- a/trainingmgr/trainingmgr_main.py
+++ b/trainingmgr/trainingmgr_main.py
@@ -30,6 +30,7 @@ from flask import Flask, request, send_file
 from flask_api import status
 import requests
 from flask_cors import cross_origin
+from werkzeug.utils import secure_filename
 from modelmetricsdk.model_metrics_sdk import ModelMetricsSdk
 from trainingmgr.common.trainingmgr_operations import data_extraction_start, training_start, data_extraction_status
 from trainingmgr.common.trainingmgr_config import TrainingMgrConfig
@@ -41,7 +42,6 @@ from trainingmgr.common.trainingmgr_util import get_one_word_status, check_train
 from trainingmgr.common.exceptions_utls import APIException,TMException
 from trainingmgr.constants.steps import Steps
 from trainingmgr.constants.states import States
-
 from trainingmgr.db.trainingmgr_ps_db import PSDB
 from trainingmgr.db.common_db_fun import get_data_extraction_in_progress_trainingjobs, \
     change_field_of_latest_version, \
@@ -624,7 +624,7 @@ def upload_pipeline(pipe_name):
 
         LOGGER.debug("Uploading received for %s", uploaded_file.filename)
         if uploaded_file.filename != '':
-            uploaded_file_path = "/tmp/" + uploaded_file.filename
+            uploaded_file_path = "/tmp/" + secure_filename(uploaded_file.filename)
             uploaded_file.save(uploaded_file_path)
             LOGGER.debug("File uploaded :%s", uploaded_file_path)
             kf_adapter_ip = TRAININGMGR_CONFIG_OBJ.kf_adapter_ip