From: vlad shkapenyuk <vshkap@research.att.com>
Date: Thu, 13 Aug 2020 18:59:54 +0000 (-0400)
Subject: Fix socket descritpor leak in http client post
X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=commitdiff_plain;h=a3f38475d1e9340f916140f4cf70221908cdff72;p=com%2Fgs-lite.git

Fix socket descritpor leak in http client post

Signed-off-by: vlad shkapenyuk <vshkap@research.att.com>
Change-Id: I567194ec3dec82a6c93ac6f98a1abddf2ec87197
---

diff --git a/src/lib/gscpaux/simple_http.cpp b/src/lib/gscpaux/simple_http.cpp
index c4f8bdd..e9bfdbf 100644
--- a/src/lib/gscpaux/simple_http.cpp
+++ b/src/lib/gscpaux/simple_http.cpp
@@ -56,6 +56,7 @@ int http_get_request(endpoint addr, gs_csp_t url, gs_uint32_t* http_code, gs_sp_
 
 	if (connect(sockfd, (sockaddr*)&servaddr, sizeof(servaddr))) {
 		fprintf(stderr, "Unable to connect to HTTP server\n");
+		close(sockfd);
 		return -1;
 	}
 
@@ -192,6 +193,7 @@ int http_post_request_hdr(endpoint addr, gs_csp_t url, gs_sp_t json_request, gs_
 
 	if (connect(sockfd, (sockaddr*)&servaddr, sizeof(servaddr))) {
 		fprintf(stderr, "Unable to connect to HTTP server\n");
+		close(sockfd);
 		return -1;
 	}