From: elinuxhenrik <henrik.b.andersson@est.tech>
Date: Mon, 9 Mar 2020 08:37:37 +0000 (+0100)
Subject: Remove code smells
X-Git-Tag: 2.0.0~136
X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=commitdiff_plain;h=9033316e83ab3927034ed0380d048648813caaab;p=nonrtric.git

Remove code smells

Change-Id: Idb8644ba89de3210ca069f8a92b0d4148b47a61f
Issue-ID: NONRTRIC-142
Signed-off-by: elinuxhenrik <henrik.b.andersson@est.tech>
---

diff --git a/policy-agent/src/main/java/org/oransc/policyagent/controllers/StatusController.java b/policy-agent/src/main/java/org/oransc/policyagent/controllers/StatusController.java
index 48d9a579..cacf64d5 100644
--- a/policy-agent/src/main/java/org/oransc/policyagent/controllers/StatusController.java
+++ b/policy-agent/src/main/java/org/oransc/policyagent/controllers/StatusController.java
@@ -40,8 +40,7 @@ public class StatusController {
             @ApiResponse(code = 200, message = "Service is living", response = String.class) //
         })
     public Mono<ResponseEntity<String>> getStatus() {
-        Mono<ResponseEntity<String>> response = Mono.just(new ResponseEntity<>("hunky dory", HttpStatus.OK));
-        return response;
+        return Mono.just(new ResponseEntity<>("hunky dory", HttpStatus.OK));
     }
 
 }
diff --git a/policy-agent/src/main/java/org/oransc/policyagent/tasks/RicSynchronizationTask.java b/policy-agent/src/main/java/org/oransc/policyagent/tasks/RicSynchronizationTask.java
index a664b26c..19036efb 100644
--- a/policy-agent/src/main/java/org/oransc/policyagent/tasks/RicSynchronizationTask.java
+++ b/policy-agent/src/main/java/org/oransc/policyagent/tasks/RicSynchronizationTask.java
@@ -137,7 +137,7 @@ public class RicSynchronizationTask {
             .doOnComplete(() -> deleteAllPoliciesInRepository(ric));
 
         Flux.concat(recoverTypes, deletePoliciesInRic) //
-            .subscribe(x -> logger.debug("Brute recover: ", x), //
+            .subscribe(x -> logger.debug("Brute recover: {}", x), //
                 throwable -> onRecoveryError(ric, throwable), //
                 () -> onSynchronizationComplete(ric));
     }