From: is005q <idan.shalom@intl.att.com>
Date: Sun, 8 Dec 2019 12:15:31 +0000 (+0200)
Subject: [RICPLT-2523] Add RnibReader GetE2TInstances  UTs
X-Git-Tag: common/v1.0.27~3
X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=commitdiff_plain;h=542ac350eb05661c8b895eb92332f785c70211af;p=ric-plt%2Fnodeb-rnib.git

[RICPLT-2523] Add RnibReader GetE2TInstances  UTs

Change-Id: I5da65bed78bb4d798fa84ada5968bdc9499ef22e
Signed-off-by: is005q <idan.shalom@intl.att.com>
---

diff --git a/reader/rNibReader_test.go b/reader/rNibReader_test.go
index 8f8bf38..32e3503 100644
--- a/reader/rNibReader_test.go
+++ b/reader/rNibReader_test.go
@@ -21,6 +21,7 @@ package reader
 
 import (
 	"encoding/json"
+	"fmt"
 	"gerrit.o-ran-sc.org/r/ric-plt/nodeb-rnib.git/common"
 	"gerrit.o-ran-sc.org/r/ric-plt/nodeb-rnib.git/entities"
 	"github.com/golang/protobuf/proto"
@@ -30,8 +31,6 @@ import (
 	"time"
 )
 
-var namespace = "namespace"
-
 func initSdlInstanceMock() (w RNibReader, sdlInstanceMock *MockSdlInstance) {
 	sdlInstanceMock = new(MockSdlInstance)
 	w = GetRNibReader(sdlInstanceMock)
@@ -1120,6 +1119,52 @@ func TestGetE2TInstancesSuccess(t *testing.T) {
 	assert.Equal(t, []*entities.E2TInstance{e2tInstance1, e2tInstance2}, res)
 }
 
+func TestGetE2TInstancesUnmarhalPartialSuccess(t *testing.T) {
+	address := "10.10.2.15:9800"
+	address2 := "10.10.2.16:9800"
+	redisKey, _ := common.ValidateAndBuildE2TInstanceKey(address)
+	redisKey2, _ := common.ValidateAndBuildE2TInstanceKey(address2)
+
+	w, sdlInstanceMock := initSdlInstanceMock()
+
+	e2tInstance1 := generateE2tInstance(address)
+	data1, _ := json.Marshal(e2tInstance1)
+
+	var e error
+	ret := map[string]interface{}{redisKey: string(data1), redisKey2: "abc"}
+	sdlInstanceMock.On("Get", []string{redisKey, redisKey2}).Return(ret, e)
+
+	res, err := w.GetE2TInstances([]string{address, address2})
+	assert.Nil(t, err)
+	assert.Equal(t, []*entities.E2TInstance{e2tInstance1}, res)
+}
+
+func TestGetE2TInstancesSdlFailure(t *testing.T) {
+	address := "10.10.2.15:9800"
+	address2 := "10.10.2.16:9800"
+	redisKey, _ := common.ValidateAndBuildE2TInstanceKey(address)
+	redisKey2, _ := common.ValidateAndBuildE2TInstanceKey(address2)
+
+	w, sdlInstanceMock := initSdlInstanceMock()
+
+	sdlInstanceMock.On("Get", []string{redisKey, redisKey2}).Return(map[string]interface{}{}, fmt.Errorf(""))
+	_, err := w.GetE2TInstances([]string{address, address2})
+	assert.IsType(t, &common.InternalError{}, err)
+}
+
+func TestGetE2TInstancesEmptyData(t *testing.T) {
+	address := "10.10.2.15:9800"
+	address2 := "10.10.2.16:9800"
+	redisKey, _ := common.ValidateAndBuildE2TInstanceKey(address)
+	redisKey2, _ := common.ValidateAndBuildE2TInstanceKey(address2)
+
+	w, sdlInstanceMock := initSdlInstanceMock()
+
+	sdlInstanceMock.On("Get", []string{redisKey, redisKey2}).Return(map[string]interface{}{}, nil)
+	_, err := w.GetE2TInstances([]string{address, address2})
+	assert.IsType(t, &common.ResourceNotFoundError{}, err)
+}
+
 func TestGetE2TInfoListSdlError(t *testing.T) {
 	w, sdlInstanceMock := initSdlInstanceMock()
 
@@ -1283,3 +1328,11 @@ func TestGetE2TInfoListSdlError(t *testing.T) {
 //	assert.NotNil(t, ranLoadInformation)
 //	fmt.Printf("#rNibReader_test.TestGetRanLoadInformationInteg - GNB ID: %s\n", ranLoadInformation)
 //}
+
+//func TestGetE2TInstancesInteg(t *testing.T) {
+//	db := sdlgo.NewDatabase()
+//	sdl := sdlgo.NewSdlInstance("e2Manager", db)
+//	rnibReader := GetRNibReader(sdl)
+//	e2tInstances, _ := rnibReader.GetE2TInstances([]string{"e2t.att.com:38000","whatever"})
+//	assert.Len(t, e2tInstances, 1)
+//}