import (
"e2mgr/configuration"
- "e2mgr/e2pdus"
"e2mgr/logger"
"e2mgr/managers"
"e2mgr/mocks"
"fmt"
"gerrit.o-ran-sc.org/r/ric-plt/nodeb-rnib.git/common"
"gerrit.o-ran-sc.org/r/ric-plt/nodeb-rnib.git/entities"
- "github.com/stretchr/testify/mock"
"testing"
)
-func initRanLostConnectionTest(t *testing.T) (*logger.Logger, E2TermInitNotificationHandler, *mocks.RnibReaderMock, *mocks.RnibWriterMock, *mocks.RmrMessengerMock) {
+func initRanLostConnectionTest(t *testing.T) (*logger.Logger, E2TermInitNotificationHandler, *mocks.RnibReaderMock, *mocks.RnibWriterMock, *mocks.RmrMessengerMock, *mocks.E2TInstancesManagerMock) {
logger := initLog(t)
config := &configuration.Configuration{RnibRetryIntervalMs: 10, MaxRnibConnectionAttempts: 3}
rnibDataService := services.NewRnibDataService(logger, config, readerMock, writerMock)
ranSetupManager := managers.NewRanSetupManager(logger, rmrSender, rnibDataService)
- ranReconnectionManager := managers.NewRanReconnectionManager(logger, configuration.ParseConfiguration(), rnibDataService, ranSetupManager)
- handler := NewE2TermInitNotificationHandler(logger, ranReconnectionManager, rnibDataService)
- return logger, handler, readerMock, writerMock, rmrMessengerMock
-}
-
-func TestE2TerminInitHandlerSuccessOneRan(t *testing.T) {
- _, handler, readerMock, writerMock, rmrMessengerMock := initRanLostConnectionTest(t)
- var rnibErr error
-
- ids := []*entities.NbIdentity{{InventoryName: "test1"}}
- readerMock.On("GetListNodebIds").Return(ids, rnibErr)
-
- var initialNodeb = &entities.NodebInfo{ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST}
- readerMock.On("GetNodeb", ids[0].InventoryName).Return(initialNodeb, rnibErr)
-
- var argNodeb = &entities.NodebInfo{ConnectionStatus: entities.ConnectionStatus_CONNECTING, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 1}
- writerMock.On("UpdateNodebInfo", argNodeb).Return(rnibErr)
-
- payload := e2pdus.PackedX2setupRequest
- xaction := []byte(ids[0].InventoryName)
- msg := rmrCgo.NewMBuf(rmrCgo.RIC_X2_SETUP_REQ, len(payload), ids[0].InventoryName, &payload, &xaction)
-
- rmrMessengerMock.On("SendMsg", mock.Anything).Return(msg, nil)
-
- handler.Handle(nil)
-
- writerMock.AssertNumberOfCalls(t, "UpdateNodebInfo", 1)
- rmrMessengerMock.AssertNumberOfCalls(t, "SendMsg", 1)
-}
-
-func TestE2TerminInitHandlerSuccessTwoRans(t *testing.T) {
- _, handler, readerMock, writerMock, rmrMessengerMock := initRanLostConnectionTest(t)
- var rnibErr error
-
- ids := []*entities.NbIdentity{{InventoryName: "test1"}, {InventoryName: "test2"}}
- readerMock.On("GetListNodebIds").Return(ids, rnibErr)
-
- var initialNodeb0 = &entities.NodebInfo{ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST}
- var initialNodeb1 = &entities.NodebInfo{ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST}
- readerMock.On("GetNodeb", ids[0].InventoryName).Return(initialNodeb0, rnibErr)
- readerMock.On("GetNodeb", ids[1].InventoryName).Return(initialNodeb1, rnibErr)
-
- var argNodeb = &entities.NodebInfo{ConnectionStatus: entities.ConnectionStatus_CONNECTING, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 1}
- writerMock.On("UpdateNodebInfo", argNodeb).Return(rnibErr)
-
- payload := e2pdus.PackedX2setupRequest
- xaction := []byte(ids[0].InventoryName)
- msg := rmrCgo.NewMBuf(rmrCgo.RIC_X2_SETUP_REQ, len(payload), ids[0].InventoryName, &payload, &xaction)
-
- rmrMessengerMock.On("SendMsg", mock.Anything).Return(msg, nil)
-
- handler.Handle(nil)
-
- writerMock.AssertNumberOfCalls(t, "UpdateNodebInfo", 2)
- rmrMessengerMock.AssertNumberOfCalls(t, "SendMsg", 2)
-}
-
-func TestE2TerminInitHandlerSuccessThreeRansFirstRmrFailure(t *testing.T) {
- log, handler, readerMock, writerMock, rmrMessengerMock := initRanLostConnectionTest(t)
- var rnibErr error
-
- ids := []*entities.NbIdentity{{InventoryName: "test1"}, {InventoryName: "test2"}, {InventoryName: "test3"}}
- readerMock.On("GetListNodebIds").Return(ids, rnibErr)
-
- var initialNodeb0 = &entities.NodebInfo{RanName: ids[0].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST}
- var initialNodeb1 = &entities.NodebInfo{RanName: ids[1].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST}
- var initialNodeb2 = &entities.NodebInfo{RanName: ids[2].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST}
- readerMock.On("GetNodeb", ids[0].InventoryName).Return(initialNodeb0, rnibErr)
- readerMock.On("GetNodeb", ids[1].InventoryName).Return(initialNodeb1, rnibErr)
- readerMock.On("GetNodeb", ids[2].InventoryName).Return(initialNodeb2, rnibErr)
-
- var argNodeb0 = &entities.NodebInfo{RanName: ids[0].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTING, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 1}
- var argNodeb0Fail = &entities.NodebInfo{RanName: ids[0].InventoryName, ConnectionStatus: entities.ConnectionStatus_DISCONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 0}
- writerMock.On("UpdateNodebInfo", argNodeb0).Return(rnibErr)
- writerMock.On("UpdateNodebInfo", argNodeb0Fail).Return(rnibErr)
-
- payload := models.NewE2RequestMessage(ids[0].InventoryName /*tid*/, "", 0, ids[0].InventoryName, e2pdus.PackedX2setupRequest).GetMessageAsBytes(log)
- xaction := []byte(ids[0].InventoryName)
- msg0 := rmrCgo.NewMBuf(rmrCgo.RIC_X2_SETUP_REQ, len(payload), ids[0].InventoryName, &payload, &xaction)
-
- // Cannot use Mock because request MBuf contains pointers
- //payload =models.NewE2RequestMessage(ids[1].InventoryName /*tid*/, "", 0,ids[1].InventoryName, e2pdus.PackedX2setupRequest).GetMessageAsBytes(log)
- //xaction = []byte(ids[1].InventoryName)
- //msg1 := rmrCgo.NewMBuf(rmrCgo.RIC_X2_SETUP_REQ, len(payload), ids[1].InventoryName, &payload, &xaction)
-
- rmrMessengerMock.On("SendMsg", mock.Anything).Return(msg0, fmt.Errorf("RMR Error"))
- handler.Handle(nil)
-
- //test1 (before send +1, after failure +1), test2 (0) test3 (0)
- writerMock.AssertNumberOfCalls(t, "UpdateNodebInfo", 2)
- //test1 failure (+1), test2 (0). test3 (0)
- rmrMessengerMock.AssertNumberOfCalls(t, "SendMsg", 1)
+ e2tInstancesManagerMock := &mocks.E2TInstancesManagerMock{}
+ ranReconnectionManager := managers.NewRanReconnectionManager(logger, configuration.ParseConfiguration(), rnibDataService, ranSetupManager, e2tInstancesManagerMock)
+ handler := NewE2TermInitNotificationHandler(logger, ranReconnectionManager, rnibDataService, e2tInstancesManagerMock)
+ return logger, handler, readerMock, writerMock, rmrMessengerMock, e2tInstancesManagerMock
}
-func TestE2TerminInitHandlerSuccessThreeRansSecondNotFoundFailure(t *testing.T) {
- log, handler, readerMock, writerMock, rmrMessengerMock := initRanLostConnectionTest(t)
- var rnibErr error
-
- ids := []*entities.NbIdentity{{InventoryName: "test1"}, {InventoryName: "test2"}, {InventoryName: "test3"}}
- readerMock.On("GetListNodebIds").Return(ids, rnibErr)
-
- var initialNodeb0 = &entities.NodebInfo{RanName: ids[0].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST}
- var initialNodeb1 = &entities.NodebInfo{RanName: ids[1].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST}
- var initialNodeb2 = &entities.NodebInfo{RanName: ids[2].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST}
- readerMock.On("GetNodeb", ids[0].InventoryName).Return(initialNodeb0, rnibErr)
- readerMock.On("GetNodeb", ids[1].InventoryName).Return(initialNodeb1, common.NewResourceNotFoundError("not found"))
- readerMock.On("GetNodeb", ids[2].InventoryName).Return(initialNodeb2, rnibErr)
-
- var argNodeb0 = &entities.NodebInfo{RanName: ids[0].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTING, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 1}
- var argNodeb0Success = &entities.NodebInfo{RanName: ids[0].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 1}
- writerMock.On("UpdateNodebInfo", argNodeb0).Return(rnibErr)
- writerMock.On("UpdateNodebInfo", argNodeb0Success).Return(rnibErr)
-
- var argNodeb2 = &entities.NodebInfo{RanName: ids[2].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTING, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 1}
- var argNodeb2Success = &entities.NodebInfo{RanName: ids[2].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 1}
- writerMock.On("UpdateNodebInfo", argNodeb2).Return(rnibErr)
- writerMock.On("UpdateNodebInfo", argNodeb2Success).Return(rnibErr)
-
- payload := models.NewE2RequestMessage(ids[0].InventoryName /*tid*/, "", 0, ids[0].InventoryName, e2pdus.PackedX2setupRequest).GetMessageAsBytes(log)
- xaction := []byte(ids[0].InventoryName)
- msg0 := rmrCgo.NewMBuf(rmrCgo.RIC_X2_SETUP_REQ, len(payload), ids[0].InventoryName, &payload, &xaction)
-
- // Cannot use Mock because request MBuf contains pointers
- //payload =models.NewE2RequestMessage(ids[1].InventoryName /*tid*/, "", 0,ids[1].InventoryName, e2pdus.PackedX2setupRequest).GetMessageAsBytes(log)
- //xaction = []byte(ids[1].InventoryName)
- //msg1 := rmrCgo.NewMBuf(rmrCgo.RIC_X2_SETUP_REQ, len(payload), ids[1].InventoryName, &payload, &xaction)
-
- rmrMessengerMock.On("SendMsg", mock.Anything).Return(msg0, nil)
-
- handler.Handle(nil)
-
- readerMock.AssertNumberOfCalls(t, "GetNodeb", 3)
- //test1 (+1), test2 failure (0) test3 (+1)
- writerMock.AssertNumberOfCalls(t, "UpdateNodebInfo", 2)
- //test1 success (+1), test2 (0). test3 (+1)
- rmrMessengerMock.AssertNumberOfCalls(t, "SendMsg", 2)
+func TestE2TermInitGetE2TInstanceFailure(t *testing.T) {
+ _, handler, _, _, _, e2tInstancesManagerMock := initRanLostConnectionTest(t)
+ e2tInstanceAddress := "10.0.2.15"
+ var e2tInstance *entities.E2TInstance
+ e2tInstancesManagerMock.On("GetE2TInstance", e2tInstanceAddress).Return(e2tInstance, common.NewInternalError(fmt.Errorf("internal error")))
+ notificationRequest := &models.NotificationRequest{RanName: RanName, Payload: []byte(e2tInstanceAddress)}
+ handler.Handle(notificationRequest)
+ e2tInstancesManagerMock.AssertNotCalled(t, "AddE2TInstance")
}
-func TestE2TerminInitHandlerSuccessThreeRansSecondRnibInternalErrorFailure(t *testing.T) {
- log, handler, readerMock, writerMock, rmrMessengerMock := initRanLostConnectionTest(t)
- var rnibErr error
-
- ids := []*entities.NbIdentity{{InventoryName: "test1"}, {InventoryName: "test2"}, {InventoryName: "test3"}}
- readerMock.On("GetListNodebIds").Return(ids, rnibErr)
-
- var initialNodeb0 = &entities.NodebInfo{RanName: ids[0].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST}
- var initialNodeb1 = &entities.NodebInfo{RanName: ids[1].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST}
- var initialNodeb2 = &entities.NodebInfo{RanName: ids[2].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST}
- readerMock.On("GetNodeb", ids[0].InventoryName).Return(initialNodeb0, rnibErr)
- readerMock.On("GetNodeb", ids[1].InventoryName).Return(initialNodeb1, common.NewInternalError(fmt.Errorf("internal error")))
- readerMock.On("GetNodeb", ids[2].InventoryName).Return(initialNodeb2, rnibErr)
-
- var argNodeb0 = &entities.NodebInfo{RanName: ids[0].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTING, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 1}
- var argNodeb0Success = &entities.NodebInfo{RanName: ids[0].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 1}
- writerMock.On("UpdateNodebInfo", argNodeb0).Return(rnibErr)
- writerMock.On("UpdateNodebInfo", argNodeb0Success).Return(rnibErr)
-
- var argNodeb2 = &entities.NodebInfo{RanName: ids[2].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTING, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 1}
- var argNodeb2Success = &entities.NodebInfo{RanName: ids[2].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 1}
- writerMock.On("UpdateNodebInfo", argNodeb2).Return(rnibErr)
- writerMock.On("UpdateNodebInfo", argNodeb2Success).Return(rnibErr)
-
- payload := models.NewE2RequestMessage(ids[0].InventoryName /*tid*/, "", 0, ids[0].InventoryName, e2pdus.PackedX2setupRequest).GetMessageAsBytes(log)
- xaction := []byte(ids[0].InventoryName)
- msg0 := rmrCgo.NewMBuf(rmrCgo.RIC_X2_SETUP_REQ, len(payload), ids[0].InventoryName, &payload, &xaction)
-
- // Cannot use Mock because request MBuf contains pointers
- //payload =models.NewE2RequestMessage(ids[1].InventoryName /*tid*/, "", 0,ids[1].InventoryName, e2pdus.PackedX2setupRequest).GetMessageAsBytes(log)
- //xaction = []byte(ids[1].InventoryName)
- //msg1 := rmrCgo.NewMBuf(rmrCgo.RIC_X2_SETUP_REQ, len(payload), ids[1].InventoryName, &payload, &xaction)
-
- rmrMessengerMock.On("SendMsg", mock.Anything).Return(msg0, nil)
-
- handler.Handle(nil)
-
- readerMock.AssertNumberOfCalls(t, "GetNodeb", 2)
- //test1 (+1), test2 failure (0) test3 (0)
- writerMock.AssertNumberOfCalls(t, "UpdateNodebInfo", 1)
- //test1 success (+1), test2 (0). test3 (+1)
- rmrMessengerMock.AssertNumberOfCalls(t, "SendMsg", 1)
+func TestE2TermInitNewE2TInstance(t *testing.T) {
+ _, handler, _, _, _, e2tInstancesManagerMock := initRanLostConnectionTest(t)
+ e2tInstanceAddress := "10.0.2.15"
+ var e2tInstance *entities.E2TInstance
+ e2tInstancesManagerMock.On("GetE2TInstance", e2tInstanceAddress).Return(e2tInstance, common.NewResourceNotFoundError("not found"))
+ e2tInstance = entities.NewE2TInstance(e2tInstanceAddress)
+ e2tInstancesManagerMock.On("AddE2TInstance", e2tInstanceAddress).Return(nil)
+ notificationRequest := &models.NotificationRequest{RanName: RanName, Payload: []byte(e2tInstanceAddress)}
+ handler.Handle(notificationRequest)
+ e2tInstancesManagerMock.AssertCalled(t, "AddE2TInstance", e2tInstanceAddress)
}
-func TestE2TerminInitHandlerSuccessZeroRans(t *testing.T) {
- _, handler, readerMock, writerMock, rmrMessengerMock := initRanLostConnectionTest(t)
- var rnibErr error
-
- readerMock.On("GetListNodebIds").Return([]*entities.NbIdentity{}, rnibErr)
-
- handler.Handle(nil)
-
- writerMock.AssertNumberOfCalls(t, "UpdateNodebInfo", 0)
- rmrMessengerMock.AssertNumberOfCalls(t, "SendMsg", 0)
+func TestE2TermInitExistingE2TInstanceNoAssociatedRans(t *testing.T) {
+ _, handler, _, _, _, e2tInstancesManagerMock := initRanLostConnectionTest(t)
+ e2tInstanceAddress := "10.0.2.15"
+ e2tInstance := entities.NewE2TInstance(e2tInstanceAddress)
+ e2tInstancesManagerMock.On("GetE2TInstance", e2tInstanceAddress).Return(e2tInstance, nil)
+ notificationRequest := &models.NotificationRequest{RanName: RanName, Payload: []byte(e2tInstanceAddress)}
+ handler.Handle(notificationRequest)
+ e2tInstancesManagerMock.AssertCalled(t, "GetE2TInstance", e2tInstanceAddress)
}
-func TestE2TerminInitHandlerFailureGetListNodebIds(t *testing.T) {
- _, handler, readerMock, writerMock, rmrMessengerMock := initRanLostConnectionTest(t)
-
- readerMock.On("GetListNodebIds").Return([]*entities.NbIdentity{}, common.NewInternalError(fmt.Errorf("internal error")))
-
- handler.Handle(nil)
-
- writerMock.AssertNumberOfCalls(t, "UpdateNodebInfo", 0)
- rmrMessengerMock.AssertNumberOfCalls(t, "SendMsg", 0)
-}
+//func TestE2TerminInitHandlerSuccessOneRan(t *testing.T) {
+// _, handler, readerMock, writerMock, rmrMessengerMock, _ := initRanLostConnectionTest(t)
+// var rnibErr error
+//
+// ids := []*entities.NbIdentity{{InventoryName: "test1"}}
+// readerMock.On("GetListNodebIds").Return(ids, rnibErr)
+//
+// var initialNodeb = &entities.NodebInfo{ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST}
+// readerMock.On("GetNodeb", ids[0].InventoryName).Return(initialNodeb, rnibErr)
+//
+// var argNodeb = &entities.NodebInfo{ConnectionStatus: entities.ConnectionStatus_CONNECTING, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 1}
+// writerMock.On("UpdateNodebInfo", argNodeb).Return(rnibErr)
+//
+// payload := e2pdus.PackedX2setupRequest
+// xaction := []byte(ids[0].InventoryName)
+// msg := rmrCgo.NewMBuf(rmrCgo.RIC_X2_SETUP_REQ, len(payload), ids[0].InventoryName, &payload, &xaction)
+//
+// rmrMessengerMock.On("SendMsg", mock.Anything).Return(msg, nil)
+//
+// handler.Handle(nil)
+//
+// writerMock.AssertNumberOfCalls(t, "UpdateNodebInfo", 1)
+// rmrMessengerMock.AssertNumberOfCalls(t, "SendMsg", 1)
+//}
+//
+//func TestE2TerminInitHandlerSuccessTwoRans(t *testing.T) {
+// _, handler, readerMock, writerMock, rmrMessengerMock, _ := initRanLostConnectionTest(t)
+// var rnibErr error
+//
+// ids := []*entities.NbIdentity{{InventoryName: "test1"}, {InventoryName: "test2"}}
+// readerMock.On("GetListNodebIds").Return(ids, rnibErr)
+//
+// var initialNodeb0 = &entities.NodebInfo{ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST}
+// var initialNodeb1 = &entities.NodebInfo{ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST}
+// readerMock.On("GetNodeb", ids[0].InventoryName).Return(initialNodeb0, rnibErr)
+// readerMock.On("GetNodeb", ids[1].InventoryName).Return(initialNodeb1, rnibErr)
+//
+// var argNodeb = &entities.NodebInfo{ConnectionStatus: entities.ConnectionStatus_CONNECTING, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 1}
+// writerMock.On("UpdateNodebInfo", argNodeb).Return(rnibErr)
+//
+// payload := e2pdus.PackedX2setupRequest
+// xaction := []byte(ids[0].InventoryName)
+// msg := rmrCgo.NewMBuf(rmrCgo.RIC_X2_SETUP_REQ, len(payload), ids[0].InventoryName, &payload, &xaction)
+//
+// rmrMessengerMock.On("SendMsg", mock.Anything).Return(msg, nil)
+//
+// handler.Handle(nil)
+//
+// writerMock.AssertNumberOfCalls(t, "UpdateNodebInfo", 2)
+// rmrMessengerMock.AssertNumberOfCalls(t, "SendMsg", 2)
+//}
+//
+//func TestE2TerminInitHandlerSuccessThreeRansFirstRmrFailure(t *testing.T) {
+// log, handler, readerMock, writerMock, rmrMessengerMock, _ := initRanLostConnectionTest(t)
+// var rnibErr error
+//
+// ids := []*entities.NbIdentity{{InventoryName: "test1"}, {InventoryName: "test2"}, {InventoryName: "test3"}}
+// readerMock.On("GetListNodebIds").Return(ids, rnibErr)
+//
+// var initialNodeb0 = &entities.NodebInfo{RanName: ids[0].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST}
+// var initialNodeb1 = &entities.NodebInfo{RanName: ids[1].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST}
+// var initialNodeb2 = &entities.NodebInfo{RanName: ids[2].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST}
+// readerMock.On("GetNodeb", ids[0].InventoryName).Return(initialNodeb0, rnibErr)
+// readerMock.On("GetNodeb", ids[1].InventoryName).Return(initialNodeb1, rnibErr)
+// readerMock.On("GetNodeb", ids[2].InventoryName).Return(initialNodeb2, rnibErr)
+//
+// var argNodeb0 = &entities.NodebInfo{RanName: ids[0].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTING, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 1}
+// var argNodeb0Fail = &entities.NodebInfo{RanName: ids[0].InventoryName, ConnectionStatus: entities.ConnectionStatus_DISCONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 0}
+// writerMock.On("UpdateNodebInfo", argNodeb0).Return(rnibErr)
+// writerMock.On("UpdateNodebInfo", argNodeb0Fail).Return(rnibErr)
+//
+// payload := models.NewE2RequestMessage(ids[0].InventoryName /*tid*/, "", 0, ids[0].InventoryName, e2pdus.PackedX2setupRequest).GetMessageAsBytes(log)
+// xaction := []byte(ids[0].InventoryName)
+// msg0 := rmrCgo.NewMBuf(rmrCgo.RIC_X2_SETUP_REQ, len(payload), ids[0].InventoryName, &payload, &xaction)
+//
+// // Cannot use Mock because request MBuf contains pointers
+// //payload =models.NewE2RequestMessage(ids[1].InventoryName /*tid*/, "", 0,ids[1].InventoryName, e2pdus.PackedX2setupRequest).GetMessageAsBytes(log)
+// //xaction = []byte(ids[1].InventoryName)
+// //msg1 := rmrCgo.NewMBuf(rmrCgo.RIC_X2_SETUP_REQ, len(payload), ids[1].InventoryName, &payload, &xaction)
+//
+// rmrMessengerMock.On("SendMsg", mock.Anything).Return(msg0, fmt.Errorf("RMR Error"))
+//
+// handler.Handle(nil)
+//
+// //test1 (before send +1, after failure +1), test2 (0) test3 (0)
+// writerMock.AssertNumberOfCalls(t, "UpdateNodebInfo", 2)
+// //test1 failure (+1), test2 (0). test3 (0)
+// rmrMessengerMock.AssertNumberOfCalls(t, "SendMsg", 1)
+//}
+//
+//func TestE2TerminInitHandlerSuccessThreeRansSecondNotFoundFailure(t *testing.T) {
+// log, handler, readerMock, writerMock, rmrMessengerMock, _ := initRanLostConnectionTest(t)
+// var rnibErr error
+//
+// ids := []*entities.NbIdentity{{InventoryName: "test1"}, {InventoryName: "test2"}, {InventoryName: "test3"}}
+// readerMock.On("GetListNodebIds").Return(ids, rnibErr)
+//
+// var initialNodeb0 = &entities.NodebInfo{RanName: ids[0].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST}
+// var initialNodeb1 = &entities.NodebInfo{RanName: ids[1].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST}
+// var initialNodeb2 = &entities.NodebInfo{RanName: ids[2].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST}
+// readerMock.On("GetNodeb", ids[0].InventoryName).Return(initialNodeb0, rnibErr)
+// readerMock.On("GetNodeb", ids[1].InventoryName).Return(initialNodeb1, common.NewResourceNotFoundError("not found"))
+// readerMock.On("GetNodeb", ids[2].InventoryName).Return(initialNodeb2, rnibErr)
+//
+// var argNodeb0 = &entities.NodebInfo{RanName: ids[0].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTING, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 1}
+// var argNodeb0Success = &entities.NodebInfo{RanName: ids[0].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 1}
+// writerMock.On("UpdateNodebInfo", argNodeb0).Return(rnibErr)
+// writerMock.On("UpdateNodebInfo", argNodeb0Success).Return(rnibErr)
+//
+// var argNodeb2 = &entities.NodebInfo{RanName: ids[2].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTING, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 1}
+// var argNodeb2Success = &entities.NodebInfo{RanName: ids[2].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 1}
+// writerMock.On("UpdateNodebInfo", argNodeb2).Return(rnibErr)
+// writerMock.On("UpdateNodebInfo", argNodeb2Success).Return(rnibErr)
+//
+// payload := models.NewE2RequestMessage(ids[0].InventoryName /*tid*/, "", 0, ids[0].InventoryName, e2pdus.PackedX2setupRequest).GetMessageAsBytes(log)
+// xaction := []byte(ids[0].InventoryName)
+// msg0 := rmrCgo.NewMBuf(rmrCgo.RIC_X2_SETUP_REQ, len(payload), ids[0].InventoryName, &payload, &xaction)
+//
+// // Cannot use Mock because request MBuf contains pointers
+// //payload =models.NewE2RequestMessage(ids[1].InventoryName /*tid*/, "", 0,ids[1].InventoryName, e2pdus.PackedX2setupRequest).GetMessageAsBytes(log)
+// //xaction = []byte(ids[1].InventoryName)
+// //msg1 := rmrCgo.NewMBuf(rmrCgo.RIC_X2_SETUP_REQ, len(payload), ids[1].InventoryName, &payload, &xaction)
+//
+// rmrMessengerMock.On("SendMsg", mock.Anything).Return(msg0, nil)
+//
+// handler.Handle(nil)
+//
+// readerMock.AssertNumberOfCalls(t, "GetNodeb", 3)
+// //test1 (+1), test2 failure (0) test3 (+1)
+// writerMock.AssertNumberOfCalls(t, "UpdateNodebInfo", 2)
+// //test1 success (+1), test2 (0). test3 (+1)
+// rmrMessengerMock.AssertNumberOfCalls(t, "SendMsg", 2)
+//}
+//
+//func TestE2TerminInitHandlerSuccessThreeRansSecondRnibInternalErrorFailure(t *testing.T) {
+// log, handler, readerMock, writerMock, rmrMessengerMock, _ := initRanLostConnectionTest(t)
+// var rnibErr error
+//
+// ids := []*entities.NbIdentity{{InventoryName: "test1"}, {InventoryName: "test2"}, {InventoryName: "test3"}}
+// readerMock.On("GetListNodebIds").Return(ids, rnibErr)
+//
+// var initialNodeb0 = &entities.NodebInfo{RanName: ids[0].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST}
+// var initialNodeb1 = &entities.NodebInfo{RanName: ids[1].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST}
+// var initialNodeb2 = &entities.NodebInfo{RanName: ids[2].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST}
+// readerMock.On("GetNodeb", ids[0].InventoryName).Return(initialNodeb0, rnibErr)
+// readerMock.On("GetNodeb", ids[1].InventoryName).Return(initialNodeb1, common.NewInternalError(fmt.Errorf("internal error")))
+// readerMock.On("GetNodeb", ids[2].InventoryName).Return(initialNodeb2, rnibErr)
+//
+// var argNodeb0 = &entities.NodebInfo{RanName: ids[0].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTING, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 1}
+// var argNodeb0Success = &entities.NodebInfo{RanName: ids[0].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 1}
+// writerMock.On("UpdateNodebInfo", argNodeb0).Return(rnibErr)
+// writerMock.On("UpdateNodebInfo", argNodeb0Success).Return(rnibErr)
+//
+// var argNodeb2 = &entities.NodebInfo{RanName: ids[2].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTING, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 1}
+// var argNodeb2Success = &entities.NodebInfo{RanName: ids[2].InventoryName, ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 1}
+// writerMock.On("UpdateNodebInfo", argNodeb2).Return(rnibErr)
+// writerMock.On("UpdateNodebInfo", argNodeb2Success).Return(rnibErr)
+//
+// payload := models.NewE2RequestMessage(ids[0].InventoryName /*tid*/, "", 0, ids[0].InventoryName, e2pdus.PackedX2setupRequest).GetMessageAsBytes(log)
+// xaction := []byte(ids[0].InventoryName)
+// msg0 := rmrCgo.NewMBuf(rmrCgo.RIC_X2_SETUP_REQ, len(payload), ids[0].InventoryName, &payload, &xaction)
+//
+// // Cannot use Mock because request MBuf contains pointers
+// //payload =models.NewE2RequestMessage(ids[1].InventoryName /*tid*/, "", 0,ids[1].InventoryName, e2pdus.PackedX2setupRequest).GetMessageAsBytes(log)
+// //xaction = []byte(ids[1].InventoryName)
+// //msg1 := rmrCgo.NewMBuf(rmrCgo.RIC_X2_SETUP_REQ, len(payload), ids[1].InventoryName, &payload, &xaction)
+//
+// rmrMessengerMock.On("SendMsg", mock.Anything).Return(msg0, nil)
+//
+// handler.Handle(nil)
+//
+// readerMock.AssertNumberOfCalls(t, "GetNodeb", 2)
+// //test1 (+1), test2 failure (0) test3 (0)
+// writerMock.AssertNumberOfCalls(t, "UpdateNodebInfo", 1)
+// //test1 success (+1), test2 (0). test3 (+1)
+// rmrMessengerMock.AssertNumberOfCalls(t, "SendMsg", 1)
+//}
+//
+//func TestE2TerminInitHandlerSuccessZeroRans(t *testing.T) {
+// _, handler, readerMock, writerMock, rmrMessengerMock, _ := initRanLostConnectionTest(t)
+// var rnibErr error
+//
+// readerMock.On("GetListNodebIds").Return([]*entities.NbIdentity{}, rnibErr)
+//
+// handler.Handle(nil)
+//
+// writerMock.AssertNumberOfCalls(t, "UpdateNodebInfo", 0)
+// rmrMessengerMock.AssertNumberOfCalls(t, "SendMsg", 0)
+//}
+//
+//func TestE2TerminInitHandlerFailureGetListNodebIds(t *testing.T) {
+// _, handler, readerMock, writerMock, rmrMessengerMock, _ := initRanLostConnectionTest(t)
+//
+// readerMock.On("GetListNodebIds").Return([]*entities.NbIdentity{}, common.NewInternalError(fmt.Errorf("internal error")))
+//
+// handler.Handle(nil)
+//
+// writerMock.AssertNumberOfCalls(t, "UpdateNodebInfo", 0)
+// rmrMessengerMock.AssertNumberOfCalls(t, "SendMsg", 0)
+//}
// TODO: extract to test_utils
func initRmrSender(rmrMessengerMock *mocks.RmrMessengerMock, log *logger.Logger) *rmrsender.RmrSender {
"testing"
)
-func initRanLostConnectionTest(t *testing.T) (*logger.Logger, *mocks.RmrMessengerMock, *mocks.RnibReaderMock, *mocks.RnibWriterMock, *RanReconnectionManager) {
+func initRanLostConnectionTest(t *testing.T) (*logger.Logger, *mocks.RmrMessengerMock, *mocks.RnibReaderMock, *mocks.RnibWriterMock, *RanReconnectionManager, *mocks.E2TInstancesManagerMock) {
logger, err := logger.InitLogger(logger.DebugLevel)
if err != nil {
t.Errorf("#... - failed to initialize logger, error: %s", err)
writerMock := &mocks.RnibWriterMock{}
rnibDataService := services.NewRnibDataService(logger, config, readerMock, writerMock)
+ e2tInstancesManagerMock := &mocks.E2TInstancesManagerMock{}
ranSetupManager := NewRanSetupManager(logger, rmrSender, rnibDataService)
- ranReconnectionManager := NewRanReconnectionManager(logger, configuration.ParseConfiguration(), rnibDataService, ranSetupManager)
- return logger, rmrMessengerMock, readerMock, writerMock, ranReconnectionManager
+ ranReconnectionManager := NewRanReconnectionManager(logger, configuration.ParseConfiguration(), rnibDataService, ranSetupManager, e2tInstancesManagerMock)
+ return logger, rmrMessengerMock, readerMock, writerMock, ranReconnectionManager, e2tInstancesManagerMock
}
func TestRanReconnectionGetNodebFailure(t *testing.T) {
- _, _, readerMock, writerMock, ranReconnectionManager := initRanLostConnectionTest(t)
+ _, _, readerMock, writerMock, ranReconnectionManager, _ := initRanLostConnectionTest(t)
ranName := "test"
var nodebInfo *entities.NodebInfo
readerMock.On("GetNodeb", ranName).Return(nodebInfo, common.NewInternalError(errors.New("Error")))
}
func TestShutdownRanReconnection(t *testing.T) {
- _, _, readerMock, writerMock, ranReconnectionManager := initRanLostConnectionTest(t)
+ _, _, readerMock, writerMock, ranReconnectionManager, _ := initRanLostConnectionTest(t)
ranName := "test"
origNodebInfo := &entities.NodebInfo{RanName: ranName, GlobalNbId: &entities.GlobalNbId{PlmnId: "xxx", NbId: "yyy"}, ConnectionStatus: entities.ConnectionStatus_SHUT_DOWN}
var rnibErr error
}
func TestShuttingdownRanReconnection(t *testing.T) {
- _, _, readerMock, writerMock, ranReconnectionManager := initRanLostConnectionTest(t)
+ _, _, readerMock, writerMock, ranReconnectionManager, _ := initRanLostConnectionTest(t)
ranName := "test"
origNodebInfo := &entities.NodebInfo{RanName: ranName, GlobalNbId: &entities.GlobalNbId{PlmnId: "xxx", NbId: "yyy"}, ConnectionStatus: entities.ConnectionStatus_SHUTTING_DOWN}
var rnibErr error
writerMock.AssertNumberOfCalls(t, "UpdateNodebInfo", 1)
}
-func TestConnectingRanWithMaxAttemptsReconnection(t *testing.T) {
- _, _, readerMock, writerMock, ranReconnectionManager := initRanLostConnectionTest(t)
+func TestConnectingRanWithMaxAttemptsReconnectionDeassociateSucceeds(t *testing.T) {
+ _, _, readerMock, writerMock, ranReconnectionManager, e2tInstancesManagerMock := initRanLostConnectionTest(t)
ranName := "test"
- origNodebInfo := &entities.NodebInfo{RanName: ranName, GlobalNbId: &entities.GlobalNbId{PlmnId: "xxx", NbId: "yyy"}, ConnectionStatus: entities.ConnectionStatus_CONNECTING, ConnectionAttempts: 20}
+ e2tAddress := "10.0.2.15"
+ origNodebInfo := &entities.NodebInfo{RanName: ranName, GlobalNbId: &entities.GlobalNbId{PlmnId: "xxx", NbId: "yyy"}, ConnectionStatus: entities.ConnectionStatus_CONNECTING, ConnectionAttempts: 20, AssociatedE2TInstanceAddress: e2tAddress}
var rnibErr error
readerMock.On("GetNodeb", ranName).Return(origNodebInfo, rnibErr)
updatedNodebInfo := *origNodebInfo
updatedNodebInfo.ConnectionStatus = entities.ConnectionStatus_DISCONNECTED
writerMock.On("UpdateNodebInfo", &updatedNodebInfo).Return(rnibErr)
+ e2tInstancesManagerMock.On("DeassociateRan", ranName, e2tAddress).Return(nil)
err := ranReconnectionManager.ReconnectRan(ranName)
assert.Nil(t, err)
readerMock.AssertCalled(t, "GetNodeb", ranName)
writerMock.AssertNumberOfCalls(t, "UpdateNodebInfo", 1)
+ e2tInstancesManagerMock.AssertCalled(t, "DeassociateRan", ranName, e2tAddress)
+}
+
+func TestConnectingRanWithMaxAttemptsReconnectionDeassociateFails(t *testing.T) {
+ _, _, readerMock, writerMock, ranReconnectionManager, e2tInstancesManagerMock := initRanLostConnectionTest(t)
+ ranName := "test"
+ e2tAddress := "10.0.2.15"
+ origNodebInfo := &entities.NodebInfo{RanName: ranName, GlobalNbId: &entities.GlobalNbId{PlmnId: "xxx", NbId: "yyy"}, ConnectionStatus: entities.ConnectionStatus_CONNECTING, ConnectionAttempts: 20, AssociatedE2TInstanceAddress: e2tAddress}
+ var rnibErr error
+ readerMock.On("GetNodeb", ranName).Return(origNodebInfo, rnibErr)
+ updatedNodebInfo := *origNodebInfo
+ updatedNodebInfo.ConnectionStatus = entities.ConnectionStatus_DISCONNECTED
+ writerMock.On("UpdateNodebInfo", &updatedNodebInfo).Return(rnibErr)
+ e2tInstancesManagerMock.On("DeassociateRan", ranName, e2tAddress).Return(common.NewInternalError(errors.New("Error")))
+ err := ranReconnectionManager.ReconnectRan(ranName)
+ assert.NotNil(t, err)
+ readerMock.AssertCalled(t, "GetNodeb", ranName)
+ writerMock.AssertNumberOfCalls(t, "UpdateNodebInfo", 1)
+ e2tInstancesManagerMock.AssertCalled(t, "DeassociateRan", ranName, e2tAddress)
}
func TestUnconnectableRanUpdateNodebInfoFailure(t *testing.T) {
- _, _, readerMock, writerMock, ranReconnectionManager := initRanLostConnectionTest(t)
+ _, _, readerMock, writerMock, ranReconnectionManager, _ := initRanLostConnectionTest(t)
ranName := "test"
origNodebInfo := &entities.NodebInfo{RanName: ranName, GlobalNbId: &entities.GlobalNbId{PlmnId: "xxx", NbId: "yyy"}, ConnectionStatus: entities.ConnectionStatus_SHUTTING_DOWN}
var rnibErr error
}
func TestConnectedRanExecuteSetupSuccess(t *testing.T) {
- _, rmrMessengerMock, readerMock, writerMock, ranReconnectionManager := initRanLostConnectionTest(t)
+ _, rmrMessengerMock, readerMock, writerMock, ranReconnectionManager, _ := initRanLostConnectionTest(t)
ranName := "test"
origNodebInfo := &entities.NodebInfo{RanName: ranName, GlobalNbId: &entities.GlobalNbId{PlmnId: "xxx", NbId: "yyy"}, ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_ENDC_X2_SETUP_REQUEST}
var rnibErr error
}
func TestConnectedRanExecuteSetupFailure(t *testing.T) {
- _, _, readerMock, writerMock, ranReconnectionManager := initRanLostConnectionTest(t)
+ _, _, readerMock, writerMock, ranReconnectionManager, _ := initRanLostConnectionTest(t)
ranName := "test"
origNodebInfo := &entities.NodebInfo{RanName: ranName, GlobalNbId: &entities.GlobalNbId{PlmnId: "xxx", NbId: "yyy"}, ConnectionStatus: entities.ConnectionStatus_CONNECTED}
var rnibErr error
}
func TestUnnecessaryUpdateNodebInfoStatus(t *testing.T) {
- _, _, _, _, ranReconnectionManager := initRanLostConnectionTest(t)
+ _, _, _, _, ranReconnectionManager, _ := initRanLostConnectionTest(t)
nodebInfo := &entities.NodebInfo{RanName: "ranName", GlobalNbId: &entities.GlobalNbId{PlmnId: "xxx", NbId: "yyy"}, ConnectionStatus: entities.ConnectionStatus_CONNECTED}
err := ranReconnectionManager.updateNodebInfoStatus(nodebInfo, entities.ConnectionStatus_CONNECTED)
assert.Nil(t, err)
}
func TestNoSetConnectionStatus(t *testing.T) {
- _, _, _, _, ranReconnectionManager := initRanLostConnectionTest(t)
+ _, _, _, _, ranReconnectionManager, _ := initRanLostConnectionTest(t)
nodebInfo := &entities.NodebInfo{RanName: "ranName", GlobalNbId: &entities.GlobalNbId{PlmnId: "xxx", NbId: "yyy"}, ConnectionStatus: entities.ConnectionStatus_CONNECTED}
err := ranReconnectionManager.setConnectionStatusOfUnconnectableRan(nodebInfo)
assert.Nil(t, err)