fix: remove runtime exception when the FPR is not in Fullfilled state

Runtime exception remove when focom provisioning request is not in fullfilled state. Instead log message added

Issue-ID: SMO-208
Change-Id: Iac71a01eb6a9c891dd06910a50c1e75fdf2c6038
Signed-off-by: aravind.est <aravindhan.a@est.tech>

diff --git a/adapters/focom-to-teiv-adapter/src/main/java/org/oran/smo/teiv/adapters/focom_to_teiv_adapter/service/FocomToTeivModelBuilder.java b/adapters/focom-to-teiv-adapter/src/main/java/org/oran/smo/teiv/adapters/focom_to_teiv_adapter/service/FocomToTeivModelBuilder.java
index 721c6e9..4e28ebf 100644 (file)
--- a/adapters/focom-to-teiv-adapter/src/main/java/org/oran/smo/teiv/adapters/focom_to_teiv_adapter/service/FocomToTeivModelBuilder.java
+++ b/adapters/focom-to-teiv-adapter/src/main/java/org/oran/smo/teiv/adapters/focom_to_teiv_adapter/service/FocomToTeivModelBuilder.java
@@ -85,7 +85,10 @@ public class FocomToTeivModelBuilder {
 
         for (FocomProvisioningRequest focomProvisioningRequest : focomRequests) {
 
-            validateProvisioningRequest(focomProvisioningRequest);
+            if (!isProvisioningRequestFulfilled(focomProvisioningRequest)) {
+                index++;
+                continue;
+            }
 
             EntityItem oCloudNamespace = buildOCloudNamespace(focomProvisioningRequest, index);
             oCloudNamespaces.add(oCloudNamespace);
@@ -141,10 +144,14 @@ public class FocomToTeivModelBuilder {
         return json;
     }
 
-    private void validateProvisioningRequest(FocomProvisioningRequest focomProvisioningRequest) {
+    private boolean isProvisioningRequestFulfilled(FocomProvisioningRequest focomProvisioningRequest) {
         if (!"Fulfilled".equals(focomProvisioningRequest.getStatus().getPhase())) {
-            throw new RuntimeException("Requested Focomprovisioning request is not in Fulfilled phase");
+            log.info("Skipping FOCOM provisioning request '{}' as it is not in Fulfilled phase (current phase: '{}')",
+                    focomProvisioningRequest.getMetadata().getName(),
+                    focomProvisioningRequest.getStatus().getPhase());
+            return false;
         }
+        return true;
     }
 
     private EntityItem buildOCloudNamespace(FocomProvisioningRequest focomProvisioningRequest, int index) {