Merge "[ODUHIGH-343]: PUCCH resource allocation (check for SR PRBs, if unavailable...
authorAnkit Barve <anbarve@radisys.com>
Mon, 22 Nov 2021 12:16:04 +0000 (12:16 +0000)
committerGerrit Code Review <gerrit@o-ran-sc.org>
Mon, 22 Nov 2021 12:16:04 +0000 (12:16 +0000)
1  2 
src/5gnrsch/sch_common.c

diff --combined src/5gnrsch/sch_common.c
@@@ -320,12 -320,14 +320,14 @@@ uint8_t fillUlSchedPucchFormat(uint8_t 
   *  @return  void
   **/
  
- uint8_t fillUlSchedPucchDedicatedCfg(uint16_t numSlots, SchPucchCfg *pucchDedCfg,\
+ uint8_t fillUlSchedPucchDedicatedCfg(SchCellCb *cell, SchPucchCfg *pucchDedCfg,\
     SlotTimingInfo *slotInfo, SchPucchInfo *ulSchedPucch)
  {
     uint8_t ret, resrcSetIdx, resrcIdx, schedReqIdx, srPeriodicity = 0;
     uint16_t srOffset = 0;
+    uint16_t numSlots = cell->numSlots;
+    bool isAllocated = false;
+    uint16_t pucchStartPrb;
     ret = ROK;
     if(pucchDedCfg->resrcSet && pucchDedCfg->resrc)
     {
           for(resrcIdx = 0; resrcIdx < pucchDedCfg->resrc->resrcToAddModListCount; resrcIdx++)
           {
              if(pucchDedCfg->resrcSet->resrcSetToAddModList[resrcSetIdx].resrcList[resrcSetIdx] ==\
-              pucchDedCfg->resrc->resrcToAddModList[resrcIdx].resrcId)
-           {
+                   pucchDedCfg->resrc->resrcToAddModList[resrcIdx].resrcId)
+             {
                 ulSchedPucch->intraFreqHop = pucchDedCfg->resrc->resrcToAddModList[resrcIdx].intraFreqHop;
                 ulSchedPucch->secondPrbHop = pucchDedCfg->resrc->resrcToAddModList[resrcIdx].secondPrbHop;
                 ulSchedPucch->fdAlloc.startPrb = pucchDedCfg->resrc->resrcToAddModList[resrcIdx].startPrb;
-              ulSchedPucch->pucchFormat = pucchDedCfg->resrc->resrcToAddModList[resrcIdx].pucchFormat;
-              ret = fillUlSchedPucchFormat(ulSchedPucch->pucchFormat, ulSchedPucch,\
-                       &pucchDedCfg->resrc->resrcToAddModList[resrcIdx], NULLP);
-              if(ret == RFAILED)
-                 return ret;
-           }
+                ulSchedPucch->pucchFormat = pucchDedCfg->resrc->resrcToAddModList[resrcIdx].pucchFormat;
+                ret = fillUlSchedPucchFormat(ulSchedPucch->pucchFormat, ulSchedPucch,\
+                      &pucchDedCfg->resrc->resrcToAddModList[resrcIdx], NULLP);
+                if(ret == RFAILED)
+                   return ret;
+                pucchStartPrb = pucchDedCfg->resrc->resrcToAddModList[resrcIdx].startPrb;
+                ret = allocatePrbUl(cell, *slotInfo, ulSchedPucch->tdAlloc.startSymb, ulSchedPucch->tdAlloc.numSymb, &pucchStartPrb, PUCCH_NUM_PRB_FORMAT_0_1_4);
+                if(ret == ROK)
+                {
+                   isAllocated = true;
+                   break;
+                }
+             }
           }
+          if(isAllocated)
+          break;
        }
     }
     if(pucchDedCfg->format1)
     {
        memset(&ulSchedPucch->cmnFormatCfg, 0, sizeof(SchPucchFormatCfg));
        if(ret == RFAILED)
           return ret;
     }
-    
+    if(!isAllocated)
+    {
+       return RFAILED;
+    }
     /* setting SR and UCI flag */
     if(pucchDedCfg->schedReq)
     {
   *  @return  ROK/RFAILED
   **/
  
- uint16_t fillPucchResourceInfo(SchPucchInfo *schPucchInfo, Inst inst)
+ uint16_t fillPucchResourceInfo(SchPucchInfo *schPucchInfo, Inst inst, SlotTimingInfo slotInfo)
  {
     uint8_t ret = ROK, ueIdx = 0, pucchIdx = 0;
     SchCellCb  *cell = schCb[inst].cells[inst];
     SchPucchCfgCmn *pucchCfg = NULLP;
     SchBwpParams *ulBwp = NULLP;
+    uint16_t startPrb;
  
     GET_UE_IDX(schPucchInfo->rnti, ueIdx);
     if(cell->ueCb[ueIdx].ueCfg.spCellCfg.servCellCfg.initUlBwp.pucchCfgPres)
     {
        /* fill pucch dedicated cfg */
-       ret = fillUlSchedPucchDedicatedCfg(cell->numSlots,\
-        &cell->ueCb[ueIdx].ueCfg.spCellCfg.servCellCfg.initUlBwp.pucchCfg, &cell->slotInfo, schPucchInfo);
+       ret = fillUlSchedPucchDedicatedCfg(cell,\
+        &cell->ueCb[ueIdx].ueCfg.spCellCfg.servCellCfg.initUlBwp.pucchCfg, &slotInfo, schPucchInfo);
        if(ret == RFAILED)
        {
           memset(schPucchInfo, 0, sizeof(SchPucchInfo));
        pucchCfg = &cell->cellCfg.schInitialUlBwp.pucchCommon;
        pucchIdx = pucchCfg->pucchResourceCommon;
        ulBwp = &cell->cellCfg.schInitialUlBwp.bwp;
-       schPucchInfo->fdAlloc.startPrb = ulBwp->freqAlloc.startPrb + pucchResourceSet[pucchIdx][3];
-       schPucchInfo->fdAlloc.numPrb = PUCCH_NUM_PRB_FORMAT_0_1_4;
-       schPucchInfo->tdAlloc.startSymb = pucchResourceSet[pucchIdx][1];
-       schPucchInfo->tdAlloc.numSymb = pucchResourceSet[pucchIdx][2];
-       schPucchInfo->pucchFormat = pucchResourceSet[pucchIdx][0];
-       /* set SR and UCI flag to false */
-       schPucchInfo->srFlag  = true;
-       schPucchInfo->uciFlag = true;
+       startPrb = ulBwp->freqAlloc.startPrb + pucchResourceSet[pucchIdx][3];
+       ret = allocatePrbUl(cell, slotInfo, pucchResourceSet[pucchIdx][1], pucchResourceSet[pucchIdx][2],\
+             &startPrb, PUCCH_NUM_PRB_FORMAT_0_1_4);
+       if (ret == ROK)
+       {
+          schPucchInfo->fdAlloc.startPrb = ulBwp->freqAlloc.startPrb + pucchResourceSet[pucchIdx][3];
+          schPucchInfo->fdAlloc.numPrb = PUCCH_NUM_PRB_FORMAT_0_1_4;
+          schPucchInfo->tdAlloc.startSymb = pucchResourceSet[pucchIdx][1];
+          schPucchInfo->tdAlloc.numSymb = pucchResourceSet[pucchIdx][2];
+          schPucchInfo->pucchFormat = pucchResourceSet[pucchIdx][0];
+          /* set SR and UCI flag to false */
+          schPucchInfo->srFlag  = true;
+          schPucchInfo->uciFlag = true;
+       }
     }
     /* set HARQ flag to true */
     schPucchInfo->harqFlag = true;
@@@ -477,10 -502,13 +502,13 @@@ uint8_t schUlResAlloc(SchCellCb *cell, 
  
     if(schUlSlotInfo->pucchPres)
     {
-       ulSchedInfo.dataType |= SCH_DATATYPE_UCI;
-       fillPucchResourceInfo(&schUlSlotInfo->schPucchInfo, schInst);
-       memcpy(&ulSchedInfo.schPucchInfo, &schUlSlotInfo->schPucchInfo,
-           sizeof(SchPucchInfo));
+       ret = fillPucchResourceInfo(&schUlSlotInfo->schPucchInfo, schInst, ulTimingInfo);
+       if (ret == ROK)
+       {
+          ulSchedInfo.dataType |= SCH_DATATYPE_UCI;
+          memcpy(&ulSchedInfo.schPucchInfo, &schUlSlotInfo->schPucchInfo,
+                sizeof(SchPucchInfo));
+       }
        memset(&schUlSlotInfo->schPucchInfo, 0, sizeof(SchPucchInfo));
     }
  
@@@ -1365,14 -1393,13 +1393,14 @@@ SchK2TimingInfoTbl *msg3K2InfoTbl, SchK
   *             I/P > mcsIdx and PDSCH symbols count 
   *             I/P & O/P > Shared PRB , reserved PRB Count
   *             I/P & O/P > Total TBS size accumulated
 - *             I/P & O/P > isTxPayloadLenAdded : Decision flag to add the TX_PAYLOAD_HDR_LEN
 + *             I/P & O/P > isTxPayloadLenAdded[For DL] : Decision flag to add the TX_PAYLOAD_HDR_LEN
 + *             I/P & O/P > srRcvd Flag[For UL] : Decision flag to add UL_GRANT_SIZE
   *
   * @return void
   *
   * *******************************************************************************************/
  void prbAllocUsingRRMPolicy(CmLListCp *lcLL, bool isDedicatedPRB, uint16_t mcsIdx,uint8_t numSymbols,\
 -                              uint16_t *sharedPRB, uint16_t *reservedPRB, bool *isTxPayloadLenAdded)
 +                  uint16_t *sharedPRB, uint16_t *reservedPRB, bool *isTxPayloadLenAdded, bool *srRcvd)
  {
     CmLList *node = NULLP;
     LcInfo *lcNode = NULLP;
        /*[Exit1]: All LCs are allocated(allocBO = 0 for fully unallocated LC)*/
        if(lcNode->allocBO != 0)
        {
 -         DU_LOG("\nWARNING --> SCH: All LC are allocated [SharedPRB:%d]",*sharedPRB);
 +         DU_LOG("\nDEBUG -->  SCH: All LC are allocated [SharedPRB:%d]",*sharedPRB);
           return;
        }
  
           /*Loop Exit: All resources exhausted*/
           if(remReservedPRB == 0 && *sharedPRB == 0)
           {
 -            DU_LOG("\nWARNING --> SCH: Dedicated resources exhausted for LC:%d",lcNode->lcId);
 +            DU_LOG("\nDEBUG  -->  SCH: Dedicated resources exhausted for LC:%d",lcNode->lcId);
              return;
           }
        }
           /*Loop Exit: All resources exhausted*/
           if(*sharedPRB == 0)
           {
 -            DU_LOG("\nWARNING --> SCH: Default resources exhausted for LC:%d",lcNode->lcId);
 +            DU_LOG("\nDEBUG  --> SCH: Default resources exhausted for LC:%d",lcNode->lcId);
              return;
           }
        }
        maxPRB = remReservedPRB + *sharedPRB;
  
        /*[Step4]*/
 -      if(!(*isTxPayloadLenAdded))
 +      if((isTxPayloadLenAdded != NULLP) && (*isTxPayloadLenAdded == FALSE))
        {
 -         DU_LOG("\nINFO --> SCH: LC:%d is the First node to be allocated which includes TX_PAYLOAD_HDR_LEN",\
 +         DU_LOG("\nDEBUG  --> SCH: LC:%d is the First node to be allocated which includes TX_PAYLOAD_HDR_LEN",\
                 lcNode->lcId);
           *isTxPayloadLenAdded = TRUE;
           lcNode->allocBO = calculateEstimateTBSize((lcNode->reqBO + TX_PAYLOAD_HDR_LEN),\
                 mcsIdx, numSymbols, maxPRB, &estPrb);
           lcNode->allocBO -=TX_PAYLOAD_HDR_LEN;
        }
 +      else if((srRcvd != NULLP) && (*srRcvd == TRUE))
 +      {
 +         DU_LOG("\nDEBUG  --> SCH: LC:%d is the First node to be allocated which includes UL_GRANT_SIZE",\
 +               lcNode->lcId);
 +         *srRcvd = FALSE;
 +         lcNode->reqBO += UL_GRANT_SIZE;
 +         lcNode->allocBO = calculateEstimateTBSize(lcNode->reqBO, mcsIdx, numSymbols, maxPRB, &estPrb);
 +      }
        else
        {
           /*[Step4]*/
        {
           if(*sharedPRB <=  (estPrb - remReservedPRB))
           {
 -            DU_LOG("\nINFO --> SCH: SharedPRB is less");
 +            DU_LOG("\nDEBUG  --> SCH: SharedPRB is less");
              *sharedPRB = 0;
           }
           else
   *             BO Report in dlMsgAlloc Pointer
   *
   * @params[in] I/P > lcLinkList pointer (LcInfo list)
 - *             I/P & O/P > dlMsgAlloc(Pending LC to be added in this context) 
 + *             I/P & O/P > dlMsgAlloc[for DL](Pending LC to be added in this context) 
 + *             I/P & O/P > BsrInfo (applicable for UL)
   *             I/P & O/P > accumalatedBOSize
   * @return void
   *
   * *******************************************************************************************/
 -void updateGrantSizeForBoRpt(CmLListCp *lcLL, DlMsgAlloc *dlMsgAlloc, uint32_t *accumalatedBOSize)
 +void updateGrantSizeForBoRpt(CmLListCp *lcLL, DlMsgAlloc *dlMsgAlloc,\
 +                                BsrInfo *bsrInfo, uint32_t *accumalatedBOSize)
  {
     CmLList *node = NULLP, *next = NULLP;
     LcInfo *lcNode = NULLP;
        return;
     }
  
 -   dlMsgSchInfo = &dlMsgAlloc->dlMsgSchedInfo[dlMsgAlloc->numSchedInfo];
 -
     /*Traverse List*/
     while(node)
     {
        lcNode = (LcInfo *)node->node;
        if(lcNode != NULLP)
        {
 -         DU_LOG("\nINFO  --> SCH : LcID:%d, [reqBO, allocBO, allocPRB]:[%d,%d,%d]",\
 +         DU_LOG("\nINFO   --> SCH : LcID:%d, [reqBO, allocBO, allocPRB]:[%d,%d,%d]",\
                 lcNode->lcId, lcNode->reqBO, lcNode->allocBO, lcNode->allocPRB);
 +         if(dlMsgAlloc != NULLP)
 +         {
 +            dlMsgSchInfo = &dlMsgAlloc->dlMsgSchedInfo[dlMsgAlloc->numSchedInfo];
  
 -         /*Add this LC to dlMsgAlloc so that if this LC gets allocated, BO
 -          * report for allocation can be sent to MAC*/
 -         dlMsgSchInfo->lcSchInfo[dlMsgSchInfo->numLc].lcId = lcNode->lcId;
 -         dlMsgSchInfo->lcSchInfo[dlMsgSchInfo->numLc].schBytes = lcNode->allocBO;
 +            /*Add this LC to dlMsgAlloc so that if this LC gets allocated, BO
 +             * report for allocation can be sent to MAC*/
 +            dlMsgSchInfo->lcSchInfo[dlMsgSchInfo->numLc].lcId = lcNode->lcId;
 +            dlMsgSchInfo->lcSchInfo[dlMsgSchInfo->numLc].schBytes = lcNode->allocBO;
  
 -         /*Calculate the Total Payload/BO size allocated*/
 -         *accumalatedBOSize += dlMsgSchInfo->lcSchInfo[dlMsgSchInfo->numLc].schBytes; 
 +            /*Calculate the Total Payload/BO size allocated*/
 +            *accumalatedBOSize += dlMsgSchInfo->lcSchInfo[dlMsgSchInfo->numLc].schBytes; 
  
 -         DU_LOG("\nINFO --> SCH: Added in MAC BO report: LCID:%d,reqBO:%d,Idx:%d, TotalBO Size:%d",\
 -               lcNode->lcId,lcNode->reqBO, dlMsgSchInfo->numLc, *accumalatedBOSize);
 +            DU_LOG("\nINFO   --> SCH: Added in MAC BO report: LCID:%d,reqBO:%d,Idx:%d, TotalBO Size:%d",\
 +                  lcNode->lcId,lcNode->reqBO, dlMsgSchInfo->numLc, *accumalatedBOSize);
  
 -         dlMsgSchInfo->numLc++;
 -         /*The LC has been fully allocated, clean it*/
 -         if(lcNode->reqBO == 0)
 +            dlMsgSchInfo->numLc++;
 +            /*The LC has been fully allocated, clean it*/
 +            if(lcNode->reqBO == 0)
 +            {
 +               handleLcLList(lcLL, lcNode->lcId, DELETE);
 +            }
 +         }
 +         else if(bsrInfo != NULLP)
           {
 -            handleLcLList(lcLL, lcNode->lcId, DELETE);
 +            *accumalatedBOSize += lcNode->allocBO;   
 +            DU_LOG("\nINFO   --> SCH: UL : LCID:%d,reqBO:%d, TotalBO Size:%d",\
 +                  lcNode->lcId,lcNode->reqBO, *accumalatedBOSize);
           }
        }
        node = next;
@@@ -1737,141 -1746,6 +1765,141 @@@ bool schProcessMsg4Req(SchCellCb *cell
     return true;
  }
  
 +/*******************************************************************
 + *
 + * @brief  Handler to calculate TBS size for BSR requested
 + *
 + * @details
 + *
 + *    Function :  schCalculateUlTbs
 + *
 + *    Functionality: Function will note the required TBS for each LCGIDX and use
 + *    the Priority LCG List and RRM policy to allocate the TBS size
 + *
 + * @params [in] ueCb (Pointer to UE CB)
 + *         [in] puschTime (Time slot where PUSCH will be sent)
 + *         [in] symbLen (No of Symbols used for PUSCH transmission)
 + *         [out] startPrb(Pointer to startPRB which will be calculated while
 + *         finding the best Free Block)
 + *         [out] totTBS(Pointer to total TBS size)
 + *
 + * @return bool : true > Scheduling of UL grant is successful
 + *                false > vice versa
 + *
 + * ****************************************************************/
 +bool schCalculateUlTbs(SchUeCb *ueCb, SlotTimingInfo puschTime, uint8_t symbLen,\
 +                          uint16_t *startPrb, uint32_t *totTBS)
 +{
 +   uint16_t mcsIdx = 0;
 +   CmLListCp *lcLL = NULLP;
 +   uint16_t lcgIdx = 0, lcId =0, maxFreePRB = 0;
 +
 +   *startPrb = 0;
 +   *totTBS = 0;
 +
 +   /* check for BSR */
 +   for(lcgIdx=0; lcgIdx<MAX_NUM_LOGICAL_CHANNEL_GROUPS; lcgIdx++)
 +   {
 +      if(ueCb->bsrInfo[lcgIdx].dataVol == 0)
 +      {
 +         continue;
 +      }
 +
 +      /*TODO: lcgIdx and LCID has been implemented as one to one mapping.
 +       * Need to check the mapping to figure out the LCID and lcgIdx once L2
 +       * spec specifies any logic*/
 +      lcId = lcgIdx;
 +      if(ueCb->ulInfo.ulLcCtxt[lcId].isDedicated)
 +      {
 +         lcLL = &(ueCb->ulLcPrbEst.dedLcInfo->dedLcList);
 +      }
 +      else
 +      {
 +         lcLL = &(ueCb->ulLcPrbEst.defLcList);
 +      }
 +
 +      /*[Step2]: Update the reqPRB and Payloadsize for this LC in the appropriate List*/
 +      if(updateLcListReqPRB(lcLL, lcId, ueCb->bsrInfo[lcgIdx].dataVol) != ROK)
 +      {
 +         DU_LOG("\nERROR  --> SCH: LcgId:%d updation failed",lcId);
 +         return false; 
 +      }
 +   }
 +
 +   if ((ueCb->ulLcPrbEst.defLcList.count == 0) && \
 +         ((ueCb->ulLcPrbEst.dedLcInfo == NULL) || (ueCb->ulLcPrbEst.dedLcInfo->dedLcList.count == 0)))
 +   {
 +      if(ueCb->srRcvd)
 +      {
 +         *startPrb = MAX_NUM_RB;
 +         *totTBS = schCalcTbSize(UL_GRANT_SIZE);
 +      }
 +
 +      /*Returning true when NO Grant is there for UE as this is not scheduling
 +       * error*/
 +      return (true);
 +   }
 +
 +   maxFreePRB = searchLargestFreeBlock(ueCb->cellCb, puschTime, startPrb, DIR_UL);
 +
 +   /*[Step4]: Estimation of PRB and BO which can be allocated to each LC in
 +    * the list based on RRM policy*/
 +
 +   /*Either this UE contains no reservedPRB pool fir dedicated S-NSSAI or 
 +    * Num of Free PRB available is not enough to reserve Dedicated PRBs*/
 +   if(maxFreePRB != 0)
 +   {
 +      mcsIdx = ueCb->ueCfg.ulModInfo.mcsIndex;
 +      if((ueCb->ulLcPrbEst.dedLcInfo == NULLP) 
 +            || ((maxFreePRB <  ueCb->ulLcPrbEst.dedLcInfo->rsvdDedicatedPRB)))
 +      { 
 +         ueCb->ulLcPrbEst.sharedNumPrb = maxFreePRB;
 +         DU_LOG("\nDEBUG  -->  SCH : UL Only Default Slice is scheduled, sharedPRB Count:%d",\
 +               ueCb->ulLcPrbEst.sharedNumPrb);
 +
 +         /*PRB Alloc for Default LCs*/
 +         prbAllocUsingRRMPolicy(&(ueCb->ulLcPrbEst.defLcList), FALSE, mcsIdx, symbLen,\
 +               &(ueCb->ulLcPrbEst.sharedNumPrb), NULLP, NULLP,&(ueCb->srRcvd));
 +      }
 +      else
 +      {
 +         ueCb->ulLcPrbEst.sharedNumPrb = maxFreePRB - ueCb->ulLcPrbEst.dedLcInfo->rsvdDedicatedPRB;
 +
 +         /*PRB Alloc for Dedicated LCs*/
 +         prbAllocUsingRRMPolicy(&(ueCb->ulLcPrbEst.dedLcInfo->dedLcList), TRUE, mcsIdx, symbLen,\
 +               &(ueCb->ulLcPrbEst.sharedNumPrb), &(ueCb->ulLcPrbEst.dedLcInfo->rsvdDedicatedPRB),\
 +               NULLP,&(ueCb->srRcvd));
 +
 +         /*PRB Alloc for Default LCs*/
 +         prbAllocUsingRRMPolicy(&(ueCb->ulLcPrbEst.defLcList), FALSE, mcsIdx, symbLen, \
 +               &(ueCb->ulLcPrbEst.sharedNumPrb), &(ueCb->ulLcPrbEst.dedLcInfo->rsvdDedicatedPRB),\
 +               NULLP,&(ueCb->srRcvd));
 +      }
 +   }
 +   /*[Step5]:Traverse each LCID in LcList to calculate the exact Scheduled Bytes
 +    * using allocated BO per LC and Update dlMsgAlloc(BO report for MAC*/ 
 +   if(ueCb->ulLcPrbEst.dedLcInfo != NULLP)
 +      updateGrantSizeForBoRpt(&(ueCb->ulLcPrbEst.dedLcInfo->dedLcList), NULLP, ueCb->bsrInfo, totTBS);
 +
 +   updateGrantSizeForBoRpt(&(ueCb->ulLcPrbEst.defLcList), NULLP, ueCb->bsrInfo, totTBS);
 +
 +   /*Below case will hit if NO LC(s) are allocated due to resource crunch*/
 +   if (*totTBS == 0)
 +   {
 +      if(maxFreePRB == 0)
 +      {
 +         DU_LOG("\nERROR  --> SCH : NO FREE PRB!!");
 +      }
 +      else
 +      {
 +         /*Schedule the LC for next slot*/
 +         DU_LOG("\nDEBUG  -->  SCH : No LC has been scheduled");
 +      }
 +      return (false);
 +   }
 +   return (true);
 +}
 +
  /*******************************************************************
   *
   * @brief sch Process pending Sr or Bsr Req
   *******************************************************************/
  bool schProcessSrOrBsrReq(SchCellCb *cell, SlotTimingInfo currTime, uint8_t ueId)
  {
 -   bool k2Found = FALSE;
 -   uint8_t lcgIdx = 0;
 +   bool k2Found = FALSE, ret = FALSE;
     uint8_t startSymb = 0, symbLen = 0;
     uint8_t k2TblIdx = 0, k2Index = 0, k2Val = 0;
 +   uint16_t startPrb = 0;
     uint32_t totDataReq = 0; /* in bytes */
     SchUeCb *ueCb;
     SchPuschInfo *puschInfo;
     SchK2TimingInfoTbl *k2InfoTbl=NULLP;
     SlotTimingInfo dciTime, puschTime;
  
 -   if(cell == NULL)
 +   if(cell == NULLP)
     {
        DU_LOG("\nERROR  -->  SCH: schDlRsrcAllocMsg4() : Cell is NULL");
        return false;
     }
 -   
 +
     ueCb = &cell->ueCb[ueId-1];
  
 -   /* check for SR */
 -   if(ueCb->srRcvd)
 -   {
 -      totDataReq = UL_GRANT_SIZE; /*fixing so that all control msgs can be handled in SR */
 -   }
 -   /* check for BSR */
 -   if(ueCb->bsrRcvd == true)
 +   if(ueCb == NULLP)
     {
 -      for(lcgIdx=0; lcgIdx<MAX_NUM_LOGICAL_CHANNEL_GROUPS; lcgIdx++)
 -      {
 -         totDataReq+= ueCb->bsrInfo[lcgIdx].dataVol;
 -      }
 +      DU_LOG("\nERROR  -->  SCH: schDlRsrcAllocMsg4() : UE is NULL");
 +      return false;
     }
 -
 -   if(totDataReq > 0)
 -   {
 -      /* Calculating time frame to send DCI for SR */
 -      ADD_DELTA_TO_TIME(currTime, dciTime, PHY_DELTA_DL + SCHED_DELTA);
 +   /* Calculating time frame to send DCI for SR */
 +   ADD_DELTA_TO_TIME(currTime, dciTime, PHY_DELTA_DL + SCHED_DELTA);
  #ifdef NR_TDD
 -      if(schGetSlotSymbFrmt(dciTime.slot, cell->slotFrmtBitMap) == DL_SLOT)
 +   if(schGetSlotSymbFrmt(dciTime.slot, cell->slotFrmtBitMap) == DL_SLOT)
  #endif
 -      {     
 -         if(ueCb->ueCfg.spCellCfg.servCellCfg.initUlBwp.k2TblPrsnt)
 -            k2InfoTbl = &ueCb->ueCfg.spCellCfg.servCellCfg.initUlBwp.k2InfoTbl;
 -         else
 -            k2InfoTbl =  &cell->cellCfg.schInitialUlBwp.k2InfoTbl;
 +   {     
 +      if(ueCb->ueCfg.spCellCfg.servCellCfg.initUlBwp.k2TblPrsnt)
 +         k2InfoTbl = &ueCb->ueCfg.spCellCfg.servCellCfg.initUlBwp.k2InfoTbl;
 +      else
 +         k2InfoTbl =  &cell->cellCfg.schInitialUlBwp.k2InfoTbl;
  
 -         for(k2TblIdx = 0; k2TblIdx < k2InfoTbl->k2TimingInfo[dciTime.slot].numK2; k2TblIdx++)
 -         {
 -            k2Index = k2InfoTbl->k2TimingInfo[dciTime.slot].k2Indexes[k2TblIdx];
 +      for(k2TblIdx = 0; k2TblIdx < k2InfoTbl->k2TimingInfo[dciTime.slot].numK2; k2TblIdx++)
 +      {
 +         k2Index = k2InfoTbl->k2TimingInfo[dciTime.slot].k2Indexes[k2TblIdx];
  
 -            if(!ueCb->ueCfg.spCellCfg.servCellCfg.initUlBwp.k2TblPrsnt)
 -            {
 -               k2Val = cell->cellCfg.schInitialUlBwp.puschCommon.timeDomRsrcAllocList[k2Index].k2;
 -               startSymb = cell->cellCfg.schInitialUlBwp.puschCommon.timeDomRsrcAllocList[k2Index].startSymbol;
 -               symbLen = cell->cellCfg.schInitialUlBwp.puschCommon.timeDomRsrcAllocList[k2Index].symbolLength;
 -            }
 -            else
 -            {
 -               k2Val = ueCb->ueCfg.spCellCfg.servCellCfg.initUlBwp.puschCfg.timeDomRsrcAllocList[k2Index].k2;
 -               startSymb =  ueCb->ueCfg.spCellCfg.servCellCfg.initUlBwp.puschCfg.timeDomRsrcAllocList[k2Index].startSymbol;
 -               symbLen =  ueCb->ueCfg.spCellCfg.servCellCfg.initUlBwp.puschCfg.timeDomRsrcAllocList[k2Index].symbolLength;
 -            }
 +         if(!ueCb->ueCfg.spCellCfg.servCellCfg.initUlBwp.k2TblPrsnt)
 +         {
 +            k2Val = cell->cellCfg.schInitialUlBwp.puschCommon.timeDomRsrcAllocList[k2Index].k2;
 +            startSymb = cell->cellCfg.schInitialUlBwp.puschCommon.timeDomRsrcAllocList[k2Index].startSymbol;
 +            symbLen = cell->cellCfg.schInitialUlBwp.puschCommon.timeDomRsrcAllocList[k2Index].symbolLength;
 +         }
 +         else
 +         {
 +            k2Val = ueCb->ueCfg.spCellCfg.servCellCfg.initUlBwp.puschCfg.timeDomRsrcAllocList[k2Index].k2;
 +            startSymb =  ueCb->ueCfg.spCellCfg.servCellCfg.initUlBwp.puschCfg.timeDomRsrcAllocList[k2Index].startSymbol;
 +            symbLen =  ueCb->ueCfg.spCellCfg.servCellCfg.initUlBwp.puschCfg.timeDomRsrcAllocList[k2Index].symbolLength;
 +         }
  
 -            /* Calculating time frame to send PUSCH for SR */
 -            ADD_DELTA_TO_TIME(dciTime, puschTime, k2Val);
 +         /* Calculating time frame to send PUSCH for SR */
 +         ADD_DELTA_TO_TIME(dciTime, puschTime, k2Val);
  #ifdef NR_TDD
 -            if(schGetSlotSymbFrmt(puschTime.slot, cell->slotFrmtBitMap) == DL_SLOT)
 -               continue;
 +         if(schGetSlotSymbFrmt(puschTime.slot, cell->slotFrmtBitMap) == DL_SLOT)
 +            continue;
  #endif
 -            if(cell->schUlSlotInfo[puschTime.slot]->puschUe != 0)
 -            {
 -               continue;
 -            }
 -            k2Found = true;
 -            break;
 +         if(cell->schUlSlotInfo[puschTime.slot]->puschUe != 0)
 +         {
 +            continue;
           }
 +         k2Found = true;
 +         break;
        }
 +   }
  
 -      if(k2Found == true)
 +   if(k2Found == true)
 +   {
 +      ret = schCalculateUlTbs(ueCb, puschTime, symbLen, &startPrb, &totDataReq);
 +      if(totDataReq > 0 && ret == TRUE)
        {
           SCH_ALLOC(dciInfo, sizeof(DciInfo));
           if(!dciInfo)
           {
              DU_LOG("\nERROR  -->  SCH : Memory Allocation failed for dciInfo alloc");
 +
 +            if(ueCb->ulLcPrbEst.dedLcInfo != NULLP)
 +               updateBsrAndLcList(&(ueCb->ulLcPrbEst.dedLcInfo->dedLcList), ueCb->bsrInfo, RFAILED);
 +
 +            updateBsrAndLcList(&(ueCb->ulLcPrbEst.defLcList), ueCb->bsrInfo, RFAILED);
              return false;
           }
           cell->schDlSlotInfo[dciTime.slot]->ulGrant = dciInfo;
           memset(dciInfo,0,sizeof(DciInfo));
  
           /* Update PUSCH allocation */
 -         if(schFillPuschAlloc(ueCb, puschTime, totDataReq, k2Val, startSymb, symbLen) == ROK)
 +         if(schFillPuschAlloc(ueCb, puschTime, totDataReq, startSymb, symbLen, startPrb) == ROK)
           {
              if(cell->schUlSlotInfo[puschTime.slot]->schPuschInfo)
              {
                    memcpy(&dciInfo->slotIndInfo, &dciTime, sizeof(SlotTimingInfo));
                    ueCb->srRcvd = false;
                    ueCb->bsrRcvd = false;
 -                  for(lcgIdx=0; lcgIdx<MAX_NUM_LOGICAL_CHANNEL_GROUPS; lcgIdx++)
 -                  {
 -                     ueCb->bsrInfo[lcgIdx].dataVol = 0;
 -                  }
 -
                    cell->schUlSlotInfo[puschTime.slot]->puschUe = ueId;
 +                  if(ueCb->ulLcPrbEst.dedLcInfo != NULLP)
 +                     updateBsrAndLcList(&(ueCb->ulLcPrbEst.dedLcInfo->dedLcList), ueCb->bsrInfo, ROK);
 +
 +                  updateBsrAndLcList(&(ueCb->ulLcPrbEst.defLcList), ueCb->bsrInfo, ROK);
                    return true;
                 }
              }
           }
 +
 +         if(ueCb->ulLcPrbEst.dedLcInfo != NULLP)
 +            updateBsrAndLcList(&(ueCb->ulLcPrbEst.dedLcInfo->dedLcList), ueCb->bsrInfo, RFAILED);
 +
 +         updateBsrAndLcList(&(ueCb->ulLcPrbEst.defLcList), ueCb->bsrInfo, RFAILED);
        }
     }
 -   return false;
 +   return (ret);
  }
 +
 +
 +/*******************************************************************
 + *
 + * @brief sch Process pending Sr or Bsr Req
 + *
 + * @details
 + *
 + *    Function : updateBsrAndLcList
 + *
 + *    Functionality:
 + *       Updating the BSRInfo in UECB and Lclist
 + *
 + * @params[in] SchCellCb *cell,  SlotTimingInfo currTime 
 + * @return ROK     - success
 + *         RFAILED - failure
 + *
 + *******************************************************************/
 +void updateBsrAndLcList(CmLListCp *lcLL, BsrInfo *bsrInfo, uint8_t status)
 +{
 +   CmLList *node = NULLP, *next = NULLP;
 +   LcInfo *lcNode = NULLP;
 +
 +   if(lcLL == NULLP)
 +   {
 +      DU_LOG("\nERROR --> SCH: LcList not present");
 +      return;
 +   }
 +
 +   if(lcLL->count)
 +   {
 +      node = lcLL->first;
 +   }
 +   else
 +   {
 +      /*lcLL is empty*/
 +      return;
 +   }
 +
 +   while(node)
 +   {
 +      next = node->next;
 +      lcNode = (LcInfo *)node->node;
 +      if(lcNode != NULLP)
 +      {
 +          /*Only when Status is OK then allocation is marked as ZERO and reqBO
 +           * is updated in UE's DB. If Failure, then allocation is added to reqBO 
 +           * and same is updated in Ue's DB inside BSR Info structure*/
 +         if(status == ROK)
 +         {
 +            lcNode->allocBO = 0;
 +         }
 +
 +         lcNode->reqBO += lcNode->allocBO;
 +         bsrInfo[lcNode->lcId].dataVol = lcNode->reqBO;
 +         if(lcNode->reqBO == 0)
 +         {
 +            handleLcLList(lcLL, lcNode->lcId, DELETE);
 +         }
 +      }
 +      node = next;
 +   }
 +}     
  /**********************************************************************
    End of file
   **********************************************************************/