Merge "Unit test cases improvements - Some fixed delays replaced with function which...
authorAnssi Mannila <anssi.mannila@nokia.com>
Tue, 21 Dec 2021 07:19:05 +0000 (07:19 +0000)
committerGerrit Code Review <gerrit@o-ran-sc.org>
Tue, 21 Dec 2021 07:19:05 +0000 (07:19 +0000)
1  2 
pkg/control/ut_messaging_test.go

@@@ -675,6 -675,7 +675,6 @@@ func TestSubDelReqAndRouteDeleteNok(t *
        xappConn2.TestMsgChanEmpty(t)
        e2termConn1.TestMsgChanEmpty(t)
        mainCtrl.wait_registry_empty(t, 10)
 -
        mainCtrl.VerifyCounterValues(t)
  }
  
@@@ -2982,19 -2983,21 +2982,21 @@@ func TestRESTSubReqRetransmissionV2(t *
  
        queryXappSubscription(t, int64(e2SubsId), "RAN_NAME_1", []string{"localhost:13560"})
  
+       mainCtrl.WaitOngoingRequestMapEmpty()
        //1.st resend
        restSubId_resend := xappConn1.SendRESTSubsReq(t, params)
  
        assert.Equal(t, restSubId_resend, restSubId)
  
-       <-time.After(100 * time.Millisecond)
+       mainCtrl.WaitOngoingRequestMapEmpty()
  
        //2.nd resend
        restSubId_resend2 := xappConn1.SendRESTSubsReq(t, params)
  
        assert.Equal(t, restSubId_resend2, restSubId)
  
-       <-time.After(100 * time.Millisecond)
+       mainCtrl.WaitOngoingRequestMapEmpty()
  
        deleteSubscription(t, xappConn1, e2termConn1, &restSubId)
  
@@@ -3066,7 -3069,7 +3068,7 @@@ func TestRESTSubReqRetransmissionV3(t *
  
        queryXappSubscription(t, int64(e2SubsId), "RAN_NAME_1", []string{"localhost:13560"})
  
-       <-time.After(100 * time.Millisecond)
+       mainCtrl.WaitOngoingRequestMapEmpty()
  
        //1.st resend with subscription ID
        params.SetSubscriptionID(&restSubId)
  
        assert.Equal(t, restSubId_resend, restSubId)
  
-       <-time.After(100 * time.Millisecond)
+       mainCtrl.WaitOngoingRequestMapEmpty()
  
        //2.nd resend without subscription ID (faking app restart)
        params = xappConn1.GetRESTSubsReqReportParams(subReqCount)
  
        assert.Equal(t, restSubId_resend2, restSubId)
  
-       <-time.After(100 * time.Millisecond)
+       mainCtrl.WaitOngoingRequestMapEmpty()
  
        deleteSubscription(t, xappConn1, e2termConn1, &restSubId)
  
@@@ -3168,7 -3171,7 +3170,7 @@@ func TestRESTSubReqRetransmissionV4(t *
  
        restSubId, e2SubsId := createSubscription(t, xappConn1, e2termConn1, params)
  
-       <-time.After(100 * time.Millisecond)
+       mainCtrl.WaitOngoingRequestMapEmpty()
  
        // Send modified  requst, this time with e2 subscriptions.
        params2 := xappConn1.GetRESTSubsReqReportParams(subReqCount + 1)
        e2SubsId2 := xappConn1.WaitRESTNotification(t, restSubId_resend)
        assert.NotEqual(t, e2SubsId2, 0)
  
-       <-time.After(100 * time.Millisecond)
+       mainCtrl.WaitOngoingRequestMapEmpty()
  
        xapp.Subscription.SetResponseCB(xappConn1.SubscriptionRespHandler)
        params = xappConn1.GetRESTSubsReqReportParams(subReqCount)
        e2SubsId1 = xappConn1.WaitAnyRESTNotification(t)
        assert.Equal(t, e2SubsId, e2SubsId1)
  
+       mainCtrl.WaitOngoingRequestMapEmpty()
        // Delete both e2 subscriptions
        xappConn1.SendRESTSubsDelReq(t, &restSubId)
        e2SubsIds := []uint32{e2SubsId, e2SubsId2}
@@@ -3289,9 -3294,9 +3293,9 @@@ func TestRESTSubReqRetransmissionV5(t *
  
        restSubId, e2SubsId := createSubscription(t, xappConn1, e2termConn1, params)
  
-       <-time.After(100 * time.Millisecond)
+       mainCtrl.WaitOngoingRequestMapEmpty()
  
 -      // Send modified  requst, this time with e2 subscriptions.
 +      // Send modified  request, this time with e2 subscriptions.
        params2 := xappConn1.GetRESTSubsReqReportParams(subReqCount + 1)
        params2.SetSubscriptionID(&restSubId)
  
        e2SubsId2 := xappConn1.WaitRESTNotification(t, restSubId_resend)
        assert.NotEqual(t, e2SubsId2, 0)
  
-       <-time.After(100 * time.Millisecond)
+       mainCtrl.WaitOngoingRequestMapEmpty()
  
        xapp.Subscription.SetResponseCB(xappConn1.SubscriptionRespHandler)
        params = xappConn1.GetRESTSubsReqReportParams(subReqCount)
        e2SubsId1 = xappConn1.WaitAnyRESTNotification(t)
        assert.Equal(t, e2SubsId, e2SubsId1)
  
+       mainCtrl.WaitOngoingRequestMapEmpty()
        // Delete both e2 subscriptions
        xappConn1.SendRESTSubsDelReq(t, &restSubId)
        e2SubsIds := []uint32{e2SubsId, e2SubsId2}
@@@ -3421,7 -3428,7 +3427,7 @@@ func TestRESTSubReqRetransmissionV6(t *
  
        restSubId, e2SubsId := createSubscription(t, xappConn1, e2termConn1, params)
  
-       <-time.After(100 * time.Millisecond)
+       mainCtrl.WaitOngoingRequestMapEmpty()
  
        // Send modified  requst, this time with e2 subscriptions.
        params2 := xappConn1.GetRESTSubsReqReportParams(subReqCount + 1)
        e2SubsId2 := xappConn1.WaitRESTNotification(t, restSubId_resend)
        assert.NotEqual(t, e2SubsId2, 0)
  
-       <-time.After(100 * time.Millisecond)
+       mainCtrl.WaitOngoingRequestMapEmpty()
  
        // Delete both e2 subscriptions
        xappConn1.SendRESTSubsDelReq(t, &restSubId)
        // fresh create.
        restSubId, e2SubsId = createSubscription(t, xappConn1, e2termConn1, params)
  
-       <-time.After(100 * time.Millisecond)
+       mainCtrl.WaitOngoingRequestMapEmpty()
  
        deleteSubscription(t, xappConn1, e2termConn1, &restSubId)
  
@@@ -5312,14 -5319,14 +5318,14 @@@ func TestRESTSubReqAndSubDelOkSameActio
  //     | RESTSubDelReq   |              |
  //     |---------------->|              |
  //     |                 |              |
 +//     |   RESTSubDelResp|              |
 +//     |<----------------|              |
  //     |                 | SubDelReq    |
  //     |                 |------------->|
  //     |                 |              |
  //     |                 |   SubDelResp |
  //     |                 |<-------------|
  //     |                 |              |
 -//     |   RESTSubDelResp|              |
 -//     |<----------------|              |
  //
  //-----------------------------------------------------------------------------
  
@@@ -5333,18 -5340,6 +5339,18 @@@ func TestRESTReportSubReqAndSubDelOk(t 
  func RESTReportSubReqAndSubDelOk(t *testing.T, subReqCount int, testIndex int) {
        xapp.Logger.Debug("TEST: TestRESTReportSubReqAndSubDelOk with testIndex %v", testIndex)
  
 +      mainCtrl.CounterValuesToBeVeriefied(t, CountersToBeAdded{
 +              Counter{cRestSubReqFromXapp, 1},
 +              Counter{cRestSubRespToXapp, 1},
 +              Counter{cSubReqToE2, uint64(subReqCount)},
 +              Counter{cSubRespFromE2, uint64(subReqCount)},
 +              Counter{cRestSubNotifToXapp, 1},
 +              Counter{cRestSubDelReqFromXapp, 1},
 +              Counter{cRestSubDelRespToXapp, 1},
 +              Counter{cSubDelReqToE2, uint64(subReqCount)},
 +              Counter{cSubDelRespFromE2, uint64(subReqCount)},
 +      })
 +
        // Req
        params := xappConn1.GetRESTSubsReqReportParams(subReqCount)
        restSubId := xappConn1.SendRESTSubsReq(t, params)
        e2termConn1.TestMsgChanEmpty(t)
        mainCtrl.wait_registry_empty(t, 10)
        mainCtrl.VerifyAllClean(t)
 +      mainCtrl.VerifyCounterValues(t)
  }
  
  /*
 -func TestRESTPolicySubReqAndSubDelOk(t *testing.T) {  was in comments already
 +func TestRESTPolicySubReqAndSubDelOk(t *testing.T) {  //Was in comments already. Next case is not run!
        CaseBegin("TestRESTPolicySubReqAndSubDelOk")
  
        subReqCount := 2
  func RESTPolicySubReqAndSubDelOk(t *testing.T, subReqCount int, testIndex int) {
        xapp.Logger.Debug("TEST: TestRESTPolicySubReqAndSubDelOk with testIndex %v", testIndex)
  
 +      mainCtrl.CounterValuesToBeVeriefied(t, CountersToBeAdded{
 +              Counter{cRestSubReqFromXapp, 1},
 +              Counter{cRestSubRespToXapp, 1},
 +              Counter{cSubReqToE2, uint64(subReqCount)},
 +              Counter{cSubRespFromE2, uint64(subReqCount)},
 +              Counter{cRestSubNotifToXapp, 1},
 +              Counter{cRestSubDelReqFromXapp, 1},
 +              Counter{cRestSubDelRespToXapp, 1},
 +              Counter{cSubDelReqToE2, uint64(subReqCount)},
 +              Counter{cSubDelRespFromE2, uint64(subReqCount)},
 +      })
 +
        // Req
        params := xappConn1.GetRESTSubsReqPolicyParams(subReqCount)
        restSubId := xappConn1.SendRESTSubsReq(t, params)
        e2termConn1.TestMsgChanEmpty(t)
        mainCtrl.wait_registry_empty(t, 10)
        mainCtrl.VerifyAllClean(t)
 +      mainCtrl.VerifyCounterValues(t)
  }
  
  func TestRESTTwoPolicySubReqAndSubDelOk(t *testing.T) {
@@@ -6022,7 -6003,7 +6028,7 @@@ func TestRESTSubReqReportSameActionDiff
  //     |                 |------------->|
  //     |                 |              |
  //     |                 |      SubResp | ASN.1 decode fails
 -//     |                 |<-------------|
 +//     |                 |<-------------| Decode failed. More data needed. This will result timer expiry and resending
  //     |                 |              |
  //     |                 | SubReq       |
  //     |                 |------------->|
  //     | RESTNotif (fail)|              |
  //     |<----------------|              |
  //     |                 |              |
 +//     |           [SUBS DELETE]        |
 +//     |                 |              |
  //
  //-----------------------------------------------------------------------------
  
  func TestRESTUnpackSubscriptionResponseDecodeFail(t *testing.T) {
        xapp.Logger.Debug("TEST: TestRESTUnpackSubscriptionResponseDecodeFail")
 +
 +      mainCtrl.CounterValuesToBeVeriefied(t, CountersToBeAdded{
 +              Counter{cRestSubReqFromXapp, 1},
 +              Counter{cRestSubRespToXapp, 1},
 +              Counter{cSubReqToE2, 1},
 +              Counter{cSubReqTimerExpiry, 1},
 +              Counter{cSubReReqToE2, 1},
 +              Counter{cSubRespFromE2, 1},
 +              Counter{cSubFailFromE2, 1},
 +              Counter{cRestSubFailNotifToXapp, 1},
 +              Counter{cRestSubDelReqFromXapp, 1},
 +              Counter{cRestSubDelRespToXapp, 1},
 +      })
 +
        const subReqCount int = 1
  
        // Req
        e2termConn1.TestMsgChanEmpty(t)
        mainCtrl.wait_registry_empty(t, 10)
        mainCtrl.VerifyAllClean(t)
 +      mainCtrl.VerifyCounterValues(t)
  }
  
  //-----------------------------------------------------------------------------
  //     |                 |------------->|
  //     |                 |              |
  //     |                 |      SubResp | Unknown instanceId
 -//     |                 |<-------------|
 +//     |                 |<-------------| No valid subscription found with subIds [0]
  //     |                 |              |
  //     |                 | SubReq       |
  //     |                 |------------->|
  //     |                 |              |
  //     |                 |      SubFail | Duplicated action
 -//     |                 |<-------------|
 +//     |                 |<-------------| No valid subscription found with subIds [0]
  //     | RESTNotif (fail)|              |
  //     |<----------------|              |
  //     |                 | SubDelReq    |
  //     |                 |              |
  //     |                 |   SubDelResp |
  //     |                 |<-------------|
 +//     |                 |              |
 +//     |           [SUBS DELETE]        |
 +//     |                 |              |
  //
  //-----------------------------------------------------------------------------
  
  func TestRESTUnpackSubscriptionResponseUnknownInstanceId(t *testing.T) {
        xapp.Logger.Debug("TEST: TestRESTUnpackSubscriptionResponseUnknownInstanceId")
 +
 +      mainCtrl.CounterValuesToBeVeriefied(t, CountersToBeAdded{
 +              Counter{cRestSubReqFromXapp, 1},
 +              Counter{cRestSubRespToXapp, 1},
 +              Counter{cSubReqToE2, 1},
 +              Counter{cSubReqTimerExpiry, 2},
 +              Counter{cSubReReqToE2, 1},
 +              Counter{cSubRespFromE2, 1},
 +              Counter{cSubFailFromE2, 1},
 +              Counter{cRestSubFailNotifToXapp, 1},
 +              Counter{cRestSubDelReqFromXapp, 1},
 +              Counter{cRestSubDelRespToXapp, 1},
 +              Counter{cSubDelReqToE2, 1},
 +              Counter{cSubDelRespFromE2, 1},
 +      })
 +
        const subReqCount int = 1
  
        // Req
  
        crereq, cremsg := e2termConn1.RecvSubsReq(t)
  
 -      // Unknown instanceId in this response which will result resending original request
 +      // Unknown instanceId in this response which will result resending original request
        orgInstanceId := crereq.RequestId.InstanceId
        crereq.RequestId.InstanceId = 0
        e2termConn1.SendSubsResp(t, crereq, cremsg)
  
        xappConn1.ExpectRESTNotificationNok(t, restSubId, "allFail")
  
 -      // Subscription already created in E2 Node.
 +      // Subscription already created in E2 Node. E2 Node responds with failure but there is also same unknown instanceId 0
        fparams := &teststube2ap.E2StubSubsFailParams{}
        fparams.Set(crereq)
        fparams.SetCauseVal(0, 1, 3) // CauseRIC / duplicate-action
        e2termConn1.TestMsgChanEmpty(t)
        mainCtrl.wait_registry_empty(t, 10)
        mainCtrl.VerifyAllClean(t)
 +      mainCtrl.VerifyCounterValues(t)
  }
  
  //-----------------------------------------------------------------------------
  //     |                 |------------->|
  //     |                 |              |
  //     |                 |      SubResp | No transaction for the response
 -//     |                 |<-------------|
 +//     |                 |<-------------| Ongoing transaction not found. This will result timer expiry and resending
  //     |                 |              |
  //     |                 | SubReq       |
  //     |                 |------------->|
  //     |                 |              |
  //     |                 |      SubFail | Duplicated action
 -//     |                 |<-------------|
 +//     |                 |<-------------|Ongoing transaction not found. This will result timer expiry and sending delete
  //     | RESTNotif (fail)|              |
  //     |<----------------|              |
  //     |                 | SubDelReq    |
  //     |                 |------------->|
  //     |                 |              |
  //     |                 |   SubDelResp |
 -//     |                 |<-------------|
 +//     |                 |<-------------| Ongoing transaction not found. This will result timer expiry and resending
  //     |                 |              |
  //     |                 | SubDelReq    |
  //     |                 |------------->|
  //     |                 |              |
  //     |                 |   SubDelResp |
 -//     |                 |<-------------|
 +//     |                 |<-------------| Ongoing transaction not found.
 +//     |                 |              |
 +//     |           [SUBS DELETE]        |
 +//     |                 |              |
  //
  //-----------------------------------------------------------------------------
  func TestRESTUnpackSubscriptionResponseNoTransaction(t *testing.T) {
        xapp.Logger.Debug("TEST: TestRESTUnpackSubscriptionResponseNoTransaction")
 +
 +      mainCtrl.CounterValuesToBeVeriefied(t, CountersToBeAdded{
 +              Counter{cRestSubReqFromXapp, 1},
 +              Counter{cRestSubRespToXapp, 1},
 +              Counter{cSubReqToE2, 1},
 +              Counter{cSubReqTimerExpiry, 2},
 +              Counter{cSubReReqToE2, 1},
 +              Counter{cSubRespFromE2, 1},
 +              Counter{cSubFailFromE2, 1},
 +              Counter{cRestSubFailNotifToXapp, 1},
 +              Counter{cRestSubDelReqFromXapp, 1},
 +              Counter{cRestSubDelRespToXapp, 1},
 +              Counter{cSubDelReqToE2, 1},
 +              Counter{cSubDelReqTimerExpiry, 2},
 +              Counter{cSubDelReReqToE2, 1},
 +              Counter{cSubDelRespFromE2, 2},
 +      })
 +
        const subReqCount int = 1
  
        // Req
        e2termConn1.TestMsgChanEmpty(t)
        mainCtrl.wait_registry_empty(t, 10)
        mainCtrl.VerifyAllClean(t)
 +      mainCtrl.VerifyCounterValues(t)
  }
  
  //-----------------------------------------------------------------------------
  //     |                 |------------->|
  //     |                 |              |
  //     |                 |      SubFail | ASN.1 decode fails
 -//     |                 |<-------------|
 +//     |                 |<-------------| Decode failed. More data needed. This will result timer expiry and resending
  //     |                 |              |
  //     |                 | SubReq       |
  //     |                 |------------->|
  //     | RESTNotif (fail)|              |
  //     |<----------------|              |
  //     |                 |              |
 +//     |           [SUBS DELETE]        |
 +//     |                 |              |
  //
  //-----------------------------------------------------------------------------
  func TestRESTUnpackSubscriptionFailureDecodeFail(t *testing.T) {
        xapp.Logger.Debug("TEST: TestRESTUnpackSubscriptionFailureDecodeFail")
 +
 +      mainCtrl.CounterValuesToBeVeriefied(t, CountersToBeAdded{
 +              Counter{cRestSubReqFromXapp, 1},
 +              Counter{cRestSubRespToXapp, 1},
 +              Counter{cSubReqToE2, 1},
 +              Counter{cSubReqTimerExpiry, 1},
 +              Counter{cSubReReqToE2, 1},
 +              Counter{cSubFailFromE2, 2},
 +              Counter{cRestSubFailNotifToXapp, 1},
 +              Counter{cRestSubDelReqFromXapp, 1},
 +              Counter{cRestSubDelRespToXapp, 1},
 +      })
 +
        const subReqCount int = 1
  
        // Req
        e2termConn1.TestMsgChanEmpty(t)
        mainCtrl.wait_registry_empty(t, 10)
        mainCtrl.VerifyAllClean(t)
 +      mainCtrl.VerifyCounterValues(t)
  }
  
  //-----------------------------------------------------------------------------
  //     |                 |------------->|
  //     |                 |              |
  //     |                 |      SubFail | Unknown instanceId
 -//     |                 |<-------------|
 +//     |                 |<-------------| No valid subscription found with subIds [0]. This will result timer expiry and resending
  //     |                 |              |
  //     |                 | SubReq       |
  //     |                 |------------->|
  //     |                 |              |
  //     |                 |      SubFail | Duplicated action
 -//     |                 |<-------------|
 +//     |                 |<-------------|No valid subscription found with subIds [0]. This will result timer expiry and sending delete
  //     | RESTNotif (fail)|              |
  //     |<----------------|              |
  //     |                 | SubDelReq    |
  //     |                 |              |
  //     |                 |   SubDelResp |
  //     |                 |<-------------|
 +//     |                 |              |
 +//     |           [SUBS DELETE]        |
 +//     |                 |              |
  //
  //-----------------------------------------------------------------------------
  func TestRESTUnpackSubscriptionFailureUnknownInstanceId(t *testing.T) {
        xapp.Logger.Debug("TEST: TestRESTUnpackSubscriptionFailureUnknownInstanceId")
        const subReqCount int = 1
  
 +      mainCtrl.CounterValuesToBeVeriefied(t, CountersToBeAdded{
 +              Counter{cRestSubReqFromXapp, 1},
 +              Counter{cRestSubRespToXapp, 1},
 +              Counter{cSubReqToE2, 1},
 +              Counter{cSubReqTimerExpiry, 2},
 +              Counter{cSubReReqToE2, 1},
 +              Counter{cSubFailFromE2, 2},
 +              Counter{cRestSubFailNotifToXapp, 1},
 +              Counter{cRestSubDelReqFromXapp, 1},
 +              Counter{cRestSubDelRespToXapp, 1},
 +              Counter{cSubDelReqToE2, 1},
 +              Counter{cSubDelRespFromE2, 1},
 +      })
 +
        // Req
        params := xappConn1.GetRESTSubsReqReportParams(subReqCount)
        restSubId := xappConn1.SendRESTSubsReq(t, params)
  
        crereq, cremsg := e2termConn1.RecvSubsReq(t)
  
 -      // Unknown instanceId in this response which will result resending original request
 +      // Unknown instanceId in this response which will result resending original request
        fparams := &teststube2ap.E2StubSubsFailParams{}
        fparams.Set(crereq)
        fparams.Fail.RequestId.InstanceId = 0
  
        xappConn1.ExpectRESTNotificationNok(t, restSubId, "allFail")
  
 -      // Subscription already created in E2 Node.
 +      // Subscription already created in E2 Node. E2 Node responds with failure but there is also same unknown instanceId 0
        fparams.SetCauseVal(0, 1, 3) // CauseRIC / duplicate-action
        e2termConn1.SendSubsFail(t, fparams, cremsg)
  
        e2termConn1.TestMsgChanEmpty(t)
        mainCtrl.wait_registry_empty(t, 10)
        mainCtrl.VerifyAllClean(t)
 +      mainCtrl.VerifyCounterValues(t)
  }
  
  //-----------------------------------------------------------------------------
  //     |                 |------------->|
  //     |                 |              |
  //     |                 |      SubFail | No transaction for the response
 -//     |                 |<-------------|
 +//     |                 |<-------------| Ongoing transaction not found. This will result timer expiry and resending
  //     |                 |              |
  //     |                 | SubReq       |
  //     |                 |------------->|
  //     |                 |              |
  //     |                 |      SubFail | Duplicated action
 -//     |                 |<-------------|
 +//     |                 |<-------------| Ongoing transaction not found. This will result timer expiry and sending delete
  //     | RESTNotif (fail)|              |
  //     |<----------------|              |
  //     |                 | SubDelReq    |
  //     |                 |------------->|
  //     |                 |              |
  //     |                 |   SubDelResp |
 -//     |                 |<-------------|
 +//     |                 |<-------------| Ongoing transaction not found. This will result timer expiry and resending
 +//     |                 |              |
 +//     |                 | SubDelReq    |
 +//     |                 |------------->|
 +//     |                 |              |
 +//     |                 |   SubDelResp |
 +//     |                 |<-------------| Ongoing transaction not found.
 +//     |                 |              |
 +//     |           [SUBS DELETE]        |
 +//     |                 |              |
  //
  //-----------------------------------------------------------------------------
  func TestRESTUnpackSubscriptionFailureNoTransaction(t *testing.T) {
        xapp.Logger.Debug("TEST: TestRESTUnpackSubscriptionFailureNoTransaction")
        const subReqCount int = 1
  
 +      mainCtrl.CounterValuesToBeVeriefied(t, CountersToBeAdded{
 +              Counter{cRestSubReqFromXapp, 1},
 +              Counter{cRestSubRespToXapp, 1},
 +              Counter{cSubReqToE2, 1},
 +              Counter{cSubReqTimerExpiry, 2},
 +              Counter{cSubReReqToE2, 1},
 +              Counter{cSubFailFromE2, 2},
 +              Counter{cRestSubFailNotifToXapp, 1},
 +              Counter{cRestSubDelReqFromXapp, 1},
 +              Counter{cRestSubDelRespToXapp, 1},
 +              Counter{cSubDelReqToE2, 1},
 +              Counter{cSubDelReqTimerExpiry, 2},
 +              Counter{cSubDelReReqToE2, 1},
 +              Counter{cSubDelRespFromE2, 2},
 +      })
 +
        // Req
        params := xappConn1.GetRESTSubsReqReportParams(subReqCount)
        restSubId := xappConn1.SendRESTSubsReq(t, params)
        e2termConn1.TestMsgChanEmpty(t)
        mainCtrl.wait_registry_empty(t, 10)
        mainCtrl.VerifyAllClean(t)
 +      mainCtrl.VerifyCounterValues(t)
  }
  
  //-----------------------------------------------------------------------------
  //     |                 | SubDelReq    |
  //     |                 |------------->|
  //     |                 |              |
 -//     |                 |   SubDelResp | ASN.1 decode fails
 -//     |                 |<-------------|
 +//     |                 |   SubDelResp | ASN.1 decode fails.
 +//     |                 |<-------------| Decode failed. More data needed. This will result timer expiry and resending
  //     |                 |              |
  //     |                 | SubDelReq    |
  //     |                 |------------->|
  //     |                 |              |
 -//     |                 |   SubDelFail | Subscription does exist any more
 +//     |                 |   SubDelFail | Subscription does exist any more in E2 node
  //     |                 |<-------------|
  //     |                 |              |
 +//     |           [SUBS DELETE]        |
 +//     |                 |              |
  //
  //-----------------------------------------------------------------------------
  func TestRESTUnpackSubscriptionDeleteResponseDecodeFail(t *testing.T) {
        xapp.Logger.Debug("TEST: TestRESTUnpackSubscriptionDeleteResponseDecodeFail")
  
 +      mainCtrl.CounterValuesToBeVeriefied(t, CountersToBeAdded{
 +              Counter{cRestSubReqFromXapp, 1},
 +              Counter{cRestSubRespToXapp, 1},
 +              Counter{cSubReqToE2, 1},
 +              Counter{cSubRespFromE2, 1},
 +              Counter{cRestSubNotifToXapp, 1},
 +              Counter{cRestSubDelReqFromXapp, 1},
 +              Counter{cRestSubDelRespToXapp, 1},
 +              Counter{cSubDelReqToE2, 1},
 +              Counter{cSubDelReqTimerExpiry, 1},
 +              Counter{cSubDelReReqToE2, 1},
 +              Counter{cSubDelFailFromE2, 1},
 +              Counter{cSubDelRespFromE2, 1},
 +      })
 +
        // Req
        var params *teststube2ap.RESTSubsReqParams = nil
        restSubId, e2SubsId := createSubscription(t, xappConn1, e2termConn1, params)
        delreq, delmsg := e2termConn1.RecvSubsDelReq(t)
  
        // Decode of this response fails which will result resending original request
 -      e2termConn1.SendInvalidE2Asn1Resp(t, delmsg, xapp.RIC_SUB_DEL_REQ)
 +      e2termConn1.SendInvalidE2Asn1Resp(t, delmsg, xapp.RIC_SUB_DEL_RESP)
  
        // E2t: Receive 2nd SubsDelReq and send SubsDelResp
        delreq, delmsg = e2termConn1.RecvSubsDelReq(t)
        e2termConn1.TestMsgChanEmpty(t)
        mainCtrl.wait_registry_empty(t, 10)
        mainCtrl.VerifyAllClean(t)
 +      mainCtrl.VerifyCounterValues(t)
  }
  
  //-----------------------------------------------------------------------------
  //     |                 |------------->|
  //     |                 |              |
  //     |                 |   SubDelResp | Unknown instanceId
 -//     |                 |<-------------|
 +//     |                 |<-------------| No valid subscription found with subIds [0]. This will result timer expiry and resending
  //     |                 |              |
  //     |                 | SubDelReq    |
  //     |                 |------------->|
  //     |                 |              |
 -//     |                 |   SubDelFail | Subscription does exist any more
 +//     |                 |   SubDelFail | Subscription does exist any more in E2 node
  //     |                 |<-------------|
 -//
 +//     |                 |              |
 +//     |           [SUBS DELETE]        |
 +//     |                 |              |
  //-----------------------------------------------------------------------------
  func TestRESTUnpackSubscriptionDeleteResponseUnknownInstanceId(t *testing.T) {
        xapp.Logger.Debug("TEST: TestRESTUnpackSubscriptionDeleteResponseUnknownInstanceId")
  
 +      mainCtrl.CounterValuesToBeVeriefied(t, CountersToBeAdded{
 +              Counter{cRestSubReqFromXapp, 1},
 +              Counter{cRestSubRespToXapp, 1},
 +              Counter{cSubReqToE2, 1},
 +              Counter{cSubRespFromE2, 1},
 +              Counter{cRestSubNotifToXapp, 1},
 +              Counter{cRestSubDelReqFromXapp, 1},
 +              Counter{cRestSubDelRespToXapp, 1},
 +              Counter{cSubDelReqToE2, 1},
 +              Counter{cSubDelReqTimerExpiry, 1},
 +              Counter{cSubDelReReqToE2, 1},
 +              Counter{cSubDelRespFromE2, 1},
 +              Counter{cSubDelFailFromE2, 1},
 +      })
 +
        // Req
        var params *teststube2ap.RESTSubsReqParams = nil
        restSubId, e2SubsId := createSubscription(t, xappConn1, e2termConn1, params)
        e2termConn1.TestMsgChanEmpty(t)
        mainCtrl.wait_registry_empty(t, 10)
        mainCtrl.VerifyAllClean(t)
 +      mainCtrl.VerifyCounterValues(t)
  }
  
  //-----------------------------------------------------------------------------
  //     |                 |------------->|
  //     |                 |              |
  //     |                 |   SubDelResp | No transaction for the response
 -//     |                 |<-------------|
 +//     |                 |<-------------| Ongoing transaction not found. This will result timer expiry and resending
  //     |                 |              |
  //     |                 | SubDelReq    |
  //     |                 |------------->|
  //     |                 |              |
 -//     |                 |   SubDelFail | Subscription does exist any more
 -//     |                 |<-------------|
 -//
 +//     |                 |   SubDelFail | Subscription does exist any more in E2 node
 +//     |                 |<-------------| Ongoing transaction not found. This will result timer expiry
 +//     |                 |              |
 +//     |           [SUBS DELETE]        |
 +//     |                 |              |
  //-----------------------------------------------------------------------------
  func TestRESTUnpackSubscriptionDeleteResponseNoTransaction(t *testing.T) {
        xapp.Logger.Debug("TEST: TestRESTUnpackSubscriptionDeleteResponseNoTransaction")
  
 +      mainCtrl.CounterValuesToBeVeriefied(t, CountersToBeAdded{
 +              Counter{cRestSubReqFromXapp, 1},
 +              Counter{cRestSubRespToXapp, 1},
 +              Counter{cSubReqToE2, 1},
 +              Counter{cSubRespFromE2, 1},
 +              Counter{cRestSubNotifToXapp, 1},
 +              Counter{cRestSubDelReqFromXapp, 1},
 +              Counter{cRestSubDelRespToXapp, 1},
 +              Counter{cSubDelReqToE2, 1},
 +              Counter{cSubDelReqTimerExpiry, 2},
 +              Counter{cSubDelReReqToE2, 1},
 +              Counter{cSubDelRespFromE2, 1},
 +              Counter{cSubDelFailFromE2, 1},
 +      })
 +
        // Req
        var params *teststube2ap.RESTSubsReqParams = nil
        restSubId, e2SubsId := createSubscription(t, xappConn1, e2termConn1, params)
        e2termConn1.TestMsgChanEmpty(t)
        mainCtrl.wait_registry_empty(t, 10)
        mainCtrl.VerifyAllClean(t)
 +      mainCtrl.VerifyCounterValues(t)
  }
  
  //-----------------------------------------------------------------------------
  //     |                 |------------->|
  //     |                 |              |
  //     |                 |   SubDelFail | ASN.1 decode fails
 -//     |                 |<-------------|
 +//     |                 |<-------------| Decode failed. More data needed. This will result timer expiry and resending
  //     |                 |              |
  //     |                 | SubDelReq    |
  //     |                 |------------->|
  //     |                 |              |
 -//     |                 |   SubDelFail | Subscription does exist any more
 +//     |                 |   SubDelFail | Subscription does exist any more in E2 node
  //     |                 |<-------------|
 -//
 +//     |                 |              |
 +//     |           [SUBS DELETE]        |
 +//     |                 |              |
  //-----------------------------------------------------------------------------
  func TestRESTUnpackSubscriptionDeleteFailureDecodeFail(t *testing.T) {
        xapp.Logger.Debug("TEST: TestRESTUnpackSubscriptionDeleteFailureDecodeFail")
  
 +      mainCtrl.CounterValuesToBeVeriefied(t, CountersToBeAdded{
 +              Counter{cRestSubReqFromXapp, 1},
 +              Counter{cRestSubRespToXapp, 1},
 +              Counter{cSubReqToE2, 1},
 +              Counter{cSubRespFromE2, 1},
 +              Counter{cRestSubNotifToXapp, 1},
 +              Counter{cRestSubDelReqFromXapp, 1},
 +              Counter{cRestSubDelRespToXapp, 1},
 +              Counter{cSubDelReqToE2, 1},
 +              Counter{cSubDelReqTimerExpiry, 1},
 +              Counter{cSubDelReReqToE2, 1},
 +              Counter{cSubDelFailFromE2, 2},
 +      })
 +
        // Req
        var params *teststube2ap.RESTSubsReqParams = nil
        restSubId, e2SubsId := createSubscription(t, xappConn1, e2termConn1, params)
        e2termConn1.TestMsgChanEmpty(t)
        mainCtrl.wait_registry_empty(t, 10)
        mainCtrl.VerifyAllClean(t)
 +      mainCtrl.VerifyCounterValues(t)
  }
  
  //-----------------------------------------------------------------------------
  //     |                 |------------->|
  //     |                 |              |
  //     |                 |   SubDelFail | Unknown instanceId
 -//     |                 |<-------------|
 +//     |                 |<-------------| No valid subscription found with subIds [0]. This will result timer expiry and resending
  //     |                 |              |
  //     |                 | SubDelReq    |
  //     |                 |------------->|
  //     |                 |              |
 -//     |                 |   SubDelFail | Subscription does exist any more
 -//     |                 |<-------------|
 -//
 +//     |                 |   SubDelFail | Subscription does exist any more in E2 node
 +//     |                 |<-------------| No valid subscription found with subIds [0].
 +//     |                 |              |
 +//     |           [SUBS DELETE]        |
 +//     |                 |              |
  //-----------------------------------------------------------------------------
  func TestRESTUnpackSubscriptionDeleteailureUnknownInstanceId(t *testing.T) {
        xapp.Logger.Debug("TEST: TestRESTUnpackSubscriptionDeleteailureUnknownInstanceId")
  
 +      mainCtrl.CounterValuesToBeVeriefied(t, CountersToBeAdded{
 +              Counter{cRestSubReqFromXapp, 1},
 +              Counter{cRestSubRespToXapp, 1},
 +              Counter{cSubReqToE2, 1},
 +              Counter{cSubRespFromE2, 1},
 +              Counter{cRestSubNotifToXapp, 1},
 +              Counter{cRestSubDelReqFromXapp, 1},
 +              Counter{cRestSubDelRespToXapp, 1},
 +              Counter{cSubDelReqToE2, 1},
 +              Counter{cSubDelReqTimerExpiry, 1},
 +              Counter{cSubDelReReqToE2, 1},
 +              Counter{cSubDelFailFromE2, 2},
 +      })
 +
        // Req
        var params *teststube2ap.RESTSubsReqParams = nil
        restSubId, e2SubsId := createSubscription(t, xappConn1, e2termConn1, params)
        // E2t: Receive 1st SubsDelReq
        delreq, delmsg := e2termConn1.RecvSubsDelReq(t)
  
 -      // Unknown instanceId in this response which will result resending original request
 +      // Unknown instanceId in this response which will result resending original request
        delreq.RequestId.InstanceId = 0
        e2termConn1.SendSubsDelFail(t, delreq, delmsg)
  
        // E2t: Receive 2nd SubsDelReq
        delreq, delmsg = e2termConn1.RecvSubsDelReq(t)
  
 -      // Subscription does not exist in in E2 Node.
 +      // Subscription does not exist in in E2 Node. E2 Node responds with failure but there is also same unknown instanceId 0
        e2termConn1.SendSubsDelFail(t, delreq, delmsg)
  
        // Wait that subs is cleaned
        e2termConn1.TestMsgChanEmpty(t)
        mainCtrl.wait_registry_empty(t, 10)
        mainCtrl.VerifyAllClean(t)
 +      mainCtrl.VerifyCounterValues(t)
  }
  
  //-----------------------------------------------------------------------------
  //     |                 |------------->|
  //     |                 |              |
  //     |                 |   SubDelFail | No transaction for the response
 -//     |                 |<-------------|
 +//     |                 |<-------------| Ongoing transaction not found. This will result timer expiry and resending
  //     |                 |              |
  //     |                 | SubDelReq    |
  //     |                 |------------->|
  //     |                 |              |
 -//     |                 |   SubDelFail | Subscription does exist any more
 -//     |                 |<-------------|
 -//
 +//     |                 |   SubDelFail | Subscription does exist any more in E2 node
 +//     |                 |<-------------| Ongoing transaction not found. This will result timer expiry
 +//     |                 |              |
 +//     |           [SUBS DELETE]        |
 +//     |                 |              |
  //-----------------------------------------------------------------------------
  func TestRESTUnpackSubscriptionDeleteFailureNoTransaction(t *testing.T) {
        xapp.Logger.Debug("TEST: TestRESTUnpackSubscriptionDeleteFailureNoTransaction")
  
 +      mainCtrl.CounterValuesToBeVeriefied(t, CountersToBeAdded{
 +              Counter{cRestSubReqFromXapp, 1},
 +              Counter{cRestSubRespToXapp, 1},
 +              Counter{cSubReqToE2, 1},
 +              Counter{cSubRespFromE2, 1},
 +              Counter{cRestSubNotifToXapp, 1},
 +              Counter{cRestSubDelReqFromXapp, 1},
 +              Counter{cRestSubDelRespToXapp, 1},
 +              Counter{cSubDelReqToE2, 1},
 +              Counter{cSubDelReqTimerExpiry, 2},
 +              Counter{cSubDelReReqToE2, 1},
 +              Counter{cSubDelFailFromE2, 2},
 +      })
 +
        // Req
        var params *teststube2ap.RESTSubsReqParams = nil
        restSubId, e2SubsId := createSubscription(t, xappConn1, e2termConn1, params)
        e2termConn1.TestMsgChanEmpty(t)
        mainCtrl.wait_registry_empty(t, 10)
        mainCtrl.VerifyAllClean(t)
 +      mainCtrl.VerifyCounterValues(t)
  }
  
  //-----------------------------------------------------------------------------
@@@ -7114,8 -6871,8 +7120,8 @@@ func TestRESTSubReqFailAsn1PackSubReqEr
  
        // Wait that subs is cleaned
        waitSubsCleanup(t, e2SubsId, 10)
 -      mainCtrl.VerifyCounterValues(t)
        mainCtrl.VerifyAllClean(t)
 +      mainCtrl.VerifyCounterValues(t)
  }
  
  func TestRESTSubReqPolicyUpdateTimeoutAndSubDelOkSameAction(t *testing.T) {
        e2termConn1.SendSubsDelResp(t, delreq, delmsg)
  
        waitSubsCleanup(t, e2SubsId, 10)
 -
 -      mainCtrl.VerifyCounterValues(t)
        mainCtrl.VerifyAllClean(t)
 +      mainCtrl.VerifyCounterValues(t)
  }
  
  //-----------------------------------------------------------------------------