Fix create feature gruop 14/13814/2
authorsubhash kumar singh <subh.singh@samsung.com>
Thu, 5 Dec 2024 10:29:22 +0000 (10:29 +0000)
committersubhash kumar singh <subh.singh@samsung.com>
Mon, 9 Dec 2024 08:52:33 +0000 (08:52 +0000)
Return feature group on creation.
Also, include the pip package in tox.

Change-Id: I30787851817ba8517a798cda389b8dcafeaa32f2
Signed-off-by: subhash kumar singh <subh.singh@samsung.com>
tox.ini
trainingmgr/trainingmgr_main.py

diff --git a/tox.ini b/tox.ini
index 92d3a48..e3606f1 100644 (file)
--- a/tox.ini
+++ b/tox.ini
@@ -51,11 +51,7 @@ setenv = cd  = {toxinidir}/tests
 commands =
   pip3 install -e {toxinidir}
 
-  git clone "https://gerrit.o-ran-sc.org/r/aiml-fw/athp/sdk/feature-store" /tmp/fssdk/
-  git clone "https://gerrit.o-ran-sc.org/r/aiml-fw/athp/sdk/model-storage" /tmp/modelsdk/
-
-  pip3 install /tmp/fssdk/.
-  pip3 install /tmp/modelsdk/.
+  pip3 install featurestoresdk modelmetricsdk
   pytest --cov {toxinidir}/trainingmgr --cov-report xml --cov-report term-missing --cov-report html --cov-fail-under=10 --junitxml=/tmp/tests.xml
   coverage xml -i
 
index a38bfbf..aad71e3 100644 (file)
@@ -1244,7 +1244,7 @@ def create_feature_group():
         else:
             # the features are stored in string format in the db, and has to be passed as list of feature to the dme. Hence the conversion.
             add_featuregroup(featuregroup)
-            api_response={"result": "Feature Group Created"}
+            api_response = FeatureGroupSchema().dump(featuregroup)
             response_code =status.HTTP_200_OK
             if featuregroup.enable_dme == True :
                 response= create_dme_filtered_data_job(TRAININGMGR_CONFIG_OBJ, featuregroup)