Certain gcc versions will give (per my understanding false positive)
warning when 'EXPECT_EQ' macro is used so that other argument is
'true' or 'false'.
For example, Ubuntu 16.04 has by default such a gcc version.
See some related discussion below:
https://github.com/google/googletest/issues/322
We have defined all compiler warning to be treated as errors, thus
above issue will lead to compilation error.
Simple fix is to use 'EXPECT_TRUE' or 'EXPECT_FALSE' instead. Those are
more readable, and thus better choice anyway.
Signed-off-by: Rolf Badorek <rolf.badorek@nokia.com>
Change-Id: Ib0f3841c1b6fe2cf95eac3e4dc0cbcba9c3c8268
expectSetIfNotExistsAsync("key1", { 0x0a, 0x0b, 0x0c });
expectPollWait();
expectModifyIfAck(std::error_code(), true);
expectSetIfNotExistsAsync("key1", { 0x0a, 0x0b, 0x0c });
expectPollWait();
expectModifyIfAck(std::error_code(), true);
- EXPECT_EQ(true, syncStorage->setIfNotExists(ns, "key1", { 0x0a, 0x0b, 0x0c }));
+ EXPECT_TRUE(syncStorage->setIfNotExists(ns, "key1", { 0x0a, 0x0b, 0x0c }));
}
TEST_F(SyncStorageImplTest, SetIfNotExistsReturnsFalseIfKeyAlreadyExists)
}
TEST_F(SyncStorageImplTest, SetIfNotExistsReturnsFalseIfKeyAlreadyExists)
expectSetIfNotExistsAsync("key1", { 0x0a, 0x0b, 0x0c });
expectPollWait();
expectModifyIfAck(std::error_code(), false);
expectSetIfNotExistsAsync("key1", { 0x0a, 0x0b, 0x0c });
expectPollWait();
expectModifyIfAck(std::error_code(), false);
- EXPECT_EQ(false, syncStorage->setIfNotExists(ns, "key1", { 0x0a, 0x0b, 0x0c }));
+ EXPECT_FALSE(syncStorage->setIfNotExists(ns, "key1", { 0x0a, 0x0b, 0x0c }));
}
TEST_F(SyncStorageImplTest, SetIfNotExistsCanThrowBackendError)
}
TEST_F(SyncStorageImplTest, SetIfNotExistsCanThrowBackendError)
expectRemoveIfAsync("key1", { 0x0a, 0x0b, 0x0c });
expectPollWait();
expectModifyIfAck(std::error_code(), true);
expectRemoveIfAsync("key1", { 0x0a, 0x0b, 0x0c });
expectPollWait();
expectModifyIfAck(std::error_code(), true);
- EXPECT_EQ(true, syncStorage->removeIf(ns, "key1", { 0x0a, 0x0b, 0x0c }));
+ EXPECT_TRUE(syncStorage->removeIf(ns, "key1", { 0x0a, 0x0b, 0x0c }));
}
TEST_F(SyncStorageImplTest, RemoveIfReturnsFalseIfKeyDoesnotMatch)
}
TEST_F(SyncStorageImplTest, RemoveIfReturnsFalseIfKeyDoesnotMatch)
expectRemoveIfAsync("key1", { 0x0a, 0x0b, 0x0c });
expectPollWait();
expectModifyIfAck(std::error_code(), false);
expectRemoveIfAsync("key1", { 0x0a, 0x0b, 0x0c });
expectPollWait();
expectModifyIfAck(std::error_code(), false);
- EXPECT_EQ(false, syncStorage->removeIf(ns, "key1", { 0x0a, 0x0b, 0x0c }));
+ EXPECT_FALSE(syncStorage->removeIf(ns, "key1", { 0x0a, 0x0b, 0x0c }));
}
TEST_F(SyncStorageImplTest, RemoveIfCanThrowBackendError)
}
TEST_F(SyncStorageImplTest, RemoveIfCanThrowBackendError)