+/*
+ * ============LICENSE_START======================================================================
+ * Copyright (C) 2024 OpenInfra Foundation Europe. All rights reserved.
+ * ===============================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END========================================================================
+ *
+ */
+
+package com.oransc.rappmanager.models.csar.validator;
+
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.doCallRealMethod;
+import static org.mockito.Mockito.doReturn;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.oransc.rappmanager.models.BeanTestConfiguration;
+import com.oransc.rappmanager.models.cache.RappCacheService;
+import com.oransc.rappmanager.models.csar.AsdMetadata;
+import com.oransc.rappmanager.models.csar.RappCsarConfigurationHandler;
+import com.oransc.rappmanager.models.exception.RappValidationException;
+import com.oransc.rappmanager.models.rapp.Rapp;
+import java.io.ByteArrayOutputStream;
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.IOException;
+import java.util.UUID;
+import org.apache.http.entity.ContentType;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.NullSource;
+import org.junit.jupiter.params.provider.ValueSource;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.test.context.SpringBootTest;
+import org.springframework.boot.test.mock.mockito.SpyBean;
+import org.springframework.cache.CacheManager;
+import org.springframework.http.HttpStatus;
+import org.springframework.mock.web.MockMultipartFile;
+import org.springframework.test.context.ContextConfiguration;
+import org.springframework.web.multipart.MultipartFile;
+
+@SpringBootTest
+@ContextConfiguration(classes = {BeanTestConfiguration.class, AsdDescriptorValidator.class, RappValidationUtils.class,
+ ObjectMapper.class, RappCsarConfigurationHandler.class, RappCacheService.class, CacheManager.class})
+class AsdDescriptorValidatorTest {
+
+ @Autowired
+ AsdDescriptorValidator asdDescriptorValidator;
+ @SpyBean
+ RappValidationUtils rappValidationUtils;
+ @Autowired
+ RappCacheService rappCacheService;
+
+ String validCsarFileLocation = "src/test/resources/";
+ String validRappFile = "valid-rapp-package.csar";
+ String invalidRappAsdEmptyFile = "invalid-rapp-package-empty-asd-yaml.csar";
+
+ @Test
+ void testCsarContainsValidAsdFile() throws IOException {
+ String rappCsarPath = validCsarFileLocation + File.separator + validRappFile;
+ MultipartFile multipartFile =
+ new MockMultipartFile(rappCsarPath, rappCsarPath, ContentType.MULTIPART_FORM_DATA.getMimeType(),
+ new FileInputStream(rappCsarPath));
+ assertDoesNotThrow(() -> asdDescriptorValidator.validate(multipartFile, null));
+ }
+
+ @Test
+ void testCsarContainsDuplicateDescriptorId() throws IOException {
+ String rappCsarPath = validCsarFileLocation + File.separator + validRappFile;
+ AsdMetadata asdMetadata = new AsdMetadata();
+ asdMetadata.setDescriptorId("123e4567-e89b-12d3-a456-426614174000");
+ asdMetadata.setDescriptorInvariantId(UUID.randomUUID().toString());
+ Rapp rapp = Rapp.builder().name("").asdMetadata(asdMetadata).build();
+ rappCacheService.putRapp(rapp);
+ MultipartFile multipartFile =
+ new MockMultipartFile(rappCsarPath, rappCsarPath, ContentType.MULTIPART_FORM_DATA.getMimeType(),
+ new FileInputStream(rappCsarPath));
+ RappValidationException exception =
+ assertThrows(RappValidationException.class, () -> asdDescriptorValidator.validate(multipartFile, null));
+ assertEquals(HttpStatus.BAD_REQUEST, exception.getStatusCode());
+ assertEquals("ASD descriptor already exists.", exception.getMessage());
+ rappCacheService.deleteRapp(rapp);
+ }
+
+ @Test
+ void testCsarContainsDuplicateDescriptorInvariantId() throws IOException {
+ String rappCsarPath = validCsarFileLocation + File.separator + validRappFile;
+ AsdMetadata asdMetadata = new AsdMetadata();
+ asdMetadata.setDescriptorId("");
+ asdMetadata.setDescriptorInvariantId("040eff2a-eb1a-4aff-bd46-37ce38092985");
+ Rapp rapp = Rapp.builder().name("").asdMetadata(asdMetadata).build();
+ rappCacheService.putRapp(rapp);
+ MultipartFile multipartFile =
+ new MockMultipartFile(rappCsarPath, rappCsarPath, ContentType.MULTIPART_FORM_DATA.getMimeType(),
+ new FileInputStream(rappCsarPath));
+ RappValidationException exception =
+ assertThrows(RappValidationException.class, () -> asdDescriptorValidator.validate(multipartFile, null));
+ assertEquals(HttpStatus.BAD_REQUEST, exception.getStatusCode());
+ assertEquals("ASD descriptor invariant already exists.", exception.getMessage());
+ rappCacheService.deleteRapp(rapp);
+ }
+
+ @Test
+ void testCsarContainsValidAsdFileFailure() throws IOException {
+ String rappCsarPath = validCsarFileLocation + File.separator + invalidRappAsdEmptyFile;
+ MultipartFile multipartFile =
+ new MockMultipartFile(rappCsarPath, rappCsarPath, ContentType.MULTIPART_FORM_DATA.getMimeType(),
+ new FileInputStream(rappCsarPath));
+ RappValidationException exception =
+ assertThrows(RappValidationException.class, () -> asdDescriptorValidator.validate(multipartFile, null));
+ assertEquals(HttpStatus.BAD_REQUEST, exception.getStatusCode());
+ assertEquals("ASD definition in rApp package is invalid.", exception.getMessage());
+ }
+
+ @ParameterizedTest
+ @NullSource
+ @ValueSource(strings = {""})
+ void testCsarAsdLocationNullFailure(String asdLocation) throws IOException {
+ String rappCsarPath = validCsarFileLocation + File.separator + invalidRappAsdEmptyFile;
+ MultipartFile multipartFile =
+ new MockMultipartFile(rappCsarPath, rappCsarPath, ContentType.MULTIPART_FORM_DATA.getMimeType(),
+ new FileInputStream(rappCsarPath));
+ doReturn(asdLocation).when(rappValidationUtils).getAsdDefinitionLocation(any());
+ RappValidationException exception =
+ assertThrows(RappValidationException.class, () -> asdDescriptorValidator.validate(multipartFile, null));
+ assertEquals(HttpStatus.BAD_REQUEST, exception.getStatusCode());
+ assertEquals("ASD definition in rApp package is invalid.", exception.getMessage());
+ }
+
+ @ParameterizedTest
+ @NullSource
+ @ValueSource(strings = {"", "{asasdasd"})
+ void testCsarAsdContentInvalidFailure(String asdContent) throws IOException {
+ String rappCsarPath = validCsarFileLocation + File.separator + validRappFile;
+ MultipartFile multipartFile =
+ new MockMultipartFile(rappCsarPath, rappCsarPath, ContentType.MULTIPART_FORM_DATA.getMimeType(),
+ new FileInputStream(rappCsarPath));
+ if (asdContent != null) {
+ ByteArrayOutputStream byteArrayOutputStream = new ByteArrayOutputStream();
+ byteArrayOutputStream.write(asdContent.getBytes(), 0, asdContent.getBytes().length);
+ doCallRealMethod().doReturn(byteArrayOutputStream).when(rappValidationUtils)
+ .getFileFromCsar(any(MultipartFile.class), any());
+ } else {
+ doCallRealMethod().doReturn(asdContent).when(rappValidationUtils)
+ .getFileFromCsar(any(MultipartFile.class), any());
+ }
+ RappValidationException exception =
+ assertThrows(RappValidationException.class, () -> asdDescriptorValidator.validate(multipartFile, null));
+ assertEquals(HttpStatus.BAD_REQUEST, exception.getStatusCode());
+ assertEquals("ASD definition in rApp package is invalid.", exception.getMessage());
+ }
+}
Code Review / nonrtric / plt / rappmanager.git / commitdiff