gerrit.o-ran-sc Code Review - ric-app/mc.git/commit

author	E. Scott Daniels <daniels@research.att.com>
	Mon, 24 Aug 2020 18:29:04 +0000 (14:29 -0400)
committer	E. Scott Daniels <daniels@research.att.com>
	Tue, 25 Aug 2020 11:46:57 +0000 (07:46 -0400)
commit	216e43c47dc133f10f095f78dad1ac8b8c1a55f9
tree	8c7b64732d0b42bf6960e5d1706df5e4cff38443	tree \| snapshot
parent	ee54f8a6949329913d30e638593ed8e3cc515575	commit \| diff

Cleanup listener based on sonar grumblings

This change attempts to address the bugs and smells in the listener.
A fair few of the "bugs" were unit test coverage related (passing a
nil pointer) and to avoid those the test code was moved into a new
test directory, but it might need to be overtly excluded inthe
CI setup. The other bugs were addressed.

Issue-ID: RIC-632

Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: Ifbc9234e4408db3cb7111dc4a4ad9e9e268341c9

12 files changed:

CMakeLists.txt		diff \| blob \| history
sidecars/listener/Dockerfile		diff \| blob \| history
sidecars/listener/Makefile		diff \| blob \| history
sidecars/listener/mcl.c		diff \| blob \| history
sidecars/listener/mcl.h		diff \| blob \| history
sidecars/listener/rdc.c		diff \| blob \| history
sidecars/listener/test/Makefile	[new file with mode: 0644]	blob
sidecars/listener/test/discount_chk.ksh	[moved from sidecars/listener/discount_chk.ksh with 100% similarity]	blob \| history
sidecars/listener/test/run_unit_test.ksh	[moved from sidecars/listener/run_unit_test.ksh with 95% similarity]	diff \| blob \| history
sidecars/listener/test/show_coverage.ksh	[moved from sidecars/listener/show_coverage.ksh with 100% similarity]	blob \| history
sidecars/listener/test/test_rmr_em.c	[moved from sidecars/listener/test_rmr_em.c with 100% similarity]	blob \| history
sidecars/listener/test/unit_test.c	[moved from sidecars/listener/unit_test.c with 97% similarity]	diff \| blob \| history

RSS Atom