X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;f=webapp-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Foransc%2Fportal%2Fnonrtric%2Fcontrolpanel%2Fcontroller%2FEnrichmentController.java;h=297f5bc73a0a9294ee184ab3086c73c92b4ba90b;hb=5840fd8fc16980ade4af6735f991e08f8fca65e7;hp=57019cead728f76f2c67a4e5fb5af8df8bd29c23;hpb=714fa4fa439de489c7ddec02a46ac8d2543ec7f2;p=portal%2Fnonrtric-controlpanel.git diff --git a/webapp-backend/src/main/java/org/oransc/portal/nonrtric/controlpanel/controller/EnrichmentController.java b/webapp-backend/src/main/java/org/oransc/portal/nonrtric/controlpanel/controller/EnrichmentController.java index 57019ce..297f5bc 100644 --- a/webapp-backend/src/main/java/org/oransc/portal/nonrtric/controlpanel/controller/EnrichmentController.java +++ b/webapp-backend/src/main/java/org/oransc/portal/nonrtric/controlpanel/controller/EnrichmentController.java @@ -34,6 +34,9 @@ import org.oransc.portal.nonrtric.controlpanel.ControlPanelConstants; import org.oransc.portal.nonrtric.controlpanel.eiproducerapi.EiProducerApi; import org.oransc.portal.nonrtric.controlpanel.model.JobInfo; import org.oransc.portal.nonrtric.controlpanel.model.ProducerInfo; +import org.oransc.portal.nonrtric.controlpanel.model.ProducerRegistrationInfo; +import org.oransc.portal.nonrtric.controlpanel.model.ProducerRegistrationInfo.ProducerEiTypeRegistrationInfo; +import org.oransc.portal.nonrtric.controlpanel.model.ProducerStatusInfo; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.springframework.beans.factory.annotation.Autowired; @@ -59,8 +62,6 @@ public class EnrichmentController { private static final Logger logger = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); - private static com.google.gson.Gson gson = new GsonBuilder().create(); - // Publish paths in constants so tests are easy to write public static final String CONTROLLER_PATH = ControlPanelConstants.ENDPOINT_PREFIX + "/enrichment"; // Endpoints @@ -73,6 +74,7 @@ public class EnrichmentController { // Populated by the autowired constructor private final EiProducerApi eiProducerApi; + public static com.google.gson.Gson gson = new GsonBuilder().create(); @Autowired public EnrichmentController(final EiProducerApi eiProducerApi) { @@ -83,7 +85,7 @@ public class EnrichmentController { @ApiOperation(value = "Get the EI job definitions for one EI producer") @GetMapping(EI_JOBS) - public ResponseEntity> getEiJobs() { + public ResponseEntity getEiJobs() { logger.debug("getEiJobs"); ResponseEntity response = this.eiProducerApi.getAllEiProducerIds(); JsonArray bodyJson = JsonParser.parseString(response.getBody()).getAsJsonArray(); @@ -91,23 +93,18 @@ public class EnrichmentController { for (JsonElement producerId : bodyJson) { allJobs.addAll(getJobs(producerId)); } - return new ResponseEntity<>(allJobs, HttpStatus.OK); + return new ResponseEntity<>(gson.toJson(allJobs), HttpStatus.OK); } private List getJobs(JsonElement producerId) { - List jobs = new ArrayList<>(); - ResponseEntity jobsResponse = this.eiProducerApi.getEiJobsForOneEiProducer(producerId.getAsString()); - JsonArray jobsJson = JsonParser.parseString(jobsResponse.getBody()).getAsJsonArray(); - for (JsonElement jobJson : jobsJson) { - JobInfo jobInfo = gson.fromJson(jobJson, JobInfo.class); - jobs.add(jobInfo); - } - return jobs; + ResponseEntity> jobsResponse = + this.eiProducerApi.getEiJobsForOneEiProducer(producerId.getAsString()); + return jobsResponse.getBody(); } @ApiOperation(value = "Get EI producers") @GetMapping(EI_PRODUCERS) - public ResponseEntity> getEiProducers() { + public ResponseEntity getEiProducers() { logger.debug("getEiProducers"); ResponseEntity response = this.eiProducerApi.getAllEiProducerIds(); JsonArray bodyJson = JsonParser.parseString(response.getBody()).getAsJsonArray(); @@ -121,23 +118,22 @@ public class EnrichmentController { producers.add(producerInfo); } - return new ResponseEntity<>(producers, HttpStatus.OK); + return new ResponseEntity<>(gson.toJson(producers), HttpStatus.OK); } private String[] getSupportedTypes(JsonElement producerId) { - ResponseEntity producerResponse = this.eiProducerApi.getEiProducer(producerId.getAsString()); - JsonArray supportedTypesJson = JsonParser.parseString(producerResponse.getBody()).getAsJsonObject() - .get("supported_ei_types").getAsJsonArray(); + ResponseEntity producerResponse = + this.eiProducerApi.getEiProducer(producerId.getAsString()); List supportedTypes = new ArrayList<>(); - for (JsonElement typeJson : supportedTypesJson) { - supportedTypes.add(typeJson.getAsJsonObject().get("ei_type_identity").getAsString()); + for (ProducerEiTypeRegistrationInfo type : producerResponse.getBody().types) { + supportedTypes.add(type.eiTypeId); } return supportedTypes.toArray(new String[0]); } private String getProducerStatus(JsonElement producerId) { - ResponseEntity statusResponse = this.eiProducerApi.getEiProducerStatus(producerId.getAsString()); - return JsonParser.parseString(statusResponse.getBody()).getAsJsonObject().get("operational_state") - .getAsString(); + ResponseEntity statusResponse = + this.eiProducerApi.getEiProducerStatus(producerId.getAsString()); + return statusResponse.getBody().opState.toString(); } }