X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;f=test%2Fusecases%2Foruclosedlooprecovery%2Fgoversion%2Finternal%2Frepository%2Fcsvhelp_test.go;h=ddcc229bb4f407a6026b6b22008a8dff5f100c00;hb=f1cee0f81c6bc482f73182c8f4c903e8376381e8;hp=dfd29cc9811c3b8833b3d0691dfed9f238d017dd;hpb=856d55d6413fe66c05b42a3c5e98d0b0f20743e3;p=nonrtric.git diff --git a/test/usecases/oruclosedlooprecovery/goversion/internal/repository/csvhelp_test.go b/test/usecases/oruclosedlooprecovery/goversion/internal/repository/csvhelp_test.go index dfd29cc9..ddcc229b 100644 --- a/test/usecases/oruclosedlooprecovery/goversion/internal/repository/csvhelp_test.go +++ b/test/usecases/oruclosedlooprecovery/goversion/internal/repository/csvhelp_test.go @@ -22,52 +22,46 @@ package repository import ( "os" - "reflect" "testing" + + "github.com/stretchr/testify/require" ) func TestCsvFileHelperImpl_GetCsvFromFile(t *testing.T) { + assertions := require.New(t) filePath := createTempCsvFile() defer os.Remove(filePath) type args struct { name string } tests := []struct { - name string - fileHelper *CsvFileHelperImpl - args args - want [][]string - wantErr bool + name string + args args + want [][]string + wantErrString string }{ { - name: "Read from file should return array of content", - fileHelper: &CsvFileHelperImpl{}, + name: "Read from file should return array of content", args: args{ name: filePath, }, - want: [][]string{{"O-RU-ID", "O-DU-ID"}}, - wantErr: false, + want: [][]string{{"O-RU-ID", "O-DU-ID"}}, }, { - name: "File missing should return error", - fileHelper: &CsvFileHelperImpl{}, + name: "File missing should return error", args: args{ name: "nofile.csv", }, - want: nil, - wantErr: true, + wantErrString: "open nofile.csv: no such file or directory", }, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { - h := &CsvFileHelperImpl{} + h := NewCsvFileHelperImpl() got, err := h.GetCsvFromFile(tt.args.name) - if (err != nil) != tt.wantErr { - t.Errorf("CsvFileHelperImpl.GetCsvFromFile() error = %v, wantErr %v", err, tt.wantErr) - return - } - if !reflect.DeepEqual(got, tt.want) { - t.Errorf("CsvFileHelperImpl.GetCsvFromFile() = %v, want %v", got, tt.want) + assertions.Equal(tt.want, got) + if tt.wantErrString != "" { + assertions.Contains(err.Error(), tt.wantErrString) } }) }