X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;f=test%2Fusecases%2Foruclosedlooprecovery%2Fgoversion%2Finternal%2Flinkfailure%2Flinkfailurehandler.go;h=3aecf45cd69941b70277f8908c56aaaa4683fb99;hb=0f6367023720ecc7d7b4b38cbbc4282792172a89;hp=ebcf31253fc7a5100a360a75bd6c6f1c2c84ca85;hpb=856d55d6413fe66c05b42a3c5e98d0b0f20743e3;p=nonrtric.git

diff --git a/test/usecases/oruclosedlooprecovery/goversion/internal/linkfailure/linkfailurehandler.go b/test/usecases/oruclosedlooprecovery/goversion/internal/linkfailure/linkfailurehandler.go
index ebcf3125..3aecf45c 100644
--- a/test/usecases/oruclosedlooprecovery/goversion/internal/linkfailure/linkfailurehandler.go
+++ b/test/usecases/oruclosedlooprecovery/goversion/internal/linkfailure/linkfailurehandler.go
@@ -21,8 +21,6 @@
 package linkfailure
 
 import (
-	"encoding/json"
-	"io/ioutil"
 	"net/http"
 	"strings"
 
@@ -34,32 +32,31 @@ import (
 )
 
 type Configuration struct {
-	ConsumerAddress  string
-	InfoCoordAddress string
-	SDNRAddress      string
-	SDNRUser         string
-	SDNRPassword     string
+	SDNRAddress  string
+	SDNRUser     string
+	SDNRPassword string
 }
 
 const rawSdnrPath = "/rests/data/network-topology:network-topology/topology=topology-netconf/node=[O-DU-ID]/yang-ext:mount/o-ran-sc-du-hello-world:network-function/du-to-ru-connection=[O-RU-ID]"
-
 const unlockMessage = `{"o-ran-sc-du-hello-world:du-to-ru-connection": [{"name":"[O-RU-ID]","administrative-state":"UNLOCKED"}]}`
 
 type LinkFailureHandler struct {
 	lookupService repository.LookupService
 	config        Configuration
+	client        restclient.HTTPClient
 }
 
-func NewLinkFailureHandler(ls repository.LookupService, conf Configuration) *LinkFailureHandler {
+func NewLinkFailureHandler(ls repository.LookupService, conf Configuration, client restclient.HTTPClient) *LinkFailureHandler {
 	return &LinkFailureHandler{
 		lookupService: ls,
 		config:        conf,
+		client:        client,
 	}
 }
 
 func (lfh LinkFailureHandler) MessagesHandler(w http.ResponseWriter, r *http.Request) {
 	log.Debug("Handling messages")
-	if messages := lfh.getVesMessages(r); messages != nil {
+	if messages := ves.GetVesMessages(r.Body); messages != nil {
 		faultMessages := ves.GetFaultMessages(messages)
 
 		for _, message := range faultMessages {
@@ -76,13 +73,13 @@ func (lfh LinkFailureHandler) sendUnlockMessage(oRuId string) {
 	if oDuId, err := lfh.lookupService.GetODuID(oRuId); err == nil {
 		sdnrPath := getSdnrPath(oRuId, oDuId)
 		unlockMessage := lfh.getUnlockMessage(oRuId)
-		if error := restclient.Put(lfh.config.SDNRAddress+sdnrPath, unlockMessage, lfh.config.SDNRUser, lfh.config.SDNRPassword); error == nil {
+		if error := restclient.Put(lfh.config.SDNRAddress+sdnrPath, unlockMessage, lfh.client, lfh.config.SDNRUser, lfh.config.SDNRPassword); error == nil {
 			log.Debugf("Sent unlock message for O-RU: %v to O-DU: %v.", oRuId, oDuId)
 		} else {
-			log.Warn(error)
+			log.Warn("Send of unlock message failed due to ", error)
 		}
 	} else {
-		log.Warn(err)
+		log.Warn("Send of unlock message failed due to ", err)
 	}
 
 }
@@ -96,18 +93,3 @@ func getSdnrPath(oRuId string, oDuId string) string {
 func (lfh LinkFailureHandler) getUnlockMessage(oRuId string) string {
 	return strings.Replace(unlockMessage, "[O-RU-ID]", oRuId, 1)
 }
-
-func (lfh LinkFailureHandler) getVesMessages(r *http.Request) *[]string {
-	var messages []string
-	body, err := ioutil.ReadAll(r.Body)
-	if err != nil {
-		log.Warn(err)
-		return nil
-	}
-	err = json.Unmarshal(body, &messages)
-	if err != nil {
-		log.Warn(err)
-		return nil
-	}
-	return &messages
-}