X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;f=src%2Frmr%2Fcommon%2Fsrc%2Fwrapper.c;h=9d3dd72cc1a8b70864a026e684ed1ded8c9e6e73;hb=9c2f0c74adb03a21646742702813b6ba4a4ae288;hp=18d2a239962250fc2f332fa9458be1207c0973c2;hpb=4441a79be9a6f9d1b4ec0111eb0030a8f2e3e5e5;p=ric-plt%2Flib%2Frmr.git

diff --git a/src/rmr/common/src/wrapper.c b/src/rmr/common/src/wrapper.c
index 18d2a23..9d3dd72 100644
--- a/src/rmr/common/src/wrapper.c
+++ b/src/rmr/common/src/wrapper.c
@@ -32,7 +32,7 @@
 
 #include "../include/rmr.h"
 
-#define ADD_SEP 	1
+#define ADD_SEP		1
 #define	NO_SEP		0
 
 /*
@@ -63,8 +63,9 @@ static char* build_sval( char* name, char* val, int add_sep ) {
 	strcat src is freed as a convenience. Max is the max amount
 	that target can accept; we don't bang on if src len is
 	larger than max.  Return is the size of src; 0 if the
-	target was not modified.  If target is not modified, then
-	src is NOT released.
+	target was not modified.
+
+	Source is ALWAYS freed!
 */
 static int bang_on( char* target, char* src, int max ) {
 	int		len;
@@ -73,11 +74,13 @@ static int bang_on( char* target, char* src, int max ) {
 	if( src && target ) {
 		len = strlen( src );
 		if( (rc = len <= max ? len : 0 ) > 0 ) {	// if it fits, add it.
-			strcat( target, src );
-			free( src );
+			strncat( target, src, len );
 		}
 	}
 
+	if( src ) {
+		free( src );
+	}
 	return rc;
 }
 
@@ -152,6 +155,6 @@ extern char* rmr_get_consts( ) {
 	phrase = build_ival( "RMR_ERR_INITFAILED", RMR_ERR_INITFAILED, NO_SEP );
 	remain -= bang_on( wbuf, phrase, remain );
 
-	strcat( wbuf, " }" );
+	strncat( wbuf, " }", remain );
 	return strdup( wbuf );			// chop unused space and return
 }