X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;f=redismodule%2Ftst%2Fsrc%2Fexstrings_test.cpp;h=d239eeabda0728108c44cba56a5b402a6c7f08c2;hb=dc8b09a63af0b4cba51b49b758a999aeeac1630e;hp=4816de5a5413a3614ea5484c76ba6778a61d23f1;hpb=24b73dac134d27649cb18c571f774011865debbb;p=ric-plt%2Fdbaas.git

diff --git a/redismodule/tst/src/exstrings_test.cpp b/redismodule/tst/src/exstrings_test.cpp
index 4816de5..d239eea 100755
--- a/redismodule/tst/src/exstrings_test.cpp
+++ b/redismodule/tst/src/exstrings_test.cpp
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2018-2019 Nokia.
+ * Copyright (c) 2018-2020 Nokia.
  *
  *   Licensed under the Apache License, Version 2.0 (the "License");
  *   you may not use this file except in compliance with the License.
@@ -19,18 +19,6 @@
  * platform project (RICP).
  */
 
-#include <string>
-#include <map>
-#include <list>
-#include <set>
-#include <vector>
-#include <syslog.h>
-
-
-//#include <stdio.h>
-//#include <stdlib.h>
-//#include <ctype.h>
-
 
 extern "C" {
 #include "exstringsStub.h"
@@ -46,6 +34,11 @@ extern "C" {
 #define OBJ_OP_IE (1<<4)     /* OP if equal old value */
 #define OBJ_OP_NE (1<<5)     /* OP if not equal old value */
 
+typedef struct RedisModuleBlockedClientArgs {
+    RedisModuleBlockedClient *bc;
+    RedisModuleString **argv;
+    int argc;
+} RedisModuleBlockedClientArgs;
 
 TEST_GROUP(exstring)
 {
@@ -88,6 +81,7 @@ TEST(exstring, setie)
 
     int ret = SetIE_RedisCommand(&ctx, redisStrVec,  4);
     CHECK_EQUAL(ret, 0);
+    CHECK_EQUAL(mock().getData("RedisModule_AutoMemory").getIntValue(),1);
     delete []redisStrVec;
 }
 
@@ -106,6 +100,7 @@ TEST(exstring, setne)
     mock().setData("RedisModule_String_same", 1);
     int ret = SetNE_RedisCommand(&ctx,redisStrVec, 4);
     CHECK_EQUAL(ret, 0);
+    CHECK_EQUAL(mock().getData("RedisModule_AutoMemory").getIntValue(),1);
     delete []redisStrVec;
 }
 
@@ -266,6 +261,7 @@ TEST(exstring, delie)
     int ret = DelIE_RedisCommand(&ctx, redisStrVec,  3);
     CHECK_EQUAL(ret, 0);
     mock().checkExpectations();
+    CHECK_EQUAL(mock().getData("RedisModule_AutoMemory").getIntValue(),1);
     delete []redisStrVec;
 }
 
@@ -285,6 +281,7 @@ TEST(exstring, delne)
     int ret = DelNE_RedisCommand(&ctx,redisStrVec, 3);
     CHECK_EQUAL(ret, 0);
     mock().checkExpectations();
+    CHECK_EQUAL(mock().getData("RedisModule_AutoMemory").getIntValue(),1);
     delete []redisStrVec;
 }
 
@@ -446,144 +443,6 @@ TEST(exstring, delne_command_key_string_nosame_reply)
 
 }
 
-TEST(exstring, setpub)
-{
-    RedisModuleCtx ctx;
-    RedisModuleString ** redisStrVec = new (RedisModuleString*[5]);
-
-    redisStrVec[0] = (RedisModuleString *)1;
-    redisStrVec[1] = (RedisModuleString *)1;
-    redisStrVec[2] = (RedisModuleString *)1;
-    redisStrVec[3] = (RedisModuleString *)1;
-    redisStrVec[4] = (RedisModuleString *)1;
-
-    mock().setData("RedisModule_OpenKey_have", 1);
-    mock().setData("RedisModule_KeyType_str", 1);
-    mock().setData("RedisModule_String_same", 1);
-    mock().setData("RedisModule_CallReplyType_null", 1);
-
-    int ret = SetPub_RedisCommand(&ctx, redisStrVec,  5);
-    CHECK_EQUAL(ret, REDISMODULE_OK);
-    mock().checkExpectations();
-    delete []redisStrVec;
-}
-
-TEST(exstring, setmpub)
-{
-    RedisModuleCtx ctx;
-    RedisModuleString ** redisStrVec = new (RedisModuleString*[11]);
-
-    for (int i = 0 ; i < 11 ; ++i)
-        redisStrVec[i] = (RedisModuleString *)1;
-
-    mock().setData("RedisModule_OpenKey_have", 1);
-    mock().setData("RedisModule_KeyType_str", 1);
-    mock().setData("RedisModule_String_same", 1);
-    mock().setData("RedisModule_CallReplyType_null", 1);
-    mock().setData("RedisModule_StringToLongLongCallCount", 0);
-    mock().setData("RedisModule_StringToLongLongCall_1", 2);
-    mock().setData("RedisModule_StringToLongLongCall_2", 2);
-
-    int ret = SetMPub_RedisCommand(&ctx, redisStrVec, 11);
-    CHECK_EQUAL(ret, REDISMODULE_OK);
-    mock().checkExpectations();
-    delete []redisStrVec;
-}
-
-TEST(exstring, setxxpub)
-{
-    RedisModuleCtx ctx;
-    RedisModuleString ** redisStrVec = new (RedisModuleString*[5]);
-
-    redisStrVec[0] = (RedisModuleString *)1;
-    redisStrVec[1] = (RedisModuleString *)1;
-    redisStrVec[2] = (RedisModuleString *)1;
-    redisStrVec[3] = (RedisModuleString *)1;
-    redisStrVec[4] = (RedisModuleString *)1;
-
-    mock().setData("RedisModule_OpenKey_have", 1);
-    mock().setData("RedisModule_KeyType_str", 1);
-    mock().setData("RedisModule_String_same", 1);
-    mock().setData("RedisModule_CallReplyType_null", 1);
-
-    mock().expectOneCall("RedisModule_CloseKey");
-    int ret = SetXXPub_RedisCommand(&ctx, redisStrVec,  5);
-    CHECK_EQUAL(ret, REDISMODULE_OK);
-    mock().checkExpectations();
-    delete []redisStrVec;
-}
-
-TEST(exstring, setnxpub)
-{
-    RedisModuleCtx ctx;
-    RedisModuleString ** redisStrVec = new (RedisModuleString*[5]);
-
-    redisStrVec[0] = (RedisModuleString *)1;
-    redisStrVec[1] = (RedisModuleString *)1;
-    redisStrVec[2] = (RedisModuleString *)1;
-    redisStrVec[3] = (RedisModuleString *)1;
-    redisStrVec[4] = (RedisModuleString *)1;
-
-    mock().setData("RedisModule_OpenKey_have", 1);
-    mock().setData("RedisModule_KeyType_str", 1);
-    mock().setData("RedisModule_String_same", 1);
-    mock().setData("RedisModule_CallReplyType_null", 1);
-
-    mock().expectOneCall("RedisModule_CloseKey");
-    int ret = SetNXPub_RedisCommand(&ctx, redisStrVec,  5);
-    CHECK_EQUAL(ret, REDISMODULE_OK);
-    mock().checkExpectations();
-    delete []redisStrVec;
-}
-
-TEST(exstring, setiepub)
-{
-    RedisModuleCtx ctx;
-    RedisModuleString ** redisStrVec = new (RedisModuleString*[6]);
-
-    redisStrVec[0] = (RedisModuleString *)1;
-    redisStrVec[1] = (RedisModuleString *)1;
-    redisStrVec[2] = (RedisModuleString *)1;
-    redisStrVec[3] = (RedisModuleString *)1;
-    redisStrVec[4] = (RedisModuleString *)1;
-    redisStrVec[5] = (RedisModuleString *)1;
-
-    mock().setData("RedisModule_OpenKey_have", 1);
-    mock().setData("RedisModule_KeyType_str", 1);
-    mock().setData("RedisModule_String_same", 1);
-    mock().setData("RedisModule_CallReplyType_null", 1);
-
-    mock().expectOneCall("RedisModule_CloseKey");
-    int ret = SetIEPub_RedisCommand(&ctx, redisStrVec,  6);
-    CHECK_EQUAL(ret, REDISMODULE_OK);
-    mock().checkExpectations();
-    delete []redisStrVec;
-}
-
-TEST(exstring, setnepub)
-{
-    RedisModuleCtx ctx;
-    RedisModuleString ** redisStrVec = new (RedisModuleString*[6]);
-
-    redisStrVec[0] = (RedisModuleString *)1;
-    redisStrVec[1] = (RedisModuleString *)1;
-    redisStrVec[2] = (RedisModuleString *)1;
-    redisStrVec[3] = (RedisModuleString *)1;
-    redisStrVec[4] = (RedisModuleString *)1;
-    redisStrVec[5] = (RedisModuleString *)1;
-
-    mock().setData("RedisModule_OpenKey_have", 1);
-    mock().setData("RedisModule_KeyType_str", 1);
-    mock().setData("RedisModule_String_same", 1);
-    mock().setData("RedisModule_CallReplyType_null", 1);
-
-    mock().expectOneCall("RedisModule_CloseKey");
-    int ret = SetNEPub_RedisCommand(&ctx, redisStrVec,  6);
-    CHECK_EQUAL(ret, REDISMODULE_OK);
-    mock().checkExpectations();
-    delete []redisStrVec;
-}
-
 TEST(exstring, setpub_command_parameter_number_incorrect)
 {
     RedisModuleCtx ctx;
@@ -616,6 +475,10 @@ TEST(exstring, setpub_command_parameter_number_incorrect)
     ret = SetNXPub_RedisCommand(&ctx, 0, 3);
     CHECK_EQUAL(ret, REDISMODULE_ERR);
 
+    ret = 0;
+    ret = SetNXMPub_RedisCommand(&ctx, 0, 3);
+    CHECK_EQUAL(ret, REDISMODULE_ERR);
+
     ret = 0;
     ret = SetNXPub_RedisCommand(&ctx, 0, 6);
     CHECK_EQUAL(ret, REDISMODULE_ERR);
@@ -624,6 +487,10 @@ TEST(exstring, setpub_command_parameter_number_incorrect)
     ret = SetIEPub_RedisCommand(&ctx, 0, 4);
     CHECK_EQUAL(ret, REDISMODULE_ERR);
 
+    ret = 0;
+    ret = SetIEMPub_RedisCommand(&ctx, 0, 4);
+    CHECK_EQUAL(ret, REDISMODULE_ERR);
+
     ret = 0;
     ret = SetIEPub_RedisCommand(&ctx, 0, 9);
     CHECK_EQUAL(ret, REDISMODULE_ERR);
@@ -637,32 +504,6 @@ TEST(exstring, setpub_command_parameter_number_incorrect)
     CHECK_EQUAL(ret, REDISMODULE_ERR);
 }
 
-TEST(exstring, setpub_command_no_key_replynull)
-{
-    RedisModuleCtx ctx;
-    RedisModuleString ** redisStrVec = new (RedisModuleString*[5]);
-
-    redisStrVec[0] = (RedisModuleString *)0;
-    redisStrVec[1] = (RedisModuleString *)1;
-    redisStrVec[2] = (RedisModuleString *)2;
-    redisStrVec[3] = (RedisModuleString *)3;
-    redisStrVec[4] = (RedisModuleString *)4;
-
-    mock().setData("RedisModule_KeyType_empty", 1);
-    mock().setData("RedisModule_CallReplyType_null", 1);
-
-    int ret = SetPub_RedisCommand(&ctx, redisStrVec, 5);
-    CHECK_EQUAL(ret, REDISMODULE_OK);
-    mock().checkExpectations();
-    CHECK_EQUAL(mock().getData("GET").getIntValue(), 0);
-    CHECK_EQUAL(mock().getData("MSET").getIntValue(), 1);
-    CHECK_EQUAL(mock().getData("PUBLISH").getIntValue(), 0);
-    CHECK_EQUAL(mock().getData("RedisModule_FreeCallReply").getIntValue(), 1);
-
-    delete []redisStrVec;
-
-}
-
 TEST(exstring, setpub_command_no_key_replystr)
 {
     RedisModuleCtx ctx;
@@ -684,38 +525,7 @@ TEST(exstring, setpub_command_no_key_replystr)
     CHECK_EQUAL(mock().getData("MSET").getIntValue(), 1);
     CHECK_EQUAL(mock().getData("PUBLISH").getIntValue(), 1);
     CHECK_EQUAL(mock().getData("RedisModule_FreeCallReply").getIntValue(), 2);
-
-    delete []redisStrVec;
-
-}
-
-TEST(exstring, setmpub_command_no_key_replynull)
-{
-    RedisModuleCtx ctx;
-    RedisModuleString ** redisStrVec = new (RedisModuleString*[9]);
-
-    redisStrVec[0] = (RedisModuleString *)0;
-    redisStrVec[1] = (RedisModuleString *)1;
-    redisStrVec[2] = (RedisModuleString *)2;
-    redisStrVec[3] = (RedisModuleString *)3;
-    redisStrVec[4] = (RedisModuleString *)4;
-    redisStrVec[5] = (RedisModuleString *)5;
-    redisStrVec[6] = (RedisModuleString *)6;
-    redisStrVec[7] = (RedisModuleString *)7;
-    redisStrVec[8] = (RedisModuleString *)8;
-
-    mock().setData("RedisModule_KeyType_empty", 1);
-    mock().setData("RedisModule_CallReplyType_null", 1);
-    mock().setData("RedisModule_StringToLongLongCall_1", 1);
-    mock().setData("RedisModule_StringToLongLongCall_2", 2);
-
-    int ret = SetMPub_RedisCommand(&ctx, redisStrVec, 9);
-    CHECK_EQUAL(ret, REDISMODULE_OK);
-    mock().checkExpectations();
-    CHECK_EQUAL(0, mock().getData("GET").getIntValue());
-    CHECK_EQUAL(1, mock().getData("MSET").getIntValue());
-    CHECK_EQUAL(0, mock().getData("PUBLISH").getIntValue());
-    CHECK_EQUAL(1, mock().getData("RedisModule_FreeCallReply").getIntValue());
+    CHECK_EQUAL(mock().getData("RedisModule_AutoMemory").getIntValue(),1);
 
     delete []redisStrVec;
 
@@ -747,6 +557,7 @@ TEST(exstring, setmpub_command_negative_key_val_count)
     CHECK_EQUAL(0, mock().getData("PUBLISH").getIntValue());
     CHECK_EQUAL(1, mock().getData("RedisModule_ReplyWithError").getIntValue());
     CHECK_EQUAL(0, mock().getData("RedisModule_FreeCallReply").getIntValue());
+    CHECK_EQUAL(mock().getData("RedisModule_AutoMemory").getIntValue(),1);
 
     delete []redisStrVec;
 
@@ -778,6 +589,7 @@ TEST(exstring, setmpub_command_negative_chan_msg_count)
     CHECK_EQUAL(0, mock().getData("PUBLISH").getIntValue());
     CHECK_EQUAL(1, mock().getData("RedisModule_ReplyWithError").getIntValue());
     CHECK_EQUAL(0, mock().getData("RedisModule_FreeCallReply").getIntValue());
+    CHECK_EQUAL(mock().getData("RedisModule_AutoMemory").getIntValue(),1);
 
     delete []redisStrVec;
 
@@ -809,6 +621,7 @@ TEST(exstring, setmpub_command_invalid_total_count)
     CHECK_EQUAL(0, mock().getData("PUBLISH").getIntValue());
     CHECK_EQUAL(1, mock().getData("RedisModule_ReplyWithError").getIntValue());
     CHECK_EQUAL(0, mock().getData("RedisModule_FreeCallReply").getIntValue());
+    CHECK_EQUAL(mock().getData("RedisModule_AutoMemory").getIntValue(),1);
 
     delete []redisStrVec;
 
@@ -839,6 +652,7 @@ TEST(exstring, setmpub_command_set)
     CHECK_EQUAL(1, mock().getData("MSET").getIntValue());
     CHECK_EQUAL(1, mock().getData("PUBLISH").getIntValue());
     CHECK_EQUAL(2, mock().getData("RedisModule_FreeCallReply").getIntValue());
+    CHECK_EQUAL(mock().getData("RedisModule_AutoMemory").getIntValue(),1);
 
     delete []redisStrVec;
 
@@ -871,6 +685,7 @@ TEST(exstring, setmpub_command_set_multipub)
     CHECK_EQUAL(1, mock().getData("MSET").getIntValue());
     CHECK_EQUAL(2, mock().getData("PUBLISH").getIntValue());
     CHECK_EQUAL(3, mock().getData("RedisModule_FreeCallReply").getIntValue());
+    CHECK_EQUAL(mock().getData("RedisModule_AutoMemory").getIntValue(),1);
 
     delete []redisStrVec;
 
@@ -900,6 +715,7 @@ TEST(exstring, setxxpub_command_has_no_key)
     CHECK_EQUAL(mock().getData("MSET").getIntValue(), 0);
     CHECK_EQUAL(mock().getData("PUBLISH").getIntValue(), 0);
     CHECK_EQUAL(mock().getData("RedisModule_FreeCallReply").getIntValue(), 0);
+    CHECK_EQUAL(mock().getData("RedisModule_AutoMemory").getIntValue(),1);
 
     delete []redisStrVec;
 
@@ -928,6 +744,7 @@ TEST(exstring, setxxpub_command_parameter_has_key_set)
     CHECK_EQUAL(mock().getData("MSET").getIntValue(), 0);
     CHECK_EQUAL(mock().getData("PUBLISH").getIntValue(), 0);
     CHECK_EQUAL(mock().getData("RedisModule_FreeCallReply").getIntValue(), 0);
+    CHECK_EQUAL(mock().getData("RedisModule_AutoMemory").getIntValue(),1);
 
     delete []redisStrVec;
 
@@ -957,6 +774,7 @@ TEST(exstring, setxxpub_command_has_key_string)
     CHECK_EQUAL(mock().getData("MSET").getIntValue(), 1);
     CHECK_EQUAL(mock().getData("PUBLISH").getIntValue(), 1);
     CHECK_EQUAL(mock().getData("RedisModule_FreeCallReply").getIntValue(), 2);
+    CHECK_EQUAL(mock().getData("RedisModule_AutoMemory").getIntValue(),1);
 
     delete []redisStrVec;
 
@@ -987,6 +805,7 @@ TEST(exstring, setnxpub_command_has_key_string)
     CHECK_EQUAL(mock().getData("MSET").getIntValue(), 0);
     CHECK_EQUAL(mock().getData("PUBLISH").getIntValue(), 0);
     CHECK_EQUAL(mock().getData("RedisModule_FreeCallReply").getIntValue(), 0);
+    CHECK_EQUAL(mock().getData("RedisModule_AutoMemory").getIntValue(),1);
 
     delete []redisStrVec;
 
@@ -1016,6 +835,7 @@ TEST(exstring, setnxpub_command_has_no_key)
     CHECK_EQUAL(mock().getData("MSET").getIntValue(), 1);
     CHECK_EQUAL(mock().getData("PUBLISH").getIntValue(), 1);
     CHECK_EQUAL(mock().getData("RedisModule_FreeCallReply").getIntValue(), 2);
+    CHECK_EQUAL(mock().getData("RedisModule_AutoMemory").getIntValue(),1);
 
     delete []redisStrVec;
 
@@ -1048,6 +868,7 @@ TEST(exstring, setiepub_command_has_no_key)
     CHECK_EQUAL(mock().getData("MSET").getIntValue(), 0);
     CHECK_EQUAL(mock().getData("PUBLISH").getIntValue(), 0);
     CHECK_EQUAL(mock().getData("RedisModule_FreeCallReply").getIntValue(), 0);
+    CHECK_EQUAL(mock().getData("RedisModule_AutoMemory").getIntValue(),1);
 
     delete []redisStrVec;
 
@@ -1080,37 +901,7 @@ TEST(exstring, setiepub_command_key_string_nosame)
     CHECK_EQUAL(mock().getData("MSET").getIntValue(), 0);
     CHECK_EQUAL(mock().getData("PUBLISH").getIntValue(), 0);
     CHECK_EQUAL(mock().getData("RedisModule_FreeCallReply").getIntValue(), 1);
-
-    delete []redisStrVec;
-
-}
-
-TEST(exstring, setiepub_command_key_same_string_replynull)
-{
-    RedisModuleCtx ctx;
-    RedisModuleString ** redisStrVec = new (RedisModuleString*[6]);
-
-    redisStrVec[0] = (RedisModuleString *)0;
-    redisStrVec[1] = (RedisModuleString *)1;
-    redisStrVec[2] = (RedisModuleString *)2;
-    redisStrVec[3] = (RedisModuleString *)3;
-    redisStrVec[4] = (RedisModuleString *)4;
-    redisStrVec[5] = (RedisModuleString *)5;
-
-    mock().setData("RedisModule_KeyType_str", 1);
-    mock().setData("RedisModule_String_same", 1);
-    mock().setData("RedisModule_CallReplyType_null", 1);
-
-    mock().expectOneCall("RedisModule_CloseKey");
-    int ret = SetIEPub_RedisCommand(&ctx, redisStrVec, 6);
-
-    CHECK_EQUAL(ret, REDISMODULE_OK);
-    mock().checkExpectations();
-    CHECK_EQUAL(mock().getData("GET").getIntValue(), 1);
-    CHECK_EQUAL(mock().getData("MSET").getIntValue(), 1);
-    CHECK_EQUAL(mock().getData("RedisModule_ReplyWithNull").getIntValue(), 1);
-    CHECK_EQUAL(mock().getData("PUBLISH").getIntValue(), 0);
-    CHECK_EQUAL(mock().getData("RedisModule_FreeCallReply").getIntValue(), 2);
+    CHECK_EQUAL(mock().getData("RedisModule_AutoMemory").getIntValue(),1);
 
     delete []redisStrVec;
 
@@ -1142,6 +933,7 @@ TEST(exstring, setiepub_command_key_same_string_reply)
     CHECK_EQUAL(mock().getData("PUBLISH").getIntValue(), 1);
     CHECK_EQUAL(mock().getData("RedisModule_ReplyWithCallReply").getIntValue(), 1);
     CHECK_EQUAL(mock().getData("RedisModule_FreeCallReply").getIntValue(), 3);
+    CHECK_EQUAL(mock().getData("RedisModule_AutoMemory").getIntValue(),1);
 
     delete []redisStrVec;
 
@@ -1173,6 +965,7 @@ TEST(exstring, setnepub_command_has_no_key)
     CHECK_EQUAL(mock().getData("PUBLISH").getIntValue(), 1);
     CHECK_EQUAL(mock().getData("RedisModule_ReplyWithCallReply").getIntValue(), 1);
     CHECK_EQUAL(mock().getData("RedisModule_FreeCallReply").getIntValue(), 3);
+    CHECK_EQUAL(mock().getData("RedisModule_AutoMemory").getIntValue(),1);
 
     delete []redisStrVec;
 
@@ -1313,6 +1106,29 @@ TEST(exstring, deliepub)
     delete []redisStrVec;
 }
 
+TEST(exstring, deliempub)
+{
+    RedisModuleCtx ctx;
+    RedisModuleString ** redisStrVec = new (RedisModuleString*[5]);
+
+    redisStrVec[0] = (RedisModuleString *)1;
+    redisStrVec[1] = (RedisModuleString *)1;
+    redisStrVec[2] = (RedisModuleString *)1;
+    redisStrVec[3] = (RedisModuleString *)1;
+    redisStrVec[4] = (RedisModuleString *)1;
+
+    mock().setData("RedisModule_OpenKey_have", 1);
+    mock().setData("RedisModule_KeyType_str", 1);
+    mock().setData("RedisModule_String_same", 1);
+    mock().setData("RedisModule_CallReplyType_null", 1);
+
+    mock().expectOneCall("RedisModule_CloseKey");
+    int ret = DelIEMPub_RedisCommand(&ctx, redisStrVec,  5);
+    CHECK_EQUAL(ret, REDISMODULE_OK);
+    mock().checkExpectations();
+    delete []redisStrVec;
+}
+
 TEST(exstring, delnepub)
 {
     RedisModuleCtx ctx;
@@ -1351,6 +1167,10 @@ TEST(exstring, delpub_command_parameter_number_incorrect)
     ret = DelIEPub_RedisCommand(&ctx, 0, 4);
     CHECK_EQUAL(ret, REDISMODULE_ERR);
 
+    ret = 0;
+    ret = DelIEMPub_RedisCommand(&ctx, 0, 4);
+    CHECK_EQUAL(ret, REDISMODULE_ERR);
+
     ret = 0;
     ret = DelNEPub_RedisCommand(&ctx, 0, 8);
     CHECK_EQUAL(ret, REDISMODULE_ERR);
@@ -1396,12 +1216,12 @@ TEST(exstring, delpub_command_reply_error)
     mock().setData("RedisModule_CallReplyType_err", 1);
 
     int ret = DelPub_RedisCommand(&ctx, redisStrVec, 5);
-    CHECK_EQUAL(ret, REDISMODULE_ERR);
+    CHECK_EQUAL(ret, REDISMODULE_OK);
     CHECK_EQUAL(mock().getData("GET").getIntValue(), 0);
     CHECK_EQUAL(mock().getData("UNLINK").getIntValue(), 1);
     CHECK_EQUAL(mock().getData("PUBLISH").getIntValue(), 0);
     CHECK_EQUAL(mock().getData("RedisModule_ReplyWithCallReply").getIntValue(), 1);
-    CHECK_EQUAL(mock().getData("RedisModule_FreeCallReply").getIntValue(), 1);
+    CHECK_EQUAL(mock().getData("RedisModule_FreeCallReply").getIntValue(), 0);
     CHECK_EQUAL(mock().getData("RedisModule_ReplyWithError").getIntValue(), 0);
     delete []redisStrVec;
 
@@ -1479,12 +1299,12 @@ TEST(exstring, delmpub_command_reply_error)
     mock().setData("RedisModule_StringToLongLongCall_2", 1);
 
     int ret = DelMPub_RedisCommand(&ctx, redisStrVec, 6);
-    CHECK_EQUAL(ret, REDISMODULE_ERR);
+    CHECK_EQUAL(ret, REDISMODULE_OK);
     CHECK_EQUAL(mock().getData("GET").getIntValue(), 0);
     CHECK_EQUAL(mock().getData("UNLINK").getIntValue(), 1);
     CHECK_EQUAL(mock().getData("PUBLISH").getIntValue(), 0);
     CHECK_EQUAL(mock().getData("RedisModule_ReplyWithCallReply").getIntValue(), 1);
-    CHECK_EQUAL(mock().getData("RedisModule_FreeCallReply").getIntValue(), 1);
+    CHECK_EQUAL(mock().getData("RedisModule_FreeCallReply").getIntValue(), 0);
     CHECK_EQUAL(mock().getData("RedisModule_ReplyWithError").getIntValue(), 0);
     delete []redisStrVec;
 
@@ -1869,100 +1689,3 @@ TEST(exstring, delnepub_command_nosame_string_reply)
 
     delete []redisStrVec;
 }
-
-TEST(exstring, nget_command_parameter_number_incorrect)
-{
-    RedisModuleCtx ctx;
-    RedisModuleString ** redisStrVec = new (RedisModuleString*[2]);
-    redisStrVec[0] = (RedisModuleString *)1;
-    redisStrVec[1] = (RedisModuleString *)1;
-
-    int ret = NGet_RedisCommand(&ctx, redisStrVec,  3);
-    CHECK_EQUAL(ret, REDISMODULE_ERR);
-
-    delete []redisStrVec;
-}
-
-TEST(exstring, nget_command_zero_item)
-{
-    RedisModuleCtx ctx;
-    RedisModuleString ** redisStrVec = new (RedisModuleString*[2]);
-    redisStrVec[0] = (RedisModuleString *)1;
-    redisStrVec[1] = (RedisModuleString *)1;
-
-    mock().setData("RedisModule_CallReplyLength", 0);
-    int ret = NGet_RedisCommand(&ctx, redisStrVec,  2);
-    CHECK_EQUAL(ret, REDISMODULE_OK);
-    CHECK_EQUAL(mock().getData("KEYS").getIntValue(), 1);
-    CHECK_EQUAL(mock().getData("RedisModule_ReplyWithCallReply").getIntValue(), 1);
-    CHECK_EQUAL(mock().getData("RedisModule_FreeCallReply").getIntValue(), 1);
-
-    delete []redisStrVec;
-}
-
-TEST(exstring, nget_command_none_zero_items)
-{
-    RedisModuleCtx ctx;
-    RedisModuleString ** redisStrVec = new (RedisModuleString*[2]);
-    redisStrVec[0] = (RedisModuleString *)1;
-    redisStrVec[1] = (RedisModuleString *)1;
-
-    mock().setData("RedisModule_CallReplyLength", 3);
-    int ret = NGet_RedisCommand(&ctx, redisStrVec,  2);
-    CHECK_EQUAL(ret, REDISMODULE_OK);
-    CHECK_EQUAL(mock().getData("KEYS").getIntValue(), 1);
-    CHECK_EQUAL(mock().getData("MGET").getIntValue(), 1);
-    CHECK_EQUAL(mock().getData("RedisModule_ReplyWithArray").getIntValue(), 3*2);
-    CHECK_EQUAL(mock().getData("RedisModule_ReplyWithString").getIntValue(), 3*2);
-    CHECK_EQUAL(mock().getData("RedisModule_FreeCallReply").getIntValue(), 2);
-
-    delete []redisStrVec;
-}
-
-TEST(exstring, ndel_command_parameter_parameter_number_incorrect)
-{
-    RedisModuleCtx ctx;
-    RedisModuleString ** redisStrVec = new (RedisModuleString*[2]);
-    redisStrVec[0] = (RedisModuleString *)1;
-    redisStrVec[1] = (RedisModuleString *)1;
-
-    int ret = NDel_RedisCommand(&ctx, redisStrVec,  3);
-    CHECK_EQUAL(ret, REDISMODULE_ERR);
-
-    delete []redisStrVec;
-}
-
-TEST(exstring, ndel_command_zero_item)
-{
-    RedisModuleCtx ctx;
-    RedisModuleString ** redisStrVec = new (RedisModuleString*[2]);
-    redisStrVec[0] = (RedisModuleString *)1;
-    redisStrVec[1] = (RedisModuleString *)1;
-
-    mock().setData("RedisModule_CallReplyLength", 0);
-    int ret = NDel_RedisCommand(&ctx, redisStrVec,  2);
-    CHECK_EQUAL(ret, REDISMODULE_OK);
-    CHECK_EQUAL(mock().getData("KEYS").getIntValue(), 1);
-    CHECK_EQUAL(mock().getData("RedisModule_ReplyWithLongLong").getIntValue(), 0);
-    CHECK_EQUAL(mock().getData("RedisModule_FreeCallReply").getIntValue(), 1);
-
-    delete []redisStrVec;
-}
-
-TEST(exstring, ndel_command_none_zero_items)
-{
-    RedisModuleCtx ctx;
-    RedisModuleString ** redisStrVec = new (RedisModuleString*[2]);
-    redisStrVec[0] = (RedisModuleString *)1;
-    redisStrVec[1] = (RedisModuleString *)1;
-
-    mock().setData("RedisModule_CallReplyLength", 3);
-    int ret = NDel_RedisCommand(&ctx, redisStrVec,  2);
-    CHECK_EQUAL(ret, REDISMODULE_OK);
-    CHECK_EQUAL(mock().getData("KEYS").getIntValue(), 1);
-    CHECK_EQUAL(mock().getData("UNLINK").getIntValue(), 1);
-    CHECK_EQUAL(mock().getData("RedisModule_ReplyWithCallReply").getIntValue(), 1);
-    CHECK_EQUAL(mock().getData("RedisModule_FreeCallReply").getIntValue(), 2);
-
-    delete []redisStrVec;
-}