X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;f=policy-agent%2Fsrc%2Fmain%2Fjava%2Forg%2Foransc%2Fpolicyagent%2Ftasks%2FServiceSupervision.java;h=9c5553296b5a35806df64515ced608e1b477d57d;hb=6a39814272307d0207222c9229b0d765ac062bf0;hp=26509925db587160cdd121591925438e03722ba9;hpb=be2000ec2d21151b42cb559ef881695eb32e35e9;p=nonrtric.git diff --git a/policy-agent/src/main/java/org/oransc/policyagent/tasks/ServiceSupervision.java b/policy-agent/src/main/java/org/oransc/policyagent/tasks/ServiceSupervision.java index 26509925..9c555329 100644 --- a/policy-agent/src/main/java/org/oransc/policyagent/tasks/ServiceSupervision.java +++ b/policy-agent/src/main/java/org/oransc/policyagent/tasks/ServiceSupervision.java @@ -50,6 +50,7 @@ import reactor.core.publisher.Mono; @SuppressWarnings("squid:S2629") // Invoke method(s) only conditionally public class ServiceSupervision { private static final Logger logger = LoggerFactory.getLogger(ServiceSupervision.class); + static final int CONCURRENCY_RIC = 1; // How may paralell requests that is sent private final Services services; private final Policies policies; private A1ClientFactory a1ClientFactory; @@ -85,7 +86,7 @@ public class ServiceSupervision { .doOnNext(service -> logger.info("Service is expired: {}", service.getName())) // .doOnNext(service -> services.remove(service.getName())) // .flatMap(this::getAllPoliciesForService) // - .flatMap(this::deletePolicy); + .flatMap(this::deletePolicy, CONCURRENCY_RIC); } @SuppressWarnings("squid:S2629") // Invoke method(s) only conditionally @@ -105,9 +106,7 @@ public class ServiceSupervision { } private Flux getAllPoliciesForService(Service service) { - synchronized (policies) { - return Flux.fromIterable(policies.getForService(service.getName())); - } + return Flux.fromIterable(policies.getForService(service.getName())); } private Mono deletePolicyInRic(Policy policy) { @@ -118,7 +117,8 @@ public class ServiceSupervision { } private Mono handleDeleteFromRicFailure(Policy policy, Throwable e) { - logger.warn("Could not delete policy: {} from ric: {}", policy.id(), policy.ric().name(), e); + logger.warn("Could not delete policy: {} from ric: {}. Cause: {}", policy.id(), policy.ric().name(), + e.getMessage()); return Mono.empty(); } }