X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;f=policy-agent%2Fsrc%2Fmain%2Fjava%2Forg%2Foransc%2Fpolicyagent%2Frepository%2FServices.java;h=35cae71764c3da7c5e96eb24bc66979a0c03c56a;hb=7a4a590fb0ebf8772169625cdda327da43c79c6d;hp=509b2f515bfd8fbbda94e55e7f529c6a478c7877;hpb=89537fa85fdb1c0ce75e469674785d08dc62b986;p=nonrtric.git

diff --git a/policy-agent/src/main/java/org/oransc/policyagent/repository/Services.java b/policy-agent/src/main/java/org/oransc/policyagent/repository/Services.java
index 509b2f51..35cae717 100644
--- a/policy-agent/src/main/java/org/oransc/policyagent/repository/Services.java
+++ b/policy-agent/src/main/java/org/oransc/policyagent/repository/Services.java
@@ -50,9 +50,12 @@ public class Services {
 
     public synchronized void put(Service service) {
         logger.debug("Put service: " + service.getName());
+        // TODO a threading problem is that this may happend at the same time as someone is iterating (getAll())
+        // This is a generic problem
         services.put(service.getName(), service);
     }
 
+    // TODO the returned value should be unmodifiable if possible
     public synchronized Collection<Service> getAll() {
         return services.values();
     }