X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;f=pkg%2Fcontrol%2Fregistry.go;h=9cacd9433333d8da7f528ad379097053533819b1;hb=f44377db11001585180cb1a41452a12bfd44546f;hp=c3499212e1c8358116afcbddfa62f818d4b6bccb;hpb=93cc3e245f87798c8753209980817727e0648401;p=ric-plt%2Fsubmgr.git diff --git a/pkg/control/registry.go b/pkg/control/registry.go index c349921..9cacd94 100644 --- a/pkg/control/registry.go +++ b/pkg/control/registry.go @@ -19,58 +19,264 @@ package control -import "gerrit.o-ran-sc.org/r/ric-plt/xapp-frame/pkg/xapp" +import ( + "fmt" + "gerrit.o-ran-sc.org/r/ric-plt/e2ap/pkg/e2ap" + "gerrit.o-ran-sc.org/r/ric-plt/xapp-frame/pkg/xapp" + "sync" + "time" +) + +//----------------------------------------------------------------------------- +// +//----------------------------------------------------------------------------- type Registry struct { - register map[uint16]bool - counter uint16 + mutex sync.Mutex + register map[uint32]*Subscription + subIds []uint32 + rtmgrClient *RtmgrClient } -// This method should run as a constructor -func (r *Registry) Initialize(seedsn uint16) { - r.register = make(map[uint16]bool) - r.counter = seedsn +func (r *Registry) Initialize() { + r.register = make(map[uint32]*Subscription) + var i uint32 + for i = 0; i < 65535; i++ { + r.subIds = append(r.subIds, i+1) + } } -// Reserves and returns the next free sequence number -func (r *Registry) ReserveSequenceNumber() uint16 { - if r.IsValidSequenceNumber(r.counter){ +func (r *Registry) allocateSubs(trans *TransactionXapp, subReqMsg *e2ap.E2APSubscriptionRequest) (*Subscription, error) { + if len(r.subIds) > 0 { + sequenceNumber := r.subIds[0] + r.subIds = r.subIds[1:] + if _, ok := r.register[sequenceNumber]; ok == true { + r.subIds = append(r.subIds, sequenceNumber) + return nil, fmt.Errorf("Registry: Failed to reserve subscription exists") + } + subs := &Subscription{ + registry: r, + Meid: trans.Meid, + SubReqMsg: subReqMsg, + valid: true, + } + subs.ReqId.Id = 123 + subs.ReqId.Seq = sequenceNumber + + if subs.EpList.AddEndpoint(trans.GetEndpoint()) == false { + r.subIds = append(r.subIds, subs.ReqId.Seq) + return nil, fmt.Errorf("Registry: Endpoint existing already in subscription") + } + return subs, nil } - sequenceNumber := r.counter - r.register[sequenceNumber] = false - r.shift() - return sequenceNumber + return nil, fmt.Errorf("Registry: Failed to reserve subscription no free ids") } -// This function checks the validity of the given subscription id -func (r *Registry) IsValidSequenceNumber(sn uint16) bool { - xapp.Logger.Debug("Registry map: %v", r.register) - if _, ok := r.register[sn]; ok { - return true +func (r *Registry) findExistingSubs(trans *TransactionXapp, subReqMsg *e2ap.E2APSubscriptionRequest) *Subscription { + + for _, subs := range r.register { + if subs.IsMergeable(trans, subReqMsg) { + + // + // check if there has been race conditions + // + subs.mutex.Lock() + //subs has been set to invalid + if subs.valid == false { + subs.mutex.Unlock() + continue + } + // If size is zero, entry is to be deleted + if subs.EpList.Size() == 0 { + subs.mutex.Unlock() + continue + } + // try to add to endpointlist. + if subs.EpList.AddEndpoint(trans.GetEndpoint()) == false { + subs.mutex.Unlock() + continue + } + subs.mutex.Unlock() + + xapp.Logger.Debug("Registry: Mergeable subs found %s for %s", subs.String(), trans.String()) + return subs + } } - return false + return nil } -// This function sets the give id as confirmed in the register -func (r *Registry) setSubscriptionToConfirmed(sn uint16) { - r.register[sn] = true -} +func (r *Registry) AssignToSubscription(trans *TransactionXapp, subReqMsg *e2ap.E2APSubscriptionRequest) (*Subscription, error) { + var err error + var newAlloc bool + r.mutex.Lock() + defer r.mutex.Unlock() + + // + // Check validity of subscription action types + // + actionType, err := r.CheckActionTypes(subReqMsg) + if err != nil { + xapp.Logger.Debug("CREATE %s", err) + return nil, err + } + + // + // Find possible existing Policy subscription + // + if actionType == e2ap.E2AP_ActionTypePolicy { + if subs, ok := r.register[subReqMsg.RequestId.Seq]; ok { + xapp.Logger.Debug("CREATE %s. Existing subscription for Policy found", subs.String()) + subs.SetCachedResponse(nil, true) + return subs, nil + } + } -func (r *Registry) shift() { - if r.counter == 65535 { - r.counter = 0 + subs := r.findExistingSubs(trans, subReqMsg) + if subs == nil { + subs, err = r.allocateSubs(trans, subReqMsg) + if err != nil { + return nil, err + } + newAlloc = true + } + + // + // Add to subscription + // + subs.mutex.Lock() + defer subs.mutex.Unlock() + + epamount := subs.EpList.Size() + + r.mutex.Unlock() + // + // Subscription route updates + // + if epamount == 1 { + subRouteAction := SubRouteInfo{subs.EpList, uint16(subs.ReqId.Seq)} + err = r.rtmgrClient.SubscriptionRequestCreate(subRouteAction) } else { - r.counter++ + subRouteAction := SubRouteInfo{subs.EpList, uint16(subs.ReqId.Seq)} + err = r.rtmgrClient.SubscriptionRequestUpdate(subRouteAction) + } + r.mutex.Lock() + + if err != nil { + if newAlloc { + r.subIds = append(r.subIds, subs.ReqId.Seq) + } + return nil, err } + + if newAlloc { + r.register[subs.ReqId.Seq] = subs + } + xapp.Logger.Debug("CREATE %s", subs.String()) + xapp.Logger.Debug("Registry: substable=%v", r.register) + return subs, nil } -//This function sets the given id as unused in the register -func (r *Registry) deleteSubscription(sn uint16) { - r.register[sn] = false +func (r *Registry) CheckActionTypes(subReqMsg *e2ap.E2APSubscriptionRequest) (uint64, error) { + var reportFound bool = false + var policyFound bool = false + + for _, acts := range subReqMsg.ActionSetups { + if acts.ActionType == e2ap.E2AP_ActionTypeReport { + reportFound = true + } + if acts.ActionType == e2ap.E2AP_ActionTypePolicy { + policyFound = true + } + } + if reportFound == true && policyFound == true { + return e2ap.E2AP_ActionTypeInvalid, fmt.Errorf("Report and Policy in same RICactions-ToBeSetup-List") + } + if reportFound == true { + return e2ap.E2AP_ActionTypeReport, nil + } + if policyFound == true { + return e2ap.E2AP_ActionTypePolicy, nil + } + return e2ap.E2AP_ActionTypeInvalid, fmt.Errorf("Invalid action type in RICactions-ToBeSetup-List") +} + +// TODO: Works with concurrent calls, but check if can be improved +func (r *Registry) RemoveFromSubscription(subs *Subscription, trans *TransactionXapp, waitRouteClean time.Duration) error { + + r.mutex.Lock() + defer r.mutex.Unlock() + subs.mutex.Lock() + defer subs.mutex.Unlock() + + delStatus := subs.EpList.DelEndpoint(trans.GetEndpoint()) + epamount := subs.EpList.Size() + seqId := subs.ReqId.Seq + + if delStatus == false { + return nil + } + + go func() { + if waitRouteClean > 0 { + time.Sleep(waitRouteClean) + } + + subs.mutex.Lock() + defer subs.mutex.Unlock() + xapp.Logger.Info("CLEAN %s", subs.String()) + + if epamount == 0 { + // + // Subscription route delete + // + tmpList := RmrEndpointList{} + tmpList.AddEndpoint(trans.GetEndpoint()) + subRouteAction := SubRouteInfo{tmpList, uint16(seqId)} + r.rtmgrClient.SubscriptionRequestDelete(subRouteAction) + + // + // Subscription release + // + r.mutex.Lock() + defer r.mutex.Unlock() + + if _, ok := r.register[seqId]; ok { + xapp.Logger.Debug("RELEASE %s", subs.String()) + delete(r.register, seqId) + xapp.Logger.Debug("Registry: substable=%v", r.register) + } + r.subIds = append(r.subIds, seqId) + + } else if subs.EpList.Size() > 0 { + // + // Subscription route updates + // + subRouteAction := SubRouteInfo{subs.EpList, uint16(seqId)} + r.rtmgrClient.SubscriptionRequestUpdate(subRouteAction) + } + + }() + + return nil } -//This function releases the given id as unused in the register -//func (r *Registry) releaseSequenceNumber(sn uint16) { -// delete(r.register, sn) -//} \ No newline at end of file +func (r *Registry) GetSubscription(sn uint32) *Subscription { + r.mutex.Lock() + defer r.mutex.Unlock() + if _, ok := r.register[sn]; ok { + return r.register[sn] + } + return nil +} + +func (r *Registry) GetSubscriptionFirstMatch(ids []uint32) (*Subscription, error) { + r.mutex.Lock() + defer r.mutex.Unlock() + for _, id := range ids { + if _, ok := r.register[id]; ok { + return r.register[id], nil + } + } + return nil, fmt.Errorf("No valid subscription found with ids %v", ids) +}