X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;f=pkg%2Fcontrol%2Fregistry.go;h=4f5c4fd41f4a8aedfde3a1c1be3880cdf40a0d13;hb=c65f5b0d9ad73ce3f66eabc22e80244546e97238;hp=98aa97e8e84a099f2b2f9ee844b3f9ddd957b9de;hpb=2e99e2f4c89b1c232b3d1765197db44e3cced5b8;p=ric-plt%2Fsubmgr.git diff --git a/pkg/control/registry.go b/pkg/control/registry.go index 98aa97e..4f5c4fd 100644 --- a/pkg/control/registry.go +++ b/pkg/control/registry.go @@ -24,11 +24,10 @@ import ( "sync" ) -var registryMutex = &sync.Mutex{} - type Registry struct { register map[uint16]bool counter uint16 + mutex sync.Mutex } // This method should run as a constructor @@ -40,11 +39,11 @@ func (r *Registry) Initialize(seedsn uint16) { // Reserves and returns the next free sequence number func (r *Registry) ReserveSequenceNumber() (uint16, bool) { // Check is current SequenceNumber valid - registryMutex.Lock() - defer registryMutex.Unlock() + r.mutex.Lock() + defer r.mutex.Unlock() sequenceNumber := r.counter if _, ok := r.register[sequenceNumber]; ok { - xapp.Logger.Error("Invalid SeqenceNumber sequenceNumber: %v",sequenceNumber) + xapp.Logger.Error("Invalid SeqenceNumber sequenceNumber: %v", sequenceNumber) return sequenceNumber, false } r.register[sequenceNumber] = false @@ -60,8 +59,8 @@ func (r *Registry) ReserveSequenceNumber() (uint16, bool) { // This function checks the validity of the given subscription id func (r *Registry) IsValidSequenceNumber(sn uint16) bool { - registryMutex.Lock() - defer registryMutex.Unlock() + r.mutex.Lock() + defer r.mutex.Unlock() xapp.Logger.Debug("Registry map: %v", r.register) if _, ok := r.register[sn]; ok { return true @@ -71,26 +70,26 @@ func (r *Registry) IsValidSequenceNumber(sn uint16) bool { // This function sets the give id as confirmed in the register func (r *Registry) setSubscriptionToConfirmed(sn uint16) { - registryMutex.Lock() - defer registryMutex.Unlock() + r.mutex.Lock() + defer r.mutex.Unlock() r.register[sn] = true } //This function sets the given id as unused in the register func (r *Registry) deleteSubscription(sn uint16) { - registryMutex.Lock() - defer registryMutex.Unlock() + r.mutex.Lock() + defer r.mutex.Unlock() r.register[sn] = false } //This function releases the given id as unused in the register func (r *Registry) releaseSequenceNumber(sn uint16) bool { - registryMutex.Lock() - defer registryMutex.Unlock() - if r.register[sn] { - return false - } else { + r.mutex.Lock() + defer r.mutex.Unlock() + if _, ok := r.register[sn]; ok { delete(r.register, sn) return true + } else { + return false } }