X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;f=o2ims%2Fviews%2Falarm_view.py;h=83189c12fc18879da104bbac8d90f15ad0764338;hb=7762dca97d4714f79b723e6d3759e954793fb33f;hp=bb238be126f5651f0b304dc5b5ad2d52a6d00d87;hpb=0e743715cabed900807aa0ba9ade459006472274;p=pti%2Fo2.git

diff --git a/o2ims/views/alarm_view.py b/o2ims/views/alarm_view.py
index bb238be..83189c1 100644
--- a/o2ims/views/alarm_view.py
+++ b/o2ims/views/alarm_view.py
@@ -15,8 +15,11 @@
 import uuid as uuid
 
 from o2common.service import unit_of_work
-from o2common.views.pagination_view import Pagination
 from o2common.views.view import gen_filter, check_filter
+from o2common.views.pagination_view import Pagination
+from o2common.views.route_exception import BadRequestException, \
+    NotFoundException
+
 from o2ims.views.alarm_dto import SubscriptionDTO
 from o2ims.domain.alarm_obj import AlarmSubscription, AlarmEventRecord
 
@@ -71,6 +74,15 @@ def subscription_create(subscriptionDto: SubscriptionDTO.subscription_create,
         sub_uuid, subscriptionDto['callback'],
         consumer_subs_id, filter)
     with uow:
+        args = list()
+        args.append(getattr(AlarmSubscription, 'callback')
+                    == subscriptionDto['callback'])
+        args.append(getattr(AlarmSubscription, 'filter') == filter)
+        args.append(getattr(AlarmSubscription,
+                    'consumerSubscriptionId') == consumer_subs_id)
+        count, _ = uow.alarm_subscriptions.list_with_count(*args)
+        if count > 0:
+            raise BadRequestException("The value of parameters is duplicated")
         uow.alarm_subscriptions.add(subscription)
         uow.commit()
         first = uow.alarm_subscriptions.get(sub_uuid)
@@ -80,6 +92,10 @@ def subscription_create(subscriptionDto: SubscriptionDTO.subscription_create,
 def subscription_delete(subscriptionId: str,
                         uow: unit_of_work.AbstractUnitOfWork):
     with uow:
+        first = uow.alarm_subscriptions.get(subscriptionId)
+        if not first:
+            raise NotFoundException(
+                "Alarm Subscription {} not found.".format(subscriptionId))
         uow.alarm_subscriptions.delete(subscriptionId)
         uow.commit()
     return True