X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;f=internal%2Fcli%2Fhealthcheck_test.go;h=858385bbfc91b080354e429b6bf918eb12957b24;hb=b1cc9affa891649332fb034f648e44514624a956;hp=2cc06190336e3a3bc31a097ee835318defd571a3;hpb=273d032db02901dba8deeb692f92ed2366dc6ee5;p=ric-plt%2Fsdlgo.git diff --git a/internal/cli/healthcheck_test.go b/internal/cli/healthcheck_test.go index 2cc0619..858385b 100644 --- a/internal/cli/healthcheck_test.go +++ b/internal/cli/healthcheck_test.go @@ -127,6 +127,7 @@ func TestCliHealthCheckCanShowHelp(t *testing.T) { var expOkErr error expHelp := "Usage:\n " + "healthcheck [flags]" expNokErr := errors.New("unknown flag: --some-unknown-flag") + expArgCntErr := errors.New("accepts 0 arg(s), received 1") tests := []struct { args string expErr error @@ -135,6 +136,7 @@ func TestCliHealthCheckCanShowHelp(t *testing.T) { {args: "-h", expErr: expOkErr, expOutput: expHelp}, {args: "--help", expErr: expOkErr, expOutput: expHelp}, {args: "--some-unknown-flag", expErr: expNokErr, expOutput: expHelp}, + {args: "some-extra-argument", expErr: expArgCntErr, expOutput: expHelp}, } for _, test := range tests { @@ -203,7 +205,6 @@ func TestCliHealthCheckCanShowHaDeploymentStatusCorrectlyWhenOneSentinelStateNot func TestCliHealthCheckCanShowHaDeploymentStatusCorrectlyWhenDbStateQueryFails(t *testing.T) { setupHcMockMasterDb("10.20.30.40", "6379") hcMocks.dbErr = errors.New("Some error") - expCliErr := errors.New("SDL CLI error: Some error") buf := new(bytes.Buffer) cmd := cli.NewHealthCheckCmd(newMockDatabase) @@ -212,8 +213,8 @@ func TestCliHealthCheckCanShowHaDeploymentStatusCorrectlyWhenDbStateQueryFails(t err := cmd.Execute() stderr := buf.String() - assert.Equal(t, expCliErr, err) - assert.Contains(t, stderr, "Error: "+expCliErr.Error()) + assert.Equal(t, hcMocks.dbErr, err) + assert.Contains(t, stderr, "Error: "+hcMocks.dbErr.Error()) } func TestCliHealthCheckCanShowHaDeploymentOkStatusCorrectlyWhenDbStateIsFromReplicaOnly(t *testing.T) {