X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;f=enrichment-coordinator-service%2Fsrc%2Fmain%2Fjava%2Forg%2Foransc%2Fenrichment%2Fcontrollers%2FErrorResponse.java;h=921b807328bd50fcfe98d473ae29ac71d12d74a7;hb=e912ee4367d6a305ac038c86dec816b5ce71191b;hp=edaa3bb44f788533e55753fcf9fd8aea062eef87;hpb=ebf3211ddd6e634ca9c0a2fec56abd1f12c7625d;p=nonrtric.git diff --git a/enrichment-coordinator-service/src/main/java/org/oransc/enrichment/controllers/ErrorResponse.java b/enrichment-coordinator-service/src/main/java/org/oransc/enrichment/controllers/ErrorResponse.java index edaa3bb4..921b8073 100644 --- a/enrichment-coordinator-service/src/main/java/org/oransc/enrichment/controllers/ErrorResponse.java +++ b/enrichment-coordinator-service/src/main/java/org/oransc/enrichment/controllers/ErrorResponse.java @@ -1,9 +1,9 @@ /*- * ========================LICENSE_START================================= - * ONAP : ccsdk oran - * ====================================================================== - * Copyright (C) 2020 Nordix Foundation. All rights reserved. - * ====================================================================== + * O-RAN-SC + * %% + * Copyright (C) 2020 Nordix Foundation + * %% * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at @@ -27,6 +27,7 @@ import com.google.gson.annotations.SerializedName; import io.swagger.annotations.ApiModel; import io.swagger.annotations.ApiModelProperty; +import org.oransc.enrichment.exceptions.ServiceException; import org.springframework.http.HttpHeaders; import org.springframework.http.HttpStatus; import org.springframework.http.MediaType; @@ -34,11 +35,12 @@ import org.springframework.http.ResponseEntity; import reactor.core.publisher.Mono; public class ErrorResponse { - private static Gson gson = new GsonBuilder() // - .create(); // + private static Gson gson = new GsonBuilder().create(); // Returned as body for all failed REST calls - @ApiModel(value = "error_information", description = "Problem as defined in https://tools.ietf.org/html/rfc7807") + @ApiModel( + value = "ProblemDetails", + description = "A problem detail to carry details in a HTTP response according to RFC 7807") public static class ErrorInfo { @SerializedName("type") private String type = "about:blank"; @@ -61,7 +63,7 @@ public class ErrorResponse { } @ApiModelProperty( - example = "503", + example = "404", value = "The HTTP status code generated by the origin server for this occurrence of the problem.") public Integer getStatus() { return status; @@ -73,7 +75,6 @@ public class ErrorResponse { public String getDetail() { return this.detail; } - } @ApiModelProperty(value = "message") @@ -83,16 +84,25 @@ public class ErrorResponse { this.message = message; } - public static Mono> createMono(Exception e, HttpStatus code) { + public static Mono> createMono(Throwable e, HttpStatus code) { return Mono.just(create(e, code)); } - public static ResponseEntity create(Exception e, HttpStatus code) { + public static ResponseEntity create(Throwable e, HttpStatus code) { if (e instanceof RuntimeException) { code = HttpStatus.INTERNAL_SERVER_ERROR; + } else if (e instanceof ServiceException) { + ServiceException se = (ServiceException) e; + if (se.getHttpStatus() != null) { + code = se.getHttpStatus(); + } } - ErrorInfo p = new ErrorInfo(e.toString(), code.value()); - String json = gson.toJson(p); + return create(e.toString(), code); + } + + public static ResponseEntity create(String str, HttpStatus code) { + ErrorInfo errorInfo = new ErrorInfo(str, code.value()); + String json = gson.toJson(errorInfo); HttpHeaders headers = new HttpHeaders(); headers.setContentType(MediaType.APPLICATION_PROBLEM_JSON); return new ResponseEntity<>(json, headers, code);