X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;f=dmaap-mediator-producer%2Finternal%2Fserver%2Fserver_test.go;h=dbe503dd4e1b7259c5ff307bdd73747b17314596;hb=2a6b1317357b5387f98e846c3b0387384cbadf4b;hp=a4b19c43708bb686d1bb5843f76fc9cbb09c5eec;hpb=b65d86fc9b02415e1adf2415f8c4a257378e9c09;p=nonrtric.git diff --git a/dmaap-mediator-producer/internal/server/server_test.go b/dmaap-mediator-producer/internal/server/server_test.go index a4b19c43..dbe503dd 100644 --- a/dmaap-mediator-producer/internal/server/server_test.go +++ b/dmaap-mediator-producer/internal/server/server_test.go @@ -30,135 +30,205 @@ import ( "net/http/httptest" "testing" + "github.com/gorilla/mux" + "github.com/stretchr/testify/mock" "github.com/stretchr/testify/require" "oransc.org/nonrtric/dmaapmediatorproducer/internal/jobs" - "oransc.org/nonrtric/dmaapmediatorproducer/mocks/jobhandler" + "oransc.org/nonrtric/dmaapmediatorproducer/mocks/jobshandler" ) -func TestStatusHandler(t *testing.T) { +func TestNewRouter(t *testing.T) { assertions := require.New(t) + + r := NewRouter(nil, nil) + statusRoute := r.Get("health_check") + assertions.NotNil(statusRoute) + supportedMethods, err := statusRoute.GetMethods() + assertions.Equal([]string{http.MethodGet}, supportedMethods) + assertions.Nil(err) + path, _ := statusRoute.GetPathTemplate() + assertions.Equal("/health_check", path) + + addJobRoute := r.Get("add") + assertions.NotNil(addJobRoute) + supportedMethods, err = addJobRoute.GetMethods() + assertions.Equal([]string{http.MethodPost}, supportedMethods) + assertions.Nil(err) + path, _ = addJobRoute.GetPathTemplate() + assertions.Equal("/info_job", path) + + deleteJobRoute := r.Get("delete") + assertions.NotNil(deleteJobRoute) + supportedMethods, err = deleteJobRoute.GetMethods() + assertions.Equal([]string{http.MethodDelete}, supportedMethods) + assertions.Nil(err) + path, _ = deleteJobRoute.GetPathTemplate() + assertions.Equal("/info_job/{infoJobId}", path) + + notFoundHandler := r.NotFoundHandler + handler := http.HandlerFunc(notFoundHandler.ServeHTTP) + responseRecorder := httptest.NewRecorder() + handler.ServeHTTP(responseRecorder, newRequest("GET", "/wrong", nil, t)) + assertions.Equal(http.StatusNotFound, responseRecorder.Code) + assertions.Contains(responseRecorder.Body.String(), "404 not found.") + + methodNotAllowedHandler := r.MethodNotAllowedHandler + handler = http.HandlerFunc(methodNotAllowedHandler.ServeHTTP) + responseRecorder = httptest.NewRecorder() + handler.ServeHTTP(responseRecorder, newRequest(http.MethodPut, "/status", nil, t)) + assertions.Equal(http.StatusMethodNotAllowed, responseRecorder.Code) + assertions.Contains(responseRecorder.Body.String(), "Method is not supported.") + + setLogLevelRoute := r.Get("setLogLevel") + assertions.NotNil(setLogLevelRoute) + supportedMethods, err = setLogLevelRoute.GetMethods() + assertions.Equal([]string{http.MethodPut}, supportedMethods) + assertions.Nil(err) + path, _ = setLogLevelRoute.GetPathTemplate() + assertions.Equal("/admin/log", path) +} + +func TestAddInfoJobToJobsHandler(t *testing.T) { + assertions := require.New(t) + type args struct { - responseRecorder *httptest.ResponseRecorder - r *http.Request + job jobs.JobInfo + mockReturn error } tests := []struct { - name string - args args - wantedStatus int - wantedBody string + name string + args args + wantedStatus int + wantedErrorInfo *ErrorInfo }{ { - name: "StatusHandler with correct path and method, should return OK", + name: "AddInfoJobToJobsHandler with correct job, should return OK", args: args{ - responseRecorder: httptest.NewRecorder(), - r: newRequest("GET", "/status", nil, t), + job: jobs.JobInfo{ + Owner: "owner", + LastUpdated: "now", + InfoJobIdentity: "jobId", + TargetUri: "target", + InfoJobData: jobs.Parameters{}, + InfoTypeIdentity: "type", + }, }, wantedStatus: http.StatusOK, - wantedBody: "All is well!", }, { - name: "StatusHandler with incorrect path, should return NotFound", + name: "AddInfoJobToJobsHandler with incorrect job info, should return BadRequest", args: args{ - responseRecorder: httptest.NewRecorder(), - r: newRequest("GET", "/wrong", nil, t), + job: jobs.JobInfo{ + Owner: "bad", + }, + mockReturn: errors.New("error"), }, - wantedStatus: http.StatusNotFound, - wantedBody: "404 not found.\n", - }, - { - name: "StatusHandler with incorrect method, should return MethodNotAllowed", - args: args{ - responseRecorder: httptest.NewRecorder(), - r: newRequest("PUT", "/status", nil, t), + wantedStatus: http.StatusBadRequest, + wantedErrorInfo: &ErrorInfo{ + Status: http.StatusBadRequest, + Detail: "Invalid job info. Cause: error", }, - wantedStatus: http.StatusMethodNotAllowed, - wantedBody: "Method is not supported.\n", }, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { - handler := http.HandlerFunc(StatusHandler) - handler.ServeHTTP(tt.args.responseRecorder, tt.args.r) - assertions.Equal(tt.wantedStatus, tt.args.responseRecorder.Code) + jobsHandlerMock := jobshandler.JobsHandler{} + jobsHandlerMock.On("AddJobFromRESTCall", tt.args.job).Return(tt.args.mockReturn) + + callbackHandlerUnderTest := NewProducerCallbackHandler(&jobsHandlerMock) - assertions.Equal(tt.wantedBody, tt.args.responseRecorder.Body.String()) + handler := http.HandlerFunc(callbackHandlerUnderTest.addInfoJobHandler) + responseRecorder := httptest.NewRecorder() + r := newRequest(http.MethodPost, "/jobs", &tt.args.job, t) + + handler.ServeHTTP(responseRecorder, r) + + assertions.Equal(tt.wantedStatus, responseRecorder.Code, tt.name) + if tt.wantedErrorInfo != nil { + var actualErrInfo ErrorInfo + err := json.Unmarshal(getBody(responseRecorder, t), &actualErrInfo) + if err != nil { + t.Error("Unable to unmarshal error body", err) + t.Fail() + } + assertions.Equal(*tt.wantedErrorInfo, actualErrInfo, tt.name) + assertions.Equal("application/problem+json", responseRecorder.Result().Header.Get("Content-Type")) + } + jobsHandlerMock.AssertCalled(t, "AddJobFromRESTCall", tt.args.job) }) } } -func TestCreateInfoJobHandler(t *testing.T) { +func TestDeleteJob(t *testing.T) { + assertions := require.New(t) + jobsHandlerMock := jobshandler.JobsHandler{} + jobsHandlerMock.On("DeleteJobFromRESTCall", mock.Anything).Return(nil) + + callbackHandlerUnderTest := NewProducerCallbackHandler(&jobsHandlerMock) + + responseRecorder := httptest.NewRecorder() + r := mux.SetURLVars(newRequest(http.MethodDelete, "/jobs/", nil, t), map[string]string{"infoJobId": "job1"}) + handler := http.HandlerFunc(callbackHandlerUnderTest.deleteInfoJobHandler) + handler.ServeHTTP(responseRecorder, r) + assertions.Equal(http.StatusOK, responseRecorder.Result().StatusCode) + + assertions.Equal("", responseRecorder.Body.String()) + + jobsHandlerMock.AssertCalled(t, "DeleteJobFromRESTCall", "job1") +} + +func TestSetLogLevel(t *testing.T) { assertions := require.New(t) - jobHandlerMock := jobhandler.JobHandler{} - - goodJobInfo := jobs.JobInfo{ - Owner: "owner", - LastUpdated: "now", - InfoJobIdentity: "jobId", - TargetUri: "target", - InfoJobData: "{}", - InfoTypeIdentity: "type", - } - badJobInfo := jobs.JobInfo{ - Owner: "bad", - } - jobHandlerMock.On("AddJob", goodJobInfo).Return(nil) - jobHandlerMock.On("AddJob", badJobInfo).Return(errors.New("error")) - jobs.Handler = &jobHandlerMock type args struct { - responseRecorder *httptest.ResponseRecorder - r *http.Request + logLevel string } tests := []struct { - name string - args args - wantedStatus int - wantedBody string + name string + args args + wantedStatus int + wantedErrorInfo *ErrorInfo }{ { - name: "CreateInfoJobHandler with correct path and method, should return OK", + name: "Set to valid log level, should return OK", args: args{ - responseRecorder: httptest.NewRecorder(), - r: newRequest("POST", "/jobs", &goodJobInfo, t), + logLevel: "Debug", }, wantedStatus: http.StatusOK, - wantedBody: "", }, { - name: "CreateInfoJobHandler with incorrect job info, should return BadRequest", + name: "Set to invalid log level, should return BadRequest", args: args{ - responseRecorder: httptest.NewRecorder(), - r: newRequest("POST", "/jobs", &badJobInfo, t), + logLevel: "bad", }, wantedStatus: http.StatusBadRequest, - wantedBody: "Invalid job info. Cause: error", - }, - { - name: "CreateInfoJobHandler with incorrect path, should return NotFound", - args: args{ - responseRecorder: httptest.NewRecorder(), - r: newRequest("GET", "/wrong", nil, t), + wantedErrorInfo: &ErrorInfo{ + Detail: "Invalid log level: bad. Log level will not be changed!", + Status: http.StatusBadRequest, }, - wantedStatus: http.StatusNotFound, - wantedBody: "404 not found.", - }, - { - name: "CreateInfoJobHandler with incorrect method, should return MethodNotAllowed", - args: args{ - responseRecorder: httptest.NewRecorder(), - r: newRequest("PUT", "/jobs", nil, t), - }, - wantedStatus: http.StatusMethodNotAllowed, - wantedBody: "Method is not supported.", }, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { - handler := http.HandlerFunc(CreateInfoJobHandler) - handler.ServeHTTP(tt.args.responseRecorder, tt.args.r) - assertions.Equal(tt.wantedStatus, tt.args.responseRecorder.Code) + callbackHandlerUnderTest := NewProducerCallbackHandler(nil) + + handler := http.HandlerFunc(callbackHandlerUnderTest.setLogLevel) + responseRecorder := httptest.NewRecorder() + r, _ := http.NewRequest(http.MethodPut, "/admin/log?level="+tt.args.logLevel, nil) - assertions.Contains(tt.args.responseRecorder.Body.String(), tt.wantedBody) + handler.ServeHTTP(responseRecorder, r) + + assertions.Equal(tt.wantedStatus, responseRecorder.Code, tt.name) + if tt.wantedErrorInfo != nil { + var actualErrInfo ErrorInfo + err := json.Unmarshal(getBody(responseRecorder, t), &actualErrInfo) + if err != nil { + t.Error("Unable to unmarshal error body", err) + t.Fail() + } + assertions.Equal(*tt.wantedErrorInfo, actualErrInfo, tt.name) + assertions.Equal("application/problem+json", responseRecorder.Result().Header.Get("Content-Type")) + } }) } } @@ -176,3 +246,12 @@ func newRequest(method string, url string, jobInfo *jobs.JobInfo, t *testing.T) return nil } } + +func getBody(responseRecorder *httptest.ResponseRecorder, t *testing.T) []byte { + buf := new(bytes.Buffer) + if _, err := buf.ReadFrom(responseRecorder.Body); err != nil { + t.Error("Unable to read error body", err) + t.Fail() + } + return buf.Bytes() +}