X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;f=dmaap-mediator-producer%2Finternal%2Fjobs%2Fjobs_test.go;h=3651a136f0dadb7b5db342f62758a70f99ad136c;hb=2d522d44bf5f69b091380b57e2879d3b7139bc8f;hp=42fc3e23fa858dcc64246974b18d188249f40de6;hpb=63a42cacf9c52b7dff64431a3354f55c49bd6e4b;p=nonrtric.git diff --git a/dmaap-mediator-producer/internal/jobs/jobs_test.go b/dmaap-mediator-producer/internal/jobs/jobs_test.go index 42fc3e23..3651a136 100644 --- a/dmaap-mediator-producer/internal/jobs/jobs_test.go +++ b/dmaap-mediator-producer/internal/jobs/jobs_test.go @@ -21,14 +21,20 @@ package jobs import ( + "bytes" + "io/ioutil" + "net/http" "os" "path/filepath" + "sync" "testing" + "time" "github.com/stretchr/testify/require" + "oransc.org/nonrtric/dmaapmediatorproducer/internal/config" ) -const type1Schema = `{"title": "Type 1"}` +const typeDefinition = `{"types": [{"id": "type1", "dmaapTopicUrl": "events/unauthenticated.SEC_FAULT_OUTPUT/dmaapmediatorproducer/type1"}]}` func TestGetTypes_filesOkShouldReturnSliceOfTypesAndProvideSupportedTypes(t *testing.T) { assertions := require.New(t) @@ -36,29 +42,31 @@ func TestGetTypes_filesOkShouldReturnSliceOfTypesAndProvideSupportedTypes(t *tes if err != nil { t.Errorf("Unable to create temporary directory for types due to: %v", err) } - defer os.RemoveAll(typesDir) - typeDir = typesDir - fname := filepath.Join(typesDir, "type1.json") - if err = os.WriteFile(fname, []byte(type1Schema), 0666); err != nil { - t.Errorf("Unable to create temporary files for types due to: %v", err) + fname := filepath.Join(typesDir, "type_config.json") + managerUnderTest := NewJobsManagerImpl(fname, nil, "", nil) + t.Cleanup(func() { + os.RemoveAll(typesDir) + }) + if err = os.WriteFile(fname, []byte(typeDefinition), 0666); err != nil { + t.Errorf("Unable to create temporary config file for types due to: %v", err) } - types, err := GetTypes() - wantedType := Type{ - TypeId: "type1", - Schema: type1Schema, + types, err := managerUnderTest.LoadTypesFromConfiguration() + wantedType := config.TypeDefinition{ + Id: "type1", + DmaapTopicURL: "events/unauthenticated.SEC_FAULT_OUTPUT/dmaapmediatorproducer/type1", } - wantedTypes := []*Type{&wantedType} + wantedTypes := []config.TypeDefinition{wantedType} assertions.EqualValues(wantedTypes, types) assertions.Nil(err) - supportedTypes := GetSupportedTypes() + supportedTypes := managerUnderTest.GetSupportedTypes() assertions.EqualValues([]string{"type1"}, supportedTypes) } -func TestAddJob_shouldAddJobToAllJobsMap(t *testing.T) { +func TestManagerAddJobWhenTypeIsSupported_shouldAddJobToChannel(t *testing.T) { assertions := require.New(t) - allJobs["type1"] = make(map[string]JobInfo) - jobInfo := JobInfo{ + managerUnderTest := NewJobsManagerImpl("", nil, "", nil) + wantedJob := JobInfo{ Owner: "owner", LastUpdated: "now", InfoJobIdentity: "job1", @@ -66,8 +74,216 @@ func TestAddJob_shouldAddJobToAllJobsMap(t *testing.T) { InfoJobData: "{}", InfoTypeIdentity: "type1", } + jobHandler := jobHandler{ + addJobCh: make(chan JobInfo)} + managerUnderTest.allTypes["type1"] = TypeData{ + TypeId: "type1", + jobHandler: &jobHandler, + } + + var err error + go func() { + err = managerUnderTest.AddJob(wantedJob) + }() - err := AddJob(jobInfo) assertions.Nil(err) - assertions.Equal(1, len(allJobs["type1"])) + addedJob := <-jobHandler.addJobCh + assertions.Equal(wantedJob, addedJob) +} + +func TestManagerAddJobWhenTypeIsNotSupported_shouldReturnError(t *testing.T) { + assertions := require.New(t) + managerUnderTest := NewJobsManagerImpl("", nil, "", nil) + jobInfo := JobInfo{ + InfoTypeIdentity: "type1", + } + + err := managerUnderTest.AddJob(jobInfo) + assertions.NotNil(err) + assertions.Equal("type not supported: type1", err.Error()) +} + +func TestManagerAddJobWhenJobIdMissing_shouldReturnError(t *testing.T) { + assertions := require.New(t) + managerUnderTest := NewJobsManagerImpl("", nil, "", nil) + managerUnderTest.allTypes["type1"] = TypeData{ + TypeId: "type1", + } + + jobInfo := JobInfo{ + InfoTypeIdentity: "type1", + } + err := managerUnderTest.AddJob(jobInfo) + assertions.NotNil(err) + assertions.Equal("missing required job identity: { type1}", err.Error()) +} + +func TestManagerAddJobWhenTargetUriMissing_shouldReturnError(t *testing.T) { + assertions := require.New(t) + managerUnderTest := NewJobsManagerImpl("", nil, "", nil) + managerUnderTest.allTypes["type1"] = TypeData{ + TypeId: "type1", + } + + jobInfo := JobInfo{ + InfoTypeIdentity: "type1", + InfoJobIdentity: "job1", + } + err := managerUnderTest.AddJob(jobInfo) + assertions.NotNil(err) + assertions.Equal("missing required target URI: { job1 type1}", err.Error()) +} + +func TestManagerDeleteJob(t *testing.T) { + assertions := require.New(t) + managerUnderTest := NewJobsManagerImpl("", nil, "", nil) + jobHandler := jobHandler{ + deleteJobCh: make(chan string)} + managerUnderTest.allTypes["type1"] = TypeData{ + TypeId: "type1", + jobHandler: &jobHandler, + } + + go managerUnderTest.DeleteJob("job2") + + assertions.Equal("job2", <-jobHandler.deleteJobCh) +} + +func TestHandlerPollAndDistributeMessages(t *testing.T) { + assertions := require.New(t) + + wg := sync.WaitGroup{} + messages := `[{"message": {"data": "data"}}]` + pollClientMock := NewTestClient(func(req *http.Request) *http.Response { + if req.URL.String() == "http://mrAddr/topicUrl" { + assertions.Equal(req.Method, "GET") + wg.Done() // Signal that the poll call has been made + return &http.Response{ + StatusCode: 200, + Body: ioutil.NopCloser(bytes.NewReader([]byte(messages))), + Header: make(http.Header), // Must be set to non-nil value or it panics + } + } + t.Error("Wrong call to client: ", req) + t.Fail() + return nil + }) + distributeClientMock := NewTestClient(func(req *http.Request) *http.Response { + if req.URL.String() == "http://consumerHost/target" { + assertions.Equal(req.Method, "POST") + assertions.Equal(messages, getBodyAsString(req)) + assertions.Equal("application/json", req.Header.Get("Content-Type")) + wg.Done() // Signal that the distribution call has been made + return &http.Response{ + StatusCode: 200, + Body: ioutil.NopCloser(bytes.NewBufferString(`OK`)), + Header: make(http.Header), // Must be set to non-nil value or it panics + } + } + t.Error("Wrong call to client: ", req) + t.Fail() + return nil + }) + + jobInfo := JobInfo{ + InfoTypeIdentity: "type1", + InfoJobIdentity: "job1", + TargetUri: "http://consumerHost/target", + } + handlerUnderTest := jobHandler{ + topicUrl: "/topicUrl", + jobs: map[string]JobInfo{jobInfo.InfoJobIdentity: jobInfo}, + pollClient: pollClientMock, + distributeClient: distributeClientMock, + } + + wg.Add(2) // Two calls should be made to the server, one to poll and one to distribute + handlerUnderTest.pollAndDistributeMessages("http://mrAddr") + + if waitTimeout(&wg, 100*time.Millisecond) { + t.Error("Not all calls to server were made") + t.Fail() + } +} + +func TestHandlerAddJob_shouldAddJobToJobsMap(t *testing.T) { + assertions := require.New(t) + + jobInfo := JobInfo{ + InfoTypeIdentity: "type1", + InfoJobIdentity: "job1", + TargetUri: "http://consumerHost/target", + } + + addCh := make(chan JobInfo) + handlerUnderTest := jobHandler{ + mu: sync.Mutex{}, + jobs: map[string]JobInfo{}, + addJobCh: addCh, + } + + go func() { + addCh <- jobInfo + }() + + handlerUnderTest.monitorManagementChannels() + + assertions.Len(handlerUnderTest.jobs, 1) + assertions.Equal(jobInfo, handlerUnderTest.jobs["job1"]) +} + +func TestHandlerDeleteJob_shouldDeleteJobFromJobsMap(t *testing.T) { + assertions := require.New(t) + + deleteCh := make(chan string) + handlerUnderTest := jobHandler{ + mu: sync.Mutex{}, + jobs: map[string]JobInfo{"job1": { + InfoJobIdentity: "job1", + }}, + deleteJobCh: deleteCh, + } + + go func() { + deleteCh <- "job1" + }() + + handlerUnderTest.monitorManagementChannels() + + assertions.Len(handlerUnderTest.jobs, 0) +} + +type RoundTripFunc func(req *http.Request) *http.Response + +func (f RoundTripFunc) RoundTrip(req *http.Request) (*http.Response, error) { + return f(req), nil +} + +//NewTestClient returns *http.Client with Transport replaced to avoid making real calls +func NewTestClient(fn RoundTripFunc) *http.Client { + return &http.Client{ + Transport: RoundTripFunc(fn), + } +} + +// waitTimeout waits for the waitgroup for the specified max timeout. +// Returns true if waiting timed out. +func waitTimeout(wg *sync.WaitGroup, timeout time.Duration) bool { + c := make(chan struct{}) + go func() { + defer close(c) + wg.Wait() + }() + select { + case <-c: + return false // completed normally + case <-time.After(timeout): + return true // timed out + } +} + +func getBodyAsString(req *http.Request) string { + buf := new(bytes.Buffer) + buf.ReadFrom(req.Body) + return buf.String() }