X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;f=dmaap-mediator-producer%2Finternal%2Fjobs%2Fjobs_test.go;h=066823d5ab3c2a523b37046fb1769854a97f7665;hb=c0f4d277bca3ac3f3d7a7a9dfc687580dc6a1f35;hp=0941033897d2b0893cfa79771d24363863d59e4c;hpb=b1fb1d8f58d756be42a139043e4ef02374d6c434;p=nonrtric.git diff --git a/dmaap-mediator-producer/internal/jobs/jobs_test.go b/dmaap-mediator-producer/internal/jobs/jobs_test.go index 09410338..066823d5 100644 --- a/dmaap-mediator-producer/internal/jobs/jobs_test.go +++ b/dmaap-mediator-producer/internal/jobs/jobs_test.go @@ -21,50 +21,52 @@ package jobs import ( + "bytes" + "io/ioutil" + "net/http" "os" "path/filepath" + "sync" "testing" + "time" "github.com/stretchr/testify/require" + "oransc.org/nonrtric/dmaapmediatorproducer/internal/config" ) -const type1Schema = `{"title": "Type 1"}` +const typeDefinition = `{"types": [{"id": "type1", "dmaapTopicUrl": "events/unauthenticated.SEC_FAULT_OUTPUT/dmaapmediatorproducer/type1"}]}` -func TestGetTypes_filesOkShouldReturnSliceOfTypesAndProvideSupportedTypes(t *testing.T) { +func TestJobsManagerGetTypes_filesOkShouldReturnSliceOfTypesAndProvideSupportedTypes(t *testing.T) { assertions := require.New(t) typesDir, err := os.MkdirTemp("", "configs") if err != nil { t.Errorf("Unable to create temporary directory for types due to: %v", err) } + fname := filepath.Join(typesDir, "type_config.json") + managerUnderTest := NewJobsManagerImpl(fname, nil, "", nil) t.Cleanup(func() { os.RemoveAll(typesDir) - clearAll() }) - typeDir = typesDir - fname := filepath.Join(typesDir, "type1.json") - if err = os.WriteFile(fname, []byte(type1Schema), 0666); err != nil { - t.Errorf("Unable to create temporary files for types due to: %v", err) + if err = os.WriteFile(fname, []byte(typeDefinition), 0666); err != nil { + t.Errorf("Unable to create temporary config file for types due to: %v", err) } - types, err := GetTypes() - wantedType := Type{ - TypeId: "type1", - Schema: type1Schema, + types, err := managerUnderTest.LoadTypesFromConfiguration() + wantedType := config.TypeDefinition{ + Id: "type1", + DmaapTopicURL: "events/unauthenticated.SEC_FAULT_OUTPUT/dmaapmediatorproducer/type1", } - wantedTypes := []*Type{&wantedType} + wantedTypes := []config.TypeDefinition{wantedType} assertions.EqualValues(wantedTypes, types) assertions.Nil(err) - supportedTypes := GetSupportedTypes() + supportedTypes := managerUnderTest.GetSupportedTypes() assertions.EqualValues([]string{"type1"}, supportedTypes) } -func TestAddJobWhenTypeIsSupported_shouldAddJobToAllJobsMap(t *testing.T) { +func TestJobsManagerAddJobWhenTypeIsSupported_shouldAddJobToChannel(t *testing.T) { assertions := require.New(t) - allJobs["type1"] = make(map[string]JobInfo) - t.Cleanup(func() { - clearAll() - }) - jobInfo := JobInfo{ + managerUnderTest := NewJobsManagerImpl("", nil, "", nil) + wantedJob := JobInfo{ Owner: "owner", LastUpdated: "now", InfoJobIdentity: "job1", @@ -72,49 +74,221 @@ func TestAddJobWhenTypeIsSupported_shouldAddJobToAllJobsMap(t *testing.T) { InfoJobData: "{}", InfoTypeIdentity: "type1", } + jobsHandler := jobsHandler{ + addJobCh: make(chan JobInfo)} + managerUnderTest.allTypes["type1"] = TypeData{ + TypeId: "type1", + jobsHandler: &jobsHandler, + } + + var err error + go func() { + err = managerUnderTest.AddJob(wantedJob) + }() - err := AddJob(jobInfo) assertions.Nil(err) - assertions.Equal(1, len(allJobs["type1"])) - assertions.Equal(jobInfo, allJobs["type1"]["job1"]) + addedJob := <-jobsHandler.addJobCh + assertions.Equal(wantedJob, addedJob) } -func TestAddJobWhenTypeIsNotSupported_shouldReturnError(t *testing.T) { +func TestJobsManagerAddJobWhenTypeIsNotSupported_shouldReturnError(t *testing.T) { assertions := require.New(t) + managerUnderTest := NewJobsManagerImpl("", nil, "", nil) jobInfo := JobInfo{ InfoTypeIdentity: "type1", } - err := AddJob(jobInfo) + err := managerUnderTest.AddJob(jobInfo) assertions.NotNil(err) assertions.Equal("type not supported: type1", err.Error()) } -func TestAddJobWhenJobIdMissing_shouldReturnError(t *testing.T) { +func TestJobsManagerAddJobWhenJobIdMissing_shouldReturnError(t *testing.T) { assertions := require.New(t) - allJobs["type1"] = make(map[string]JobInfo) - t.Cleanup(func() { - clearAll() - }) + managerUnderTest := NewJobsManagerImpl("", nil, "", nil) + managerUnderTest.allTypes["type1"] = TypeData{ + TypeId: "type1", + } + jobInfo := JobInfo{ InfoTypeIdentity: "type1", } + err := managerUnderTest.AddJob(jobInfo) + assertions.NotNil(err) + assertions.Equal("missing required job identity: { type1}", err.Error()) +} + +func TestJobsManagerAddJobWhenTargetUriMissing_shouldReturnError(t *testing.T) { + assertions := require.New(t) + managerUnderTest := NewJobsManagerImpl("", nil, "", nil) + managerUnderTest.allTypes["type1"] = TypeData{ + TypeId: "type1", + } - err := AddJob(jobInfo) + jobInfo := JobInfo{ + InfoTypeIdentity: "type1", + InfoJobIdentity: "job1", + } + err := managerUnderTest.AddJob(jobInfo) assertions.NotNil(err) - assertions.Equal("missing required job identity: { type1}", err.Error()) + assertions.Equal("missing required target URI: { job1 type1}", err.Error()) +} + +func TestJobsManagerDeleteJob_shouldSendDeleteToChannel(t *testing.T) { + assertions := require.New(t) + managerUnderTest := NewJobsManagerImpl("", nil, "", nil) + jobsHandler := jobsHandler{ + deleteJobCh: make(chan string)} + managerUnderTest.allTypes["type1"] = TypeData{ + TypeId: "type1", + jobsHandler: &jobsHandler, + } + + go managerUnderTest.DeleteJob("job2") + + assertions.Equal("job2", <-jobsHandler.deleteJobCh) } -func TestAddJobWhenTargetUriMissing_shouldReturnError(t *testing.T) { +func TestAddJobToJobsManager_shouldStartPollAndDistributeMessages(t *testing.T) { assertions := require.New(t) - allJobs["type1"] = make(map[string]JobInfo) + + called := false + messages := `[{"message": {"data": "data"}}]` + pollClientMock := NewTestClient(func(req *http.Request) *http.Response { + if req.URL.String() == "http://mrAddr/topicUrl" { + assertions.Equal(req.Method, "GET") + body := "[]" + if !called { + called = true + body = messages + } + return &http.Response{ + StatusCode: 200, + Body: ioutil.NopCloser(bytes.NewReader([]byte(body))), + Header: make(http.Header), // Must be set to non-nil value or it panics + } + } + t.Error("Wrong call to client: ", req) + t.Fail() + return nil + }) + + wg := sync.WaitGroup{} + distributeClientMock := NewTestClient(func(req *http.Request) *http.Response { + if req.URL.String() == "http://consumerHost/target" { + assertions.Equal(req.Method, "POST") + assertions.Equal(messages, getBodyAsString(req)) + assertions.Equal("application/json", req.Header.Get("Content-Type")) + wg.Done() + return &http.Response{ + StatusCode: 200, + Body: ioutil.NopCloser(bytes.NewBufferString(`OK`)), + Header: make(http.Header), // Must be set to non-nil value or it panics + } + } + t.Error("Wrong call to client: ", req) + t.Fail() + return nil + }) + jobsHandler := newJobsHandler("type1", "/topicUrl", pollClientMock, distributeClientMock) + + jobsManager := NewJobsManagerImpl("", pollClientMock, "http://mrAddr", distributeClientMock) + jobsManager.allTypes["type1"] = TypeData{ + DMaaPTopicURL: "/topicUrl", + TypeId: "type1", + jobsHandler: jobsHandler, + } + + jobsManager.StartJobs() + jobInfo := JobInfo{ InfoTypeIdentity: "type1", InfoJobIdentity: "job1", + TargetUri: "http://consumerHost/target", } - err := AddJob(jobInfo) - assertions.NotNil(err) - assertions.Equal("missing required target URI: { job1 type1}", err.Error()) - clearAll() + wg.Add(1) // Wait till the distribution has happened + jobsManager.AddJob(jobInfo) + + if waitTimeout(&wg, 2*time.Second) { + t.Error("Not all calls to server were made") + t.Fail() + } +} + +func TestJobsHandlerDeleteJob_shouldDeleteJobFromJobsMap(t *testing.T) { + jobToDelete := newJob(JobInfo{}, nil) + go jobToDelete.start() + jobsHandler := newJobsHandler("type1", "/topicUrl", nil, nil) + jobsHandler.jobs["job1"] = jobToDelete + + go jobsHandler.monitorManagementChannels() + + jobsHandler.deleteJobCh <- "job1" + + deleted := false + for i := 0; i < 100; i++ { + if len(jobsHandler.jobs) == 0 { + deleted = true + break + } + time.Sleep(time.Microsecond) // Need to drop control to let the job's goroutine do the job + } + require.New(t).True(deleted, "Job not deleted") +} + +func TestJobsHandlerEmptyJobMessageBufferWhenItIsFull(t *testing.T) { + job := newJob(JobInfo{ + InfoJobIdentity: "job", + }, nil) + + jobsHandler := newJobsHandler("type1", "/topicUrl", nil, nil) + jobsHandler.jobs["job1"] = job + + fillMessagesBuffer(job.messagesChannel) + + jobsHandler.distributeMessages([]byte("sent msg")) + + require.New(t).Len(job.messagesChannel, 0) +} + +func fillMessagesBuffer(mc chan []byte) { + for i := 0; i < cap(mc); i++ { + mc <- []byte("msg") + } +} + +type RoundTripFunc func(req *http.Request) *http.Response + +func (f RoundTripFunc) RoundTrip(req *http.Request) (*http.Response, error) { + return f(req), nil +} + +//NewTestClient returns *http.Client with Transport replaced to avoid making real calls +func NewTestClient(fn RoundTripFunc) *http.Client { + return &http.Client{ + Transport: RoundTripFunc(fn), + } +} + +// waitTimeout waits for the waitgroup for the specified max timeout. +// Returns true if waiting timed out. +func waitTimeout(wg *sync.WaitGroup, timeout time.Duration) bool { + c := make(chan struct{}) + go func() { + defer close(c) + wg.Wait() + }() + select { + case <-c: + return false // completed normally + case <-time.After(timeout): + return true // timed out + } +} + +func getBodyAsString(req *http.Request) string { + buf := new(bytes.Buffer) + buf.ReadFrom(req.Body) + return buf.String() }