X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;f=dmaap-mediator-producer%2Finternal%2Fconfig%2Fconfig_test.go;h=fc64e575a3032016208ab6345503cc31f0b523d1;hb=65a53d2388547247222d144b365401056bbdffc5;hp=104302726406fc9a970c176fffc18e013ad6aa9c;hpb=280385634f160bb78a8944998e9106a2f6549eb0;p=nonrtric.git diff --git a/dmaap-mediator-producer/internal/config/config_test.go b/dmaap-mediator-producer/internal/config/config_test.go index 10430272..fc64e575 100644 --- a/dmaap-mediator-producer/internal/config/config_test.go +++ b/dmaap-mediator-producer/internal/config/config_test.go @@ -31,11 +31,10 @@ import ( ) func TestNew_envVarsSetConfigContainSetValues(t *testing.T) { + assertions := require.New(t) os.Setenv("LOG_LEVEL", "Debug") - os.Setenv("INFO_PRODUCER_SUPERVISION_CALLBACK_HOST", "supervisionCallbackHost") - os.Setenv("INFO_PRODUCER_SUPERVISION_CALLBACK_PORT", "8095") - os.Setenv("INFO_JOB_CALLBACK_HOST", "jobCallbackHost") - os.Setenv("INFO_JOB_CALLBACK_PORT", "8096") + os.Setenv("INFO_PRODUCER_HOST", "producerHost") + os.Setenv("INFO_PRODUCER_PORT", "8095") os.Setenv("INFO_COORD_ADDR", "infoCoordAddr") os.Setenv("MR_HOST", "mrHost") os.Setenv("MR_PORT", "3908") @@ -43,18 +42,16 @@ func TestNew_envVarsSetConfigContainSetValues(t *testing.T) { os.Clearenv() }) wantConfig := Config{ - LogLevel: "Debug", - InfoProducerSupervisionCallbackHost: "supervisionCallbackHost", - InfoProducerSupervisionCallbackPort: 8095, - InfoJobCallbackHost: "jobCallbackHost", - InfoJobCallbackPort: 8096, - InfoCoordinatorAddress: "infoCoordAddr", - MRHost: "mrHost", - MRPort: 3908, - } - if got := New(); !reflect.DeepEqual(got, &wantConfig) { - t.Errorf("New() = %v, want %v", got, &wantConfig) + LogLevel: log.DebugLevel, + InfoProducerHost: "producerHost", + InfoProducerPort: 8095, + InfoCoordinatorAddress: "infoCoordAddr", + MRHost: "mrHost", + MRPort: 3908, } + got := New() + + assertions.Equal(&wantConfig, got) } func TestNew_faultyIntValueSetConfigContainDefaultValueAndWarnInLog(t *testing.T) { @@ -62,40 +59,49 @@ func TestNew_faultyIntValueSetConfigContainDefaultValueAndWarnInLog(t *testing.T var buf bytes.Buffer log.SetOutput(&buf) - os.Setenv("INFO_PRODUCER_SUPERVISION_CALLBACK_PORT", "wrong") + os.Setenv("INFO_PRODUCER_PORT", "wrong") t.Cleanup(func() { log.SetOutput(os.Stderr) os.Clearenv() }) wantConfig := Config{ - LogLevel: "Info", - InfoProducerSupervisionCallbackHost: "", - InfoProducerSupervisionCallbackPort: 8085, - InfoJobCallbackHost: "", - InfoJobCallbackPort: 8086, - InfoCoordinatorAddress: "http://enrichmentservice:8083", - MRHost: "http://message-router.onap", - MRPort: 3904, + LogLevel: log.InfoLevel, + InfoProducerHost: "", + InfoProducerPort: 8085, + InfoCoordinatorAddress: "http://enrichmentservice:8083", + MRHost: "http://message-router.onap", + MRPort: 3904, } if got := New(); !reflect.DeepEqual(got, &wantConfig) { t.Errorf("New() = %v, want %v", got, &wantConfig) } logString := buf.String() - assertions.Contains(logString, "Invalid int value: wrong for variable: INFO_PRODUCER_SUPERVISION_CALLBACK_PORT. Default value: 8085 will be used") + assertions.Contains(logString, "Invalid int value: wrong for variable: INFO_PRODUCER_PORT. Default value: 8085 will be used") } -func TestNew_envVarsNotSetConfigContainDefaultValues(t *testing.T) { +func TestNew_envFaultyLogLevelConfigContainDefaultValues(t *testing.T) { + assertions := require.New(t) + var buf bytes.Buffer + log.SetOutput(&buf) + + os.Setenv("LOG_LEVEL", "wrong") + t.Cleanup(func() { + log.SetOutput(os.Stderr) + os.Clearenv() + }) + wantConfig := Config{ - LogLevel: "Info", - InfoProducerSupervisionCallbackHost: "", - InfoProducerSupervisionCallbackPort: 8085, - InfoJobCallbackHost: "", - InfoJobCallbackPort: 8086, - InfoCoordinatorAddress: "http://enrichmentservice:8083", - MRHost: "http://message-router.onap", - MRPort: 3904, - } - if got := New(); !reflect.DeepEqual(got, &wantConfig) { - t.Errorf("New() = %v, want %v", got, &wantConfig) + LogLevel: log.InfoLevel, + InfoProducerHost: "", + InfoProducerPort: 8085, + InfoCoordinatorAddress: "http://enrichmentservice:8083", + MRHost: "http://message-router.onap", + MRPort: 3904, } + + got := New() + + assertions.Equal(&wantConfig, got) + logString := buf.String() + assertions.Contains(logString, "Invalid log level: wrong. Log level will be Info!") }