X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;f=dmaap-adaptor-java%2Fsrc%2Fmain%2Fjava%2Forg%2Foran%2Fdmaapadapter%2Fcontrollers%2FProducerCallbacksController.java;h=94f9f8db9ea8788732bdf314e88865fc53f58778;hb=f07ca52477eb610cf49c13b2d34f7e2c2eab3f74;hp=07f5aa72b4fdda2d5117aa2c8e3ddbc99c54917b;hpb=5ee9fd987436011e7130eb05126858cfe54ca545;p=nonrtric.git diff --git a/dmaap-adaptor-java/src/main/java/org/oran/dmaapadapter/controllers/ProducerCallbacksController.java b/dmaap-adaptor-java/src/main/java/org/oran/dmaapadapter/controllers/ProducerCallbacksController.java index 07f5aa72..94f9f8db 100644 --- a/dmaap-adaptor-java/src/main/java/org/oran/dmaapadapter/controllers/ProducerCallbacksController.java +++ b/dmaap-adaptor-java/src/main/java/org/oran/dmaapadapter/controllers/ProducerCallbacksController.java @@ -34,6 +34,7 @@ import io.swagger.v3.oas.annotations.tags.Tag; import java.util.ArrayList; import java.util.Collection; +import org.oran.dmaapadapter.exceptions.ServiceException; import org.oran.dmaapadapter.r1.ProducerJobInfo; import org.oran.dmaapadapter.repository.InfoTypes; import org.oran.dmaapadapter.repository.Job; @@ -58,8 +59,8 @@ public class ProducerCallbacksController { public static final String API_NAME = "Producer job control API"; public static final String API_DESCRIPTION = ""; - public static final String JOB_URL = "/dmaap_dataproducer/info_job"; - public static final String SUPERVISION_URL = "/dmaap_dataproducer/health_check"; + public static final String JOB_URL = "/generic_dataproducer/info_job"; + public static final String SUPERVISION_URL = "/generic_dataproducer/health_check"; private static Gson gson = new GsonBuilder().create(); private final Jobs jobs; private final InfoTypes types; @@ -77,6 +78,8 @@ public class ProducerCallbacksController { content = @Content(schema = @Schema(implementation = VoidResponse.class))), // @ApiResponse(responseCode = "404", description = "Information type is not found", // content = @Content(schema = @Schema(implementation = ErrorResponse.ErrorInfo.class))), // + @ApiResponse(responseCode = "400", description = "Other error in the request", // + content = @Content(schema = @Schema(implementation = ErrorResponse.ErrorInfo.class))) // }) public ResponseEntity jobCreatedCallback( // @RequestBody String body) { @@ -86,8 +89,12 @@ public class ProducerCallbacksController { this.jobs.addJob(request.id, request.targetUri, types.getType(request.typeId), request.owner, request.lastUpdated, toJobParameters(request.jobData)); return new ResponseEntity<>(HttpStatus.OK); + } catch (ServiceException e) { + logger.warn("jobCreatedCallback failed: {}", e.getMessage()); + return ErrorResponse.create(e, e.getHttpStatus()); } catch (Exception e) { - return ErrorResponse.create(e, HttpStatus.NOT_FOUND); + logger.warn("jobCreatedCallback failed: {}", e.getMessage()); + return ErrorResponse.create(e, HttpStatus.BAD_REQUEST); } }