X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;f=capifcore%2Finternal%2Fpublishservice%2Fpublishservice_test.go;fp=capifcore%2Finternal%2Fpublishservice%2Fpublishservice_test.go;h=a6310714c3a5f7cddbf12b73ea97928413a356b5;hb=c956436e747ab021a2593aae4f46fdbc66ece7fb;hp=9262b112d4e6255e9413f3c59a3a60bb9cc5599a;hpb=f5f140a783fbe4afcecf409f5712dd3e0d4d6ea4;p=nonrtric%2Fplt%2Fsme.git

diff --git a/capifcore/internal/publishservice/publishservice_test.go b/capifcore/internal/publishservice/publishservice_test.go
index 9262b11..a631071 100644
--- a/capifcore/internal/publishservice/publishservice_test.go
+++ b/capifcore/internal/publishservice/publishservice_test.go
@@ -26,6 +26,7 @@ import (
 	"os"
 	"testing"
 
+	"oransc.org/nonrtric/capifcore/internal/common29122"
 	"oransc.org/nonrtric/capifcore/internal/providermanagement"
 
 	"github.com/labstack/echo/v4"
@@ -60,32 +61,7 @@ func TestPublishUnpublishService(t *testing.T) {
 	domainName := "domain"
 	var protocol publishapi.Protocol = "HTTP_1_1"
 	description := "Description,namespace,repoName,chartName,releaseName"
-	newServiceDescription := publishapi.ServiceAPIDescription{
-		AefProfiles: &[]publishapi.AefProfile{
-			{
-				AefId:      aefId,
-				DomainName: &domainName,
-				Protocol:   &protocol,
-				Versions: []publishapi.Version{
-					{
-						ApiVersion: "v1",
-						Resources: &[]publishapi.Resource{
-							{
-								CommType: "REQUEST_RESPONSE",
-								Operations: &[]publishapi.Operation{
-									"POST",
-								},
-								ResourceName: "app",
-								Uri:          "app",
-							},
-						},
-					},
-				},
-			},
-		},
-		ApiName:     "app-management",
-		Description: &description,
-	}
+	newServiceDescription := getServiceAPIDescription(aefId, domainName, description, protocol)
 
 	// Publish a service
 	result = testutil.NewRequest().Post("/aefId/service-apis").WithJsonBody(newServiceDescription).Go(t, requestHandler)
@@ -126,6 +102,30 @@ func TestPublishUnpublishService(t *testing.T) {
 	assert.Equal(t, http.StatusNotFound, result.Code())
 }
 
+func TestPostUnpublishedServiceWithUnregisteredFunction(t *testing.T) {
+	aefId := "aefId"
+	serviceRegisterMock := serviceMocks.ServiceRegister{}
+	serviceRegisterMock.On("IsFunctionRegistered", aefId).Return(false)
+	_, requestHandler := getEcho(&serviceRegisterMock, nil)
+
+	domainName := "domain"
+	var protocol publishapi.Protocol = "HTTP_1_1"
+	description := "Description"
+	newServiceDescription := getServiceAPIDescription(aefId, domainName, description, protocol)
+
+	// Publish a service
+	result := testutil.NewRequest().Post("/aefId/service-apis").WithJsonBody(newServiceDescription).Go(t, requestHandler)
+
+	assert.Equal(t, http.StatusNotFound, result.Code())
+	var resultError common29122.ProblemDetails
+	err := result.UnmarshalBodyToObject(&resultError)
+	assert.NoError(t, err, "error unmarshaling response")
+	errMsg := "Function not registered, aefId"
+	assert.Equal(t, &errMsg, resultError.Cause)
+	notFound := http.StatusNotFound
+	assert.Equal(t, &notFound, resultError.Status)
+}
+
 func getEcho(serviceRegister providermanagement.ServiceRegister, helmManager helmmanagement.HelmManager) (*PublishService, *echo.Echo) {
 	swagger, err := publishapi.GetSwagger()
 	if err != nil {
@@ -144,3 +144,32 @@ func getEcho(serviceRegister providermanagement.ServiceRegister, helmManager hel
 	publishapi.RegisterHandlers(e, ps)
 	return ps, e
 }
+
+func getServiceAPIDescription(aefId, domainName, description string, protocol publishapi.Protocol) publishapi.ServiceAPIDescription {
+	return publishapi.ServiceAPIDescription{
+		AefProfiles: &[]publishapi.AefProfile{
+			{
+				AefId:      aefId,
+				DomainName: &domainName,
+				Protocol:   &protocol,
+				Versions: []publishapi.Version{
+					{
+						ApiVersion: "v1",
+						Resources: &[]publishapi.Resource{
+							{
+								CommType: "REQUEST_RESPONSE",
+								Operations: &[]publishapi.Operation{
+									"POST",
+								},
+								ResourceName: "app",
+								Uri:          "app",
+							},
+						},
+					},
+				},
+			},
+		},
+		ApiName:     "app-management",
+		Description: &description,
+	}
+}