X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;f=capifcore%2Finternal%2Fprovidermanagement%2Fprovidermanagement.go;h=5e9211e494dc1b4dd50822bf173de2253283477c;hb=c21e101767fbde3a091a0ee7fef7782fedbe5b37;hp=cb76c3a530339d2970e956454e0d6e366626741f;hpb=6245ef94c3d8d2b016b8c47881dae2fcccbf054a;p=nonrtric%2Fplt%2Fsme.git diff --git a/capifcore/internal/providermanagement/providermanagement.go b/capifcore/internal/providermanagement/providermanagement.go index cb76c3a..5e9211e 100644 --- a/capifcore/internal/providermanagement/providermanagement.go +++ b/capifcore/internal/providermanagement/providermanagement.go @@ -71,12 +71,17 @@ func (pm *ProviderManager) GetAefsForPublisher(apfId string) []string { func (pm *ProviderManager) PostRegistrations(ctx echo.Context) error { var newProvider provapi.APIProviderEnrolmentDetails + errMsg := "Unable to register provider due to %s" if err := ctx.Bind(&newProvider); err != nil { - return sendCoreError(ctx, http.StatusBadRequest, "Invalid format for provider") + return sendCoreError(ctx, http.StatusBadRequest, fmt.Sprintf(errMsg, "invalid format for provider")) + } + + if pm.isProviderRegistered(newProvider) { + return sendCoreError(ctx, http.StatusForbidden, fmt.Sprintf(errMsg, "provider already registered")) } if err := newProvider.Validate(); err != nil { - return sendCoreError(ctx, http.StatusBadRequest, fmt.Sprintf("Provider not valid due to %s", err)) + return sendCoreError(ctx, http.StatusBadRequest, fmt.Sprintf(errMsg, err)) } pm.prepareNewProvider(&newProvider) @@ -90,6 +95,15 @@ func (pm *ProviderManager) PostRegistrations(ctx echo.Context) error { return nil } +func (pm *ProviderManager) isProviderRegistered(newProvider provapi.APIProviderEnrolmentDetails) bool { + for _, prov := range pm.registeredProviders { + if prov.IsRegistered(newProvider) { + return true + } + } + return false +} + func (pm *ProviderManager) prepareNewProvider(newProvider *provapi.APIProviderEnrolmentDetails) { pm.lock.Lock() defer pm.lock.Unlock()