X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;f=capifcore%2Finternal%2Finvokermanagement%2Finvokermanagement_test.go;fp=capifcore%2Finternal%2Finvokermanagement%2Finvokermanagement_test.go;h=4365eb320283fe3a11e94021f46dd15a8efc41e4;hb=19830e74d96947d3296d0a91bf59f0af8b425404;hp=e5fa008f7b50f0a9755359e947a5c9de35ac2d38;hpb=c3cc44190afd4793d76f3cc5814b8b5e79267fb3;p=nonrtric%2Fplt%2Fsme.git

diff --git a/capifcore/internal/invokermanagement/invokermanagement_test.go b/capifcore/internal/invokermanagement/invokermanagement_test.go
index e5fa008..4365eb3 100644
--- a/capifcore/internal/invokermanagement/invokermanagement_test.go
+++ b/capifcore/internal/invokermanagement/invokermanagement_test.go
@@ -87,20 +87,28 @@ func TestOnboardInvoker(t *testing.T) {
 		assert.Equal(t, eventsapi.CAPIFEventAPIINVOKERONBOARDED, invokerEvent.Events)
 	}
 
+	// Onboarding the same invoker should result in Forbidden
+	result = testutil.NewRequest().Post("/onboardedInvokers").WithJsonBody(newInvoker).Go(t, requestHandler)
+
+	assert.Equal(t, http.StatusForbidden, result.Code())
+	var problemDetails common29122.ProblemDetails
+	err = result.UnmarshalBodyToObject(&problemDetails)
+	assert.NoError(t, err, "error unmarshaling response")
+	assert.Equal(t, http.StatusForbidden, *problemDetails.Status)
+	assert.Contains(t, *problemDetails.Cause, "already onboarded")
+
 	// Onboard an invoker missing required NotificationDestination, should get 400 with problem details
 	invalidInvoker := invokermanagementapi.APIInvokerEnrolmentDetails{
 		OnboardingInformation: invokermanagementapi.OnboardingInformation{
-			ApiInvokerPublicKey: "key",
+			ApiInvokerPublicKey: "newKey",
 		},
 	}
 	result = testutil.NewRequest().Post("/onboardedInvokers").WithJsonBody(invalidInvoker).Go(t, requestHandler)
 
 	assert.Equal(t, http.StatusBadRequest, result.Code())
-	var problemDetails common29122.ProblemDetails
 	err = result.UnmarshalBodyToObject(&problemDetails)
 	assert.NoError(t, err, "error unmarshaling response")
-	badRequest := http.StatusBadRequest
-	assert.Equal(t, &badRequest, problemDetails.Status)
+	assert.Equal(t, http.StatusBadRequest, *problemDetails.Status)
 	assert.Contains(t, *problemDetails.Cause, "missing")
 	assert.Contains(t, *problemDetails.Cause, "NotificationDestination")
 
@@ -114,7 +122,7 @@ func TestOnboardInvoker(t *testing.T) {
 	assert.Equal(t, http.StatusBadRequest, result.Code())
 	err = result.UnmarshalBodyToObject(&problemDetails)
 	assert.NoError(t, err, "error unmarshaling response")
-	assert.Equal(t, &badRequest, problemDetails.Status)
+	assert.Equal(t, http.StatusBadRequest, *problemDetails.Status)
 	assert.Contains(t, *problemDetails.Cause, "missing")
 	assert.Contains(t, *problemDetails.Cause, "OnboardingInformation.ApiInvokerPublicKey")
 }
@@ -190,8 +198,7 @@ func TestUpdateInvoker(t *testing.T) {
 	var problemDetails common29122.ProblemDetails
 	err = result.UnmarshalBodyToObject(&problemDetails)
 	assert.NoError(t, err, "error unmarshaling response")
-	badRequest := http.StatusBadRequest
-	assert.Equal(t, &badRequest, problemDetails.Status)
+	assert.Equal(t, http.StatusBadRequest, *problemDetails.Status)
 	assert.Contains(t, *problemDetails.Cause, "missing")
 	assert.Contains(t, *problemDetails.Cause, "NotificationDestination")
 
@@ -203,7 +210,7 @@ func TestUpdateInvoker(t *testing.T) {
 	assert.Equal(t, http.StatusBadRequest, result.Code())
 	err = result.UnmarshalBodyToObject(&problemDetails)
 	assert.NoError(t, err, "error unmarshaling response")
-	assert.Equal(t, &badRequest, problemDetails.Status)
+	assert.Equal(t, http.StatusBadRequest, *problemDetails.Status)
 	assert.Contains(t, *problemDetails.Cause, "missing")
 	assert.Contains(t, *problemDetails.Cause, "OnboardingInformation.ApiInvokerPublicKey")
 
@@ -216,7 +223,7 @@ func TestUpdateInvoker(t *testing.T) {
 	assert.Equal(t, http.StatusBadRequest, result.Code())
 	err = result.UnmarshalBodyToObject(&problemDetails)
 	assert.NoError(t, err, "error unmarshaling response")
-	assert.Equal(t, &badRequest, problemDetails.Status)
+	assert.Equal(t, http.StatusBadRequest, *problemDetails.Status)
 	assert.Contains(t, *problemDetails.Cause, "not matching")
 	assert.Contains(t, *problemDetails.Cause, "ApiInvokerId")
 
@@ -228,8 +235,7 @@ func TestUpdateInvoker(t *testing.T) {
 	assert.Equal(t, http.StatusNotFound, result.Code())
 	err = result.UnmarshalBodyToObject(&problemDetails)
 	assert.NoError(t, err, "error unmarshaling response")
-	notFound := http.StatusNotFound
-	assert.Equal(t, &notFound, problemDetails.Status)
+	assert.Equal(t, http.StatusNotFound, *problemDetails.Status)
 	assert.Contains(t, *problemDetails.Cause, "not been onboarded")
 	assert.Contains(t, *problemDetails.Cause, "invoker")
 }