X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;f=capifcore%2Finternal%2Feventservice%2Feventservice_test.go;h=d0b646b299d601858665bc3813d683e3c3aaa3d3;hb=refs%2Fchanges%2F19%2F10319%2F1;hp=a328e5799010825e0252ff18b509d3b3b38d3e32;hpb=8a4c1cda83ec4c3ff7fabc7591278dfe90e18c18;p=nonrtric%2Fplt%2Fsme.git

diff --git a/capifcore/internal/eventservice/eventservice_test.go b/capifcore/internal/eventservice/eventservice_test.go
index a328e57..d0b646b 100644
--- a/capifcore/internal/eventservice/eventservice_test.go
+++ b/capifcore/internal/eventservice/eventservice_test.go
@@ -24,7 +24,7 @@ import (
 	"bytes"
 	"encoding/json"
 	"fmt"
-	"io/ioutil"
+	"io"
 	"net/http"
 	"os"
 	"path"
@@ -48,7 +48,7 @@ func TestRegisterSubscriptions(t *testing.T) {
 		Events: []eventsapi.CAPIFEvent{
 			eventsapi.CAPIFEventSERVICEAPIAVAILABLE,
 		},
-		NotificationDestination: common29122.Uri("notificationUrl"),
+		NotificationDestination: common29122.Uri("http://golang.cafe/"),
 	}
 	serviceUnderTest, requestHandler := getEcho(nil)
 	subscriberId := "subscriberId"
@@ -77,6 +77,27 @@ func TestRegisterSubscriptions(t *testing.T) {
 	assert.Equal(t, subscription2, *registeredSub2)
 }
 
+func TestRegisterInvalidSubscription(t *testing.T) {
+	subscription1 := eventsapi.EventSubscription{
+		Events: []eventsapi.CAPIFEvent{eventsapi.CAPIFEventACCESSCONTROLPOLICYUNAVAILABLE},
+	}
+	serviceUnderTest, requestHandler := getEcho(nil)
+	subscriberId := "subscriberId"
+
+	result := testutil.NewRequest().Post("/"+subscriberId+"/subscriptions").WithJsonBody(subscription1).Go(t, requestHandler)
+	assert.Equal(t, http.StatusBadRequest, result.Code())
+	var problemDetails common29122.ProblemDetails
+	err := result.UnmarshalBodyToObject(&problemDetails)
+	assert.NoError(t, err, "error unmarshaling response")
+	badRequest := http.StatusBadRequest
+	assert.Equal(t, &badRequest, problemDetails.Status)
+	assert.Contains(t, *problemDetails.Cause, "missing")
+	assert.Contains(t, *problemDetails.Cause, "notificationDestination")
+	subscriptionId := path.Base(result.Recorder.Header().Get(echo.HeaderLocation))
+	registeredSub := serviceUnderTest.getSubscription(subscriptionId)
+	assert.Nil(t, registeredSub)
+}
+
 func TestDeregisterSubscription(t *testing.T) {
 	subscription := eventsapi.EventSubscription{
 		Events: []eventsapi.CAPIFEvent{
@@ -113,7 +134,7 @@ func TestSendEvent(t *testing.T) {
 			wg.Done()
 			return &http.Response{
 				StatusCode: 200,
-				Body:       ioutil.NopCloser(bytes.NewBufferString(`OK`)),
+				Body:       io.NopCloser(bytes.NewBufferString(`OK`)),
 				Header:     make(http.Header), // Must be set to non-nil value or it panics
 			}
 		}
@@ -143,7 +164,7 @@ func TestSendEvent(t *testing.T) {
 	}()
 
 	if waitTimeout(&wg, 1*time.Second) {
-		t.Error("Not all calls to server were made")
+		t.Error("No event notification was sent")
 		t.Fail()
 	}
 }