X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;f=RSM%2Fcontrollers%2Fcontroller_test.go;fp=RSM%2Fcontrollers%2Fcontroller_test.go;h=db5462ed75fcc3796f8a764aff43084d7540a466;hb=60652d98d51ee23c1eaca2e8bc2bf19c74c57658;hp=cc27b3c29d3043b89fd93874ac3bc90363428d56;hpb=b8d3ff3abf409da49ecab244cd6d2c2124dbce7c;p=ric-plt%2Fresource-status-manager.git diff --git a/RSM/controllers/controller_test.go b/RSM/controllers/controller_test.go index cc27b3c..db5462e 100644 --- a/RSM/controllers/controller_test.go +++ b/RSM/controllers/controller_test.go @@ -20,37 +20,129 @@ package controllers -/* import ( "encoding/json" "fmt" + "gerrit.o-ran-sc.org/r/ric-plt/nodeb-rnib.git/entities" "github.com/stretchr/testify/assert" + "github.com/stretchr/testify/mock" "io" "io/ioutil" "net/http" "net/http/httptest" "rsm/configuration" + "rsm/enums" + "rsm/logger" "rsm/mocks" "rsm/models" "rsm/providers/httpmsghandlerprovider" "rsm/rsmerrors" - "rsm/tests/testhelper" + "rsm/services" + "rsm/tests" + "strings" "testing" ) -func setupControllerTest(t *testing.T) (*Controller, *mocks.RnibReaderMock, *mocks.RmrMessengerMock) { - config := configuration.ParseConfiguration() +func setupControllerTest(t *testing.T) (*Controller, *mocks.RnibReaderMock, *mocks.RsmReaderMock, *mocks.RsmWriterMock, *mocks.ResourceStatusServiceMock) { + log, err := logger.InitLogger(logger.DebugLevel) + if err != nil { + t.Errorf("#... - failed to initialize logger, error: %s", err) + } - rmrMessengerMock := &mocks.RmrMessengerMock{} - readerMock := &mocks.RnibReaderMock{} - rnibDataService, rmrSender, log := testhelper.InitTestCase(t) - handlerProvider := httpmsghandlerprovider.NewRequestHandlerProvider(log, rmrSender, config, rnibDataService) + config, err := configuration.ParseConfiguration() + if err != nil { + t.Errorf("#... - failed to parse configuration error: %s", err) + } + + resourceStatusServiceMock := &mocks.ResourceStatusServiceMock{} + rnibReaderMock := &mocks.RnibReaderMock{} + rsmReaderMock := &mocks.RsmReaderMock{} + rsmWriterMock := &mocks.RsmWriterMock{} + + rnibDataService := services.NewRnibDataService(log, config, rnibReaderMock, rsmReaderMock, rsmWriterMock) + handlerProvider := httpmsghandlerprovider.NewRequestHandlerProvider(log, rnibDataService, resourceStatusServiceMock) controller := NewController(log, handlerProvider) - return controller, readerMock, rmrMessengerMock + return controller, rnibReaderMock, rsmReaderMock, rsmWriterMock, resourceStatusServiceMock +} + +func TestResourceStatusInvalidBody(t *testing.T) { + controller, _, _, _ , _:= setupControllerTest(t) + + header := http.Header{} + header.Set("Content-Type", "application/json") + httpRequest, _ := http.NewRequest("PUT", "http://localhost:4800/v1/general/resourcestatus", strings.NewReader("{}{}")) + httpRequest.Header = header + + writer := httptest.NewRecorder() + controller.ResourceStatus(writer, httpRequest) + + var errorResponse = parseJsonRequest(t, writer.Body) + + assert.Equal(t, http.StatusBadRequest, writer.Result().StatusCode) + assert.Equal(t, rsmerrors.NewInvalidJsonError().Code, errorResponse.Code) +} + +func TestResourceStatusSuccess(t *testing.T) { + controller, readerMock, rsmReaderMock, rsmWriterMock, resourceStatusServiceMock := setupControllerTest(t) + + cellId1 := "02f829:0007ab00" + cellId2 := "02f829:0007ab50" + nodebInfo := &entities.NodebInfo{ + RanName: tests.RanName, + ConnectionStatus: entities.ConnectionStatus_CONNECTED, + Configuration: &entities.NodebInfo_Enb{ + Enb: &entities.Enb{ + ServedCells: []*entities.ServedCellInfo{{CellId: cellId1}, {CellId: cellId2}}, + }, + }, + } + var nbIdentityList []*entities.NbIdentity + config := tests.GetRsmGeneralConfiguration(true) + + rsmWriterMock.On("SaveRsmGeneralConfiguration", config).Return(nil) + rsmReaderMock.On("GetRsmGeneralConfiguration").Return(config, nil) + readerMock.On("GetListEnbIds").Return(nbIdentityList, nil) + readerMock.On("GetNodeb", tests.RanName).Return(nodebInfo) + resourceStatusServiceMock.On("BuildAndSendInitiateRequest", mock.AnythingOfType("*entities.NodebInfo"), mock.AnythingOfType("*models.RsmGeneralConfiguration"), enums.Enb1MeasurementId).Return(nil) + + header := http.Header{} + header.Set("Content-Type", "application/json") + httpRequest, _ := http.NewRequest("PUT", "http://localhost:4800/v1/general/resourcestatus", strings.NewReader("{\"enableResourceStatus\":true}")) + httpRequest.Header = header + + writer := httptest.NewRecorder() + controller.ResourceStatus(writer, httpRequest) + + readerMock.AssertNumberOfCalls(t, "GetListEnbIds", 1) + resourceStatusServiceMock.AssertNumberOfCalls(t, "BuildAndSendInitiateRequest", 0) + + assert.Equal(t, http.StatusNoContent, writer.Result().StatusCode) +} + +func TestResourceStatusFail(t *testing.T) { + + controller, readerMock, rsmReaderMock, _, resourceStatusServiceMock := setupControllerTest(t) + + rnibErr := &rsmerrors.RnibDbError{} + + rsmReaderMock.On("GetRsmGeneralConfiguration").Return(tests.GetRsmGeneralConfiguration(true), rnibErr) + + header := http.Header{} + header.Set("Content-Type", "application/json") + httpRequest, _ := http.NewRequest("PUT", "http://localhost:4800/v1/general/resourcestatus", strings.NewReader("{\"enableResourceStatus\":true}")) + httpRequest.Header = header + + writer := httptest.NewRecorder() + controller.ResourceStatus(writer, httpRequest) + + readerMock.AssertNumberOfCalls(t, "GetListEnbIds", 0) + resourceStatusServiceMock.AssertNumberOfCalls(t, "BuildAndSendInitiateRequest", 0) + + assert.Equal(t, http.StatusInternalServerError, writer.Result().StatusCode) } func TestHeaderValidationFailed(t *testing.T) { - controller, _, _ := setupControllerTest(t) + controller, _, _ ,_ , _:= setupControllerTest(t) writer := httptest.NewRecorder() header := &http.Header{} @@ -62,9 +154,9 @@ func TestHeaderValidationFailed(t *testing.T) { assert.Equal(t, errorResponse.Code, err.Code) assert.Equal(t, errorResponse.Message, err.Message) } -*/ -/*func TestHandleInternalError(t *testing.T) { - controller, _, _ := setupControllerTest(t) + +func TestHandleInternalError(t *testing.T) { + controller, _, _,_ ,_ := setupControllerTest(t) writer := httptest.NewRecorder() err := rsmerrors.NewInternalError() @@ -75,10 +167,10 @@ func TestHeaderValidationFailed(t *testing.T) { assert.Equal(t, http.StatusInternalServerError, writer.Result().StatusCode) assert.Equal(t, errorResponse.Code, err.Code) assert.Equal(t, errorResponse.Message, err.Message) -}*/ +} -/*func TestValidateHeadersSuccess(t *testing.T) { - controller, _, _ := setupControllerTest(t) +func TestValidateHeadersSuccess(t *testing.T) { + controller, _, _,_ ,_ := setupControllerTest(t) header := http.Header{} header.Set("Content-Type", "application/json") @@ -86,8 +178,8 @@ func TestHeaderValidationFailed(t *testing.T) { assert.Nil(t, result) } -*/ -/*func parseJsonRequest(t *testing.T, r io.Reader) models.ErrorResponse { + +func parseJsonRequest(t *testing.T, r io.Reader) models.ErrorResponse { var errorResponse models.ErrorResponse body, err := ioutil.ReadAll(r) @@ -97,10 +189,10 @@ func TestHeaderValidationFailed(t *testing.T) { json.Unmarshal(body, &errorResponse) return errorResponse -}*/ -/* +} + func TestHandleErrorResponse(t *testing.T) { - controller, _, _ := setupControllerTest(t) + controller, _, _ ,_ , _:= setupControllerTest(t) writer := httptest.NewRecorder() controller.handleErrorResponse(rsmerrors.NewRnibDbError(), writer) @@ -133,5 +225,8 @@ func TestHandleErrorResponse(t *testing.T) { writer = httptest.NewRecorder() controller.handleErrorResponse(fmt.Errorf("ErrorError"), writer) assert.Equal(t, http.StatusInternalServerError, writer.Result().StatusCode) -} -*/ \ No newline at end of file + + writer = httptest.NewRecorder() + controller.handleErrorResponse(rsmerrors.NewRsmError(2), writer) + assert.Equal(t, http.StatusInternalServerError, writer.Result().StatusCode) +} \ No newline at end of file