X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;f=E2Manager%2Fservices%2Frnib_data_service_test.go;h=5460608b701bf291d09958c98a5cf98d2d48d077;hb=1de6ad01ae4a10222b07f144509e496eab99da9d;hp=8d57b4ec42d08e9ec828306edeb6fbdca425d1d8;hpb=de19068aaa1f3d2b415cd960106121ceb167aaa9;p=ric-plt%2Fe2mgr.git diff --git a/E2Manager/services/rnib_data_service_test.go b/E2Manager/services/rnib_data_service_test.go index 8d57b4e..5460608 100644 --- a/E2Manager/services/rnib_data_service_test.go +++ b/E2Manager/services/rnib_data_service_test.go @@ -13,7 +13,9 @@ // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. -// + +// This source code is part of the near-RT RIC (RAN Intelligent Controller) +// platform project (RICP). package services @@ -21,11 +23,9 @@ import ( "e2mgr/configuration" "e2mgr/logger" "e2mgr/mocks" - "e2mgr/rNibWriter" "fmt" "gerrit.o-ran-sc.org/r/ric-plt/nodeb-rnib.git/common" "gerrit.o-ran-sc.org/r/ric-plt/nodeb-rnib.git/entities" - "gerrit.o-ran-sc.org/r/ric-plt/nodeb-rnib.git/reader" "github.com/stretchr/testify/assert" "net" "strings" @@ -42,19 +42,13 @@ func setupRnibDataServiceTestWithMaxAttempts(t *testing.T, maxAttempts int) (*rN t.Errorf("#... - failed to initialize logger, error: %s", err) } - config := &configuration.Configuration{RnibRetryIntervalMs: 10, MaxRnibConnectionAttempts: maxAttempts} + config := &configuration.Configuration{RnibRetryIntervalMs: 10, MaxRnibConnectionAttempts: maxAttempts, RnibWriter: configuration.RnibWriterConfig{RanManipulationMessageChannel: "RAN_MANIPULATION", StateChangeMessageChannel: "RAN_CONNECTION_STATUS_CHANGE"}} readerMock := &mocks.RnibReaderMock{} - rnibReaderProvider := func() reader.RNibReader { - return readerMock - } writerMock := &mocks.RnibWriterMock{} - rnibWriterProvider := func() rNibWriter.RNibWriter { - return writerMock - } - rnibDataService := NewRnibDataService(logger, config, rnibReaderProvider, rnibWriterProvider) + rnibDataService := NewRnibDataService(logger, config, readerMock, writerMock) assert.NotNil(t, rnibDataService) return rnibDataService, readerMock, writerMock @@ -64,10 +58,9 @@ func TestSuccessfulSaveNodeb(t *testing.T) { rnibDataService, _, writerMock := setupRnibDataServiceTest(t) nodebInfo := &entities.NodebInfo{} - nbIdentity := &entities.NbIdentity{} - writerMock.On("SaveNodeb", nbIdentity, nodebInfo).Return(nil) + writerMock.On("SaveNodeb", nodebInfo).Return(nil) - rnibDataService.SaveNodeb(nbIdentity, nodebInfo) + rnibDataService.SaveNodeb(nodebInfo) writerMock.AssertNumberOfCalls(t, "SaveNodeb", 1) } @@ -75,11 +68,10 @@ func TestConnFailureSaveNodeb(t *testing.T) { rnibDataService, _, writerMock := setupRnibDataServiceTest(t) nodebInfo := &entities.NodebInfo{} - nbIdentity := &entities.NbIdentity{} mockErr := &common.InternalError{Err: &net.OpError{Err: fmt.Errorf("connection error")}} - writerMock.On("SaveNodeb", nbIdentity, nodebInfo).Return(mockErr) + writerMock.On("SaveNodeb", nodebInfo).Return(mockErr) - rnibDataService.SaveNodeb(nbIdentity, nodebInfo) + rnibDataService.SaveNodeb(nodebInfo) writerMock.AssertNumberOfCalls(t, "SaveNodeb", 3) } @@ -87,11 +79,10 @@ func TestNonConnFailureSaveNodeb(t *testing.T) { rnibDataService, _, writerMock := setupRnibDataServiceTest(t) nodebInfo := &entities.NodebInfo{} - nbIdentity := &entities.NbIdentity{} mockErr := &common.InternalError{Err: fmt.Errorf("non connection failure")} - writerMock.On("SaveNodeb", nbIdentity, nodebInfo).Return(mockErr) + writerMock.On("SaveNodeb", nodebInfo).Return(mockErr) - rnibDataService.SaveNodeb(nbIdentity, nodebInfo) + rnibDataService.SaveNodeb(nodebInfo) writerMock.AssertNumberOfCalls(t, "SaveNodeb", 1) } @@ -162,7 +153,7 @@ func TestConnFailureGetNodeb(t *testing.T) { res, err := rnibDataService.GetNodeb(invName) readerMock.AssertNumberOfCalls(t, "GetNodeb", 3) - assert.True(t, strings.Contains(err.Error(), "connection error", )) + assert.True(t, strings.Contains(err.Error(), "connection error")) assert.Equal(t, nodeb, res) } @@ -187,7 +178,7 @@ func TestConnFailureGetNodebIdList(t *testing.T) { res, err := rnibDataService.GetListNodebIds() readerMock.AssertNumberOfCalls(t, "GetListNodebIds", 3) - assert.True(t, strings.Contains(err.Error(), "connection error", )) + assert.True(t, strings.Contains(err.Error(), "connection error")) assert.Equal(t, nodeIds, res) } @@ -203,12 +194,12 @@ func TestConnFailureTwiceGetNodebIdList(t *testing.T) { res, err := rnibDataService.GetListNodebIds() readerMock.AssertNumberOfCalls(t, "GetListNodebIds", 3) - assert.True(t, strings.Contains(err.Error(), "connection error", )) + assert.True(t, strings.Contains(err.Error(), "connection error")) assert.Equal(t, nodeIds, res) res2, err := rnibDataService.GetNodeb(invName) readerMock.AssertNumberOfCalls(t, "GetNodeb", 3) - assert.True(t, strings.Contains(err.Error(), "connection error", )) + assert.True(t, strings.Contains(err.Error(), "connection error")) assert.Equal(t, nodeb, res2) } @@ -221,7 +212,7 @@ func TestConnFailureWithAnotherConfig(t *testing.T) { res, err := rnibDataService.GetListNodebIds() readerMock.AssertNumberOfCalls(t, "GetListNodebIds", 5) - assert.True(t, strings.Contains(err.Error(), "connection error", )) + assert.True(t, strings.Contains(err.Error(), "connection error")) assert.Equal(t, nodeIds, res) } @@ -260,17 +251,101 @@ func TestPingRnibOkOtherError(t *testing.T) { assert.True(t, res) } -//func TestConnFailureThenSuccessGetNodebIdList(t *testing.T) { -// rnibDataService, readerMock, _ := setupRnibDataServiceTest(t) -// -// var nilNodeIds []*entities.NbIdentity = nil -// nodeIds := []*entities.NbIdentity{} -// mockErr := &common.InternalError{Err: &net.OpError{Err:fmt.Errorf("connection error")}} -// //readerMock.On("GetListNodebIds").Return(nilNodeIds, mockErr) -// //readerMock.On("GetListNodebIds").Return(nodeIds, nil) -// -// res, err := rnibDataService.GetListNodebIds() -// readerMock.AssertNumberOfCalls(t, "GetListNodebIds", 2) -// assert.True(t, strings.Contains(err.Error(),"connection failure", )) -// assert.Equal(t, nodeIds, res) -//} +func TestSuccessfulUpdateNodebInfoOnConnectionStatusInversion(t *testing.T) { + rnibDataService, _, writerMock := setupRnibDataServiceTest(t) + event := "event" + + nodebInfo := &entities.NodebInfo{} + writerMock.On("UpdateNodebInfoOnConnectionStatusInversion", nodebInfo, event).Return(nil) + + rnibDataService.UpdateNodebInfoOnConnectionStatusInversion(nodebInfo, event) + writerMock.AssertNumberOfCalls(t, "UpdateNodebInfoOnConnectionStatusInversion", 1) +} + +func TestConnFailureUpdateNodebInfoOnConnectionStatusInversion(t *testing.T) { + rnibDataService, _, writerMock := setupRnibDataServiceTest(t) + event := "event" + + nodebInfo := &entities.NodebInfo{} + mockErr := &common.InternalError{Err: &net.OpError{Err: fmt.Errorf("connection error")}} + writerMock.On("UpdateNodebInfoOnConnectionStatusInversion", nodebInfo, event).Return(mockErr) + + rnibDataService.UpdateNodebInfoOnConnectionStatusInversion(nodebInfo, event) + writerMock.AssertNumberOfCalls(t, "UpdateNodebInfoOnConnectionStatusInversion", 3) +} + +func TestGetE2TInstanceConnFailure(t *testing.T) { + rnibDataService, readerMock, _ := setupRnibDataServiceTest(t) + + address := "10.10.5.20:3200" + var e2tInstance *entities.E2TInstance = nil + mockErr := &common.InternalError{Err: &net.OpError{Err: fmt.Errorf("connection error")}} + readerMock.On("GetE2TInstance", address).Return(e2tInstance, mockErr) + + res, err := rnibDataService.GetE2TInstance(address) + readerMock.AssertNumberOfCalls(t, "GetE2TInstance", 3) + assert.Nil(t, res) + assert.NotNil(t, err) +} + +func TestGetE2TInstanceOkNoError(t *testing.T) { + rnibDataService, readerMock, _ := setupRnibDataServiceTest(t) + + address := "10.10.5.20:3200" + e2tInstance := &entities.E2TInstance{} + readerMock.On("GetE2TInstance", address).Return(e2tInstance, nil) + + res, err := rnibDataService.GetE2TInstance(address) + readerMock.AssertNumberOfCalls(t, "GetE2TInstance", 1) + assert.Nil(t, err) + assert.Equal(t, e2tInstance, res) +} + +func TestGetE2TInstanceOkOtherError(t *testing.T) { + rnibDataService, readerMock, _ := setupRnibDataServiceTest(t) + + address := "10.10.5.20:3200" + var e2tInstance *entities.E2TInstance = nil + mockErr := &common.InternalError{Err: fmt.Errorf("non connection error")} + readerMock.On("GetE2TInstance", address).Return(e2tInstance, mockErr) + + res, err := rnibDataService.GetE2TInstance(address) + readerMock.AssertNumberOfCalls(t, "GetE2TInstance", 1) + assert.Nil(t, res) + assert.NotNil(t, err) +} + +func TestRemoveEnbConnFailure(t *testing.T) { + rnibDataService, _, writerMock := setupRnibDataServiceTest(t) + + mockErr := &common.InternalError{Err: &net.OpError{Err: fmt.Errorf("connection error")}} + nodebInfo := &entities.NodebInfo{} + writerMock.On("RemoveEnb", nodebInfo).Return(mockErr) + + err := rnibDataService.RemoveEnb(nodebInfo) + writerMock.AssertNumberOfCalls(t, "RemoveEnb", 3) + assert.NotNil(t, err) +} + +func TestRemoveEnbOkNoError(t *testing.T) { + rnibDataService, _, writerMock := setupRnibDataServiceTest(t) + + nodebInfo := &entities.NodebInfo{} + writerMock.On("RemoveEnb", nodebInfo).Return(nil) + + err := rnibDataService.RemoveEnb(nodebInfo) + writerMock.AssertNumberOfCalls(t, "RemoveEnb", 1) + assert.Nil(t, err) +} + +func TestRemoveEnbOtherError(t *testing.T) { + rnibDataService, _, writerMock := setupRnibDataServiceTest(t) + + mockErr := &common.InternalError{Err: fmt.Errorf("non connection error")} + nodebInfo := &entities.NodebInfo{} + writerMock.On("RemoveEnb", nodebInfo).Return(mockErr) + + err := rnibDataService.RemoveEnb(nodebInfo) + writerMock.AssertNumberOfCalls(t, "RemoveEnb", 1) + assert.NotNil(t, err) +}