X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;f=E2Manager%2Fservices%2Frnib_data_service_test.go;h=5460608b701bf291d09958c98a5cf98d2d48d077;hb=1b494b60c1208b51b4625144007ee2a3acb4efd1;hp=7a96310677243629429cdcbd293ce9dabbaf3550;hpb=e3623cf1310f8c8d2fd9b5842102516b9be3b441;p=ric-plt%2Fe2mgr.git diff --git a/E2Manager/services/rnib_data_service_test.go b/E2Manager/services/rnib_data_service_test.go index 7a96310..5460608 100644 --- a/E2Manager/services/rnib_data_service_test.go +++ b/E2Manager/services/rnib_data_service_test.go @@ -1,81 +1,93 @@ +// +// Copyright 2019 AT&T Intellectual Property +// Copyright 2019 Nokia +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +// This source code is part of the near-RT RIC (RAN Intelligent Controller) +// platform project (RICP). + package services import ( "e2mgr/configuration" "e2mgr/logger" "e2mgr/mocks" - "e2mgr/rNibWriter" "fmt" "gerrit.o-ran-sc.org/r/ric-plt/nodeb-rnib.git/common" "gerrit.o-ran-sc.org/r/ric-plt/nodeb-rnib.git/entities" - "gerrit.o-ran-sc.org/r/ric-plt/nodeb-rnib.git/reader" "github.com/stretchr/testify/assert" "net" "strings" "testing" ) -func setupTest(t *testing.T) (*rNibDataService, *mocks.RnibReaderMock, *mocks.RnibWriterMock) { +func setupRnibDataServiceTest(t *testing.T) (*rNibDataService, *mocks.RnibReaderMock, *mocks.RnibWriterMock) { + return setupRnibDataServiceTestWithMaxAttempts(t, 3) +} + +func setupRnibDataServiceTestWithMaxAttempts(t *testing.T, maxAttempts int) (*rNibDataService, *mocks.RnibReaderMock, *mocks.RnibWriterMock) { logger, err := logger.InitLogger(logger.DebugLevel) if err != nil { t.Errorf("#... - failed to initialize logger, error: %s", err) } - config := &configuration.Configuration{RnibRetryIntervalMs: 10, MaxRnibConnectionAttempts: 3} + config := &configuration.Configuration{RnibRetryIntervalMs: 10, MaxRnibConnectionAttempts: maxAttempts, RnibWriter: configuration.RnibWriterConfig{RanManipulationMessageChannel: "RAN_MANIPULATION", StateChangeMessageChannel: "RAN_CONNECTION_STATUS_CHANGE"}} readerMock := &mocks.RnibReaderMock{} - rnibReaderProvider := func() reader.RNibReader { - return readerMock - } writerMock := &mocks.RnibWriterMock{} - rnibWriterProvider := func() rNibWriter.RNibWriter { - return writerMock - } - rnibDataService := NewRnibDataService(logger, config, rnibReaderProvider, rnibWriterProvider) + rnibDataService := NewRnibDataService(logger, config, readerMock, writerMock) assert.NotNil(t, rnibDataService) return rnibDataService, readerMock, writerMock } func TestSuccessfulSaveNodeb(t *testing.T) { - rnibDataService, _, writerMock := setupTest(t) + rnibDataService, _, writerMock := setupRnibDataServiceTest(t) nodebInfo := &entities.NodebInfo{} - nbIdentity := &entities.NbIdentity{} - writerMock.On("SaveNodeb", nbIdentity, nodebInfo).Return(nil) + writerMock.On("SaveNodeb", nodebInfo).Return(nil) - rnibDataService.SaveNodeb(nbIdentity, nodebInfo) + rnibDataService.SaveNodeb(nodebInfo) writerMock.AssertNumberOfCalls(t, "SaveNodeb", 1) } func TestConnFailureSaveNodeb(t *testing.T) { - rnibDataService, _, writerMock := setupTest(t) + rnibDataService, _, writerMock := setupRnibDataServiceTest(t) nodebInfo := &entities.NodebInfo{} - nbIdentity := &entities.NbIdentity{} - mockErr := common.InternalError{Err: &net.OpError{Err: fmt.Errorf("connection error")}} - writerMock.On("SaveNodeb", nbIdentity, nodebInfo).Return(mockErr) + mockErr := &common.InternalError{Err: &net.OpError{Err: fmt.Errorf("connection error")}} + writerMock.On("SaveNodeb", nodebInfo).Return(mockErr) - rnibDataService.SaveNodeb(nbIdentity, nodebInfo) + rnibDataService.SaveNodeb(nodebInfo) writerMock.AssertNumberOfCalls(t, "SaveNodeb", 3) } func TestNonConnFailureSaveNodeb(t *testing.T) { - rnibDataService, _, writerMock := setupTest(t) + rnibDataService, _, writerMock := setupRnibDataServiceTest(t) nodebInfo := &entities.NodebInfo{} - nbIdentity := &entities.NbIdentity{} - mockErr := common.InternalError{Err: fmt.Errorf("non connection failure")} - writerMock.On("SaveNodeb", nbIdentity, nodebInfo).Return(mockErr) + mockErr := &common.InternalError{Err: fmt.Errorf("non connection failure")} + writerMock.On("SaveNodeb", nodebInfo).Return(mockErr) - rnibDataService.SaveNodeb(nbIdentity, nodebInfo) + rnibDataService.SaveNodeb(nodebInfo) writerMock.AssertNumberOfCalls(t, "SaveNodeb", 1) } func TestSuccessfulUpdateNodebInfo(t *testing.T) { - rnibDataService, _, writerMock := setupTest(t) + rnibDataService, _, writerMock := setupRnibDataServiceTest(t) nodebInfo := &entities.NodebInfo{} writerMock.On("UpdateNodebInfo", nodebInfo).Return(nil) @@ -85,10 +97,10 @@ func TestSuccessfulUpdateNodebInfo(t *testing.T) { } func TestConnFailureUpdateNodebInfo(t *testing.T) { - rnibDataService, _, writerMock := setupTest(t) + rnibDataService, _, writerMock := setupRnibDataServiceTest(t) nodebInfo := &entities.NodebInfo{} - mockErr := common.InternalError{Err: &net.OpError{Err: fmt.Errorf("connection error")}} + mockErr := &common.InternalError{Err: &net.OpError{Err: fmt.Errorf("connection error")}} writerMock.On("UpdateNodebInfo", nodebInfo).Return(mockErr) rnibDataService.UpdateNodebInfo(nodebInfo) @@ -96,7 +108,7 @@ func TestConnFailureUpdateNodebInfo(t *testing.T) { } func TestSuccessfulSaveRanLoadInformation(t *testing.T) { - rnibDataService, _, writerMock := setupTest(t) + rnibDataService, _, writerMock := setupRnibDataServiceTest(t) var ranName string = "abcd" ranLoadInformation := &entities.RanLoadInformation{} @@ -107,11 +119,11 @@ func TestSuccessfulSaveRanLoadInformation(t *testing.T) { } func TestConnFailureSaveRanLoadInformation(t *testing.T) { - rnibDataService, _, writerMock := setupTest(t) + rnibDataService, _, writerMock := setupRnibDataServiceTest(t) var ranName string = "abcd" ranLoadInformation := &entities.RanLoadInformation{} - mockErr := common.InternalError{Err: &net.OpError{Err: fmt.Errorf("connection error")}} + mockErr := &common.InternalError{Err: &net.OpError{Err: fmt.Errorf("connection error")}} writerMock.On("SaveRanLoadInformation", ranName, ranLoadInformation).Return(mockErr) rnibDataService.SaveRanLoadInformation(ranName, ranLoadInformation) @@ -119,7 +131,7 @@ func TestConnFailureSaveRanLoadInformation(t *testing.T) { } func TestSuccessfulGetNodeb(t *testing.T) { - rnibDataService, readerMock, _ := setupTest(t) + rnibDataService, readerMock, _ := setupRnibDataServiceTest(t) invName := "abcd" nodebInfo := &entities.NodebInfo{} @@ -132,21 +144,21 @@ func TestSuccessfulGetNodeb(t *testing.T) { } func TestConnFailureGetNodeb(t *testing.T) { - rnibDataService, readerMock, _ := setupTest(t) + rnibDataService, readerMock, _ := setupRnibDataServiceTest(t) invName := "abcd" var nodeb *entities.NodebInfo = nil - mockErr := common.InternalError{Err: &net.OpError{Err: fmt.Errorf("connection error")}} + mockErr := &common.InternalError{Err: &net.OpError{Err: fmt.Errorf("connection error")}} readerMock.On("GetNodeb", invName).Return(nodeb, mockErr) res, err := rnibDataService.GetNodeb(invName) readerMock.AssertNumberOfCalls(t, "GetNodeb", 3) - assert.True(t, strings.Contains(err.Error(), "connection error", )) + assert.True(t, strings.Contains(err.Error(), "connection error")) assert.Equal(t, nodeb, res) } func TestSuccessfulGetNodebIdList(t *testing.T) { - rnibDataService, readerMock, _ := setupTest(t) + rnibDataService, readerMock, _ := setupRnibDataServiceTest(t) nodeIds := []*entities.NbIdentity{} readerMock.On("GetListNodebIds").Return(nodeIds, nil) @@ -158,29 +170,182 @@ func TestSuccessfulGetNodebIdList(t *testing.T) { } func TestConnFailureGetNodebIdList(t *testing.T) { - rnibDataService, readerMock, _ := setupTest(t) + rnibDataService, readerMock, _ := setupRnibDataServiceTest(t) var nodeIds []*entities.NbIdentity = nil - mockErr := common.InternalError{Err: &net.OpError{Err: fmt.Errorf("connection error")}} + mockErr := &common.InternalError{Err: &net.OpError{Err: fmt.Errorf("connection error")}} readerMock.On("GetListNodebIds").Return(nodeIds, mockErr) res, err := rnibDataService.GetListNodebIds() readerMock.AssertNumberOfCalls(t, "GetListNodebIds", 3) - assert.True(t, strings.Contains(err.Error(), "connection error", )) + assert.True(t, strings.Contains(err.Error(), "connection error")) assert.Equal(t, nodeIds, res) } -//func TestConnFailureThenSuccessGetNodebIdList(t *testing.T) { -// rnibDataService, readerMock, _ := setupTest(t) -// -// var nilNodeIds []*entities.NbIdentity = nil -// nodeIds := []*entities.NbIdentity{} -// mockErr := common.InternalError{Err: &net.OpError{Err:fmt.Errorf("connection error")}} -// //readerMock.On("GetListNodebIds").Return(nilNodeIds, mockErr) -// //readerMock.On("GetListNodebIds").Return(nodeIds, nil) -// -// res, err := rnibDataService.GetListNodebIds() -// readerMock.AssertNumberOfCalls(t, "GetListNodebIds", 2) -// assert.True(t, strings.Contains(err.Error(),"connection failure", )) -// assert.Equal(t, nodeIds, res) -//} +func TestConnFailureTwiceGetNodebIdList(t *testing.T) { + rnibDataService, readerMock, _ := setupRnibDataServiceTest(t) + + invName := "abcd" + var nodeb *entities.NodebInfo = nil + var nodeIds []*entities.NbIdentity = nil + mockErr := &common.InternalError{Err: &net.OpError{Err: fmt.Errorf("connection error")}} + readerMock.On("GetNodeb", invName).Return(nodeb, mockErr) + readerMock.On("GetListNodebIds").Return(nodeIds, mockErr) + + res, err := rnibDataService.GetListNodebIds() + readerMock.AssertNumberOfCalls(t, "GetListNodebIds", 3) + assert.True(t, strings.Contains(err.Error(), "connection error")) + assert.Equal(t, nodeIds, res) + + res2, err := rnibDataService.GetNodeb(invName) + readerMock.AssertNumberOfCalls(t, "GetNodeb", 3) + assert.True(t, strings.Contains(err.Error(), "connection error")) + assert.Equal(t, nodeb, res2) +} + +func TestConnFailureWithAnotherConfig(t *testing.T) { + rnibDataService, readerMock, _ := setupRnibDataServiceTestWithMaxAttempts(t, 5) + + var nodeIds []*entities.NbIdentity = nil + mockErr := &common.InternalError{Err: &net.OpError{Err: fmt.Errorf("connection error")}} + readerMock.On("GetListNodebIds").Return(nodeIds, mockErr) + + res, err := rnibDataService.GetListNodebIds() + readerMock.AssertNumberOfCalls(t, "GetListNodebIds", 5) + assert.True(t, strings.Contains(err.Error(), "connection error")) + assert.Equal(t, nodeIds, res) +} + +func TestPingRnibConnFailure(t *testing.T) { + rnibDataService, readerMock, _ := setupRnibDataServiceTest(t) + + var nodeIds []*entities.NbIdentity = nil + mockErr := &common.InternalError{Err: &net.OpError{Err: fmt.Errorf("connection error")}} + readerMock.On("GetListNodebIds").Return(nodeIds, mockErr) + + res := rnibDataService.PingRnib() + readerMock.AssertNumberOfCalls(t, "GetListNodebIds", 3) + assert.False(t, res) +} + +func TestPingRnibOkNoError(t *testing.T) { + rnibDataService, readerMock, _ := setupRnibDataServiceTest(t) + + var nodeIds []*entities.NbIdentity = nil + readerMock.On("GetListNodebIds").Return(nodeIds, nil) + + res := rnibDataService.PingRnib() + readerMock.AssertNumberOfCalls(t, "GetListNodebIds", 1) + assert.True(t, res) +} + +func TestPingRnibOkOtherError(t *testing.T) { + rnibDataService, readerMock, _ := setupRnibDataServiceTest(t) + + var nodeIds []*entities.NbIdentity = nil + mockErr := &common.InternalError{Err: fmt.Errorf("non connection error")} + readerMock.On("GetListNodebIds").Return(nodeIds, mockErr) + + res := rnibDataService.PingRnib() + readerMock.AssertNumberOfCalls(t, "GetListNodebIds", 1) + assert.True(t, res) +} + +func TestSuccessfulUpdateNodebInfoOnConnectionStatusInversion(t *testing.T) { + rnibDataService, _, writerMock := setupRnibDataServiceTest(t) + event := "event" + + nodebInfo := &entities.NodebInfo{} + writerMock.On("UpdateNodebInfoOnConnectionStatusInversion", nodebInfo, event).Return(nil) + + rnibDataService.UpdateNodebInfoOnConnectionStatusInversion(nodebInfo, event) + writerMock.AssertNumberOfCalls(t, "UpdateNodebInfoOnConnectionStatusInversion", 1) +} + +func TestConnFailureUpdateNodebInfoOnConnectionStatusInversion(t *testing.T) { + rnibDataService, _, writerMock := setupRnibDataServiceTest(t) + event := "event" + + nodebInfo := &entities.NodebInfo{} + mockErr := &common.InternalError{Err: &net.OpError{Err: fmt.Errorf("connection error")}} + writerMock.On("UpdateNodebInfoOnConnectionStatusInversion", nodebInfo, event).Return(mockErr) + + rnibDataService.UpdateNodebInfoOnConnectionStatusInversion(nodebInfo, event) + writerMock.AssertNumberOfCalls(t, "UpdateNodebInfoOnConnectionStatusInversion", 3) +} + +func TestGetE2TInstanceConnFailure(t *testing.T) { + rnibDataService, readerMock, _ := setupRnibDataServiceTest(t) + + address := "10.10.5.20:3200" + var e2tInstance *entities.E2TInstance = nil + mockErr := &common.InternalError{Err: &net.OpError{Err: fmt.Errorf("connection error")}} + readerMock.On("GetE2TInstance", address).Return(e2tInstance, mockErr) + + res, err := rnibDataService.GetE2TInstance(address) + readerMock.AssertNumberOfCalls(t, "GetE2TInstance", 3) + assert.Nil(t, res) + assert.NotNil(t, err) +} + +func TestGetE2TInstanceOkNoError(t *testing.T) { + rnibDataService, readerMock, _ := setupRnibDataServiceTest(t) + + address := "10.10.5.20:3200" + e2tInstance := &entities.E2TInstance{} + readerMock.On("GetE2TInstance", address).Return(e2tInstance, nil) + + res, err := rnibDataService.GetE2TInstance(address) + readerMock.AssertNumberOfCalls(t, "GetE2TInstance", 1) + assert.Nil(t, err) + assert.Equal(t, e2tInstance, res) +} + +func TestGetE2TInstanceOkOtherError(t *testing.T) { + rnibDataService, readerMock, _ := setupRnibDataServiceTest(t) + + address := "10.10.5.20:3200" + var e2tInstance *entities.E2TInstance = nil + mockErr := &common.InternalError{Err: fmt.Errorf("non connection error")} + readerMock.On("GetE2TInstance", address).Return(e2tInstance, mockErr) + + res, err := rnibDataService.GetE2TInstance(address) + readerMock.AssertNumberOfCalls(t, "GetE2TInstance", 1) + assert.Nil(t, res) + assert.NotNil(t, err) +} + +func TestRemoveEnbConnFailure(t *testing.T) { + rnibDataService, _, writerMock := setupRnibDataServiceTest(t) + + mockErr := &common.InternalError{Err: &net.OpError{Err: fmt.Errorf("connection error")}} + nodebInfo := &entities.NodebInfo{} + writerMock.On("RemoveEnb", nodebInfo).Return(mockErr) + + err := rnibDataService.RemoveEnb(nodebInfo) + writerMock.AssertNumberOfCalls(t, "RemoveEnb", 3) + assert.NotNil(t, err) +} + +func TestRemoveEnbOkNoError(t *testing.T) { + rnibDataService, _, writerMock := setupRnibDataServiceTest(t) + + nodebInfo := &entities.NodebInfo{} + writerMock.On("RemoveEnb", nodebInfo).Return(nil) + + err := rnibDataService.RemoveEnb(nodebInfo) + writerMock.AssertNumberOfCalls(t, "RemoveEnb", 1) + assert.Nil(t, err) +} + +func TestRemoveEnbOtherError(t *testing.T) { + rnibDataService, _, writerMock := setupRnibDataServiceTest(t) + + mockErr := &common.InternalError{Err: fmt.Errorf("non connection error")} + nodebInfo := &entities.NodebInfo{} + writerMock.On("RemoveEnb", nodebInfo).Return(mockErr) + + err := rnibDataService.RemoveEnb(nodebInfo) + writerMock.AssertNumberOfCalls(t, "RemoveEnb", 1) + assert.NotNil(t, err) +}