X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;f=E2Manager%2FrNibWriter%2FrNibWriter_test.go;h=ecdd9d6af6131e6005cb2bfc342c895a71d50a42;hb=28c0585ff0a4779b938d284a9abc64fbe381bee0;hp=3dadce8fa093ba3948992f48edfd88718128825b;hpb=dc8932a553fabccf33b5cbb4e37084362493dbcf;p=ric-plt%2Fe2mgr.git diff --git a/E2Manager/rNibWriter/rNibWriter_test.go b/E2Manager/rNibWriter/rNibWriter_test.go index 3dadce8..ecdd9d6 100644 --- a/E2Manager/rNibWriter/rNibWriter_test.go +++ b/E2Manager/rNibWriter/rNibWriter_test.go @@ -1,6 +1,7 @@ // // Copyright 2019 AT&T Intellectual Property // Copyright 2019 Nokia +// Copyright 2023 Capgemini // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. @@ -33,15 +34,17 @@ import ( "time" ) -var namespace = "namespace" +var namespace = common.GetRNibNamespace() const ( RanName = "test" + PlmnId = "02f829" + NbId = "4a952a0a" ) -func initSdlInstanceMock(namespace string) (w RNibWriter, sdlInstanceMock *mocks.MockSdlInstance) { - sdlInstanceMock = new(mocks.MockSdlInstance) - w = GetRNibWriter(sdlInstanceMock, configuration.RnibWriterConfig{StateChangeMessageChannel: "RAN_CONNECTION_STATUS_CHANGE", RanManipulationMessageChannel: "RAN_MANIPULATION"}) +func initSdlMock() (w RNibWriter, sdlMock *mocks.MockSdlSyncStorage) { + sdlMock = new(mocks.MockSdlSyncStorage) + w = GetRNibWriter(sdlMock, configuration.RnibWriterConfig{StateChangeMessageChannel: "RAN_CONNECTION_STATUS_CHANGE", RanManipulationMessageChannel: "RAN_MANIPULATION"}) return } @@ -74,9 +77,7 @@ func generateServedNrCells(cellIds ...string) []*entities.ServedNRCell { servedNrCells = append(servedNrCells, &entities.ServedNRCell{ServedNrCellInformation: &entities.ServedNRCellInformation{ CellId: v, ChoiceNrMode: &entities.ServedNRCellInformation_ChoiceNRMode{ - Fdd: &entities.ServedNRCellInformation_ChoiceNRMode_FddInfo{ - - }, + Fdd: &entities.ServedNRCellInformation_ChoiceNRMode_FddInfo{}, }, NrMode: entities.Nr_FDD, NrPci: uint32(i + 1), @@ -120,39 +121,75 @@ func generateServedCellInfos(cellIds ...string) []*entities.ServedCellInfo { } func TestRemoveServedNrCellsSuccess(t *testing.T) { - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() servedNrCellsToRemove := generateServedNrCells("whatever1", "whatever2") - sdlInstanceMock.On("Remove", buildServedNRCellKeysToRemove(RanName, servedNrCellsToRemove)).Return(nil) + sdlMock.On("Remove", namespace, buildServedNRCellKeysToRemove(RanName, servedNrCellsToRemove)).Return(nil) err := w.RemoveServedNrCells(RanName, servedNrCellsToRemove) assert.Nil(t, err) } func TestRemoveServedNrCellsFailure(t *testing.T) { - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() servedNrCellsToRemove := generateServedNrCells("whatever1", "whatever2") - sdlInstanceMock.On("Remove", buildServedNRCellKeysToRemove(RanName, servedNrCellsToRemove)).Return(errors.New("expected error")) + sdlMock.On("Remove", namespace, buildServedNRCellKeysToRemove(RanName, servedNrCellsToRemove)).Return(errors.New("expected error")) err := w.RemoveServedNrCells(RanName, servedNrCellsToRemove) assert.IsType(t, &common.InternalError{}, err) } func TestUpdateGnbCellsInvalidNodebInfoFailure(t *testing.T) { - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() servedNrCells := generateServedNrCells("test1", "test2") nodebInfo := &entities.NodebInfo{} - sdlInstanceMock.AssertNotCalled(t, "Set") + sdlMock.AssertNotCalled(t, "SetAndPublish") rNibErr := w.UpdateGnbCells(nodebInfo, servedNrCells) assert.IsType(t, &common.ValidationError{}, rNibErr) } +func TestAddNbIdentitySuccess(t *testing.T) { + w, sdlMock := initSdlMock() + + nbIdentity := &entities.NbIdentity{InventoryName: RanName, GlobalNbId: &entities.GlobalNbId{PlmnId: PlmnId, NbId: NbId}} + nbIdData, err := proto.Marshal(nbIdentity) + if err != nil { + t.Fatalf("#rNibWriter_test.TestAddNbIdentitySuccess - Failed to marshal NodeB Identity entity. Error: %v", err) + } + + sdlMock.On("AddMember", namespace, "ENB", []interface{}{nbIdData}).Return(nil) + rNibErr := w.AddNbIdentity(entities.Node_ENB, nbIdentity) + assert.Nil(t, rNibErr) +} + +func TestAddNbIdentityMarshalNilFailure(t *testing.T) { + w, _ := initSdlMock() + + rNibErr := w.AddNbIdentity(entities.Node_ENB, nil) + expectedErr := common.NewInternalError(errors.New("proto: Marshal called with nil")) + assert.Equal(t, expectedErr, rNibErr) +} + +func TestAddNbIdentitySdlFailure(t *testing.T) { + w, sdlMock := initSdlMock() + + nbIdentity := &entities.NbIdentity{InventoryName: RanName, GlobalNbId: &entities.GlobalNbId{PlmnId: PlmnId, NbId: NbId}} + nbIdData, err := proto.Marshal(nbIdentity) + if err != nil { + t.Fatalf("#rNibWriter_test.TestAddNbIdentitySdlFailure - Failed to marshal NodeB Identity entity. Error: %v", err) + } + + sdlMock.On("AddMember", namespace, "ENB", []interface{}{nbIdData}).Return(errors.New("expected error")) + rNibErr := w.AddNbIdentity(entities.Node_ENB, nbIdentity) + assert.IsType(t, &common.InternalError{}, rNibErr) +} + func TestUpdateGnbCellsInvalidCellFailure(t *testing.T) { inventoryName := "name" plmnId := "02f829" nbId := "4a952a0a" - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() servedNrCells := []*entities.ServedNRCell{{ServedNrCellInformation: &entities.ServedNRCellInformation{}}} nodebInfo := generateNodebInfo(inventoryName, entities.Node_GNB, plmnId, nbId) nodebInfo.GetGnb().ServedNrCells = servedNrCells - sdlInstanceMock.AssertNotCalled(t, "Set") + sdlMock.AssertNotCalled(t, "SetAndPublish") rNibErr := w.UpdateGnbCells(nodebInfo, servedNrCells) assert.IsType(t, &common.ValidationError{}, rNibErr) } @@ -165,7 +202,7 @@ func getUpdateEnbCellsSetExpected(t *testing.T, nodebInfo *entities.NodebInfo, s } nodebNameKey, _ := common.ValidateAndBuildNodeBNameKey(nodebInfo.RanName) - nodebIdKey, _ := common.ValidateAndBuildNodeBIdKey(nodebInfo.NodeType.String(), nodebInfo.GlobalNbId.PlmnId, nodebInfo.GlobalNbId.NbId) + nodebIdKey, _ := common.ValidateAndBuildNodeBIdKey(nodebInfo.NodeType.String(), nodebInfo.GlobalNbId.PlmnId, nodebInfo.GlobalNbId.NbId,nodebInfo.CuUpId,nodebInfo.DuId) setExpected := []interface{}{nodebNameKey, nodebInfoData, nodebIdKey, nodebInfoData} for _, cell := range servedCells { @@ -193,7 +230,7 @@ func getUpdateGnbCellsSetExpected(t *testing.T, nodebInfo *entities.NodebInfo, s } nodebNameKey, _ := common.ValidateAndBuildNodeBNameKey(nodebInfo.RanName) - nodebIdKey, _ := common.ValidateAndBuildNodeBIdKey(nodebInfo.NodeType.String(), nodebInfo.GlobalNbId.PlmnId, nodebInfo.GlobalNbId.NbId) + nodebIdKey, _ := common.ValidateAndBuildNodeBIdKey(nodebInfo.NodeType.String(), nodebInfo.GlobalNbId.PlmnId, nodebInfo.GlobalNbId.NbId,nodebInfo.CuUpId,nodebInfo.DuId) setExpected := []interface{}{nodebNameKey, nodebInfoData, nodebIdKey, nodebInfoData} for _, v := range servedNrCells { @@ -217,27 +254,41 @@ func TestUpdateGnbCellsSdlFailure(t *testing.T) { inventoryName := "name" plmnId := "02f829" nbId := "4a952a0a" - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() servedNrCells := generateServedNrCells("test1", "test2") nodebInfo := generateNodebInfo(inventoryName, entities.Node_GNB, plmnId, nbId) nodebInfo.GetGnb().ServedNrCells = servedNrCells setExpected := getUpdateGnbCellsSetExpected(t, nodebInfo, servedNrCells) - sdlInstanceMock.On("Set", []interface{}{setExpected}).Return(errors.New("expected error")) + sdlMock.On("SetAndPublish", namespace, []string{"RAN_MANIPULATION", inventoryName + "_" + RanUpdatedEvent}, []interface{}{setExpected}).Return(errors.New("expected error")) rNibErr := w.UpdateGnbCells(nodebInfo, servedNrCells) assert.IsType(t, &common.InternalError{}, rNibErr) } +func TestUpdateGnbCellsRnibKeyValidationError(t *testing.T) { + //Empty RAN name fails RNIB validation + inventoryName := "" + plmnId := "02f829" + nbId := "4a952a0a" + w, _ := initSdlMock() + servedNrCells := generateServedNrCells("test1", "test2") + nodebInfo := generateNodebInfo(inventoryName, entities.Node_GNB, plmnId, nbId) + nodebInfo.GetGnb().ServedNrCells = servedNrCells + + rNibErr := w.UpdateGnbCells(nodebInfo, servedNrCells) + assert.IsType(t, &common.ValidationError{}, rNibErr) +} + func TestUpdateGnbCellsSuccess(t *testing.T) { inventoryName := "name" plmnId := "02f829" nbId := "4a952a0a" - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() servedNrCells := generateServedNrCells("test1", "test2") nodebInfo := generateNodebInfo(inventoryName, entities.Node_GNB, plmnId, nbId) nodebInfo.GetGnb().ServedNrCells = servedNrCells setExpected := getUpdateGnbCellsSetExpected(t, nodebInfo, servedNrCells) var e error - sdlInstanceMock.On("Set", []interface{}{setExpected}).Return(e) + sdlMock.On("SetAndPublish", namespace, []string{"RAN_MANIPULATION", inventoryName + "_" + RanUpdatedEvent}, []interface{}{setExpected}).Return(e) rNibErr := w.UpdateGnbCells(nodebInfo, servedNrCells) assert.Nil(t, rNibErr) } @@ -246,7 +297,7 @@ func TestUpdateNodebInfoSuccess(t *testing.T) { inventoryName := "name" plmnId := "02f829" nbId := "4a952a0a" - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() nodebInfo := generateNodebInfo(inventoryName, entities.Node_ENB, plmnId, nbId) data, err := proto.Marshal(nodebInfo) if err != nil { @@ -260,17 +311,43 @@ func TestUpdateNodebInfoSuccess(t *testing.T) { setExpected = append(setExpected, nodebNameKey, data) setExpected = append(setExpected, nodebIdKey, data) - sdlInstanceMock.On("Set", []interface{}{setExpected}).Return(e) + sdlMock.On("Set", namespace, []interface{}{setExpected}).Return(e) rNibErr := w.UpdateNodebInfo(nodebInfo) assert.Nil(t, rNibErr) + sdlMock.AssertExpectations(t) +} + +func TestUpdateNodebInfoAndPublishSuccess(t *testing.T) { + inventoryName := "name" + plmnId := "02f829" + nbId := "4a952a0a" + w, sdlMock := initSdlMock() + nodebInfo := generateNodebInfo(inventoryName, entities.Node_ENB, plmnId, nbId) + data, err := proto.Marshal(nodebInfo) + if err != nil { + t.Errorf("#rNibWriter_test.TestSaveEnb - Failed to marshal NodeB entity. Error: %v", err) + } + var e error + var setExpected []interface{} + + nodebNameKey := fmt.Sprintf("RAN:%s", inventoryName) + nodebIdKey := fmt.Sprintf("ENB:%s:%s", plmnId, nbId) + setExpected = append(setExpected, nodebNameKey, data) + setExpected = append(setExpected, nodebIdKey, data) + + sdlMock.On("SetAndPublish", namespace, []string{"RAN_MANIPULATION", inventoryName + "_" + RanUpdatedEvent}, []interface{}{setExpected}).Return(e) + + rNibErr := w.UpdateNodebInfoAndPublish(nodebInfo) + assert.Nil(t, rNibErr) + sdlMock.AssertExpectations(t) } func TestUpdateNodebInfoMissingInventoryNameFailure(t *testing.T) { inventoryName := "name" plmnId := "02f829" nbId := "4a952a0a" - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() nodebInfo := &entities.NodebInfo{} data, err := proto.Marshal(nodebInfo) if err != nil { @@ -284,7 +361,7 @@ func TestUpdateNodebInfoMissingInventoryNameFailure(t *testing.T) { setExpected = append(setExpected, nodebNameKey, data) setExpected = append(setExpected, nodebIdKey, data) - sdlInstanceMock.On("Set", []interface{}{setExpected}).Return(e) + sdlMock.On("Set", namespace, []interface{}{setExpected}).Return(e) rNibErr := w.UpdateNodebInfo(nodebInfo) @@ -294,7 +371,7 @@ func TestUpdateNodebInfoMissingInventoryNameFailure(t *testing.T) { func TestUpdateNodebInfoMissingGlobalNbId(t *testing.T) { inventoryName := "name" - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() nodebInfo := &entities.NodebInfo{} nodebInfo.RanName = inventoryName data, err := proto.Marshal(nodebInfo) @@ -306,16 +383,42 @@ func TestUpdateNodebInfoMissingGlobalNbId(t *testing.T) { nodebNameKey := fmt.Sprintf("RAN:%s", inventoryName) setExpected = append(setExpected, nodebNameKey, data) - sdlInstanceMock.On("Set", []interface{}{setExpected}).Return(e) + sdlMock.On("Set", namespace, []interface{}{setExpected}).Return(e) rNibErr := w.UpdateNodebInfo(nodebInfo) assert.Nil(t, rNibErr) } +func TestUpdateNodebInfoSdlSetFailure(t *testing.T) { + inventoryName := "name" + plmnId := "02f829" + nbId := "4a952a0a" + w, sdlMock := initSdlMock() + nodebInfo := generateNodebInfo(inventoryName, entities.Node_ENB, plmnId, nbId) + data, err := proto.Marshal(nodebInfo) + if err != nil { + t.Errorf("#rNibWriter_test.TestSaveEnb - Failed to marshal NodeB entity. Error: %v", err) + } + e := errors.New("expected error") + var setExpected []interface{} + + nodebNameKey := fmt.Sprintf("RAN:%s", inventoryName) + nodebIdKey := fmt.Sprintf("ENB:%s:%s", plmnId, nbId) + setExpected = append(setExpected, nodebNameKey, data) + setExpected = append(setExpected, nodebIdKey, data) + + sdlMock.On("Set", namespace, []interface{}{setExpected}).Return(e) + + rNibErr := w.UpdateNodebInfo(nodebInfo) + assert.NotNil(t, rNibErr) + assert.IsType(t, &common.InternalError{}, rNibErr) + sdlMock.AssertExpectations(t) +} + func TestSaveEnb(t *testing.T) { ranName := "RAN:" + RanName - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() nb := entities.NodebInfo{ RanName: RanName, NodeType: entities.Node_ENB, @@ -349,14 +452,13 @@ func TestSaveEnb(t *testing.T) { setExpected = append(setExpected, fmt.Sprintf("CELL:%s", cell.GetCellId()), cellData) setExpected = append(setExpected, fmt.Sprintf("PCI:%s:%02x", RanName, cell.GetPci()), cellData) - sdlInstanceMock.On("SetAndPublish", []string{"RAN_MANIPULATION", RanName + "_" + RanAddedEvent}, []interface{}{setExpected}).Return(e) - + sdlMock.On("Set", namespace, []interface{}{setExpected}).Return(e) rNibErr := w.SaveNodeb(&nb) assert.Nil(t, rNibErr) } func TestSaveEnbCellIdValidationFailure(t *testing.T) { - w, _ := initSdlInstanceMock(namespace) + w, _ := initSdlMock() nb := entities.NodebInfo{} nb.RanName = "name" nb.NodeType = entities.Node_ENB @@ -374,7 +476,7 @@ func TestSaveEnbCellIdValidationFailure(t *testing.T) { } func TestSaveEnbInventoryNameValidationFailure(t *testing.T) { - w, _ := initSdlInstanceMock(namespace) + w, _ := initSdlMock() nb := entities.NodebInfo{ NodeType: entities.Node_ENB, ConnectionStatus: entities.ConnectionStatus_CONNECTED, @@ -395,8 +497,32 @@ func TestSaveEnbInventoryNameValidationFailure(t *testing.T) { assert.Equal(t, "#utils.ValidateAndBuildNodeBNameKey - an empty inventory name received", rNibErr.Error()) } +func TestSaveEnbGlobalNbIdPlmnValidationFailure(t *testing.T) { + w, _ := initSdlMock() + nb := entities.NodebInfo{ + RanName: RanName, + NodeType: entities.Node_ENB, + ConnectionStatus: entities.ConnectionStatus_CONNECTED, + Ip: "localhost", + Port: 5656, + GlobalNbId: &entities.GlobalNbId{ + NbId: "4a952a0a", + //Empty PLMNID fails RNIB validation + PlmnId: "", + }, + } + enb := entities.Enb{} + cell := &entities.ServedCellInfo{CellId: "aaa", Pci: 3} + enb.ServedCells = []*entities.ServedCellInfo{cell} + nb.Configuration = &entities.NodebInfo_Enb{Enb: &enb} + rNibErr := w.SaveNodeb(&nb) + assert.NotNil(t, rNibErr) + assert.IsType(t, &common.ValidationError{}, rNibErr) + assert.Equal(t, "#utils.ValidateAndBuildNodeBIdKey - an empty plmnId received", rNibErr.Error()) +} + func TestSaveGnbCellIdValidationFailure(t *testing.T) { - w, _ := initSdlInstanceMock(namespace) + w, _ := initSdlMock() nb := entities.NodebInfo{} nb.RanName = "name" nb.NodeType = entities.Node_GNB @@ -417,9 +543,9 @@ func TestSaveGnbCellIdValidationFailure(t *testing.T) { func TestSaveGnb(t *testing.T) { ranName := "RAN:" + RanName - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() nb := entities.NodebInfo{ - RanName: RanName, + RanName: RanName, NodeType: entities.Node_GNB, ConnectionStatus: 1, GlobalNbId: &entities.GlobalNbId{ @@ -452,7 +578,7 @@ func TestSaveGnb(t *testing.T) { setExpected = append(setExpected, fmt.Sprintf("NRCELL:%s", cell.GetServedNrCellInformation().GetCellId()), cellData) setExpected = append(setExpected, fmt.Sprintf("PCI:%s:%02x", RanName, cell.GetServedNrCellInformation().GetNrPci()), cellData) - sdlInstanceMock.On("Set", []interface{}{setExpected}).Return(e) + sdlMock.On("Set", namespace, []interface{}{setExpected}).Return(e) rNibErr := w.SaveNodeb(&nb) assert.Nil(t, rNibErr) } @@ -465,7 +591,7 @@ func TestSaveRanLoadInformationSuccess(t *testing.T) { t.Errorf("#rNibWriter_test.TestSaveRanLoadInformationSuccess - Failed to build ran load infromation key. Error: %v", validationErr) } - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() ranLoadInformation := generateRanLoadInformation() data, err := proto.Marshal(ranLoadInformation) @@ -477,7 +603,7 @@ func TestSaveRanLoadInformationSuccess(t *testing.T) { var e error var setExpected []interface{} setExpected = append(setExpected, loadKey, data) - sdlInstanceMock.On("Set", []interface{}{setExpected}).Return(e) + sdlMock.On("Set", namespace, []interface{}{setExpected}).Return(e) rNibErr := w.SaveRanLoadInformation(inventoryName, ranLoadInformation) assert.Nil(t, rNibErr) @@ -485,7 +611,7 @@ func TestSaveRanLoadInformationSuccess(t *testing.T) { func TestSaveRanLoadInformationMarshalNilFailure(t *testing.T) { inventoryName := "name2" - w, _ := initSdlInstanceMock(namespace) + w, _ := initSdlMock() expectedErr := common.NewInternalError(errors.New("proto: Marshal called with nil")) err := w.SaveRanLoadInformation(inventoryName, nil) @@ -494,7 +620,7 @@ func TestSaveRanLoadInformationMarshalNilFailure(t *testing.T) { func TestSaveRanLoadInformationEmptyInventoryNameFailure(t *testing.T) { inventoryName := "" - w, _ := initSdlInstanceMock(namespace) + w, _ := initSdlMock() err := w.SaveRanLoadInformation(inventoryName, nil) assert.NotNil(t, err) @@ -510,7 +636,7 @@ func TestSaveRanLoadInformationSdlFailure(t *testing.T) { t.Errorf("#rNibWriter_test.TestSaveRanLoadInformationSuccess - Failed to build ran load infromation key. Error: %v", validationErr) } - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() ranLoadInformation := generateRanLoadInformation() data, err := proto.Marshal(ranLoadInformation) @@ -522,7 +648,7 @@ func TestSaveRanLoadInformationSdlFailure(t *testing.T) { expectedErr := errors.New("expected error") var setExpected []interface{} setExpected = append(setExpected, loadKey, data) - sdlInstanceMock.On("Set", []interface{}{setExpected}).Return(expectedErr) + sdlMock.On("Set", namespace, []interface{}{setExpected}).Return(expectedErr) rNibErr := w.SaveRanLoadInformation(inventoryName, ranLoadInformation) assert.NotNil(t, rNibErr) @@ -603,14 +729,14 @@ func generateRanLoadInformation() *entities.RanLoadInformation { } func TestSaveNilEntityFailure(t *testing.T) { - w, _ := initSdlInstanceMock(namespace) + w, _ := initSdlMock() expectedErr := common.NewInternalError(errors.New("proto: Marshal called with nil")) actualErr := w.SaveNodeb(nil) assert.Equal(t, expectedErr, actualErr) } func TestSaveUnknownTypeEntityFailure(t *testing.T) { - w, _ := initSdlInstanceMock(namespace) + w, _ := initSdlMock() nb := &entities.NodebInfo{} nb.Port = 5656 nb.Ip = "localhost" @@ -618,14 +744,23 @@ func TestSaveUnknownTypeEntityFailure(t *testing.T) { assert.IsType(t, &common.ValidationError{}, actualErr) } -func TestSaveEntityFailure(t *testing.T) { +func TestSaveEntitySetFailure(t *testing.T) { name := "name" plmnId := "02f829" nbId := "4a952a0a" - w, sdlInstanceMock := initSdlInstanceMock(namespace) - gnb := entities.NodebInfo{} - gnb.NodeType = entities.Node_GNB + w, sdlMock := initSdlMock() + gnb := entities.NodebInfo{ + RanName: name, + NodeType: entities.Node_GNB, + ConnectionStatus: 1, + GlobalNbId: &entities.GlobalNbId{ + NbId: nbId, + PlmnId: plmnId, + }, + Ip: "localhost", + Port: 5656, + } data, err := proto.Marshal(&gnb) if err != nil { t.Errorf("#rNibWriter_test.TestSaveEntityFailure - Failed to marshal NodeB entity. Error: %v", err) @@ -633,13 +768,42 @@ func TestSaveEntityFailure(t *testing.T) { setExpected := []interface{}{"RAN:" + name, data} setExpected = append(setExpected, "GNB:"+plmnId+":"+nbId, data) expectedErr := errors.New("expected error") - sdlInstanceMock.On("Set", []interface{}{setExpected}).Return(expectedErr) + sdlMock.On("Set", namespace, []interface{}{setExpected}).Return(expectedErr) rNibErr := w.SaveNodeb(&gnb) assert.NotEmpty(t, rNibErr) } +func TestSaveEntitySetAndPublishFailure(t *testing.T) { + name := "name" + plmnId := "02f829" + nbId := "4a952a0a" + + w, sdlMock := initSdlMock() + enb := entities.NodebInfo{ + RanName: name, + NodeType: entities.Node_ENB, + ConnectionStatus: 1, + GlobalNbId: &entities.GlobalNbId{ + NbId: nbId, + PlmnId: plmnId, + }, + Ip: "localhost", + Port: 5656, + } + data, err := proto.Marshal(&enb) + if err != nil { + t.Errorf("#rNibWriter_test.TestSaveEntityFailure - Failed to marshal NodeB entity. Error: %v", err) + } + setExpected := []interface{}{"RAN:" + name, data} + setExpected = append(setExpected, "ENB:"+plmnId+":"+nbId, data) + expectedErr := errors.New("expected error") + sdlMock.On("SetAndPublish", namespace, []string{"RAN_MANIPULATION", name + "_" + RanAddedEvent}, []interface{}{setExpected}).Return(expectedErr) + rNibErr := w.AddEnb(&enb) + assert.NotEmpty(t, rNibErr) +} + func TestGetRNibWriter(t *testing.T) { - received, _ := initSdlInstanceMock(namespace) + received, _ := initSdlMock() assert.NotEmpty(t, received) } @@ -651,7 +815,7 @@ func TestSaveE2TInstanceSuccess(t *testing.T) { t.Errorf("#rNibWriter_test.TestSaveE2TInstanceSuccess - Failed to build E2T Instance key. Error: %v", validationErr) } - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() e2tInstance := generateE2tInstance(address) data, err := json.Marshal(e2tInstance) @@ -663,14 +827,14 @@ func TestSaveE2TInstanceSuccess(t *testing.T) { var e error var setExpected []interface{} setExpected = append(setExpected, loadKey, data) - sdlInstanceMock.On("Set", []interface{}{setExpected}).Return(e) + sdlMock.On("Set", namespace, []interface{}{setExpected}).Return(e) rNibErr := w.SaveE2TInstance(e2tInstance) assert.Nil(t, rNibErr) } func TestSaveE2TInstanceNullE2tInstanceFailure(t *testing.T) { - w, _ := initSdlInstanceMock(namespace) + w, _ := initSdlMock() var address string e2tInstance := entities.NewE2TInstance(address, "test") err := w.SaveE2TInstance(e2tInstance) @@ -686,7 +850,7 @@ func TestSaveE2TInstanceSdlFailure(t *testing.T) { t.Errorf("#rNibWriter_test.TestSaveE2TInstanceSdlFailure - Failed to build E2T Instance key. Error: %v", validationErr) } - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() e2tInstance := generateE2tInstance(address) data, err := json.Marshal(e2tInstance) @@ -698,7 +862,7 @@ func TestSaveE2TInstanceSdlFailure(t *testing.T) { expectedErr := errors.New("expected error") var setExpected []interface{} setExpected = append(setExpected, loadKey, data) - sdlInstanceMock.On("Set", []interface{}{setExpected}).Return(expectedErr) + sdlMock.On("Set", namespace, []interface{}{setExpected}).Return(expectedErr) rNibErr := w.SaveE2TInstance(e2tInstance) assert.NotNil(t, rNibErr) @@ -715,7 +879,7 @@ func generateE2tInstance(address string) *entities.E2TInstance { func TestSaveE2TAddressesSuccess(t *testing.T) { address := "10.10.2.15:9800" - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() e2tAddresses := []string{address} data, err := json.Marshal(e2tAddresses) @@ -727,7 +891,7 @@ func TestSaveE2TAddressesSuccess(t *testing.T) { var e error var setExpected []interface{} setExpected = append(setExpected, E2TAddressesKey, data) - sdlInstanceMock.On("Set", []interface{}{setExpected}).Return(e) + sdlMock.On("Set", namespace, []interface{}{setExpected}).Return(e) rNibErr := w.SaveE2TAddresses(e2tAddresses) assert.Nil(t, rNibErr) @@ -735,7 +899,7 @@ func TestSaveE2TAddressesSuccess(t *testing.T) { func TestSaveE2TAddressesSdlFailure(t *testing.T) { address := "10.10.2.15:9800" - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() e2tAddresses := []string{address} data, err := json.Marshal(e2tAddresses) @@ -747,7 +911,7 @@ func TestSaveE2TAddressesSdlFailure(t *testing.T) { expectedErr := errors.New("expected error") var setExpected []interface{} setExpected = append(setExpected, E2TAddressesKey, data) - sdlInstanceMock.On("Set", []interface{}{setExpected}).Return(expectedErr) + sdlMock.On("Set", namespace, []interface{}{setExpected}).Return(expectedErr) rNibErr := w.SaveE2TAddresses(e2tAddresses) assert.NotNil(t, rNibErr) @@ -756,35 +920,35 @@ func TestSaveE2TAddressesSdlFailure(t *testing.T) { func TestRemoveE2TInstanceSuccess(t *testing.T) { address := "10.10.2.15:9800" - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() e2tAddresses := []string{fmt.Sprintf("E2TInstance:%s", address)} var e error - sdlInstanceMock.On("Remove", e2tAddresses).Return(e) + sdlMock.On("Remove", namespace, e2tAddresses).Return(e) rNibErr := w.RemoveE2TInstance(address) assert.Nil(t, rNibErr) - sdlInstanceMock.AssertExpectations(t) + sdlMock.AssertExpectations(t) } func TestRemoveE2TInstanceSdlFailure(t *testing.T) { address := "10.10.2.15:9800" - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() e2tAddresses := []string{fmt.Sprintf("E2TInstance:%s", address)} expectedErr := errors.New("expected error") - sdlInstanceMock.On("Remove", e2tAddresses).Return(expectedErr) + sdlMock.On("Remove", namespace, e2tAddresses).Return(expectedErr) rNibErr := w.RemoveE2TInstance(address) assert.IsType(t, &common.InternalError{}, rNibErr) } func TestRemoveE2TInstanceEmptyAddressFailure(t *testing.T) { - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() rNibErr := w.RemoveE2TInstance("") assert.IsType(t, &common.ValidationError{}, rNibErr) - sdlInstanceMock.AssertExpectations(t) + sdlMock.AssertExpectations(t) } func TestUpdateNodebInfoOnConnectionStatusInversionSuccess(t *testing.T) { @@ -793,7 +957,7 @@ func TestUpdateNodebInfoOnConnectionStatusInversionSuccess(t *testing.T) { nbId := "4a952a0a" channelName := "RAN_CONNECTION_STATUS_CHANGE" eventName := inventoryName + "_" + "CONNECTED" - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() nodebInfo := generateNodebInfo(inventoryName, entities.Node_ENB, plmnId, nbId) data, err := proto.Marshal(nodebInfo) if err != nil { @@ -807,7 +971,7 @@ func TestUpdateNodebInfoOnConnectionStatusInversionSuccess(t *testing.T) { setExpected = append(setExpected, nodebNameKey, data) setExpected = append(setExpected, nodebIdKey, data) - sdlInstanceMock.On("SetAndPublish", []string{channelName, eventName}, []interface{}{setExpected}).Return(e) + sdlMock.On("SetAndPublish", namespace, []string{channelName, eventName}, []interface{}{setExpected}).Return(e) rNibErr := w.UpdateNodebInfoOnConnectionStatusInversion(nodebInfo, eventName) assert.Nil(t, rNibErr) @@ -819,7 +983,7 @@ func TestUpdateNodebInfoOnConnectionStatusInversionMissingInventoryNameFailure(t nbId := "4a952a0a" channelName := "RAN_CONNECTION_STATUS_CHANGE" eventName := inventoryName + "_" + "CONNECTED" - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() nodebInfo := &entities.NodebInfo{} data, err := proto.Marshal(nodebInfo) if err != nil { @@ -833,7 +997,7 @@ func TestUpdateNodebInfoOnConnectionStatusInversionMissingInventoryNameFailure(t setExpected = append(setExpected, nodebNameKey, data) setExpected = append(setExpected, nodebIdKey, data) - sdlInstanceMock.On("SetAndPublish", []string{channelName, eventName}, []interface{}{setExpected}).Return(e) + sdlMock.On("SetAndPublish", namespace, []string{channelName, eventName}, []interface{}{setExpected}).Return(e) rNibErr := w.UpdateNodebInfoOnConnectionStatusInversion(nodebInfo, eventName) @@ -845,7 +1009,7 @@ func TestUpdateNodebInfoOnConnectionStatusInversionMissingGlobalNbId(t *testing. inventoryName := "name" channelName := "RAN_CONNECTION_STATUS_CHANGE" eventName := inventoryName + "_" + "CONNECTED" - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() nodebInfo := &entities.NodebInfo{} nodebInfo.RanName = inventoryName data, err := proto.Marshal(nodebInfo) @@ -857,30 +1021,57 @@ func TestUpdateNodebInfoOnConnectionStatusInversionMissingGlobalNbId(t *testing. nodebNameKey := fmt.Sprintf("RAN:%s", inventoryName) setExpected = append(setExpected, nodebNameKey, data) - sdlInstanceMock.On("SetAndPublish", []string{channelName, eventName}, []interface{}{setExpected}).Return(e) + sdlMock.On("SetAndPublish", namespace, []string{channelName, eventName}, []interface{}{setExpected}).Return(e) rNibErr := w.UpdateNodebInfoOnConnectionStatusInversion(nodebInfo, eventName) assert.Nil(t, rNibErr) } +func TestUpdateNodebInfoOnConnectionStatusInversionSdlFailure(t *testing.T) { + inventoryName := "name" + plmnId := "02f829" + nbId := "4a952a0a" + channelName := "RAN_CONNECTION_STATUS_CHANGE" + eventName := inventoryName + "_" + "CONNECTED" + w, sdlMock := initSdlMock() + nodebInfo := generateNodebInfo(inventoryName, entities.Node_ENB, plmnId, nbId) + data, err := proto.Marshal(nodebInfo) + if err != nil { + t.Errorf("#rNibWriter_test.TestUpdateNodebInfoOnConnectionStatusInversionSuccess - Failed to marshal NodeB entity. Error: %v", err) + } + e := errors.New("expected error") + var setExpected []interface{} + + nodebNameKey := fmt.Sprintf("RAN:%s", inventoryName) + nodebIdKey := fmt.Sprintf("ENB:%s:%s", plmnId, nbId) + setExpected = append(setExpected, nodebNameKey, data) + setExpected = append(setExpected, nodebIdKey, data) + + sdlMock.On("SetAndPublish", namespace, []string{channelName, eventName}, []interface{}{setExpected}).Return(e) + + rNibErr := w.UpdateNodebInfoOnConnectionStatusInversion(nodebInfo, eventName) + assert.NotNil(t, rNibErr) + assert.IsType(t, &common.InternalError{}, rNibErr) +} + func TestSaveGeneralConfiguration(t *testing.T) { - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() key := common.BuildGeneralConfigurationKey() configurationData := "{\"enableRic\":true}" configuration := &entities.GeneralConfiguration{} configuration.EnableRic = true - sdlInstanceMock.On("Set", []interface{}{[]interface{}{key, []byte(configurationData)}}).Return(nil) + sdlMock.On("Set", namespace, []interface{}{[]interface{}{key, []byte(configurationData)}}).Return(nil) rNibErr := w.SaveGeneralConfiguration(configuration) assert.Nil(t, rNibErr) - sdlInstanceMock.AssertExpectations(t) + sdlMock.AssertExpectations(t) } func TestSaveGeneralConfigurationDbError(t *testing.T) { - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() key := common.BuildGeneralConfigurationKey() configurationData := "{\"enableRic\":true}" @@ -889,17 +1080,17 @@ func TestSaveGeneralConfigurationDbError(t *testing.T) { expectedErr := errors.New("expected error") - sdlInstanceMock.On("Set", []interface{}{[]interface{}{key, []byte(configurationData)}}).Return(expectedErr) + sdlMock.On("Set", namespace, []interface{}{[]interface{}{key, []byte(configurationData)}}).Return(expectedErr) rNibErr := w.SaveGeneralConfiguration(configuration) assert.NotNil(t, rNibErr) } func TestRemoveServedCellsFailure(t *testing.T) { - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() servedCellsToRemove := generateServedCells("whatever1", "whatever2") expectedErr := errors.New("expected error") - sdlInstanceMock.On("Remove", buildServedCellInfoKeysToRemove(RanName, servedCellsToRemove)).Return(expectedErr) + sdlMock.On("Remove", namespace, buildServedCellInfoKeysToRemove(RanName, servedCellsToRemove)).Return(expectedErr) rNibErr := w.RemoveServedCells(RanName, servedCellsToRemove) @@ -907,18 +1098,18 @@ func TestRemoveServedCellsFailure(t *testing.T) { } func TestRemoveServedCellsSuccess(t *testing.T) { - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() servedCellsToRemove := generateServedCells("whatever1", "whatever2") - sdlInstanceMock.On("Remove", buildServedCellInfoKeysToRemove(RanName, servedCellsToRemove)).Return(nil) + sdlMock.On("Remove", namespace, buildServedCellInfoKeysToRemove(RanName, servedCellsToRemove)).Return(nil) err := w.RemoveServedCells(RanName, servedCellsToRemove) assert.Nil(t, err) } func TestUpdateEnbInvalidNodebInfoFailure(t *testing.T) { - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() servedCells := generateServedCells("test1", "test2") nodebInfo := &entities.NodebInfo{} - sdlInstanceMock.AssertNotCalled(t, "SetAndPublish") + sdlMock.AssertNotCalled(t, "SetAndPublish") rNibErr := w.UpdateEnb(nodebInfo, servedCells) assert.IsType(t, &common.ValidationError{}, rNibErr) } @@ -927,11 +1118,25 @@ func TestUpdateEnbInvalidCellFailure(t *testing.T) { inventoryName := "name" plmnId := "02f829" nbId := "4a952a0a" - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() servedCells := []*entities.ServedCellInfo{{CellId: ""}} nodebInfo := generateNodebInfo(inventoryName, entities.Node_ENB, plmnId, nbId) nodebInfo.GetEnb().ServedCells = servedCells - sdlInstanceMock.AssertNotCalled(t, "SetAndPublish") + sdlMock.AssertNotCalled(t, "SetAndPublish") + rNibErr := w.UpdateEnb(nodebInfo, servedCells) + assert.IsType(t, &common.ValidationError{}, rNibErr) +} + +func TestUpdateEnbRnibKeyValidationError(t *testing.T) { + //Empty RAN name fails RNIB validation + inventoryName := "" + plmnId := "02f829" + nbId := "4a952a0a" + w, _ := initSdlMock() + servedCells := generateServedCells("test1", "test2") + nodebInfo := generateNodebInfo(inventoryName, entities.Node_ENB, plmnId, nbId) + nodebInfo.GetEnb().ServedCells = servedCells + rNibErr := w.UpdateEnb(nodebInfo, servedCells) assert.IsType(t, &common.ValidationError{}, rNibErr) } @@ -940,12 +1145,12 @@ func TestUpdateEnbSdlFailure(t *testing.T) { inventoryName := "name" plmnId := "02f829" nbId := "4a952a0a" - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() servedCells := generateServedCells("test1", "test2") nodebInfo := generateNodebInfo(inventoryName, entities.Node_ENB, plmnId, nbId) nodebInfo.GetEnb().ServedCells = servedCells setExpected := getUpdateEnbCellsSetExpected(t, nodebInfo, servedCells) - sdlInstanceMock.On("SetAndPublish", []string{"RAN_MANIPULATION", inventoryName + "_" + RanUpdatedEvent}, []interface{}{setExpected}).Return(errors.New("expected error")) + sdlMock.On("SetAndPublish", namespace, []string{"RAN_MANIPULATION", inventoryName + "_" + RanUpdatedEvent}, []interface{}{setExpected}).Return(errors.New("expected error")) rNibErr := w.UpdateEnb(nodebInfo, servedCells) assert.IsType(t, &common.InternalError{}, rNibErr) } @@ -954,14 +1159,14 @@ func TestUpdateEnbSuccess(t *testing.T) { inventoryName := "name" plmnId := "02f829" nbId := "4a952a0a" - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() servedCells := generateServedCells("test1", "test2") nodebInfo := generateNodebInfo(inventoryName, entities.Node_ENB, plmnId, nbId) nodebInfo.GetEnb().ServedCells = servedCells setExpected := getUpdateEnbCellsSetExpected(t, nodebInfo, servedCells) var e error - sdlInstanceMock.On("SetAndPublish", []string{"RAN_MANIPULATION", inventoryName + "_" + RanUpdatedEvent}, []interface{}{setExpected}).Return(e) + sdlMock.On("SetAndPublish", namespace, []string{"RAN_MANIPULATION", inventoryName + "_" + RanUpdatedEvent}, []interface{}{setExpected}).Return(e) rNibErr := w.UpdateEnb(nodebInfo, servedCells) assert.Nil(t, rNibErr) } @@ -974,7 +1179,7 @@ func getUpdateEnbSetExpected(t *testing.T, nodebInfo *entities.NodebInfo, served } nodebNameKey, _ := common.ValidateAndBuildNodeBNameKey(nodebInfo.RanName) - nodebIdKey, _ := common.ValidateAndBuildNodeBIdKey(nodebInfo.NodeType.String(), nodebInfo.GlobalNbId.PlmnId, nodebInfo.GlobalNbId.NbId) + nodebIdKey, _ := common.ValidateAndBuildNodeBIdKey(nodebInfo.NodeType.String(), nodebInfo.GlobalNbId.PlmnId, nodebInfo.GlobalNbId.NbId,nodebInfo.CuUpId,nodebInfo.DuId) setExpected := []interface{}{nodebNameKey, nodebInfoData, nodebIdKey, nodebInfoData} for _, v := range servedCells { @@ -999,7 +1204,7 @@ func TestRemoveEnbSuccess(t *testing.T) { nbId := "4a952a0a" channelName := "RAN_MANIPULATION" eventName := inventoryName + "_" + "DELETED" - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() nodebInfo := generateNodebInfo(inventoryName, entities.Node_ENB, plmnId, nbId) nodebInfo.GetEnb().ServedCells = generateServedCellInfos("cell1", "cell2") @@ -1013,11 +1218,24 @@ func TestRemoveEnbSuccess(t *testing.T) { nodebNameKey := fmt.Sprintf("RAN:%s", inventoryName) nodebIdKey := fmt.Sprintf("ENB:%s:%s", plmnId, nbId) expectedKeys = append(expectedKeys, cell1Key, cell1PciKey, cell2Key, cell2PciKey, nodebNameKey, nodebIdKey) - sdlInstanceMock.On("RemoveAndPublish", []string{channelName, eventName}, expectedKeys).Return(e) + sdlMock.On("RemoveAndPublish", namespace, []string{channelName, eventName}, expectedKeys).Return(e) rNibErr := w.RemoveEnb(nodebInfo) assert.Nil(t, rNibErr) - sdlInstanceMock.AssertExpectations(t) + sdlMock.AssertExpectations(t) +} + +func TestRemoveEnbRnibKeyValidationError(t *testing.T) { + //Empty RAN name fails RNIB key validation + inventoryName := "" + plmnId := "02f829" + nbId := "4a952a0a" + w, _ := initSdlMock() + nodebInfo := generateNodebInfo(inventoryName, entities.Node_ENB, plmnId, nbId) + nodebInfo.GetEnb().ServedCells = generateServedCellInfos("cell1", "cell2") + + rNibErr := w.RemoveEnb(nodebInfo) + assert.NotNil(t, rNibErr) } func TestRemoveEnbRemoveAndPublishError(t *testing.T) { @@ -1026,7 +1244,7 @@ func TestRemoveEnbRemoveAndPublishError(t *testing.T) { nbId := "4a952a0a" channelName := "RAN_MANIPULATION" eventName := inventoryName + "_" + "DELETED" - w, sdlInstanceMock := initSdlInstanceMock(namespace) + w, sdlMock := initSdlMock() nodebInfo := generateNodebInfo(inventoryName, entities.Node_ENB, plmnId, nbId) nodebInfo.GetEnb().ServedCells = generateServedCellInfos("cell1", "cell2") @@ -1038,79 +1256,354 @@ func TestRemoveEnbRemoveAndPublishError(t *testing.T) { nodebNameKey := fmt.Sprintf("RAN:%s", inventoryName) nodebIdKey := fmt.Sprintf("ENB:%s:%s", plmnId, nbId) expectedKeys = append(expectedKeys, cell1Key, cell1PciKey, cell2Key, cell2PciKey, nodebNameKey, nodebIdKey) - sdlInstanceMock.On("RemoveAndPublish", []string{channelName, eventName}, expectedKeys).Return(errors.New("for test")) + sdlMock.On("RemoveAndPublish", namespace, []string{channelName, eventName}, expectedKeys).Return(errors.New("for test")) rNibErr := w.RemoveEnb(nodebInfo) assert.NotNil(t, rNibErr) - sdlInstanceMock.AssertExpectations(t) + sdlMock.AssertExpectations(t) } -//Integration tests -// -//func TestSaveEnbGnbInteg(t *testing.T){ -// for i := 0; i<10; i++{ -// Init("e2Manager", 1) -// w := GetRNibWriter() -// nb := entities.NodebInfo{} -// nb.NodeType = entities.Node_ENB -// nb.ConnectionStatus = entities.ConnectionStatus_CONNECTED -// nb.Ip = "localhost" -// nb.Port = uint32(5656 + i) -// enb := entities.Enb{} -// cell1 := &entities.ServedCellInfo{CellId:fmt.Sprintf("%02x",111 + i), Pci:uint32(11 + i)} -// cell2 := &entities.ServedCellInfo{CellId:fmt.Sprintf("%02x",222 + i), Pci:uint32(22 + i)} -// cell3 := &entities.ServedCellInfo{CellId:fmt.Sprintf("%02x",333 + i), Pci:uint32(33 + i)} -// enb.ServedCells = []*entities.ServedCellInfo{cell1, cell2, cell3} -// nb.Configuration = &entities.NodebInfo_Enb{Enb:&enb} -// plmnId := 0x02f828 -// nbId := 0x4a952a0a -// nbIdentity := &entities.NbIdentity{InventoryName: fmt.Sprintf("nameEnb%d" ,i), GlobalNbId:&entities.GlobalNbId{RicId:fmt.Sprintf("%02x", plmnId + i), NbId:fmt.Sprintf("%02x", nbId + i)}} -// err := w.SaveNodeb(nbIdentity, &nb) -// if err != nil{ -// t.Errorf("#rNibWriter_test.TestSaveEnbInteg - Failed to save NodeB entity. Error: %v", err) -// } -// -// nb1 := entities.NodebInfo{} -// nb1.NodeType = entities.Node_GNB -// nb1.ConnectionStatus = entities.ConnectionStatus_CONNECTED -// nb1.Ip = "localhost" -// nb1.Port = uint32(6565 + i) -// gnb := entities.Gnb{} -// gCell1 := &entities.ServedNRCell{ServedNrCellInformation:&entities.ServedNRCellInformation{CellId:fmt.Sprintf("%02x",1111 + i), NrPci:uint32(1 + i)}} -// gCell2 := &entities.ServedNRCell{ServedNrCellInformation:&entities.ServedNRCellInformation{CellId:fmt.Sprintf("%02x",2222 + i), NrPci:uint32(2 + i)}} -// gCell3 := &entities.ServedNRCell{ServedNrCellInformation:&entities.ServedNRCellInformation{CellId:fmt.Sprintf("%02x",3333 + i), NrPci:uint32(3 + i)}} -// gnb.ServedNrCells = []*entities.ServedNRCell{gCell1, gCell2, gCell3,} -// nb1.Configuration = &entities.NodebInfo_Gnb{Gnb:&gnb} -// nbIdentity = &entities.NbIdentity{InventoryName: fmt.Sprintf("nameGnb%d" ,i), GlobalNbId:&entities.GlobalNbId{RicId:fmt.Sprintf("%02x", plmnId - i), NbId:fmt.Sprintf("%02x", nbId - i)}} -// err = w.SaveNodeb(nbIdentity, &nb1) -// if err != nil{ -// t.Errorf("#rNibWriter_test.TestSaveEnbInteg - Failed to save NodeB entity. Error: %v", err) -// } -// } -//} -// -//func TestSaveNbRanNamesInteg(t *testing.T){ -// for i := 0; i<10; i++{ -// Init("e2Manager", 1) -// w := GetRNibWriter() -// nb := entities.NodebInfo{} -// nb.ConnectionStatus = entities.ConnectionStatus_CONNECTING -// nb.Ip = "localhost" -// nb.Port = uint32(5656 + i) -// nbIdentity := &entities.NbIdentity{InventoryName: fmt.Sprintf("nameOnly%d" ,i)} -// err := w.SaveNodeb(nbIdentity, &nb) -// if err != nil{ -// t.Errorf("#rNibWriter_test.TestSaveEnbInteg - Failed to save NodeB entity. Error: %v", err) -// } -// } -//} -// -//func TestSaveRanLoadInformationInteg(t *testing.T){ -// Init("e2Manager", 1) -// w := GetRNibWriter() -// ranLoadInformation := generateRanLoadInformation() -// err := w.SaveRanLoadInformation("ran_integ", ranLoadInformation) -// if err != nil{ -// t.Errorf("#rNibWriter_test.TestSaveRanLoadInformationInteg - Failed to save RanLoadInformation entity. Error: %v", err) -// } -//} +func TestRemoveNbIdentitySuccess(t *testing.T) { + w, sdlMock := initSdlMock() + nbIdentity := &entities.NbIdentity{InventoryName: "ran1", ConnectionStatus: entities.ConnectionStatus_DISCONNECTED, GlobalNbId: &entities.GlobalNbId{PlmnId: "plmnId1", NbId: "nbId1"}} + nbIdData, err := proto.Marshal(nbIdentity) + if err != nil { + t.Errorf("#TestRemoveNbIdentitySuccess - failed to Marshal NbIdentity") + } + + sdlMock.On("RemoveMember", namespace, entities.Node_ENB.String(), []interface{}{nbIdData}).Return(nil) + + rNibErr := w.RemoveNbIdentity(entities.Node_ENB, nbIdentity) + assert.Nil(t, rNibErr) + sdlMock.AssertExpectations(t) +} + +func TestRemoveNbIdentityMarshalNilFailure(t *testing.T) { + w, _ := initSdlMock() + + rNibErr := w.RemoveNbIdentity(entities.Node_ENB, nil) + expectedErr := common.NewInternalError(errors.New("proto: Marshal called with nil")) + assert.Equal(t, expectedErr, rNibErr) +} + +func TestRemoveNbIdentityError(t *testing.T) { + w, sdlMock := initSdlMock() + nbIdentity := &entities.NbIdentity{InventoryName: "ran1", ConnectionStatus: entities.ConnectionStatus_DISCONNECTED, GlobalNbId: &entities.GlobalNbId{PlmnId: "plmnId1", NbId: "nbId1"}} + nbIdData, err := proto.Marshal(nbIdentity) + if err != nil { + t.Errorf("#TestRemoveNbIdentitySuccess - failed to Marshal NbIdentity") + } + + sdlMock.On("RemoveMember", namespace, entities.Node_ENB.String(), []interface{}{nbIdData}).Return(fmt.Errorf("for test")) + + rNibErr := w.RemoveNbIdentity(entities.Node_ENB, nbIdentity) + assert.NotNil(t, rNibErr) + sdlMock.AssertExpectations(t) +} + +func TestAddEnb(t *testing.T) { + ranName := "RAN:" + RanName + w, sdlMock := initSdlMock() + nb := entities.NodebInfo{ + RanName: RanName, + NodeType: entities.Node_ENB, + ConnectionStatus: entities.ConnectionStatus_CONNECTED, + Ip: "localhost", + Port: 5656, + GlobalNbId: &entities.GlobalNbId{ + NbId: "4a952a0a", + PlmnId: "02f829", + }, + } + + enb := entities.Enb{} + cell := &entities.ServedCellInfo{CellId: "aaff", Pci: 3} + cellEntity := entities.Cell{Type: entities.Cell_LTE_CELL, Cell: &entities.Cell_ServedCellInfo{ServedCellInfo: cell}} + enb.ServedCells = []*entities.ServedCellInfo{cell} + nb.Configuration = &entities.NodebInfo_Enb{Enb: &enb} + data, err := proto.Marshal(&nb) + if err != nil { + t.Errorf("#rNibWriter_test.TestSaveEnb - Failed to marshal NodeB entity. Error: %v", err) + } + var e error + + cellData, err := proto.Marshal(&cellEntity) + if err != nil { + t.Errorf("#rNibWriter_test.TestSaveEnb - Failed to marshal Cell entity. Error: %v", err) + } + var setExpected []interface{} + setExpected = append(setExpected, ranName, data) + setExpected = append(setExpected, "ENB:02f829:4a952a0a", data) + setExpected = append(setExpected, fmt.Sprintf("CELL:%s", cell.GetCellId()), cellData) + setExpected = append(setExpected, fmt.Sprintf("PCI:%s:%02x", RanName, cell.GetPci()), cellData) + + sdlMock.On("SetAndPublish", namespace, []string{"RAN_MANIPULATION", RanName + "_" + RanAddedEvent}, []interface{}{setExpected}).Return(e) + + rNibErr := w.AddEnb(&nb) + assert.Nil(t, rNibErr) +} + +func TestAddEnbMarshalNilFailure(t *testing.T) { + w, _ := initSdlMock() + + rNibErr := w.AddEnb(nil) + expectedErr := common.NewInternalError(errors.New("proto: Marshal called with nil")) + assert.Equal(t, expectedErr, rNibErr) +} + +func TestAddEnbCellIdValidationFailure(t *testing.T) { + w, _ := initSdlMock() + nb := entities.NodebInfo{} + nb.RanName = "name" + nb.NodeType = entities.Node_ENB + nb.ConnectionStatus = 1 + nb.Ip = "localhost" + nb.Port = 5656 + enb := entities.Enb{} + cell := &entities.ServedCellInfo{Pci: 3} + enb.ServedCells = []*entities.ServedCellInfo{cell} + nb.Configuration = &entities.NodebInfo_Enb{Enb: &enb} + rNibErr := w.AddEnb(&nb) + assert.NotNil(t, rNibErr) + assert.IsType(t, &common.ValidationError{}, rNibErr) + assert.Equal(t, "#utils.ValidateAndBuildCellIdKey - an empty cell id received", rNibErr.Error()) +} + +func TestAddEnbInventoryNameValidationFailure(t *testing.T) { + w, _ := initSdlMock() + nb := entities.NodebInfo{ + NodeType: entities.Node_ENB, + ConnectionStatus: entities.ConnectionStatus_CONNECTED, + Ip: "localhost", + Port: 5656, + GlobalNbId: &entities.GlobalNbId{ + NbId: "4a952a0a", + PlmnId: "02f829", + }, + } + enb := entities.Enb{} + cell := &entities.ServedCellInfo{CellId: "aaa", Pci: 3} + enb.ServedCells = []*entities.ServedCellInfo{cell} + nb.Configuration = &entities.NodebInfo_Enb{Enb: &enb} + rNibErr := w.AddEnb(&nb) + assert.NotNil(t, rNibErr) + assert.IsType(t, &common.ValidationError{}, rNibErr) + assert.Equal(t, "#utils.ValidateAndBuildNodeBNameKey - an empty inventory name received", rNibErr.Error()) +} + +func TestAddEnbGlobalNbIdPlmnValidationFailure(t *testing.T) { + w, _ := initSdlMock() + nb := entities.NodebInfo{ + RanName: "name", + NodeType: entities.Node_ENB, + ConnectionStatus: entities.ConnectionStatus_CONNECTED, + Ip: "localhost", + Port: 5656, + GlobalNbId: &entities.GlobalNbId{ + NbId: "4a952a0a", + //Empty PLMNID fails RNIB validation + PlmnId: "", + }, + } + enb := entities.Enb{} + cell := &entities.ServedCellInfo{CellId: "aaa", Pci: 3} + enb.ServedCells = []*entities.ServedCellInfo{cell} + nb.Configuration = &entities.NodebInfo_Enb{Enb: &enb} + rNibErr := w.AddEnb(&nb) + assert.NotNil(t, rNibErr) + assert.IsType(t, &common.ValidationError{}, rNibErr) + assert.Equal(t, "#utils.ValidateAndBuildNodeBIdKey - an empty plmnId received", rNibErr.Error()) +} + +func TestUpdateNbIdentityOneMemberSuccess(t *testing.T) { + w, sdlMock := initSdlMock() + + proto, nbIdentity := createNbIdentityProto(t, "ran1", "plmnId1", "nbId1", entities.ConnectionStatus_DISCONNECTED) + val := []interface{}{proto} + + sdlMock.On("RemoveMember", namespace, entities.Node_ENB.String(), val).Return(nil) + + protoAdd, nbIdentityAdd := createNbIdentityProto(t, "ran1_add", "plmnId1_add", "nbId1_add", entities.ConnectionStatus_CONNECTED) + sdlMock.On("AddMember", namespace, entities.Node_ENB.String(), []interface{}{protoAdd}).Return(nil) + + newNbIdIdentities := []*entities.NbIdentity{nbIdentityAdd} + oldNbIdIdentities := []*entities.NbIdentity{nbIdentity} + + rNibErr := w.UpdateNbIdentities(entities.Node_ENB, oldNbIdIdentities, newNbIdIdentities) + assert.Nil(t, rNibErr) + sdlMock.AssertExpectations(t) +} + +func TestUpdateNbIdentitySuccess(t *testing.T) { + w, sdlMock := initSdlMock() + + var nbIdIdentitiesProtoToRemove []interface{} + protoRan1, _ := createNbIdentityProto(t, "ran1", "plmnId1", "nbId1", entities.ConnectionStatus_DISCONNECTED) + protoRan2, _ := createNbIdentityProto(t, "ran2", "plmnId2", "nbId2", entities.ConnectionStatus_DISCONNECTED) + nbIdIdentitiesProtoToRemove = append(nbIdIdentitiesProtoToRemove, protoRan1) + nbIdIdentitiesProtoToRemove = append(nbIdIdentitiesProtoToRemove, protoRan2) + sdlMock.On("RemoveMember", namespace, entities.Node_ENB.String(), nbIdIdentitiesProtoToRemove).Return(nil) + + var nbIdIdentitiesProtoToAdd []interface{} + protoRan1Add, _ := createNbIdentityProto(t, "ran1_add", "plmnId1_add", "nbId1_add", entities.ConnectionStatus_CONNECTED) + protoRan2Add, _ := createNbIdentityProto(t, "ran2_add", "plmnId2_add", "nbId2_add", entities.ConnectionStatus_CONNECTED) + nbIdIdentitiesProtoToAdd = append(nbIdIdentitiesProtoToAdd, protoRan1Add) + nbIdIdentitiesProtoToAdd = append(nbIdIdentitiesProtoToAdd, protoRan2Add) + sdlMock.On("AddMember", namespace, entities.Node_ENB.String(), nbIdIdentitiesProtoToAdd).Return(nil) + + var newNbIdIdentities []*entities.NbIdentity + firstNewNbIdIdentity := &entities.NbIdentity{InventoryName: "ran1_add", ConnectionStatus: entities.ConnectionStatus_CONNECTED, GlobalNbId: &entities.GlobalNbId{PlmnId: "plmnId1_add", NbId: "nbId1_add"}} + secondNewNbIdIdentity := &entities.NbIdentity{InventoryName: "ran2_add", ConnectionStatus: entities.ConnectionStatus_CONNECTED, GlobalNbId: &entities.GlobalNbId{PlmnId: "plmnId2_add", NbId: "nbId2_add"}} + newNbIdIdentities = append(newNbIdIdentities, firstNewNbIdIdentity) + newNbIdIdentities = append(newNbIdIdentities, secondNewNbIdIdentity) + + var oldNbIdIdentities []*entities.NbIdentity + firstOldNbIdIdentity := &entities.NbIdentity{InventoryName: "ran1", ConnectionStatus: entities.ConnectionStatus_DISCONNECTED, GlobalNbId: &entities.GlobalNbId{PlmnId: "plmnId1", NbId: "nbId1"}} + secondOldNbIdIdentity := &entities.NbIdentity{InventoryName: "ran2", ConnectionStatus: entities.ConnectionStatus_DISCONNECTED, GlobalNbId: &entities.GlobalNbId{PlmnId: "plmnId2", NbId: "nbId2"}} + oldNbIdIdentities = append(oldNbIdIdentities, firstOldNbIdIdentity) + oldNbIdIdentities = append(oldNbIdIdentities, secondOldNbIdIdentity) + + rNibErr := w.UpdateNbIdentities(entities.Node_ENB, oldNbIdIdentities, newNbIdIdentities) + assert.Nil(t, rNibErr) + sdlMock.AssertExpectations(t) +} + +func TestUpdateNbIdentityOldIdentityMarshalNilFailure(t *testing.T) { + w, _ := initSdlMock() + + oldNbIdIdentities := []*entities.NbIdentity{nil} + newNbIdIdentities := []*entities.NbIdentity{ + &entities.NbIdentity{ + InventoryName: "ran1_add", + ConnectionStatus: entities.ConnectionStatus_CONNECTED, + GlobalNbId: &entities.GlobalNbId{PlmnId: "plmnId1_add", NbId: "nbId1_add"}, + }, + } + + expectedErr := common.NewInternalError(errors.New("proto: Marshal called with nil")) + rNibErr := w.UpdateNbIdentities(entities.Node_ENB, oldNbIdIdentities, newNbIdIdentities) + assert.Equal(t, expectedErr, rNibErr) +} + +func TestUpdateNbIdentityNewIdentityMarshalNilFailure(t *testing.T) { + w, sdlMock := initSdlMock() + + var nbIdIdentitiesProtoToRemove []interface{} + protoRan1, _ := createNbIdentityProto(t, "ran1", "plmnId1", "nbId1", entities.ConnectionStatus_DISCONNECTED) + nbIdIdentitiesProtoToRemove = append(nbIdIdentitiesProtoToRemove, protoRan1) + sdlMock.On("RemoveMember", namespace, entities.Node_ENB.String(), nbIdIdentitiesProtoToRemove).Return(nil) + + oldNbIdIdentities := []*entities.NbIdentity{ + &entities.NbIdentity{ + InventoryName: "ran1", + ConnectionStatus: entities.ConnectionStatus_DISCONNECTED, + GlobalNbId: &entities.GlobalNbId{PlmnId: "plmnId1", NbId: "nbId1"}, + }, + } + newNbIdIdentities := []*entities.NbIdentity{nil} + + expectedErr := common.NewInternalError(errors.New("proto: Marshal called with nil")) + rNibErr := w.UpdateNbIdentities(entities.Node_ENB, oldNbIdIdentities, newNbIdIdentities) + assert.Equal(t, expectedErr, rNibErr) +} + +func TestUpdateNbIdentityRemoveFailure(t *testing.T) { + w, sdlMock := initSdlMock() + + var nbIdIdentitiesProtoToRemove []interface{} + protoRan1, _ := createNbIdentityProto(t, "ran1", "plmnId1", "nbId1", entities.ConnectionStatus_DISCONNECTED) + nbIdIdentitiesProtoToRemove = append(nbIdIdentitiesProtoToRemove, protoRan1) + protoRan2, _ := createNbIdentityProto(t, "ran2", "plmnId2", "nbId2", entities.ConnectionStatus_DISCONNECTED) + nbIdIdentitiesProtoToRemove = append(nbIdIdentitiesProtoToRemove, protoRan2) + + sdlMock.On("RemoveMember", namespace, entities.Node_ENB.String(), nbIdIdentitiesProtoToRemove).Return(fmt.Errorf("for test")) + + var oldNbIdIdentities []*entities.NbIdentity + firstOldNbIdIdentity := &entities.NbIdentity{InventoryName: "ran1", ConnectionStatus: entities.ConnectionStatus_DISCONNECTED, GlobalNbId: &entities.GlobalNbId{PlmnId: "plmnId1", NbId: "nbId1"}} + secondOldNbIdIdentity := &entities.NbIdentity{InventoryName: "ran2", ConnectionStatus: entities.ConnectionStatus_DISCONNECTED, GlobalNbId: &entities.GlobalNbId{PlmnId: "plmnId2", NbId: "nbId2"}} + oldNbIdIdentities = append(oldNbIdIdentities, firstOldNbIdIdentity) + oldNbIdIdentities = append(oldNbIdIdentities, secondOldNbIdIdentity) + + var newNbIdIdentities []*entities.NbIdentity + + rNibErr := w.UpdateNbIdentities(entities.Node_ENB, oldNbIdIdentities, newNbIdIdentities) + assert.NotNil(t, rNibErr) + sdlMock.AssertExpectations(t) +} + +func TestUpdateNbIdentitySdlAddMemberFailure(t *testing.T) { + w, sdlMock := initSdlMock() + + var nbIdIdentitiesProtoToRemove []interface{} + protoRan1, _ := createNbIdentityProto(t, "ran1", "plmnId1", "nbId1", entities.ConnectionStatus_DISCONNECTED) + nbIdIdentitiesProtoToRemove = append(nbIdIdentitiesProtoToRemove, protoRan1) + sdlMock.On("RemoveMember", namespace, entities.Node_ENB.String(), nbIdIdentitiesProtoToRemove).Return(nil) + + var nbIdIdentitiesProtoToAdd []interface{} + protoRan1Add, _ := createNbIdentityProto(t, "ran1_add", "plmnId1_add", "nbId1_add", entities.ConnectionStatus_CONNECTED) + nbIdIdentitiesProtoToAdd = append(nbIdIdentitiesProtoToAdd, protoRan1Add) + sdlMock.On("AddMember", namespace, entities.Node_ENB.String(), nbIdIdentitiesProtoToAdd).Return(fmt.Errorf("for test")) + + var oldNbIdIdentities []*entities.NbIdentity + firstOldNbIdIdentity := &entities.NbIdentity{InventoryName: "ran1", ConnectionStatus: entities.ConnectionStatus_DISCONNECTED, GlobalNbId: &entities.GlobalNbId{PlmnId: "plmnId1", NbId: "nbId1"}} + oldNbIdIdentities = append(oldNbIdIdentities, firstOldNbIdIdentity) + + var newNbIdIdentities []*entities.NbIdentity + firstNewNbIdIdentity := &entities.NbIdentity{InventoryName: "ran1_add", ConnectionStatus: entities.ConnectionStatus_CONNECTED, GlobalNbId: &entities.GlobalNbId{PlmnId: "plmnId1_add", NbId: "nbId1_add"}} + newNbIdIdentities = append(newNbIdIdentities, firstNewNbIdIdentity) + + rNibErr := w.UpdateNbIdentities(entities.Node_ENB, oldNbIdIdentities, newNbIdIdentities) + assert.NotNil(t, rNibErr) + sdlMock.AssertExpectations(t) +} + +func TestUpdateNbIdentityAddFailure(t *testing.T) { + w, sdlMock := initSdlMock() + nbIdentity := &entities.NbIdentity{InventoryName: "ran1", ConnectionStatus: entities.ConnectionStatus_DISCONNECTED, GlobalNbId: &entities.GlobalNbId{PlmnId: "plmnId1", NbId: "nbId1"}} + nbIdData, err := proto.Marshal(nbIdentity) + if err != nil { + t.Errorf("#TestRemoveNbIdentitySuccess - failed to Marshal NbIdentity") + } + sdlMock.On("RemoveMember", namespace, entities.Node_ENB.String(), []interface{}{nbIdData}).Return(fmt.Errorf("for test")) + + rNibErr := w.RemoveNbIdentity(entities.Node_ENB, nbIdentity) + assert.NotNil(t, rNibErr) + sdlMock.AssertExpectations(t) +} + +func TestUpdateNbIdentityNoNbIdentityToRemove(t *testing.T) { + w, sdlMock := initSdlMock() + nbIdentity := &entities.NbIdentity{InventoryName: "ran1", ConnectionStatus: entities.ConnectionStatus_DISCONNECTED, GlobalNbId: &entities.GlobalNbId{PlmnId: "plmnId1", NbId: "nbId1"}} + nbIdData, err := proto.Marshal(nbIdentity) + if err != nil { + t.Errorf("#TestRemoveNbIdentitySuccess - failed to Marshal NbIdentity") + } + sdlMock.On("RemoveMember", namespace, entities.Node_ENB.String(), []interface{}{nbIdData}).Return(fmt.Errorf("for test")) + + rNibErr := w.RemoveNbIdentity(entities.Node_ENB, nbIdentity) + assert.NotNil(t, rNibErr) + sdlMock.AssertExpectations(t) +} + +func TestUpdateNbIdentityNoNbIdentityToAdd(t *testing.T) { + w, sdlMock := initSdlMock() + nbIdentity := &entities.NbIdentity{InventoryName: "ran1", ConnectionStatus: entities.ConnectionStatus_DISCONNECTED, GlobalNbId: &entities.GlobalNbId{PlmnId: "plmnId1", NbId: "nbId1"}} + nbIdData, err := proto.Marshal(nbIdentity) + if err != nil { + t.Errorf("#TestRemoveNbIdentitySuccess - failed to Marshal NbIdentity") + } + sdlMock.On("RemoveMember", namespace, entities.Node_ENB.String(), []interface{}{nbIdData}).Return(fmt.Errorf("for test")) + + rNibErr := w.RemoveNbIdentity(entities.Node_ENB, nbIdentity) + assert.NotNil(t, rNibErr) + sdlMock.AssertExpectations(t) +} + +func createNbIdentityProto(t *testing.T, ranName string, plmnId string, nbId string, connectionStatus entities.ConnectionStatus) ([]byte, *entities.NbIdentity) { + nbIdentity := &entities.NbIdentity{InventoryName: ranName, ConnectionStatus: connectionStatus, GlobalNbId: &entities.GlobalNbId{PlmnId: plmnId, NbId: nbId}} + nbIdData, err := proto.Marshal(nbIdentity) + if err != nil { + t.Errorf("#createNbIdentityProto - failed to Marshal NbIdentity") + } + return nbIdData, nbIdentity +}